118018 2013-06-25 20:14:50 -0700 Remove unneeded static_casts from SelectorChecker 2013-06-26 11:07:33 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned allan.jensen benjamin cdumez commit-queue esprehn+autocc esprehn glenn kling koivisto macpherson menard oldest_to_newest 903505 0 rniwa 2013-06-25 20:14:50 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367 SelectorChecker::checkOne casts to StyledElement just to call classNames, but this method is on Element so there's no reason for this. The cast here also looks pretty suspect. The method also casts to HTMLFrameElementBase to call containsFullScreenElement which is also on Element so the cast can be removed. 903506 1 205442 rniwa 2013-06-25 20:16:29 -0700 Created attachment 205442 Merges the patch 903810 2 205442 commit-queue 2013-06-26 11:07:28 -0700 Comment on attachment 205442 Merges the patch Clearing flags on attachment: 205442 Committed r152001: <http://trac.webkit.org/changeset/152001> 903811 3 commit-queue 2013-06-26 11:07:33 -0700 All reviewed patches have been landed. Closing bug. 205442 2013-06-25 20:16:29 -0700 2013-06-26 11:07:28 -0700 Merges the patch fix118018 text/plain 2442 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTk3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA2LTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBzdGF0 aWNfY2FzdHMgZnJvbSBTZWxlY3RvckNoZWNrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExODAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1lcmdlIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNl LmNvbS9jaHJvbWl1bS9ibGluay8rL2FkYzViOGJlYzJkOGM2YTg1N2IzYzkzMGNhNzQ4NGY3NmNh ZDEzNjcKKworICAgICAgICBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lIGNhc3RzIHRvIFN0eWxl ZEVsZW1lbnQganVzdCB0byBjYWxsIGNsYXNzTmFtZXMsIGJ1dAorICAgICAgICB0aGlzIG1ldGhv ZCBpcyBvbiBFbGVtZW50IHNvIHRoZXJlJ3Mgbm8gcmVhc29uIGZvciB0aGlzLiBUaGUgY2FzdCBo ZXJlIGFsc28KKyAgICAgICAgbG9va3MgcHJldHR5IHN1c3BlY3QuIFRoZSBtZXRob2QgYWxzbyBj YXN0cyB0byBIVE1MRnJhbWVFbGVtZW50QmFzZSB0byBjYWxsCisgICAgICAgIGNvbnRhaW5zRnVs bFNjcmVlbkVsZW1lbnQgd2hpY2ggaXMgYWxzbyBvbiBFbGVtZW50IHNvIHRoZSBjYXN0IGNhbiBi ZSByZW1vdmVkLgorCisgICAgICAgICogY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lKToKKwogMjAxMy0wNi0yNSAgS2Fu Z2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRvcHQgaXMvdG9I VE1MQW5jaG9yRWxlbWVudCBmb3IgY29kZSBjbGVhbnVwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9j c3MvU2VsZWN0b3JDaGVja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3Mv U2VsZWN0b3JDaGVja2VyLmNwcAkocmV2aXNpb24gMTUxOTcwKQorKysgU291cmNlL1dlYkNvcmUv Y3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3OSw3ICszNzksNyBA QAogICAgICAgICByZXR1cm4gU2VsZWN0b3JDaGVja2VyOjp0YWdNYXRjaGVzKGVsZW1lbnQsIHNl bGVjdG9yLT50YWdRTmFtZSgpKTsKIAogICAgIGlmIChzZWxlY3Rvci0+bV9tYXRjaCA9PSBDU1NT ZWxlY3Rvcjo6Q2xhc3MpCi0gICAgICAgIHJldHVybiBlbGVtZW50LT5oYXNDbGFzcygpICYmIHN0 YXRpY19jYXN0PFN0eWxlZEVsZW1lbnQqPihlbGVtZW50KS0+Y2xhc3NOYW1lcygpLmNvbnRhaW5z KHNlbGVjdG9yLT52YWx1ZSgpKTsKKyAgICAgICAgcmV0dXJuIGVsZW1lbnQtPmhhc0NsYXNzKCkg JiYgZWxlbWVudC0+Y2xhc3NOYW1lcygpLmNvbnRhaW5zKHNlbGVjdG9yLT52YWx1ZSgpKTsKIAog ICAgIGlmIChzZWxlY3Rvci0+bV9tYXRjaCA9PSBDU1NTZWxlY3Rvcjo6SWQpCiAgICAgICAgIHJl dHVybiBlbGVtZW50LT5oYXNJRCgpICYmIGVsZW1lbnQtPmlkRm9yU3R5bGVSZXNvbHV0aW9uKCkg PT0gc2VsZWN0b3ItPnZhbHVlKCk7CkBAIC03MjEsNyArNzIxLDcgQEAKICAgICAgICAgICAgIC8v IGVsZW1lbnQgaXMgYW4gZWxlbWVudCBpbiB0aGUgZG9jdW1lbnQsIHRoZSAnZnVsbC1zY3JlZW4n IHBzZXVkb2NsYXNzIGFwcGxpZXMgdG8KICAgICAgICAgICAgIC8vIHRoYXQgZWxlbWVudC4gQWxz bywgYW4gPGlmcmFtZT4sIDxvYmplY3Q+IG9yIDxlbWJlZD4gZWxlbWVudCB3aG9zZSBjaGlsZCBi cm93c2luZwogICAgICAgICAgICAgLy8gY29udGV4dCdzIERvY3VtZW50IGlzIGluIHRoZSBmdWxs c2NyZWVuIHN0YXRlIGhhcyB0aGUgJ2Z1bGwtc2NyZWVuJyBwc2V1ZG9jbGFzcyBhcHBsaWVkLgot ICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzRnJhbWVFbGVtZW50QmFzZSgpICYmIHN0YXRpY19j YXN0PEhUTUxGcmFtZUVsZW1lbnRCYXNlKj4oZWxlbWVudCktPmNvbnRhaW5zRnVsbFNjcmVlbkVs ZW1lbnQoKSkKKyAgICAgICAgICAgIGlmIChlbGVtZW50LT5pc0ZyYW1lRWxlbWVudEJhc2UoKSAm JiBlbGVtZW50LT5jb250YWluc0Z1bGxTY3JlZW5FbGVtZW50KCkpCiAgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgICAgICAgICBpZiAoIWVsZW1lbnQtPmRvY3VtZW50KCktPndlYmtp dElzRnVsbFNjcmVlbigpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK