117994 2013-06-25 08:41:47 -0700 Web Inspector: stepping through while paused in debugger makes a popover appear 2013-06-26 23:50:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 903342 0 graouts 2013-06-25 08:41:47 -0700 When paused in the debugger and stepping through the call stack, a popover appears in the content view. I think this is related to a previously highlighted token that we're trying to restore the popover for even though the popover had been dismissed in the meantime. 903343 1 webkit-bug-importer 2013-06-25 08:42:18 -0700 <rdar://problem/14260788> 903344 2 graouts 2013-06-25 08:47:29 -0700 I'll take a look at this tomorrow. 903378 3 joepeck 2013-06-25 10:56:30 -0700 Yes, I've noticed this too. I think SourceCodeTextEditor._activeCallFrameDidChange is too keen on reshowing the last tracked token. It should only do that if the popover is visible, to refresh the popover. 903704 4 graouts 2013-06-26 07:43:29 -0700 This is due to the following code in SourceCodeTextEditor.prototype._activeCallFrameDidChange: if (this.tokenTrackingController.tracking && this.tokenTrackingController.candidate) this.tokenTrackingControllerNewHighlightCandidate(this.tokenTrackingController, this.tokenTrackingController.candidate); 903705 5 graouts 2013-06-26 07:48:43 -0700 Interestingly this call is directly followed by a call to: this._dismissPopover(); But in tokenTrackingControllerNewHighlightCandidate() we display the popover after gathering the content from the backend, so we dismiss and show the popover again. 903713 6 205492 graouts 2013-06-26 08:08:46 -0700 Created attachment 205492 Patch 903751 7 205492 commit-queue 2013-06-26 09:00:52 -0700 Comment on attachment 205492 Patch Clearing flags on attachment: 205492 Committed r151991: <http://trac.webkit.org/changeset/151991> 903752 8 commit-queue 2013-06-26 09:00:55 -0700 All reviewed patches have been landed. Closing bug. 903831 9 joepeck 2013-06-26 11:35:55 -0700 Stepping through the following code: var x = 0; x += Math.random(); x += Math.random(); x += Math.random(); x += Math.random(); If I had a popover for "x" and stepped through the code I would want to see the popover stay up and just update with the new value of x each time. Does that happen? Should I just file a separate bug requesting that behavior? 904076 10 graouts 2013-06-26 23:50:55 -0700 The popover will hide whenever you step through code and won't reappear until there is additional user action to re-highlight the token. We should indeed have a separate bug to make this work. 205492 2013-06-26 08:08:46 -0700 2013-06-26 09:00:52 -0700 Patch bug-117994-20130626170648.patch text/plain 1809 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz MmNhYmZlNWYyMWFiNGU5YTAxODE4YjM2YWE5ZTkwOTRiZDI3MzZmLi5jYjQ4NGIzNGNiYzM5ZjRl MjNjZWRkOTM2OGUwNzMwZTFjMGMwZDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNi0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHN0ZXBwaW5nIHRocm91Z2ggd2hpbGUgcGF1c2Vk IGluIGRlYnVnZ2VyIG1ha2VzIGEgcG9wb3ZlciBhcHBlYXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzk5NAorCisgICAgICAgIFRoZXJlIGlzIG5v IG9idmlvdXMgbmVlZCB0byBjYWxsIHRva2VuVHJhY2tpbmdDb250cm9sbGVyTmV3SGlnaGxpZ2h0 Q2FuZGlkYXRlIHdoZW4gdGhlCisgICAgICAgIGFjdGl2ZSBjYWxsIGZyYW1lIGNoYW5nZXMgYW5k IGl0IGxlYWRzIHRvIGFuIGV4dHJhbmVvdXMgZGlzcGxheSBvZiB0aGUgcG9wb3Zlci4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvU291cmNlQ29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNl Q29kZVRleHRFZGl0b3IucHJvdG90eXBlLl9hY3RpdmVDYWxsRnJhbWVEaWRDaGFuZ2UpOgorCiAy MDEzLTA2LTI0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogV2ViSW5zcGVjdG9yLmRpc3BsYXlOYW1lRm9yVVJMKCkgZmFpbHVyZSBw cmV2ZW50cyBET00gaW5zcGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvU291cmNlQ29kZVRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwppbmRleCA2ZGYyZmZl NDZhYmFjM2U2NWUwOTg5YTJlZWViMWJiMTc4YjQyOWY4Li5kM2JkOWUxODkwMDY3MGI5MjdlOTVh ZTQwOGEwNWQ5NjNlMmRhYjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwpAQCAtNDQzLDkgKzQ0 Myw2IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBpZiAodGhpcy50b2tlblRy YWNraW5nQ29udHJvbGxlci50cmFja2luZyAmJiB0aGlzLnRva2VuVHJhY2tpbmdDb250cm9sbGVy LmNhbmRpZGF0ZSkKLSAgICAgICAgICAgIHRoaXMudG9rZW5UcmFja2luZ0NvbnRyb2xsZXJOZXdI aWdobGlnaHRDYW5kaWRhdGUodGhpcy50b2tlblRyYWNraW5nQ29udHJvbGxlciwgdGhpcy50b2tl blRyYWNraW5nQ29udHJvbGxlci5jYW5kaWRhdGUpOwotCiAgICAgICAgIHRoaXMuX2Rpc21pc3NQ b3BvdmVyKCk7CiAKICAgICAgICAgdGhpcy5fYWN0aXZlQ2FsbEZyYW1lU291cmNlQ29kZUxvY2F0 aW9uID0gYWN0aXZlQ2FsbEZyYW1lLnNvdXJjZUNvZGVMb2NhdGlvbjsK