117991 2013-06-25 08:03:05 -0700 Fix cast-align warnings in FastMalloc.cpp 2013-07-03 03:20:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy benjamin cmarcelo commit-queue mhahnenberg msaboff oliver ossy oldest_to_newest 903329 0 ossy 2013-06-25 08:03:05 -0700 /home/oszi/WebKit/Source/WTF/wtf/FastMalloc.cpp:3167:102: warning: cast from 'char*' to 'uint32_t* {aka unsigned int*}' increases required alignment of target type [-Wcast-align] /home/oszi/WebKit/Source/WTF/wtf/FastMalloc.cpp:3167:194: warning: cast from 'char*' to 'uint32_t* {aka unsigned int*}' increases required alignment of target type [-Wcast-align] /home/oszi/WebKit/Source/WTF/wtf/FastMalloc.cpp:3167:305: warning: cast from 'char*' to 'uint32_t* {aka unsigned int*}' increases required alignment of target type [-Wcast-align] /home/oszi/WebKit/Source/WTF/wtf/FastMalloc.cpp:3167:52: warning: cast from 'char*' to 'uint32_t* {aka unsigned int*}' increases required alignment of target type [-Wcast-align] 3167: POISON_DEALLOCATION_EXPLICIT(ptr, size, startPoison, endPoison); #define POISON_DEALLOCATION_EXPLICIT(allocation, allocationSize, startPoison, endPoison) do { \ ASSERT((allocationSize) >= 2 * sizeof(uint32_t)); \ reinterpret_cast<uint32_t*>(allocation)[0] = 0xbadbeef9; \ reinterpret_cast<uint32_t*>(allocation)[1] = 0xbadbeefb; \ if ((allocationSize) < 4 * sizeof(uint32_t)) \ break; \ reinterpret_cast<uint32_t*>(allocation)[2] = (startPoison) ^ PTR_TO_UINT32(allocation); \ reinterpret_cast<uint32_t*>(allocation)[END_POISON_INDEX(allocationSize)] = (endPoison) ^ PTR_TO_UINT32(allocation); \ } while (false) This define introduced in - https://trac.webkit.org/changeset/143488/trunk/Source/WTF/wtf/FastMalloc.cpp - https://trac.webkit.org/changeset/143996/trunk/Source/WTF/wtf/FastMalloc.cpp The question is that ptr in line 3167 is uint32_t aligned or not? 904953 1 ossy 2013-07-01 02:23:47 -0700 Could you check if they can be a valid warnings or can we suppress them with using reinterpret_cast_ptr instead of reinterpret_cast ? 905433 2 ossy 2013-07-02 07:56:35 -0700 any idea? 905446 3 mhahnenberg 2013-07-02 08:35:05 -0700 (In reply to comment #2) > any idea? I think this one is okay to change to reinterpret_cast_ptr too because all FastMalloc allocations are guaranteed to be at least 8 byte aligned. 905448 4 205919 ossy 2013-07-02 08:38:31 -0700 Created attachment 205919 Patch 905450 5 ossy 2013-07-02 08:44:15 -0700 (In reply to comment #3) > (In reply to comment #2) > > any idea? > > I think this one is okay to change to reinterpret_cast_ptr too because all FastMalloc allocations are guaranteed to be at least 8 byte aligned. Thanks, I attached the patch. 905457 6 205919 mhahnenberg 2013-07-02 09:13:25 -0700 Comment on attachment 205919 Patch r=me 905792 7 205919 ossy 2013-07-03 03:19:58 -0700 Comment on attachment 205919 Patch Clearing flags on attachment: 205919 Committed r152349: <http://trac.webkit.org/changeset/152349> 905793 8 ossy 2013-07-03 03:20:04 -0700 All reviewed patches have been landed. Closing bug. 205919 2013-07-02 08:38:31 -0700 2013-07-03 03:19:58 -0700 Patch bug-117991-20130702083633.patch text/plain 1940 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYxY2U5ZjkzYWE5NDUxMDM2MDMwYzEz Yjc4ODI4ZDM5ZWE2OTAwNzMuLjg3NmQxOTE1YTEwYmFlMjM5OWMyMzlmZTk0MDQyMzk1OWNjZGNj NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDctMDIgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggY2FzdC1hbGlnbiB3YXJuaW5ncyBpbiBG YXN0TWFsbG9jLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE3OTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisKIDIwMTMtMDctMDIgIE1pa2hhaWwgUG96ZG55 YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgQXZvaWQgY29k ZSBkdXBsaWNhdGlvbiBpbnNpZGUgU3RyaW5nOjphcHBlbmQoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvRmFzdE1hbGxvYy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcApp bmRleCA4Y2U1M2E3MjcwY2M4NDg3NDg1OGU3OGMwZTljNTBkZDJiZWRiNGMyLi5jZTUyYWE5MWJh ODNiODNjOTUyMzIxNzk0OWJlNzZmMzRiMjk2ZTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9GYXN0TWFsbG9jLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcApAQCAt NTg2LDEyICs1ODYsMTIgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdWludDMyX3QgZnJlZWRPYmpl Y3RFbmRQb2lzb24oKQogCiAjZGVmaW5lIFBPSVNPTl9ERUFMTE9DQVRJT05fRVhQTElDSVQoYWxs b2NhdGlvbiwgYWxsb2NhdGlvblNpemUsIHN0YXJ0UG9pc29uLCBlbmRQb2lzb24pIGRvIHsgXAog ICAgIEFTU0VSVCgoYWxsb2NhdGlvblNpemUpID49IDIgKiBzaXplb2YodWludDMyX3QpKTsgXAot ICAgIHJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPihhbGxvY2F0aW9uKVswXSA9IDB4YmFkYmVl Zjk7IFwKLSAgICByZWludGVycHJldF9jYXN0PHVpbnQzMl90Kj4oYWxsb2NhdGlvbilbMV0gPSAw eGJhZGJlZWZiOyBcCisgICAgcmVpbnRlcnByZXRfY2FzdF9wdHI8dWludDMyX3QqPihhbGxvY2F0 aW9uKVswXSA9IDB4YmFkYmVlZjk7IFwKKyAgICByZWludGVycHJldF9jYXN0X3B0cjx1aW50MzJf dCo+KGFsbG9jYXRpb24pWzFdID0gMHhiYWRiZWVmYjsgXAogICAgIGlmICgoYWxsb2NhdGlvblNp emUpIDwgNCAqIHNpemVvZih1aW50MzJfdCkpIFwKICAgICAgICAgYnJlYWs7IFwKLSAgICByZWlu dGVycHJldF9jYXN0PHVpbnQzMl90Kj4oYWxsb2NhdGlvbilbMl0gPSAoc3RhcnRQb2lzb24pIF4g UFRSX1RPX1VJTlQzMihhbGxvY2F0aW9uKTsgXAotICAgIHJlaW50ZXJwcmV0X2Nhc3Q8dWludDMy X3QqPihhbGxvY2F0aW9uKVtFTkRfUE9JU09OX0lOREVYKGFsbG9jYXRpb25TaXplKV0gPSAoZW5k UG9pc29uKSBeIFBUUl9UT19VSU5UMzIoYWxsb2NhdGlvbik7IFwKKyAgICByZWludGVycHJldF9j YXN0X3B0cjx1aW50MzJfdCo+KGFsbG9jYXRpb24pWzJdID0gKHN0YXJ0UG9pc29uKSBeIFBUUl9U T19VSU5UMzIoYWxsb2NhdGlvbik7IFwKKyAgICByZWludGVycHJldF9jYXN0X3B0cjx1aW50MzJf dCo+KGFsbG9jYXRpb24pW0VORF9QT0lTT05fSU5ERVgoYWxsb2NhdGlvblNpemUpXSA9IChlbmRQ b2lzb24pIF4gUFRSX1RPX1VJTlQzMihhbGxvY2F0aW9uKTsgXAogfSB3aGlsZSAoZmFsc2UpCiAK ICNkZWZpbmUgUE9JU09OX0RFQUxMT0NBVElPTihhbGxvY2F0aW9uLCBhbGxvY2F0aW9uU2l6ZSkg XAo=