117987 2013-06-25 06:00:55 -0700 Fix cast-align warnings in WebKit2/Platform/CoreIPC 2013-06-27 10:44:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy andersca ap benjamin kling ossy oldest_to_newest 903302 0 ossy 2013-06-25 06:00:55 -0700 SSIA 903303 1 205391 ossy 2013-06-25 06:02:07 -0700 Created attachment 205391 Patch 903305 2 205391 ossy 2013-06-25 06:04:08 -0700 Comment on attachment 205391 Patch It's safe to use reinterpret_cast_ptr instead of reinterpret_cast, because the alignment is checked by alignBufferPosition() in ArgumentDecoder.cpp and it is forced by grow() in ArgumentEncoder.cpp 903855 3 205391 rwlbuis 2013-06-26 12:55:50 -0700 Comment on attachment 205391 Patch LGTM. 903856 4 andersca 2013-06-26 12:59:56 -0700 (In reply to comment #3) > (From update of attachment 205391 [details]) > LGTM. Rob, this is a WebKit2 patch and needs to be approved by a WebKit2 owner. 904094 5 ossy 2013-06-27 00:53:50 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 205391 [details] [details]) > > LGTM. > > Rob, this is a WebKit2 patch and needs to be approved by a WebKit2 owner. Anders, and could you approve it as WebKit2 owner, please? 904208 6 ossy 2013-06-27 06:39:55 -0700 ping for sign-off from a WebKit2 owner 904286 7 andersca 2013-06-27 10:01:43 -0700 Looks good. 904294 8 ossy 2013-06-27 10:44:46 -0700 Committed r152110: <http://trac.webkit.org/changeset/152110> 205391 2013-06-25 06:02:07 -0700 2013-06-27 10:44:59 -0700 Patch bug-117987-20130625060017.patch text/plain 5265 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGE0NjYwMzZlMzliNTUy YzA4YmI2M2YzNWViMTkyNDc0YzViZGVlNi4uNDBjYzg1MDk0YzMxZWU1YmNmMmY4ODJmZTFjYzU1 ODVkOTA1MDdkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNhc3QtYWxp Z24gd2FybmluZ3MgaW4gV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5ODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1l bnREZWNvZGVyLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkFyZ3VtZW50RGVjb2Rlcjo6ZGVjb2Rl KToKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHA6CisgICAg ICAgIChDb3JlSVBDOjpBcmd1bWVudEVuY29kZXI6OmVuY29kZSk6CisKIDIwMTMtMDYtMjQgIFNp bW9uIENvb3BlciAgPHNjb29wZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbHZlcmxpZ2h0IHRy aWdnZXJzIHNhbmRib3ggdmlvbGF0aW9uczogZGVueSBuZXR3b3JrLWJpbmQgMC4wLjAuMDowCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RGVjb2Rl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RGVjb2Rlci5j cHAKaW5kZXggMjBiYmU3ODYyNjNjNjVkNjFlZjU4NGZlM2Q5YzU1YjQyYmQ3MjZlMC4uZTIzZDI4 YTJjMDVkOWViYzczZjNkNDAzM2NmYzRjMDk3M2E5ZGI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudERlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnREZWNvZGVyLmNwcApAQCAtMTU0LDcgKzE1 NCw3IEBAIGJvb2wgQXJndW1lbnREZWNvZGVyOjpkZWNvZGUodWludDE2X3QmIHJlc3VsdCkKICAg ICBpZiAoIWFsaWduQnVmZmVyUG9zaXRpb24oc2l6ZW9mKHJlc3VsdCksIHNpemVvZihyZXN1bHQp KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgcmVzdWx0ID0gKnJlaW50ZXJwcmV0X2Nh c3Q8dWludDE2X3QqPihtX2J1ZmZlclBvcyk7CisgICAgcmVzdWx0ID0gKnJlaW50ZXJwcmV0X2Nh c3RfcHRyPHVpbnQxNl90Kj4obV9idWZmZXJQb3MpOwogICAgIG1fYnVmZmVyUG9zICs9IHNpemVv ZihyZXN1bHQpOwogICAgIHJldHVybiB0cnVlOwogfQpAQCAtMTY0LDcgKzE2NCw3IEBAIGJvb2wg QXJndW1lbnREZWNvZGVyOjpkZWNvZGUodWludDMyX3QmIHJlc3VsdCkKICAgICBpZiAoIWFsaWdu QnVmZmVyUG9zaXRpb24oc2l6ZW9mKHJlc3VsdCksIHNpemVvZihyZXN1bHQpKSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIAotICAgIHJlc3VsdCA9ICpyZWludGVycHJldF9jYXN0PHVpbnQz Ml90Kj4obV9idWZmZXJQb3MpOworICAgIHJlc3VsdCA9ICpyZWludGVycHJldF9jYXN0X3B0cjx1 aW50MzJfdCo+KG1fYnVmZmVyUG9zKTsKICAgICBtX2J1ZmZlclBvcyArPSBzaXplb2YocmVzdWx0 KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTE3NCw3ICsxNzQsNyBAQCBib29sIEFyZ3VtZW50 RGVjb2Rlcjo6ZGVjb2RlKHVpbnQ2NF90JiByZXN1bHQpCiAgICAgaWYgKCFhbGlnbkJ1ZmZlclBv c2l0aW9uKHNpemVvZihyZXN1bHQpLCBzaXplb2YocmVzdWx0KSkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICAKLSAgICByZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdCo+KG1f YnVmZmVyUG9zKTsKKyAgICByZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdF9wdHI8dWludDY0X3Qq PihtX2J1ZmZlclBvcyk7CiAgICAgbV9idWZmZXJQb3MgKz0gc2l6ZW9mKHJlc3VsdCk7CiAgICAg cmV0dXJuIHRydWU7CiB9CkBAIC0xODQsNyArMTg0LDcgQEAgYm9vbCBBcmd1bWVudERlY29kZXI6 OmRlY29kZShpbnQzMl90JiByZXN1bHQpCiAgICAgaWYgKCFhbGlnbkJ1ZmZlclBvc2l0aW9uKHNp emVvZihyZXN1bHQpLCBzaXplb2YocmVzdWx0KSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICAKLSAgICByZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdDx1aW50MzJfdCo+KG1fYnVmZmVyUG9z KTsKKyAgICByZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdF9wdHI8dWludDMyX3QqPihtX2J1ZmZl clBvcyk7CiAgICAgbV9idWZmZXJQb3MgKz0gc2l6ZW9mKHJlc3VsdCk7CiAgICAgcmV0dXJuIHRy dWU7CiB9CkBAIC0xOTQsNyArMTk0LDcgQEAgYm9vbCBBcmd1bWVudERlY29kZXI6OmRlY29kZShp bnQ2NF90JiByZXN1bHQpCiAgICAgaWYgKCFhbGlnbkJ1ZmZlclBvc2l0aW9uKHNpemVvZihyZXN1 bHQpLCBzaXplb2YocmVzdWx0KSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKLSAgICBy ZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdCo+KG1fYnVmZmVyUG9zKTsKKyAgICBy ZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdF9wdHI8dWludDY0X3QqPihtX2J1ZmZlclBvcyk7CiAg ICAgbV9idWZmZXJQb3MgKz0gc2l6ZW9mKHJlc3VsdCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CkBA IC0yMDQsNyArMjA0LDcgQEAgYm9vbCBBcmd1bWVudERlY29kZXI6OmRlY29kZShmbG9hdCYgcmVz dWx0KQogICAgIGlmICghYWxpZ25CdWZmZXJQb3NpdGlvbihzaXplb2YocmVzdWx0KSwgc2l6ZW9m KHJlc3VsdCkpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgcmVzdWx0ID0gKnJl aW50ZXJwcmV0X2Nhc3Q8ZmxvYXQqPihtX2J1ZmZlclBvcyk7CisgICAgcmVzdWx0ID0gKnJlaW50 ZXJwcmV0X2Nhc3RfcHRyPGZsb2F0Kj4obV9idWZmZXJQb3MpOwogICAgIG1fYnVmZmVyUG9zICs9 IHNpemVvZihyZXN1bHQpOwogICAgIHJldHVybiB0cnVlOwogfQpAQCAtMjE0LDcgKzIxNCw3IEBA IGJvb2wgQXJndW1lbnREZWNvZGVyOjpkZWNvZGUoZG91YmxlJiByZXN1bHQpCiAgICAgaWYgKCFh bGlnbkJ1ZmZlclBvc2l0aW9uKHNpemVvZihyZXN1bHQpLCBzaXplb2YocmVzdWx0KSkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKICAgICAKLSAgICByZXN1bHQgPSAqcmVpbnRlcnByZXRfY2FzdDxk b3VibGUqPihtX2J1ZmZlclBvcyk7CisgICAgcmVzdWx0ID0gKnJlaW50ZXJwcmV0X2Nhc3RfcHRy PGRvdWJsZSo+KG1fYnVmZmVyUG9zKTsKICAgICBtX2J1ZmZlclBvcyArPSBzaXplb2YocmVzdWx0 KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcAppbmRleCBhYTliMTBjNTQwYzgxZGYyMTUyYTJk MTFjOTgxOWU4MzgxODFhMjQ1Li40MzI0NmY0YjUxZTIyODllNDdjOGUyMGZhMDMyOGYzNTZmMDE4 YTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50 RW5jb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVu dEVuY29kZXIuY3BwCkBAIC0xNDYsNDkgKzE0Niw0OSBAQCB2b2lkIEFyZ3VtZW50RW5jb2Rlcjo6 ZW5jb2RlKHVpbnQxNl90IG4pCiB7CiAgICAgdWludDhfdCogYnVmZmVyID0gZ3JvdyhzaXplb2Yo biksIHNpemVvZihuKSk7CiAKLSAgICAqcmVpbnRlcnByZXRfY2FzdDx1aW50MTZfdCo+KGJ1ZmZl cikgPSBuOworICAgICpyZWludGVycHJldF9jYXN0X3B0cjx1aW50MTZfdCo+KGJ1ZmZlcikgPSBu OwogfQogCiB2b2lkIEFyZ3VtZW50RW5jb2Rlcjo6ZW5jb2RlKHVpbnQzMl90IG4pCiB7CiAgICAg dWludDhfdCogYnVmZmVyID0gZ3JvdyhzaXplb2YobiksIHNpemVvZihuKSk7CiAgICAgCi0gICAg KnJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPihidWZmZXIpID0gbjsKKyAgICAqcmVpbnRlcnBy ZXRfY2FzdF9wdHI8dWludDMyX3QqPihidWZmZXIpID0gbjsKIH0KIAogdm9pZCBBcmd1bWVudEVu Y29kZXI6OmVuY29kZSh1aW50NjRfdCBuKQogewogICAgIHVpbnQ4X3QqIGJ1ZmZlciA9IGdyb3co c2l6ZW9mKG4pLCBzaXplb2YobikpOwogICAgIAotICAgICpyZWludGVycHJldF9jYXN0PHVpbnQ2 NF90Kj4oYnVmZmVyKSA9IG47CisgICAgKnJlaW50ZXJwcmV0X2Nhc3RfcHRyPHVpbnQ2NF90Kj4o YnVmZmVyKSA9IG47CiB9CiAKIHZvaWQgQXJndW1lbnRFbmNvZGVyOjplbmNvZGUoaW50MzJfdCBu KQogewogICAgIHVpbnQ4X3QqIGJ1ZmZlciA9IGdyb3coc2l6ZW9mKG4pLCBzaXplb2YobikpOwog ICAgIAotICAgICpyZWludGVycHJldF9jYXN0PGludDMyX3QqPihidWZmZXIpID0gbjsKKyAgICAq cmVpbnRlcnByZXRfY2FzdF9wdHI8aW50MzJfdCo+KGJ1ZmZlcikgPSBuOwogfQogCiB2b2lkIEFy Z3VtZW50RW5jb2Rlcjo6ZW5jb2RlKGludDY0X3QgbikKIHsKICAgICB1aW50OF90KiBidWZmZXIg PSBncm93KHNpemVvZihuKSwgc2l6ZW9mKG4pKTsKICAgICAKLSAgICAqcmVpbnRlcnByZXRfY2Fz dDxpbnQ2NF90Kj4oYnVmZmVyKSA9IG47CisgICAgKnJlaW50ZXJwcmV0X2Nhc3RfcHRyPGludDY0 X3QqPihidWZmZXIpID0gbjsKIH0KIAogdm9pZCBBcmd1bWVudEVuY29kZXI6OmVuY29kZShmbG9h dCBuKQogewogICAgIHVpbnQ4X3QqIGJ1ZmZlciA9IGdyb3coc2l6ZW9mKG4pLCBzaXplb2Yobikp OwogCi0gICAgKnJlaW50ZXJwcmV0X2Nhc3Q8ZmxvYXQqPihidWZmZXIpID0gbjsKKyAgICAqcmVp bnRlcnByZXRfY2FzdF9wdHI8ZmxvYXQqPihidWZmZXIpID0gbjsKIH0KIAogdm9pZCBBcmd1bWVu dEVuY29kZXI6OmVuY29kZShkb3VibGUgbikKIHsKICAgICB1aW50OF90KiBidWZmZXIgPSBncm93 KHNpemVvZihuKSwgc2l6ZW9mKG4pKTsKIAotICAgICpyZWludGVycHJldF9jYXN0PGRvdWJsZSo+ KGJ1ZmZlcikgPSBuOworICAgICpyZWludGVycHJldF9jYXN0X3B0cjxkb3VibGUqPihidWZmZXIp ID0gbjsKIH0KIAogdm9pZCBBcmd1bWVudEVuY29kZXI6OmFkZEF0dGFjaG1lbnQoY29uc3QgQXR0 YWNobWVudCYgYXR0YWNobWVudCkK