117982 2013-06-25 05:39:33 -0700 [BlackBerry] Handle testRunner.setCustomPolicyDelegate() 2013-06-27 00:00:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned rwlbuis oldest_to_newest 903288 0 cgarcia 2013-06-25 05:39:33 -0700 It's currently implemented, but the permissive flag is ignored. 903290 1 205386 cgarcia 2013-06-25 05:47:10 -0700 Created attachment 205386 Patch Fixes test fast/loader/onload-policy-ignore-for-frame.html 903852 2 205386 rwlbuis 2013-06-26 12:43:32 -0700 Comment on attachment 205386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review LGTM. > Source/WebKit/blackberry/ChangeLog:8 > + Take custom cpolicy into account when deciding the policy for I assume you mean 'policy' here instead of 'cpolicy'. 904077 3 cgarcia 2013-06-26 23:57:22 -0700 (In reply to comment #2) > (From update of attachment 205386 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review > > LGTM. > > > Source/WebKit/blackberry/ChangeLog:8 > > + Take custom cpolicy into account when deciding the policy for > > I assume you mean 'policy' here instead of 'cpolicy'. Oops, yes, it's a typo, will fix it before landing. 904078 4 cgarcia 2013-06-27 00:00:47 -0700 Committed r152081: <http://trac.webkit.org/changeset/152081> 205386 2013-06-25 05:47:10 -0700 2013-06-26 12:43:31 -0700 Patch bb-drt-custom-policy-permissive.diff text/plain 6262 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvRHVtcFJlbmRlclRyZWVD bGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvRHVtcFJlbmRlclRyZWVDbGll bnQuaAppbmRleCA1NDAzMThmLi4xODY2Y2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL0R1bXBSZW5kZXJUcmVlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9EdW1wUmVuZGVyVHJlZUNsaWVudC5oCkBAIC02MCw2ICs2MCw4IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkRGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UoY29uc3Qg V2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGlkRGlz cGF0Y2hXaWxsUGVyZm9ybUNsaWVudFJlZGlyZWN0KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBk aWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFtZShXZWJDb3JlOjpGcmFtZSopID0gMDsKKyAgICB2 aXJ0dWFsIGJvb2wgcG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUoKSBjb25zdCA9IDA7CisgICAg dmlydHVhbCBib29sIHBvbGljeURlbGVnYXRlRW5hYmxlZCgpIGNvbnN0ID0gMDsKIAogICAgIC8v IENocm9tZUNsaWVudCBkZWxlZ2F0ZXMKICAgICB2aXJ0dWFsIHZvaWQgYWRkTWVzc2FnZVRvQ29u c29sZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIHVuc2lnbmVkIGxpbmVOdW1iZXIsIHVuc2lnbmVk IGNvbHVtbk51bWJlciwgY29uc3QgU3RyaW5nJiBzb3VyY2VJRCkgPSAwOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggYWY3NmVhNy4uMjNjYThjOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMDYtMjUgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2FyZ2FyY2lhQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5 XSBIYW5kbGUgdGVzdFJ1bm5lci5zZXRDdXN0b21Qb2xpY3lEZWxlZ2F0ZSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5ODIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWtlIGN1c3RvbSBjcG9saWN5 IGludG8gYWNjb3VudCB3aGVuIGRlY2lkaW5nIHRoZSBwb2xpY3kgZm9yCisgICAgICAgIG5hdmln YXRpb24gYWN0aW9ucy4KKworICAgICAgICBGaXhlcyB0ZXN0IGZhc3QvbG9hZGVyL29ubG9hZC1w b2xpY3ktaWdub3JlLWZvci1mcmFtZS5odG1sLgorCisgICAgICAgICogQXBpL0R1bXBSZW5kZXJU cmVlQ2xpZW50Lmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeTo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKToKKyAgICAgICAg SWYgY3VzdG9tIHBvbGljeSBpcyBlbmFibGVkIGlnbm9yZSB0aGUgbmF2aWdhdGlvbiBhY3Rpb24g d2hlbiBpdCdzCisgICAgICAgIG5vdCBwZXJtaXNzaXZlLgorCiAyMDEzLTA1LTI5ICBZb25nIExp ICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBhYm91dDptZW1vcnkgc2hv dWxkIHVzZSBtYWxsb2Nfc3RhdHMgaW5zdGVhZCBvZiBtYWxsaW5mbwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCA0YmI4N2VjLi41MjlmOGQ5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtMjIyLDggKzIy MiwxMSBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hEZWNpZGVQ b2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKEZyYW1lUAogICAgIGlmIChkZWNpc2lvbiA9PSBQb2xp Y3lJZ25vcmUpCiAgICAgICAgIGRpc3BhdGNoRGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3QoKTsKIAot ICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX2R1bXBSZW5kZXJUcmVlKQorICAgIGlmIChtX3dl YlBhZ2VQcml2YXRlLT5tX2R1bXBSZW5kZXJUcmVlKSB7CiAgICAgICAgIG1fd2ViUGFnZVByaXZh dGUtPm1fZHVtcFJlbmRlclRyZWUtPmRpZERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24o YWN0aW9uLCByZXF1ZXN0LCBtX2ZyYW1lKTsKKyAgICAgICAgaWYgKG1fd2ViUGFnZVByaXZhdGUt Pm1fZHVtcFJlbmRlclRyZWUtPnBvbGljeURlbGVnYXRlRW5hYmxlZCgpKQorICAgICAgICAgICAg ZGVjaXNpb24gPSBtX3dlYlBhZ2VQcml2YXRlLT5tX2R1bXBSZW5kZXJUcmVlLT5wb2xpY3lEZWxl Z2F0ZUlzUGVybWlzc2l2ZSgpID8gUG9saWN5VXNlIDogUG9saWN5SWdub3JlOworICAgIH0KIAog ICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+cG9saWN5Q2hlY2tlcigpLT4qZnVuY3Rpb24pKGRlY2lz aW9uKTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCAxYmRhYzI5Li5mNTk0NjcyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMDYtMjUgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2FyZ2FyY2lhQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBIYW5kbGUgdGVzdFJ1bm5lci5zZXRDdXN0b21Qb2xpY3lEZWxlZ2F0ZSgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5ODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUpOiBJbml0aWFsaXplCisgICAgICAg IG1fcG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OkR1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZyk6 CisgICAgICAgIFJlc2V0IG1fcG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUuCisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpzZXRDdXN0b21Qb2xpY3lEZWxlZ2F0 ZSk6IFNldAorICAgICAgICBtX3BvbGljeURlbGVnYXRlSXNQZXJtaXNzaXZlLgorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWVCbGFja0JlcnJ5Lmg6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpwb2xpY3lEZWxlZ2F0 ZUVuYWJsZWQpOgorICAgICAgICBSZXR1cm4gd2hldGhlciBjdXN0b20gcG9saWN5IGlzIGVuYWJs ZWQuCisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkR1bXBSZW5kZXJUcmVlOjpwb2xpY3lE ZWxlZ2F0ZUlzUGVybWlzc2l2ZSk6CisgICAgICAgIFJldHVybiB3aGV0aGVyIGN1c3RvbSBwb2xp Y3kgaXMgcGVybWlzc2l2ZS4KKwogMjAxMy0wNi0yNSAgQnl1bmd3b28gTGVlICA8Ync4MC5sZWVA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQWRkIGEgc2NyaXB0IHRvIGluc3RhbGwgZGVw ZW5kZW5jaWVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9E dW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBS ZW5kZXJUcmVlLmNwcAppbmRleCBkN2ExMWViLi40ZjgwM2FmIDEwMDY0NAotLS0gYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMTgzLDYgKzE4 Myw3IEBAIER1bXBSZW5kZXJUcmVlOjpEdW1wUmVuZGVyVHJlZShCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2UqIHBhZ2UpCiAgICAgLCBtX3dvcmtUaW1lcih0aGlzLCAmRHVtcFJlbmRlclRyZWU6 OnByb2Nlc3NXb3JrKQogICAgICwgbV9hY2NlcHRzRWRpdGluZyh0cnVlKQogICAgICwgbV9wb2xp Y3lEZWxlZ2F0ZUVuYWJsZWQoZmFsc2UpCisgICAgLCBtX3BvbGljeURlbGVnYXRlSXNQZXJtaXNz aXZlKGZhbHNlKQogewogICAgIGNvbnN0IGNoYXIqIHdvcmtlck51bWJlciA9IGdldGVudigiV09S S0VSX05VTUJFUiIpID8gZ2V0ZW52KCJXT1JLRVJfTlVNQkVSIikgOiAiMCI7CiAgICAgU3RyaW5n IHNkY2FyZFBhdGggPSBTRENBUkRfUEFUSDsKQEAgLTI5OCw2ICsyOTksNyBAQCB2b2lkIER1bXBS ZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZyhjb25zdCBTdHJp bmcmIHVybCwgY29ucwogICAgIHRvcExvYWRpbmdGcmFtZSA9IDA7CiAgICAgbV9sb2FkRmluaXNo ZWQgPSBmYWxzZTsKICAgICBtX3BvbGljeURlbGVnYXRlRW5hYmxlZCA9IGZhbHNlOworICAgIG1f cG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUgPSBmYWxzZTsKICAgICB3YWl0Rm9yUG9saWN5ID0g ZmFsc2U7CiAgICAgdGVzdERvbmUgPSBmYWxzZTsKICAgICBXb3JrUXVldWU6OnNoYXJlZCgpLT5j bGVhcigpOwpAQCAtOTY5LDcgKzk3MSw3IEBAIGJvb2wgRHVtcFJlbmRlclRyZWU6OmRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShXZWJDb3JlOjpDcmVkZW50aWFsJiBjcmVkCiB2b2lk IER1bXBSZW5kZXJUcmVlOjpzZXRDdXN0b21Qb2xpY3lEZWxlZ2F0ZShib29sIHNldERlbGVnYXRl LCBib29sIHBlcm1pc3NpdmUpCiB7CiAgICAgbV9wb2xpY3lEZWxlZ2F0ZUVuYWJsZWQgPSBzZXRE ZWxlZ2F0ZTsKLSAgICBVTlVTRURfUEFSQU0ocGVybWlzc2l2ZSk7CisgICAgbV9wb2xpY3lEZWxl Z2F0ZUlzUGVybWlzc2l2ZSA9IHBlcm1pc3NpdmU7CiB9CiB9CiB9CmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlQmxhY2tCZXJyeS5oIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZUJsYWNrQmVycnku aAppbmRleCAwY2I2YmMwLi42YWE0YThhIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9ibGFja2JlcnJ5L0R1bXBSZW5kZXJUcmVlQmxhY2tCZXJyeS5oCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWVCbGFja0JlcnJ5LmgKQEAgLTc3LDYg Kzc3LDggQEAgcHVibGljOgogICAgIHZvaWQgZGlkRGlzcGF0Y2hXaWxsUGVyZm9ybUNsaWVudFJl ZGlyZWN0KCk7CiAgICAgdm9pZCBkaWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFtZShXZWJDb3Jl OjpGcmFtZSopOwogICAgIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlRm9yRnJhbWUoV2ViQ29yZTo6 RnJhbWUqLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJik7CisgICAgYm9vbCBwb2xp Y3lEZWxlZ2F0ZUVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX3BvbGljeURlbGVnYXRlRW5hYmxl ZDsgfQorICAgIGJvb2wgcG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUoKSBjb25zdCB7IHJldHVy biBtX3BvbGljeURlbGVnYXRlSXNQZXJtaXNzaXZlOyB9CiAKICAgICAvLyBDaHJvbWVDbGllbnQg ZGVsZWdhdGVzCiAgICAgdm9pZCBhZGRNZXNzYWdlVG9Db25zb2xlKGNvbnN0IFN0cmluZyYgbWVz c2FnZSwgdW5zaWduZWQgbGluZU51bWJlciwgY29uc3QgU3RyaW5nJiBzb3VyY2VJRCk7CkBAIC0x NDgsNiArMTUwLDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1fYWNjZXB0c0VkaXRpbmc7CiAgICAg Ym9vbCBtX2xvYWRGaW5pc2hlZDsKICAgICBib29sIG1fcG9saWN5RGVsZWdhdGVFbmFibGVkOwor ICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZUlzUGVybWlzc2l2ZTsKIH07CiB9CiB9Cg==