117959 2013-06-24 16:18:08 -0700 Fix various crashes on sites with fixed backgrounds 2013-06-24 16:27:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser aestes simon.fraser webkit-bug-importer oldest_to_newest 903115 0 simon.fraser 2013-06-24 16:18:08 -0700 Fix various crashes on sites with fixed backgrounds 903116 1 205341 simon.fraser 2013-06-24 16:21:24 -0700 Created attachment 205341 Patch 903117 2 simon.fraser 2013-06-24 16:21:58 -0700 <rdar://problem/14230128> 903119 3 205341 aestes 2013-06-24 16:25:15 -0700 Comment on attachment 205341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205341&action=review > Source/WebCore/page/FrameView.cpp:-1566 > - ASSERT(m_slowRepaintObjects->contains(o)); If we did create a m_slowRepaintObjects, should we not assert that it contains the item we're removing? 903120 4 simon.fraser 2013-06-24 16:27:16 -0700 (In reply to comment #3) > If we did create a m_slowRepaintObjects, should we not assert that it contains the item we're removing? No, it might not contain it. 903121 5 simon.fraser 2013-06-24 16:27:49 -0700 https://trac.webkit.org/r151934 205341 2013-06-24 16:21:24 -0700 2013-06-24 16:25:15 -0700 Patch bug-117959-20130624161931.patch text/plain 4146 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdlNjZlN2MwZjc4MTVh OGExOTIwYzkxZmE4N2VjNjYyY2IwN2UwOS4uM2I4MjhiOWJlZWY5YjlkZTc1ZGUyZjYwNjA3MTI5 OGU1ODVhYThlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTA2LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCB2YXJpb3Vz IGNyYXNoZXMgb24gc2l0ZXMgd2l0aCBmaXhlZCBiYWNrZ3JvdW5kcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBGcmFtZVZpZXc6OnJlbW92 ZVNsb3dSZXBhaW50T2JqZWN0KCkgd291bGQgYXNzdW1lIHRoYXQgYWRkU2xvd1JlcGFpbnRPYmpl Y3QoKQorICAgICAgICBoYWQgYmVlbiBjYWxsZWQgYmVmb3JlIGl0LCBidXQgdGhpcyBpc24ndCBh bHdheXMgdGhlIGNhc2UuIEZvciBleGFtcGxlLCBpZgorICAgICAgICBhIHBhZ2UgaGFzIGEgZml4 ZWQgYmFja2dyb3VuZCBvbiB0aGUgYm9keSwgdGhpcyBmYWxscyBpbnRvIHRoZSBhY2NlbGVyYXRl ZAorICAgICAgICBwYXRoIGluIFdLMiB0aWxlZCBtb2RlLCBzbyBhZGRTbG93UmVwYWludE9iamVj dCgpIGlzIG5ldmVyIGNhbGxlZC4gSG93ZXZlciwKKyAgICAgICAgd2Ugc3RpbGwgY2FsbCByZW1v dmVTbG93UmVwYWludE9iamVjdCgpIGlmIHRoZSBib2R5IGlzIHJlbW92ZWQuCisgICAgICAgIAor ICAgICAgICBTbyBudWxsLWNoZWNrIG1fc2xvd1JlcGFpbnRPYmplY3RzIHRvIGF2b2lkIGNyYXNo aW5nLgorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9maXhl ZC1iYWNrZ3JvdW5kL2ZpeGVkLWJhY2tncm91bmQtcmVtb3ZhbC5odG1sCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnJlbW92ZVNs b3dSZXBhaW50T2JqZWN0KToKKworMjAxMy0wNi0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3ZlIGRpc3BsYXlJRCBzdHVmZiBmcm9tIFdpZGdl dCB0byBDaHJvbWUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNzk0NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggMGI3ZmU3NmYyYTk4 ZTNjNDU0NDRmMjIxZTVmYTRjMzc2YjkzMjQ2My4uZWM0ZTRlOTJhZmQ1ZTg0YWI5MmU5YzYzNDk1 MTA0MDRlZDYxMWJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTU2Miw4ICsx NTYyLDggQEAgdm9pZCBGcmFtZVZpZXc6OmFkZFNsb3dSZXBhaW50T2JqZWN0KFJlbmRlck9iamVj dCogbykKIAogdm9pZCBGcmFtZVZpZXc6OnJlbW92ZVNsb3dSZXBhaW50T2JqZWN0KFJlbmRlck9i amVjdCogbykKIHsKLSAgICBBU1NFUlQobV9zbG93UmVwYWludE9iamVjdHMpOwotICAgIEFTU0VS VChtX3Nsb3dSZXBhaW50T2JqZWN0cy0+Y29udGFpbnMobykpOworICAgIGlmICghbV9zbG93UmVw YWludE9iamVjdHMpCisgICAgICAgIHJldHVybjsKIAogICAgIG1fc2xvd1JlcGFpbnRPYmplY3Rz LT5yZW1vdmUobyk7CiAgICAgaWYgKG1fc2xvd1JlcGFpbnRPYmplY3RzLT5pc0VtcHR5KCkpIHsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjM2M0ZWZiMWZkZDlhMjk3YWU4NTFmYTM0MDk4NWU2MmEyZGVhOTlkLi4yNTNhYjk3 MzIyMGE4MjVlZDQzNWE4YjBmZDhhY2QyYzZmNmQ1NzRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDYtMjQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAg ICAgICAgRml4IHZhcmlvdXMgY3Jhc2hlcyBvbiBzaXRlcyB3aXRoIGZpeGVkIGJhY2tncm91bmRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5NTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IFRlc3QgdGhhdCBkb2VzIGEgZG9jdW1lbnQud3JpdGUgb24gYSBwYWdlIHdpdGggYSBmaXhlZCBi YWNrZ3JvdW5kIG9uIHRoZSBib2R5LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxl ZC1kcmF3aW5nL2ZpeGVkLWJhY2tncm91bmQvZml4ZWQtYmFja2dyb3VuZC1yZW1vdmFsLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5n L2ZpeGVkLWJhY2tncm91bmQvZml4ZWQtYmFja2dyb3VuZC1yZW1vdmFsLmh0bWw6IEFkZGVkLgor CiAyMDEzLTA2LTI0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIEFYOiBNYWtlIHRlc3RzIHVzYWJsZSBvbiBNYWMgYW5kIFdpbmRvd3MKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9maXhlZC1iYWNrZ3Jv dW5kL2ZpeGVkLWJhY2tncm91bmQtcmVtb3ZhbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvZml4ZWQtYmFja2dyb3VuZC9maXhlZC1iYWNr Z3JvdW5kLXJlbW92YWwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZjMDY2MGNmN2ExOTliZGM4 ODU2OTkzZGQ1Nzc2YzJkZWRhMTM1NmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvZml4ZWQtYmFja2dyb3VuZC9maXhlZC1iYWNr Z3JvdW5kLXJlbW92YWwtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBzaG91 bGQgbm90IGNyYXNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90 aWxlZC1kcmF3aW5nL2ZpeGVkLWJhY2tncm91bmQvZml4ZWQtYmFja2dyb3VuZC1yZW1vdmFsLmh0 bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvZml4ZWQtYmFj a2dyb3VuZC9maXhlZC1iYWNrZ3JvdW5kLXJlbW92YWwuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iYWU3YzM4 YjhmN2JiOTE1OGRhZGIxNWEzYzRiOWNkM2YzOGQxOWZhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL2ZpeGVkLWJhY2tncm91bmQv Zml4ZWQtYmFja2dyb3VuZC1yZW1vdmFsLmh0bWwKQEAgLTAsMCArMSwyMyBAQAorPCFET0NUWVBF IGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBib2R5IHsKKyAg ICAgICAgICAgIGJhY2tncm91bmQ6IHVybCgnZm9vYmFyLnBuZycpIGZpeGVkIG5vLXJlcGVhdDsK KyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAg ICAgICAgZnVuY3Rpb24gZG9UZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgZG9jdW1lbnQu d3JpdGUoJ1RoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLicpOworICAgICAgICB9CisgICAgICAg IHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7CisgICAgPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzwvYm9keT4KKzwvaHRtbD4K