117956 2013-06-24 15:45:26 -0700 [BlackBerry] Only resume root layer commits for visible WebPages 2013-06-25 08:06:16 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson cgarcia commit-queue rwlbuis xiaobwang oldest_to_newest 903095 0 jpetsovits 2013-06-24 15:45:26 -0700 In r150629, the code from that change introduced to suspend and resume root layer commits would not take into account whether the page is actually visible. Because application activation state is usually conveyed to all or any WebPages, this would mean on transitioning into an active application state, we were resuming root layer commits that might have previously been disabled for visibility reasons. The patch below fixes this by going through a single function that knows by itself whether to suspend or resume root layer commits, so the calling code doesn't have a chance to get it wrong. 903098 1 205337 jpetsovits 2013-06-24 15:48:42 -0700 Created attachment 205337 Patch 903123 2 205337 staikos 2013-06-24 16:32:33 -0700 Comment on attachment 205337 Patch This looks cleaner too. 903144 3 205337 commit-queue 2013-06-24 17:06:18 -0700 Comment on attachment 205337 Patch Clearing flags on attachment: 205337 Committed r151936: <http://trac.webkit.org/changeset/151936> 903145 4 commit-queue 2013-06-24 17:06:21 -0700 All reviewed patches have been landed. Closing bug. 903330 5 jpetsovits 2013-06-25 08:06:16 -0700 Appendix: See https://bugs.webkit.org/show_bug.cgi?id=115245 for the original patch that got fixed up by this one here. 205337 2013-06-24 15:48:42 -0700 2013-06-24 17:06:18 -0700 Patch bug-117956-20130624224614.patch text/plain 4566 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyYTU2MWE4MzI1YThmZDc5ZTdkMTFkNTA0ZmZhYTJmNjFmNTJlNmZmLi5jYzhiM2E5OWMw ZWU5ODE5MDA5YmJmNGYwOGQxMTFjYWNmZGE5ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMyBAQAorMjAxMy0wNi0yNCAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0BibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gT25seSByZXN1 bWUgcm9vdCBsYXllciBjb21taXRzIGZvciB2aXNpYmxlIFdlYlBhZ2VzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5NTYKKyAgICAgICAgaHR0cHM6 Ly9qaXJhLmJicW54Lm5ldC9icm93c2UvQlJXU1ItMTIwNDcKKyAgICAgICAgSklSQTQyODM4MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIxNTA2 MjksIHRoZSBjb2RlIGZyb20gdGhhdCBjaGFuZ2UgaW50cm9kdWNlZCB0bworICAgICAgICBzdXNw ZW5kIGFuZCByZXN1bWUgcm9vdCBsYXllciBjb21taXRzIHdvdWxkIG5vdCB0YWtlIGludG8KKyAg ICAgICAgYWNjb3VudCB3aGV0aGVyIHRoZSBwYWdlIGlzIGFjdHVhbGx5IHZpc2libGUuCisKKyAg ICAgICAgQmVjYXVzZSBhcHBsaWNhdGlvbiBhY3RpdmF0aW9uIHN0YXRlIGlzIHVzdWFsbHkgY29u dmV5ZWQKKyAgICAgICAgdG8gYWxsIG9yIGFueSBXZWJQYWdlcywgdGhpcyB3b3VsZCBtZWFuIG9u IHRyYW5zaXRpb25pbmcKKyAgICAgICAgaW50byBhbiBhY3RpdmUgYXBwbGljYXRpb24gc3RhdGUs IHdlIHdlcmUgcmVzdW1pbmcKKyAgICAgICAgcm9vdCBsYXllciBjb21taXRzIHRoYXQgbWlnaHQg aGF2ZSBwcmV2aW91c2x5IGJlZW4KKyAgICAgICAgZGlzYWJsZWQgZm9yIHZpc2liaWxpdHkgcmVh c29ucy4KKworICAgICAgICBGaXggdGhpcyBieSBnb2luZyB0aHJvdWdoIGEgc2luZ2xlIGZ1bmN0 aW9uIHRoYXQga25vd3MKKyAgICAgICAgYnkgaXRzZWxmIHdoZXRoZXIgdG8gc3VzcGVuZCBvciBy ZXN1bWUgcm9vdCBsYXllciBjb21taXRzLAorICAgICAgICBzbyB0aGUgY2FsbGluZyBjb2RlIGRv ZXNuJ3QgaGF2ZSBhIGNoYW5jZSB0byBnZXQgaXQgd3JvbmcuCisKKyAgICAgICAgKiBBcGkvV2Vi UGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OnNldFZpc2li bGUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6bm90aWZ5 QXBwQWN0aXZhdGlvblN0YXRlQ2hhbmdlKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViUGFnZVByaXZhdGU6OnVwZGF0ZVJvb3RMYXllckNvbW1pdEVuYWJsZWQpOgorICAgICAgICAq IEFwaS9XZWJQYWdlX3AuaDoKKyAgICAgICAgKFdlYlBhZ2VQcml2YXRlKToKKwogMjAxMy0wNi0x OSAgSmFrb2IgUGV0c292aXRzICA8anBldHNvdml0c0BibGFja2JlcnJ5LmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gUHJldmVudCBsb3NzIG9mIHRpbGUgYnVmZmVycyBpbiBCYWNraW5nU3Rv cmVQcml2YXRlOjpyZW5kZXIoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKaW5kZXggYWYzZTExYWE2ZDFmOGIyMzBmOTkxMjE0ZTUxMjljMDY2MTMyOTBmNi4uYTg0OTli ZjdkZjA5OTc4OGViNjcyMDg0MTQ5N2QzMjdiY2FiNjJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zMTkwLDE0ICszMTkwLDE0IEBAIHZvaWQgV2ViUGFn ZTo6c2V0VmlzaWJsZShib29sIHZpc2libGUpCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HKQogICAgICAgICAvLyBSb290IGxheWVyIGNvbW1pdCBpcyBub3QgbmVjZXNzYXJ5IGZvciBp bnZpc2libGUgdGFicy4KICAgICAgICAgLy8gQW5kIHJlbGVhc2UgbGF5ZXIgcmVzb3VyY2VzIGNh biByZWR1Y2UgbWVtb3J5IGNvbnN1bXB0aW9uLgotICAgICAgICBkLT5zdXNwZW5kUm9vdExheWVy Q29tbWl0KCk7CisgICAgICAgIGQtPnVwZGF0ZVJvb3RMYXllckNvbW1pdEVuYWJsZWQoKTsKICNl bmRpZgogCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCi0gICAgZC0+cmVzdW1lUm9vdExheWVyQ29tbWl0KCk7CisgICAgZC0+dXBkYXRl Um9vdExheWVyQ29tbWl0RW5hYmxlZCgpOwogI2VuZGlmCiAKICAgICAvLyBXZSB3YW50IHRvIGJl Y29tZSB2aXNpYmxlIGJ1dCBub3QgZ2V0IGJhY2tpbmcgc3RvcmUgb3duZXJzaGlwLgpAQCAtNDk2 OCwxMCArNDk2OCw3IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6Om5vdGlmeUFwcEFjdGl2YXRpb25T dGF0ZUNoYW5nZShBY3RpdmF0aW9uU3RhdGVUeXBlIGFjdGl2YXRpCiAgICAgbV9hY3RpdmF0aW9u U3RhdGUgPSBhY3RpdmF0aW9uU3RhdGU7CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJ TkcpCi0gICAgaWYgKGFjdGl2YXRpb25TdGF0ZSA9PSBBY3RpdmF0aW9uQWN0aXZlKQotICAgICAg ICByZXN1bWVSb290TGF5ZXJDb21taXQoKTsKLSAgICBlbHNlCi0gICAgICAgIHN1c3BlbmRSb290 TGF5ZXJDb21taXQoKTsKKyAgICB1cGRhdGVSb290TGF5ZXJDb21taXRFbmFibGVkKCk7CiAjZW5k aWYKIAogI2lmIEVOQUJMRShQQUdFX1ZJU0lCSUxJVFlfQVBJKQpAQCAtNTYwOCwyNSArNTYwNSwy MiBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjpyZWxlYXNlTGF5ZXJSZXNvdXJjZXNDb21wb3NpdGlu Z1RocmVhZCgpCiAgICAgbV9jb21wb3NpdG9yLT5yZWxlYXNlTGF5ZXJSZXNvdXJjZXMoKTsKIH0K IAotdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c3VzcGVuZFJvb3RMYXllckNvbW1pdCgpCit2b2lkIFdl YlBhZ2VQcml2YXRlOjp1cGRhdGVSb290TGF5ZXJDb21taXRFbmFibGVkKCkKIHsKLSAgICBpZiAo bV9zdXNwZW5kUm9vdExheWVyQ29tbWl0KQotICAgICAgICByZXR1cm47CisgICAgYm9vbCBzaG91 bGRTdXNwZW5kID0gIW1fdmlzaWJsZSB8fCBtX2FjdGl2YXRpb25TdGF0ZSAhPSBBY3RpdmF0aW9u QWN0aXZlOwogCi0gICAgbV9zdXNwZW5kUm9vdExheWVyQ29tbWl0ID0gdHJ1ZTsKLQotICAgIGlm ICghbV9jb21wb3NpdG9yKQorICAgIGlmIChtX3N1c3BlbmRSb290TGF5ZXJDb21taXQgPT0gc2hv dWxkU3VzcGVuZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgcmVsZWFzZUxheWVyUmVzb3VyY2Vz KCk7Ci19CisgICAgbV9zdXNwZW5kUm9vdExheWVyQ29tbWl0ID0gc2hvdWxkU3VzcGVuZDsKKwor ICAgIGlmIChtX3N1c3BlbmRSb290TGF5ZXJDb21taXQpIHsKKyAgICAgICAgaWYgKG1fY29tcG9z aXRvcikKKyAgICAgICAgICAgIHJlbGVhc2VMYXllclJlc291cmNlcygpOwogCi12b2lkIFdlYlBh Z2VQcml2YXRlOjpyZXN1bWVSb290TGF5ZXJDb21taXQoKQotewotICAgIGlmICghbV9zdXNwZW5k Um9vdExheWVyQ29tbWl0KQogICAgICAgICByZXR1cm47CisgICAgfQogCi0gICAgbV9zdXNwZW5k Um9vdExheWVyQ29tbWl0ID0gZmFsc2U7CiAgICAgbV9uZWVkc0NvbW1pdCA9IHRydWU7CiAgICAg Ly8gUFIgMzMwOTE3LCBleHBsaWNpdGx5IHN0YXJ0IHJvb3QgbGF5ZXIgY29tbWl0IHRpbWVyLCBz byB0aGF0IHRoZXJlJ3MgYSBjb21taXQKICAgICAvLyBldmVuIGlmIEJhY2tpbmdTdG9yZSBnb3Qg ZGlzYWJsZWQvcmVtb3ZlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5o CmluZGV4IDYwOTA4YWViNjkzNDMyY2IxOWQxZjE3ZDMzYmNjYmNiZGUzNWIzZWIuLmMwZDI3NDUz ZDc3ZDM2ODdjZDM4Y2RlNzE5YTdmMTYxNzdlYTY5MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlX3AuaApAQCAtNDAzLDggKzQwMyw3IEBAIHB1YmxpYzoKICAgICB2b2lk IHN5bmNEZXN0cm95Q29tcG9zaXRvck9uQ29tcG9zaXRpbmdUaHJlYWQoKTsKICAgICB2b2lkIHJl bGVhc2VMYXllclJlc291cmNlcygpOwogICAgIHZvaWQgcmVsZWFzZUxheWVyUmVzb3VyY2VzQ29t cG9zaXRpbmdUaHJlYWQoKTsKLSAgICB2b2lkIHN1c3BlbmRSb290TGF5ZXJDb21taXQoKTsKLSAg ICB2b2lkIHJlc3VtZVJvb3RMYXllckNvbW1pdCgpOworICAgIHZvaWQgdXBkYXRlUm9vdExheWVy Q29tbWl0RW5hYmxlZCgpOwogCiAgICAgdm9pZCBzY2hlZHVsZUNvbXBvc2l0aW5nUnVuKCk7CiAj ZW5kaWYK