117949 2013-06-24 14:50:44 -0700 WebKit should link to opengl32.lib on Windows 2013-06-24 17:15:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P4 Trivial --- 0 achristensen webkit-unassigned bfulgham commit-queue oldest_to_newest 903077 0 achristensen 2013-06-24 14:50:44 -0700 Linking to opengl32.lib will allow enabling WebGL, but it won't change anything with WebGL not enabled because it currently links successfully without it. 903079 1 205329 achristensen 2013-06-24 14:52:22 -0700 Created attachment 205329 Patch 903086 2 205329 bfulgham 2013-06-24 15:11:53 -0700 Comment on attachment 205329 Patch Looks fine. Let's allow the EWS to run on it, then land it if it's fine. 903143 3 achristensen 2013-06-24 17:05:50 -0700 EWS has had its chance. I can apply the patch, even if the windows bot can't. I'm going to cq+ it and we'll see if it gets through the commit queue. We can roll it out if it breaks the build, but I've built successfully with this. 903148 4 205329 commit-queue 2013-06-24 17:15:38 -0700 Comment on attachment 205329 Patch Clearing flags on attachment: 205329 Committed r151937: <http://trac.webkit.org/changeset/151937> 903149 5 commit-queue 2013-06-24 17:15:39 -0700 All reviewed patches have been landed. Closing bug. 205329 2013-06-24 14:52:22 -0700 2013-06-24 17:15:38 -0700 Patch bug-117949-20130624145027.patch text/plain 2475 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTE5MzEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA2LTI0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBXaW5kb3dzIGJ1aWxk IGxpbmtzIHRvIG9wZW5nbDMyLmxpYiB0byBhbGxvdyBXZWJHTCBjb21waWxpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc5NDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC52Y3hwcm9q L1dlYktpdC9XZWJLaXRDb21tb24ucHJvcHM6IEFkZGVkIGxpbmsgdG8gb3BlbmdsMzIubGliLgor CiAyMDEzLTA2LTE3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBT b3J0IGFsbCB0aGUgWGNvZGUgcHJvamVjdCBmaWxlcwpJbmRleDogU291cmNlL1dlYktpdC9XZWJL aXQudmN4cHJvai9XZWJLaXQvV2ViS2l0Q29tbW9uLnByb3BzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0L1dlYktpdENvbW1vbi5wcm9wcwkocmV2aXNp b24gMTUxODUzKQorKysgU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9XZWJLaXQvV2ViS2l0 Q29tbW9uLnByb3BzCSh3b3JraW5nIGNvcHkpCkBAIC0xMyw3ICsxMyw3IEBACiAgICAgICA8Rm9y Y2VkSW5jbHVkZUZpbGVzPldlYktpdFByZWZpeC5oO0lDVVZlcnNpb24uaDslKEZvcmNlZEluY2x1 ZGVGaWxlcyk8L0ZvcmNlZEluY2x1ZGVGaWxlcz4NCiAgICAgPC9DbENvbXBpbGU+DQogICAgIDxM aW5rPg0KLSAgICAgIDxBZGRpdGlvbmFsRGVwZW5kZW5jaWVzPmRlbGF5aW1wLmxpYjtrZXJuZWwz Mi5saWI7dXNlcjMyLmxpYjtnZGkzMi5saWI7YWR2YXBpMzIubGliO3NoZWxsMzIubGliO29sZTMy LmxpYjtvbGVhdXQzMi5saWI7dXVpZC5saWI7b2RiYzMyLmxpYjtvZGJjY3AzMi5saWI7dXNwMTAu bGliO2NvbWN0bDMyLmxpYjt2ZXJzaW9uLmxpYjtzaGx3YXBpLmxpYjtsaWJ4c2x0JChEZWJ1Z1N1 ZmZpeCkubGliO2xpYnhtbDIkKERlYnVnU3VmZml4KS5saWI7bGliaWN1aW4kKERlYnVnU3VmZml4 KS5saWI7bGliaWN1dWMkKERlYnVnU3VmZml4KS5saWI7V1RGJChEZWJ1Z1N1ZmZpeCkubGliO0ph dmFTY3JpcHRDb3JlJChEZWJ1Z1N1ZmZpeCkubGliO1dlYkNvcmUkKERlYnVnU3VmZml4KS5saWI7 V2ViS2l0R1VJRCQoRGVidWdTdWZmaXgpLmxpYjtTUUxpdGUzJChEZWJ1Z1N1ZmZpeCkubGliO21z aW1nMzIubGliO2NyeXB0MzIubGliO2lwaGxwYXBpLmxpYjt3aW5tbS5saWI7Y29tc3VwcHcubGli O3JwY3J0NC5saWI7emRsbCQoRGVidWdTdWZmaXgpLmxpYjslKEFkZGl0aW9uYWxEZXBlbmRlbmNp ZXMpPC9BZGRpdGlvbmFsRGVwZW5kZW5jaWVzPg0KKyAgICAgIDxBZGRpdGlvbmFsRGVwZW5kZW5j aWVzPm9wZW5nbDMyLmxpYjtkZWxheWltcC5saWI7a2VybmVsMzIubGliO3VzZXIzMi5saWI7Z2Rp MzIubGliO2FkdmFwaTMyLmxpYjtzaGVsbDMyLmxpYjtvbGUzMi5saWI7b2xlYXV0MzIubGliO3V1 aWQubGliO29kYmMzMi5saWI7b2RiY2NwMzIubGliO3VzcDEwLmxpYjtjb21jdGwzMi5saWI7dmVy c2lvbi5saWI7c2hsd2FwaS5saWI7bGlieHNsdCQoRGVidWdTdWZmaXgpLmxpYjtsaWJ4bWwyJChE ZWJ1Z1N1ZmZpeCkubGliO2xpYmljdWluJChEZWJ1Z1N1ZmZpeCkubGliO2xpYmljdXVjJChEZWJ1 Z1N1ZmZpeCkubGliO1dURiQoRGVidWdTdWZmaXgpLmxpYjtKYXZhU2NyaXB0Q29yZSQoRGVidWdT dWZmaXgpLmxpYjtXZWJDb3JlJChEZWJ1Z1N1ZmZpeCkubGliO1dlYktpdEdVSUQkKERlYnVnU3Vm Zml4KS5saWI7U1FMaXRlMyQoRGVidWdTdWZmaXgpLmxpYjttc2ltZzMyLmxpYjtjcnlwdDMyLmxp YjtpcGhscGFwaS5saWI7d2lubW0ubGliO2NvbXN1cHB3LmxpYjtycGNydDQubGliO3pkbGwkKERl YnVnU3VmZml4KS5saWI7JShBZGRpdGlvbmFsRGVwZW5kZW5jaWVzKTwvQWRkaXRpb25hbERlcGVu ZGVuY2llcz4NCiAgICAgICA8TW9kdWxlRGVmaW5pdGlvbkZpbGU+JChDb25maWd1cmF0aW9uQnVp bGREaXIpXG9iajMyXFdlYktpdEV4cG9ydEdlbmVyYXRvclxXZWJLaXRFeHBvcnRzLmRlZjwvTW9k dWxlRGVmaW5pdGlvbkZpbGU+DQogICAgICAgPERlbGF5TG9hZERMTHM+dXNwMTAuZGxsO2NvbWN0 bDMyLmRsbDt2ZXJzaW9uLmRsbDtpcGhscGFwaS5kbGw7JShEZWxheUxvYWRETExzKTwvRGVsYXlM b2FkRExMcz4NCiAgICAgPC9MaW5rPg0K