117943 2013-06-24 13:19:05 -0700 [WK2] Make sure m_iconDatabaseImpl is not null before closing it 2013-06-24 15:50:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nick.diego webkit-unassigned commit-queue sergio simon.fraser oldest_to_newest 903041 0 nick.diego 2013-06-24 13:19:05 -0700 Make sure m_iconDatabaseImpl is not null before closing it 903042 1 205321 nick.diego 2013-06-24 13:24:15 -0700 Created attachment 205321 Patch 903064 2 simon.fraser 2013-06-24 14:27:36 -0700 Is this a crash observed in the field, or when running tests? 903088 3 nick.diego 2013-06-24 15:22:27 -0700 Since r150474 WebIconDatabase is closed unconditionally in TestController destructor, in that case WebKitTestRunner crashes when no icon database path is set. This misbehavior was observed in ports such as efl and nix. 903089 4 205333 nick.diego 2013-06-24 15:23:36 -0700 Created attachment 205333 Patch proposed patch 903101 5 205333 commit-queue 2013-06-24 15:50:01 -0700 Comment on attachment 205333 Patch Clearing flags on attachment: 205333 Committed r151932: <http://trac.webkit.org/changeset/151932> 903102 6 commit-queue 2013-06-24 15:50:03 -0700 All reviewed patches have been landed. Closing bug. 205321 2013-06-24 13:24:15 -0700 2013-06-24 15:23:26 -0700 Patch bug-117943-20130624163250.patch text/plain 1312 nick.diego U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzU0MzYxYWU5ZjhlMmFl ZWM4ZmE1OGZlMzlmMjg0Y2NlODA2NWZmOC4uYTMzNjExNjIyNTczYmJhODg4NzllMWMzYzI3MTQx OTI3M2VjNTBlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTI0ICBOaWNr IERpZWdvIFlhbWFuZSAgPG5pY2sueWFtYW5lQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgTWFr ZSBzdXJlIG1faWNvbkRhdGFiYXNlSW1wbCBpcyBub3QgbnVsbCBiZWZvcmUgY2xvc2luZyBpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViSWNvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSWNvbkRhdGFiYXNl OjpjbG9zZSk6CisKIDIwMTMtMDYtMjQgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBJbXBsZW1lbnQgdW5pdCB0ZXN0IGNh bGxiYWNrOiBvbldvcmRHdWVzc2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkljb25EYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSWNv bkRhdGFiYXNlLmNwcAppbmRleCA3MTNmNjA1NDU3OWRlNjRiNmI2YzA0MDczMzg3NGFkOWRlNjU1 ZmQ3Li43YjdmOTk4NGIzN2RhMTg5NzZjZDA5Y2E2ZjExOWRhZjZmZjI2OTczIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSWNvbkRhdGFiYXNlLmNwcApAQCAtMjI4LDcgKzIyOCw4 IEBAIHZvaWQgV2ViSWNvbkRhdGFiYXNlOjpjaGVja0ludGVncml0eUJlZm9yZU9wZW5pbmcoKQog CiB2b2lkIFdlYkljb25EYXRhYmFzZTo6Y2xvc2UoKQogewotICAgIG1faWNvbkRhdGFiYXNlSW1w bC0+Y2xvc2UoKTsKKyAgICBpZiAobV9pY29uRGF0YWJhc2VJbXBsKQorICAgICAgICBtX2ljb25E YXRhYmFzZUltcGwtPmNsb3NlKCk7CiB9CiAKIHZvaWQgV2ViSWNvbkRhdGFiYXNlOjppbml0aWFs aXplSWNvbkRhdGFiYXNlQ2xpZW50KGNvbnN0IFdLSWNvbkRhdGFiYXNlQ2xpZW50KiBjbGllbnQp Cg== 205333 2013-06-24 15:23:36 -0700 2013-06-24 15:50:01 -0700 Patch bug-117943-20130624183212.patch text/plain 1791 nick.diego U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzU0MzYxYWU5ZjhlMmFl ZWM4ZmE1OGZlMzlmMjg0Y2NlODA2NWZmOC4uMTgxMTUwNDE4NTBmNzY3OWNhYTU5NWE4ZjU2YTdm OTZlNDQ3NjViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA2LTI0ICBOaWNr IERpZWdvIFlhbWFuZSAgPG5pY2sueWFtYW5lQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgTWFr ZSBzdXJlIG1faWNvbkRhdGFiYXNlSW1wbCBpcyBub3QgbnVsbCBiZWZvcmUgY2xvc2luZyBpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgcjE1 MDQ3NCBXZWJJY29uRGF0YWJhc2UgaXMgY2xvc2VkIHVuY29uZGl0aW9uYWxseSBpbgorICAgICAg ICBUZXN0Q29udHJvbGxlciBkZXN0cnVjdG9yLCBpbiB0aGF0IGNhc2UgV2ViS2l0VGVzdFJ1bm5l ciBjcmFzaGVzCisgICAgICAgIHdoZW4gbm8gaWNvbiBkYXRhYmFzZSBwYXRoIGlzIHNldC4gVGhp cyBtaXNiZWhhdmlvciB3YXMgb2JzZXJ2ZWQgaW4KKyAgICAgICAgcG9ydHMgc3VjaCBhcyBlZmwg YW5kIG5peC4KKyAgICAgICAgSW4gdGhpcyBwYXRjaCwgV2ViSWNvbkRhdGFiYXNlOjpjbG9zZSgp IGNhbGxzIG1faWNvbkRhdGFiYXNlSW1wbC0+Y2xvc2UoKQorICAgICAgICBvbmx5IGlmIG1faWNv bkRhdGFiYXNlSW1wbCBpcyBub3QgbnVsbCwgYXMgaXQncyBhbHJlYWR5IGJlaW5nIGRvbmUgaW4g b3RoZXIKKyAgICAgICAgV2ViSWNvbkRhdGFiYXNlJ3MgbWV0aG9kcywgc3VjaCBhcyBpc09wZW4o KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJY29uRGF0YWJhc2UuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJJY29uRGF0YWJhc2U6OmNsb3NlKToKKwogMjAxMy0wNi0yNCAgS3J6eXN6dG9m IFdvbGFuc2tpICA8ay53b2xhbnNraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJd IEltcGxlbWVudCB1bml0IHRlc3QgY2FsbGJhY2s6IG9uV29yZEd1ZXNzZXMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJJY29uRGF0YWJhc2UuY3BwCmluZGV4IDcxM2Y2MDU0NTc5ZGU2 NGI2YjZjMDQwNzMzODc0YWQ5ZGU2NTVmZDcuLjdiN2Y5OTg0YjM3ZGExODk3NmNkMDljYTZmMTE5 ZGFmNmZmMjY5NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJY29u RGF0YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJY29uRGF0YWJh c2UuY3BwCkBAIC0yMjgsNyArMjI4LDggQEAgdm9pZCBXZWJJY29uRGF0YWJhc2U6OmNoZWNrSW50 ZWdyaXR5QmVmb3JlT3BlbmluZygpCiAKIHZvaWQgV2ViSWNvbkRhdGFiYXNlOjpjbG9zZSgpCiB7 Ci0gICAgbV9pY29uRGF0YWJhc2VJbXBsLT5jbG9zZSgpOworICAgIGlmIChtX2ljb25EYXRhYmFz ZUltcGwpCisgICAgICAgIG1faWNvbkRhdGFiYXNlSW1wbC0+Y2xvc2UoKTsKIH0KIAogdm9pZCBX ZWJJY29uRGF0YWJhc2U6OmluaXRpYWxpemVJY29uRGF0YWJhc2VDbGllbnQoY29uc3QgV0tJY29u RGF0YWJhc2VDbGllbnQqIGNsaWVudCkK