117930 2013-06-24 05:09:43 -0700 Update AbstractWorker, Worker and SharedWorker to match the specification 2013-06-24 23:28:33 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://src.chromium.org/viewvc/blink?revision=152723&view=revision BlinkMergeCandidate P2 Normal --- 1 cdumez cdumez ap commit-queue darin esprehn+autocc haraken oldest_to_newest 902914 0 cdumez 2013-06-24 05:09:43 -0700 Update AbstractWorker, Worker and SharedWorker to match the spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker Worker and SharedWorker should no longer inherit from AbstractWorker. Web IDL 'implements' statements should be used instead. Worker and SharedWorker can now inherit from EventTarget as per the specification. 902917 1 205287 cdumez 2013-06-24 05:19:19 -0700 Created attachment 205287 Patch 902936 2 205287 haraken 2013-06-24 06:40:19 -0700 Comment on attachment 205287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review > Source/WebCore/workers/AbstractWorker.idl:-36 > - CustomToJSObject, Why can you remove this? 902940 3 205287 cdumez 2013-06-24 07:03:21 -0700 Comment on attachment 205287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review >> Source/WebCore/workers/AbstractWorker.idl:-36 >> - CustomToJSObject, > > Why can you remove this? This basically declares the following in JSAbstractWorker.h but don't generate its implementation in JSAbstractWorker.cpp: JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, AbstractWorker*); It can be removed for 2 reasons: - Its implementation is not provided anywhere and it likely build only because it is not used. - Now that AbstractWorker acts as a partial interface, JSAbstractWorker.* are now empty anyway so this attribute would have no impact whatsoever. 902955 4 205287 haraken 2013-06-24 07:48:32 -0700 Comment on attachment 205287 Patch Makes sense. 903225 5 205287 commit-queue 2013-06-24 23:28:28 -0700 Comment on attachment 205287 Patch Clearing flags on attachment: 205287 Committed r151956: <http://trac.webkit.org/changeset/151956> 903226 6 commit-queue 2013-06-24 23:28:33 -0700 All reviewed patches have been landed. Closing bug. 205287 2013-06-24 05:19:19 -0700 2013-06-24 23:28:28 -0700 Patch 117930_AbtractWorker.patch text/plain 3281 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZjU1NjU0Li5jM2QzODRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTMtMDYtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFVwZGF0ZSBBYnN0cmFjdFdvcmtlciwgV29ya2VyIGFuZCBTaGFyZWRX b3JrZXIgdG8gbWF0Y2ggdGhlIHNwZWNpZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzkzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBBYnN0cmFjdFdvcmtlciwgV29ya2VyIGFu ZCBTaGFyZWRXb3JrZXIgdG8gbWF0Y2ggdGhlIHNwZWM6CisgICAgICAgIGh0dHA6Ly93d3cud2hh dHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3dvcmtlcnMuaHRt bCNhYnN0cmFjdHdvcmtlcgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2Vi LWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS93b3JrZXJzLmh0bWwjd29ya2VyCisgICAgICAg IGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlw YWdlL3dvcmtlcnMuaHRtbCNzaGFyZWR3b3JrZXIKKworICAgICAgICBXb3JrZXIgYW5kIFNoYXJl ZFdvcmtlciBubyBsb25nZXIgaW5oZXJpdCBmcm9tIEFic3RyYWN0V29ya2VyLiBXZWIgSURMICdp bXBsZW1lbnRzJworICAgICAgICBzdGF0ZW1lbnRzIGFyZSB1c2VkIGluc3RlYWQuIFdvcmtlciBh bmQgU2hhcmVkV29ya2VyIGNhbiBub3cgaW5oZXJpdCBmcm9tIEV2ZW50VGFyZ2V0CisgICAgICAg IGFzIHBlciB0aGUgc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJl aGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHdvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsOgor ICAgICAgICAqIHdvcmtlcnMvU2hhcmVkV29ya2VyLmlkbDoKKyAgICAgICAgKiB3b3JrZXJzL1dv cmtlci5pZGw6CisKIDIwMTMtMDYtMjQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNTEwMjEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL0Fic3RyYWN0V29ya2VyLmlkbCBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsCmluZGV4IDZkMzM2ZjUuLjhhYTZl NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsCkBAIC0zMiwx OSArMzIsNyBAQAogWwogICAgIE5vSW50ZXJmYWNlT2JqZWN0LAogICAgIENvbmRpdGlvbmFsPVdP UktFUlMsCi0gICAgQWN0aXZlRE9NT2JqZWN0LAotICAgIEN1c3RvbVRvSlNPYmplY3QsCi0gICAg RXZlbnRUYXJnZXQKIF0gaW50ZXJmYWNlIEFic3RyYWN0V29ya2VyIHsKLQogICAgIGF0dHJpYnV0 ZSBFdmVudExpc3RlbmVyIG9uZXJyb3I7Ci0KLSAgICB2b2lkIGFkZEV2ZW50TGlzdGVuZXIoRE9N U3RyaW5nIHR5cGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgIEV2ZW50TGlzdGVuZXIgbGlz dGVuZXIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIGJvb2xlYW4gdXNlQ2Fw dHVyZSk7Ci0gICAgdm9pZCByZW1vdmVFdmVudExpc3RlbmVyKERPTVN0cmluZyB0eXBlLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBFdmVudExpc3RlbmVyIGxpc3RlbmVyLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25hbCBib29sZWFuIHVzZUNhcHR1cmUpOwotICAg IFtSYWlzZXNFeGNlcHRpb25dIGJvb2xlYW4gZGlzcGF0Y2hFdmVudChFdmVudCBldnQpOwogfTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIuaWRsIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIuaWRsCmluZGV4IDk3YzhkOWIuLmFm YTQ4MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyLmlk bAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwKQEAgLTM1LDgg KzM1LDExIEBACiAgICAgQ3VzdG9tQ29uc3RydWN0b3IoRE9NU3RyaW5nIHNjcmlwdFVSTCwgW0Rl ZmF1bHQ9TnVsbFN0cmluZ10gb3B0aW9uYWwgRE9NU3RyaW5nIG5hbWUpLAogICAgIEpTQ3VzdG9t TWFya0Z1bmN0aW9uLAogICAgIEpTR2VuZXJhdGVUb05hdGl2ZU9iamVjdCwKLSAgICBKU0dlbmVy YXRlVG9KU09iamVjdAotXSBpbnRlcmZhY2UgU2hhcmVkV29ya2VyIDogQWJzdHJhY3RXb3JrZXIg eworICAgIEpTR2VuZXJhdGVUb0pTT2JqZWN0LAorICAgIEFjdGl2ZURPTU9iamVjdAorXSBpbnRl cmZhY2UgU2hhcmVkV29ya2VyIDogRXZlbnRUYXJnZXQgewogICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBNZXNzYWdlUG9ydCBwb3J0OwogfTsKIAorU2hhcmVkV29ya2VyIGltcGxlbWVudHMgQWJzdHJh Y3RXb3JrZXI7CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmlk bCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmlkbAppbmRleCAxY2I0NGY3Li4xMWEw ZGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsCkBAIC0yOSw4ICsyOSw5IEBACiAgICAg Q29uZGl0aW9uYWw9V09SS0VSUywKICAgICBDdXN0b21Db25zdHJ1Y3RvcihET01TdHJpbmcgc2Ny aXB0VXJsKSwKICAgICBKU0dlbmVyYXRlVG9OYXRpdmVPYmplY3QsCi0gICAgSlNHZW5lcmF0ZVRv SlNPYmplY3QKLV0gaW50ZXJmYWNlIFdvcmtlciA6IEFic3RyYWN0V29ya2VyIHsKKyAgICBKU0dl bmVyYXRlVG9KU09iamVjdCwKKyAgICBBY3RpdmVET01PYmplY3QKK10gaW50ZXJmYWNlIFdvcmtl ciA6IEV2ZW50VGFyZ2V0IHsKIAogICAgIGF0dHJpYnV0ZSBFdmVudExpc3RlbmVyIG9ubWVzc2Fn ZTsKIApAQCAtNDQsMyArNDUsNSBAQAogICAgIHZvaWQgdGVybWluYXRlKCk7CiB9OwogCitXb3Jr ZXIgaW1wbGVtZW50cyBBYnN0cmFjdFdvcmtlcjsKKwo=