117927 2013-06-24 03:02:37 -0700 Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection 2013-06-24 11:06:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 902896 0 graouts 2013-06-24 03:02:37 -0700 If I go to http://www.lequipe.fr/Football/Actualites/Menez-attend-un-signe/380997#xtor=RSS-1, I can't inspect the page due to the following failure: [Error] URIError: URI error displayNameForURL (Main.js, line 2894) _updateTitles (Main.js, line 2895) _updateResource (Main.js, line 2893) ResourceTreeElement (Main.js, line 2876) _addTreeElementForRepresentedObject (Main.js, line 3014) onpopulate (Main.js, line 2980) expand (Main.js, line 2405) _attach (Main.js, line 2364) insertChild (Main.js, line 2230) _mainFrameDidChange (Main.js, line 2743) dispatch (Main.js, line 278) dispatchEventToListeners (Main.js, line 280) _mainFrameDidChange (Main.js, line 1514) _processMainFrameResourceTreePayload (Main.js, line 1500) (anonymous function) dispatch (Main.js, line 388) dispatchNextQueuedMessageFromBackend (Main.js, line 8396) (anonymous function) 902897 1 webkit-bug-importer 2013-06-24 03:02:55 -0700 <rdar://problem/14244539> 902904 2 graouts 2013-06-24 03:30:05 -0700 The error is coming from calling decodeURIComponent() with this string as the value for urlComponents.lastPathComponent: http://ww84.smartadserver.com/call2/pubjallajax/2368/17167/2077,2078,647,2163,7186,7185,630,713,650,1278,7186,631,3075,4738,736,632,12340,1075,1446,651,648,16752/4891911503/xtor%3DRSS-1%3Bsize%3Dsmall%3BFOOTBALL%3BLIGUE_1%3BSAISON_2012-2013%3BPARIS-SG%3BMENEZ_JEREMY%3BTRANSFERTS_FOOTBALL%3BMERCATO_ETE_2013%3BINFO_L_%C9QUIPE%3BD1%3B? xtor%3DRSS-1%3Bsize%3Dsmall%3BFOOTBALL%3BLIGUE_1%3BSAISON_2012-2013%3BPARIS-SG%3BMENEZ_JEREMY%3BTRANSFERTS_FOOTBALL%3BMERCATO_ETE_2013%3BINFO_L_%C9QUIPE%3BD1%3B 902920 3 graouts 2013-06-24 05:49:32 -0700 It looks like urlComponents.lastPathComponent is just set incorrectly. 902921 4 graouts 2013-06-24 05:53:41 -0700 The problematic string passed todecodeURIComponent() is actually "xtor%3DRSS-1%3Bsize%3Dsmall%3BFOOTBALL%3BLIGUE_1%3BSAISON_2012-2013%3BPARIS-SG%3BMENEZ_JEREMY%3BTRANSFERTS_FOOTBALL%3BMERCATO_ETE_2013%3BINFO_L_%C9QUIPE%3BD1%3B" 902922 5 graouts 2013-06-24 05:57:07 -0700 "%C9" is the part of the string that yields the decodeURIComponent exception. 902924 6 graouts 2013-06-24 06:03:33 -0700 Looks like the URI encoding is incorrect, and "É" should be "%C3%89" and not "%C9", although some pages on the internets seem to suggest that's OK (http://www.degraeve.com/reference/urlencoding.php). But the RFC 3986 (http://tools.ietf.org/html/rfc3986) suggests otherwise (first full paragraph of page 16). We should just handle the possible exception thrown by decodeURIComponent() here. 902925 7 205288 graouts 2013-06-24 06:09:34 -0700 Created attachment 205288 Patch 902927 8 205288 timothy 2013-06-24 06:15:28 -0700 Comment on attachment 205288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205288&action=review We should probably guard WebInspector.updateWindowTitle and parseQueryString too. > Source/WebInspectorUI/UserInterface/Main.js:360 > + displayName = decodeURIComponent(urlComponents.lastPathComponent || ""); > + } catch (e) { > + // Ignore possible URIError. We should fallback to urlComponents.lastPathComponent (not decoded) for displayName in the catch. 902928 9 205289 graouts 2013-06-24 06:18:35 -0700 Created attachment 205289 Patch for landing 903008 10 205289 commit-queue 2013-06-24 11:06:52 -0700 Comment on attachment 205289 Patch for landing Clearing flags on attachment: 205289 Committed r151918: <http://trac.webkit.org/changeset/151918> 903009 11 commit-queue 2013-06-24 11:06:55 -0700 All reviewed patches have been landed. Closing bug. 205288 2013-06-24 06:09:34 -0700 2013-06-24 06:18:31 -0700 Patch bug-117927-20130624150739.patch text/plain 1739 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 YWQxNmExZTBkMzk4MWQ5Mzg0OWNhNTAzOTY0ZmI5ZWE0MGVmOGNmLi44ZWQzMDU1NjEyZGFmZGJj Y2IzNzE2MTZjNzEzNWYzNzAyZjczODAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNi0yNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvclVS TCgpIGZhaWx1cmUgcHJldmVudHMgRE9NIGluc3BlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzkyNworCisgICAgICAgIEhhbmRsZSBwb3Nz aWJsZSBtaXMtZW5jb2RlZCBVUkkgZnJhZ21lbnRzIHBhc3NlZCB0byBkZWNvZGVVUklDb21wb25l bnQoKSB3aGljaAorICAgICAgICBjb3VsZCBwcmV2ZW50IGluc3BlY3Rpb24gb2YgdGhlIERPTS4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvTWFpbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvclVS TCk6CisKIDIwMTMtMDYtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFNvcnQgYWxsIHRoZSBYY29kZSBwcm9qZWN0IGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwppbmRleCA2MTNhNTU2YTUwMTZjMjVlYjQ1MWI0YjQ0 NWEzNDMwNDRiNDA4NDc5Li5lNWNjZmZjMzY1MjYwNWFmZTRhOGFhMTg2ODhlZTZiNmFkZmE2Mzhh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKQEAgLTM1 Myw3ICszNTMsMTMgQEAgV2ViSW5zcGVjdG9yLmRpc3BsYXlOYW1lRm9yVVJMID0gZnVuY3Rpb24o dXJsLCB1cmxDb21wb25lbnRzKQogewogICAgIGlmICghdXJsQ29tcG9uZW50cykKICAgICAgICAg dXJsQ29tcG9uZW50cyA9IHBhcnNlVVJMKHVybCk7Ci0gICAgcmV0dXJuIGRlY29kZVVSSUNvbXBv bmVudCh1cmxDb21wb25lbnRzLmxhc3RQYXRoQ29tcG9uZW50IHx8ICIiKSB8fCBXZWJJbnNwZWN0 b3IuZGlzcGxheU5hbWVGb3JIb3N0KHVybENvbXBvbmVudHMuaG9zdCkgfHwgdXJsOworICAgIHZh ciBkaXNwbGF5TmFtZTsKKyAgICB0cnkgeworICAgICAgICBkaXNwbGF5TmFtZSA9IGRlY29kZVVS SUNvbXBvbmVudCh1cmxDb21wb25lbnRzLmxhc3RQYXRoQ29tcG9uZW50IHx8ICIiKTsKKyAgICB9 IGNhdGNoIChlKSB7CisgICAgICAgIC8vIElnbm9yZSBwb3NzaWJsZSBVUklFcnJvci4KKyAgICB9 CisgICAgcmV0dXJuIGRpc3BsYXlOYW1lIHx8IFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvckhv c3QodXJsQ29tcG9uZW50cy5ob3N0KSB8fCB1cmw7CiB9CiAKIFdlYkluc3BlY3Rvci5kaXNwbGF5 TmFtZUZvckhvc3QgPSBmdW5jdGlvbihob3N0KQo= 205289 2013-06-24 06:18:35 -0700 2013-06-24 11:06:52 -0700 Patch for landing bug-117927-20130624151640.patch text/plain 1758 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 YWQxNmExZTBkMzk4MWQ5Mzg0OWNhNTAzOTY0ZmI5ZWE0MGVmOGNmLi4zMmNhYmZlNWYyMWFiNGU5 YTAxODE4YjM2YWE5ZTkwOTRiZDI3MzZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNi0yNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvclVS TCgpIGZhaWx1cmUgcHJldmVudHMgRE9NIGluc3BlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzkyNworCisgICAgICAgIEhhbmRsZSBwb3Nz aWJsZSBtaXMtZW5jb2RlZCBVUkkgZnJhZ21lbnRzIHBhc3NlZCB0byBkZWNvZGVVUklDb21wb25l bnQoKSB3aGljaAorICAgICAgICBjb3VsZCBwcmV2ZW50IGluc3BlY3Rpb24gb2YgdGhlIERPTS4K KworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVGb3JV UkwpOgorCiAyMDEzLTA2LTE3ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBTb3J0IGFsbCB0aGUgWGNvZGUgcHJvamVjdCBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKaW5kZXggNjEzYTU1NmE1MDE2YzI1ZWI0NTFiNGI0 NDVhMzQzMDQ0YjQwODQ3OS4uZDUyNWZiYTIyMDIwYjAxYTI1YmQ3ODVlYjczNjJkOTJmYTMxYzYz ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpzCkBAIC0z NTMsNyArMzUzLDEzIEBAIFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvclVSTCA9IGZ1bmN0aW9u KHVybCwgdXJsQ29tcG9uZW50cykKIHsKICAgICBpZiAoIXVybENvbXBvbmVudHMpCiAgICAgICAg IHVybENvbXBvbmVudHMgPSBwYXJzZVVSTCh1cmwpOwotICAgIHJldHVybiBkZWNvZGVVUklDb21w b25lbnQodXJsQ29tcG9uZW50cy5sYXN0UGF0aENvbXBvbmVudCB8fCAiIikgfHwgV2ViSW5zcGVj dG9yLmRpc3BsYXlOYW1lRm9ySG9zdCh1cmxDb21wb25lbnRzLmhvc3QpIHx8IHVybDsKKyAgICB2 YXIgZGlzcGxheU5hbWU7CisgICAgdHJ5IHsKKyAgICAgICAgZGlzcGxheU5hbWUgPSBkZWNvZGVV UklDb21wb25lbnQodXJsQ29tcG9uZW50cy5sYXN0UGF0aENvbXBvbmVudCB8fCAiIik7CisgICAg fSBjYXRjaCAoZSkgeworICAgICAgICBkaXNwbGF5TmFtZSA9IHVybENvbXBvbmVudHMubGFzdFBh dGhDb21wb25lbnQ7CisgICAgfQorICAgIHJldHVybiBkaXNwbGF5TmFtZSB8fCBXZWJJbnNwZWN0 b3IuZGlzcGxheU5hbWVGb3JIb3N0KHVybENvbXBvbmVudHMuaG9zdCkgfHwgdXJsOwogfQogCiBX ZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVGb3JIb3N0ID0gZnVuY3Rpb24oaG9zdCkK