117921 2013-06-23 23:08:30 -0700 Move IDL implements statements to IDL files that implement the interface 2013-06-24 00:59:08 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://src.chromium.org/viewvc/blink?view=rev&revision=152893 BlinkMergeCandidate P2 Normal --- 1 cdumez cdumez cmarcelo commit-queue darin esprehn+autocc haraken kangil.han oldest_to_newest 902864 0 cdumez 2013-06-23 23:08:30 -0700 Move IDL implements statements to IDL files that implement the interface so that we can more easily know that a given IDL interface implements another. The generator should enforce this as well for consistency. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?view=rev&revision=152893 902868 1 205276 cdumez 2013-06-23 23:40:47 -0700 Created attachment 205276 Patch 902869 2 205276 haraken 2013-06-23 23:46:02 -0700 Comment on attachment 205276 Patch Looks ok. 902879 3 205276 commit-queue 2013-06-24 00:59:05 -0700 Comment on attachment 205276 Patch Clearing flags on attachment: 205276 Committed r151896: <http://trac.webkit.org/changeset/151896> 902880 4 commit-queue 2013-06-24 00:59:08 -0700 All reviewed patches have been landed. Closing bug. 205276 2013-06-23 23:40:47 -0700 2013-06-24 00:59:05 -0700 Patch 117921_reverse_implements.patch text/plain 6875 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYTY2MjUxLi5lMDBmNGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTMtMDYtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIE1vdmUgSURMIGltcGxlbWVudHMgc3RhdGVtZW50cyB0byBJREwgZmls ZXMgdGhhdCBpbXBsZW1lbnQgdGhlIGludGVyZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBJREwgaW1wbGVtZW50cyBzdGF0ZW1lbnRzIHRv IElETCBmaWxlcyB0aGF0IGltcGxlbWVudCB0aGUgaW50ZXJmYWNlCisgICAgICAgIHNvIHRoYXQg d2UgY2FuIG1vcmUgZWFzaWx5IGtub3cgdGhhdCBhIGdpdmVuIElETCBpbnRlcmZhY2UgaW1wbGVt ZW50cworICAgICAgICBhbm90aGVyLgorCisgICAgICAgIFRoZSBnZW5lcmF0b3Igbm93IGVuZm9y Y2VzIHRoaXMgYXMgd2VsbCBmb3IgY29uc2lzdGVuY3kuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBjb3ZlcmVkIGJ5IFRlc3RJbXBsZW1lbnRzLmlkbC4KKworICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsOgorICAgICAgICAoZ2V0SW1wbGVtZW50ZWRJbnRlcmZh Y2VzRnJvbUlETCk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbXBsZW1l bnRzLmlkbDoKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdEludGVyZmFjZS5p ZGw6CisgICAgICAgICogZG9tL0NoYXJhY3RlckRhdGEuaWRsOgorICAgICAgICAqIGRvbS9DaGls ZE5vZGUuaWRsOgorICAgICAgICAqIGRvbS9Eb2N1bWVudFR5cGUuaWRsOgorICAgICAgICAqIGRv bS9FbGVtZW50LmlkbDoKKwogMjAxMy0wNi0xNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgU29ydCBhbGwgdGhlIFhjb2RlIHByb2plY3QgZmlsZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKaW5kZXgg YzVjZDQ5NC4uNTBkZWU0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKQEAgLTUxLDE1ICs1MSwyNSBAQCBteSBAaWRsRmlsZXMg PSA8Rkg+OwogY2hvbXAoQGlkbEZpbGVzKTsKIGNsb3NlIEZIOwogCi0jIFBhcnNlIGFsbCBJREwg ZmlsZXMuCiBteSAlaW50ZXJmYWNlTmFtZVRvSWRsRmlsZTsKIG15ICVpZGxGaWxlVG9JbnRlcmZh Y2VOYW1lOwogbXkgJXN1cHBsZW1lbnRhbERlcGVuZGVuY2llczsKIG15ICVzdXBwbGVtZW50YWxz OwogbXkgJHdpbmRvd0NvbnN0cnVjdG9yc0NvZGUgPSAiIjsKIG15ICR3b3JrZXJDb250ZXh0Q29u c3RydWN0b3JzQ29kZSA9ICIiOworCiAjIEdldCByaWQgb2YgZHVwbGljYXRlcyBpbiBpZGxGaWxl cyBhcnJheS4KIG15ICVpZGxGaWxlSGFzaCA9IG1hcCB7ICRfLCAxIH0gQGlkbEZpbGVzOworCisj IFBvcHVsYXRlICRpZGxGaWxlVG9JbnRlcmZhY2VOYW1lIGFuZCAkaW50ZXJmYWNlTmFtZVRvSWRs RmlsZS4KK2ZvcmVhY2ggbXkgJGlkbEZpbGUgKGtleXMgJWlkbEZpbGVIYXNoKSB7CisgICAgbXkg JGZ1bGxQYXRoID0gQ3dkOjpyZWFscGF0aCgkaWRsRmlsZSk7CisgICAgbXkgJGludGVyZmFjZU5h bWUgPSBmaWxlcGFyc2UoYmFzZW5hbWUoJGlkbEZpbGUpLCAiLmlkbCIpOworICAgICRpZGxGaWxl VG9JbnRlcmZhY2VOYW1leyRmdWxsUGF0aH0gPSAkaW50ZXJmYWNlTmFtZTsKKyAgICAkaW50ZXJm YWNlTmFtZVRvSWRsRmlsZXskaW50ZXJmYWNlTmFtZX0gPSAkZnVsbFBhdGg7Cit9CisKKyMgUGFy c2UgYWxsIElETCBmaWxlcy4KIGZvcmVhY2ggbXkgJGlkbEZpbGUgKHNvcnQga2V5cyAlaWRsRmls ZUhhc2gpIHsKICAgICBteSAkZnVsbFBhdGggPSBDd2Q6OnJlYWxwYXRoKCRpZGxGaWxlKTsKICAg ICBteSAkaWRsRmlsZUNvbnRlbnRzID0gZ2V0RmlsZUNvbnRlbnRzKCRmdWxsUGF0aCk7CkBAIC03 MSwxMiArODEsMTQgQEAgZm9yZWFjaCBteSAkaWRsRmlsZSAoc29ydCBrZXlzICVpZGxGaWxlSGFz aCkgewogICAgIH0KICAgICBteSAkaW50ZXJmYWNlTmFtZSA9IGZpbGVwYXJzZShiYXNlbmFtZSgk aWRsRmlsZSksICIuaWRsIik7CiAgICAgIyBIYW5kbGUgaW1wbGVtZW50cyBzdGF0ZW1lbnRzLgot ICAgIG15ICRpbXBsZW1lbnRlcnMgPSBnZXRJbXBsZW1lbnRlcnNGcm9tSURMKCRpZGxGaWxlQ29u dGVudHMsICRpbnRlcmZhY2VOYW1lKTsKLSAgICBmb3JlYWNoIG15ICRpbXBsZW1lbnRlciAoQHsk aW1wbGVtZW50ZXJzfSkgewotICAgICAgICBpZiAoJHN1cHBsZW1lbnRhbERlcGVuZGVuY2llc3sk ZnVsbFBhdGh9KSB7Ci0gICAgICAgICAgICBwdXNoKEB7JHN1cHBsZW1lbnRhbERlcGVuZGVuY2ll c3skZnVsbFBhdGh9fSwgJGltcGxlbWVudGVyKTsKKyAgICBteSAkaW1wbGVtZW50ZWRJbnRlcmZh Y2VzID0gZ2V0SW1wbGVtZW50ZWRJbnRlcmZhY2VzRnJvbUlETCgkaWRsRmlsZUNvbnRlbnRzLCAk aW50ZXJmYWNlTmFtZSk7CisgICAgZm9yZWFjaCBteSAkaW1wbGVtZW50ZWRJbnRlcmZhY2UgKEB7 JGltcGxlbWVudGVkSW50ZXJmYWNlc30pIHsKKyAgICAgICAgbXkgJGltcGxlbWVudGVkSWRsRmls ZSA9ICRpbnRlcmZhY2VOYW1lVG9JZGxGaWxleyRpbXBsZW1lbnRlZEludGVyZmFjZX07CisgICAg ICAgIGRpZSAiQ291bGQgbm90IGZpbmQgYSB0aGUgSURMIGZpbGUgd2hlcmUgdGhlIGZvbGxvd2lu ZyBpbXBsZW1lbnRlZCBpbnRlcmZhY2UgaXMgZGVmaW5lZDogJGltcGxlbWVudGVkSW50ZXJmYWNl IiB1bmxlc3MgJGltcGxlbWVudGVkSWRsRmlsZTsKKyAgICAgICAgaWYgKCRzdXBwbGVtZW50YWxE ZXBlbmRlbmNpZXN7JGltcGxlbWVudGVkSWRsRmlsZX0pIHsKKyAgICAgICAgICAgIHB1c2goQHsk c3VwcGxlbWVudGFsRGVwZW5kZW5jaWVzeyRpbXBsZW1lbnRlZElkbEZpbGV9fSwgJGludGVyZmFj ZU5hbWUpOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgJHN1cHBsZW1lbnRhbERlcGVu ZGVuY2llc3skZnVsbFBhdGh9ID0gWyRpbXBsZW1lbnRlcl07CisgICAgICAgICAgICAkc3VwcGxl bWVudGFsRGVwZW5kZW5jaWVzeyRpbXBsZW1lbnRlZElkbEZpbGV9ID0gWyRpbnRlcmZhY2VOYW1l XTsKICAgICAgICAgfQogICAgIH0KICAgICAjIEhhbmRsZSBbTm9JbnRlcmZhY2VPYmplY3RdLgpA QCAtODksOCArMTAxLDYgQEAgZm9yZWFjaCBteSAkaWRsRmlsZSAoc29ydCBrZXlzICVpZGxGaWxl SGFzaCkgewogICAgICAgICAgICAgJHdvcmtlckNvbnRleHRDb25zdHJ1Y3RvcnNDb2RlIC49ICRh dHRyaWJ1dGVDb2RlIHVubGVzcyAkZ2xvYmFsQ29udGV4dCBlcSAiV2luZG93T25seSIKICAgICAg ICAgfQogICAgIH0KLSAgICAkaW50ZXJmYWNlTmFtZVRvSWRsRmlsZXskaW50ZXJmYWNlTmFtZX0g PSAkZnVsbFBhdGg7Ci0gICAgJGlkbEZpbGVUb0ludGVyZmFjZU5hbWV7JGZ1bGxQYXRofSA9ICRp bnRlcmZhY2VOYW1lOwogICAgICRzdXBwbGVtZW50YWxzeyRmdWxsUGF0aH0gPSBbXTsKIH0KIApA QCAtMjMxLDE3ICsyNDEsMTcgQEAgc3ViIGdldFBhcnRpYWxJbnRlcmZhY2VOYW1lRnJvbUlETAog CiAjIGlkZW50aWZpZXItQSBpbXBsZW1lbnRzIGlkZW50aWZpZXItQjsKICMgaHR0cDovL3d3dy53 My5vcmcvVFIvV2ViSURMLyNpZGwtaW1wbGVtZW50cy1zdGF0ZW1lbnRzCi1zdWIgZ2V0SW1wbGVt ZW50ZXJzRnJvbUlETAorc3ViIGdldEltcGxlbWVudGVkSW50ZXJmYWNlc0Zyb21JREwKIHsKICAg ICBteSAkZmlsZUNvbnRlbnRzID0gc2hpZnQ7CiAgICAgbXkgJGludGVyZmFjZU5hbWUgPSBzaGlm dDsKIAotICAgIG15IEBpbXBsZW1lbnRlcnMgPSAoKTsKKyAgICBteSBAaW1wbGVtZW50ZWRJbnRl cmZhY2VzID0gKCk7CiAgICAgd2hpbGUgKCRmaWxlQ29udGVudHMgPX4gLyhcdyspXHMraW1wbGVt ZW50c1xzKyhcdyspXHMqOy9ncykgewotICAgICAgICBkaWUgIlRoZSBpZGVudGlmaWVyIG9uIHRo ZSByaWdodCBzaWRlIG9mIHRoZSBpbXBsZW1lbnRzIHN0YXRlbWVudCBtdXN0IGJlIHRoZSBjdXJy ZW50IGludGVyZmFjZSIgaWYgJDIgbmUgJGludGVyZmFjZU5hbWU7Ci0gICAgICAgIHB1c2goQGlt cGxlbWVudGVycywgJDEpOworICAgICAgICBkaWUgIklkZW50aWZpZXIgb24gdGhlIGxlZnQgb2Yg dGhlICdpbXBsZW1lbnRzJyBzdGF0ZW1lbnQgc2hvdWxkIGJlICRpbnRlcmZhY2VOYW1lIGluICRp bnRlcmZhY2VOYW1lLmlkbCwgYnV0IGZvdW5kICQxIiBpZiAkMSBuZSAkaW50ZXJmYWNlTmFtZTsK KyAgICAgICAgcHVzaChAaW1wbGVtZW50ZWRJbnRlcmZhY2VzLCAkMik7CiAgICAgfQotICAgIHJl dHVybiBcQGltcGxlbWVudGVycworICAgIHJldHVybiBcQGltcGxlbWVudGVkSW50ZXJmYWNlcwog fQogCiBzdWIgaXNDYWxsYmFja0ludGVyZmFjZUZyb21JREwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0SW1wbGVtZW50cy5pZGwgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdEltcGxlbWVudHMuaWRsCmluZGV4IDM3 YmFhOTEuLjJmNWFhZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9UZXN0SW1wbGVtZW50cy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L1Rlc3RJbXBsZW1lbnRzLmlkbApAQCAtNDksNCArNDksMyBAQAogICAgIFtS ZWZsZWN0PUNPTlNUX0lNUExdIGNvbnN0IHVuc2lnbmVkIHNob3J0IElNUExFTUVOVFNDT05TVEFO VDIgPSAyOwogfTsKIAotVGVzdEludGVyZmFjZSBpbXBsZW1lbnRzIFRlc3RJbXBsZW1lbnRzOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRl cmZhY2UuaWRsIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRl cmZhY2UuaWRsCmluZGV4IDkzMzc5NmQuLjA5ODNmMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0SW50ZXJmYWNlLmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdEludGVyZmFjZS5pZGwKQEAgLTM5LDMg KzM5LDYgQEAKICAgICBJbXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlCiBdIGludGVyZmFjZSBUZXN0 SW50ZXJmYWNlIHsKIH07CisKK1Rlc3RJbnRlcmZhY2UgaW1wbGVtZW50cyBUZXN0SW1wbGVtZW50 czsKKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuaWRsIGIv U291cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuaWRsCmluZGV4IDA1YmIzZWQuLmM4Yzk3 MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJEYXRhLmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2hhcmFjdGVyRGF0YS5pZGwKQEAgLTM5LDMgKzM5LDUgQEAg aW50ZXJmYWNlIENoYXJhY3RlckRhdGEgOiBOb2RlIHsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFtEZWZhdWx0PVVuZGVmaW5lZF0gb3B0aW9uYWwgRE9NU3RyaW5nIGRhdGEp OwogfTsKIAorQ2hhcmFjdGVyRGF0YSBpbXBsZW1lbnRzIENoaWxkTm9kZTsKKwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0NoaWxkTm9kZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20v Q2hpbGROb2RlLmlkbAppbmRleCAxNjVlMGI0Li5iOTE1NTZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vQ2hpbGROb2RlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2hpbGRO b2RlLmlkbApAQCAtMzEsNiArMzEsMyBAQAogICAgIFtSYWlzZXNFeGNlcHRpb25dIHZvaWQgcmVt b3ZlKCk7CiB9OwogCi1Eb2N1bWVudFR5cGUgaW1wbGVtZW50cyBDaGlsZE5vZGU7Ci1FbGVtZW50 IGltcGxlbWVudHMgQ2hpbGROb2RlOwotQ2hhcmFjdGVyRGF0YSBpbXBsZW1lbnRzIENoaWxkTm9k ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaWRsIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50VHlwZS5pZGwKaW5kZXggOGUyOWFiOS4uZDZiMjU0YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50VHlwZS5pZGwKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50VHlwZS5pZGwKQEAgLTM0LDMgKzM0LDUgQEAKICAgICBb VHJlYXRSZXR1cm5lZE51bGxTdHJpbmdBcz1OdWxsXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIGludGVybmFsU3Vic2V0OyAgICAgICAgCiB9OwogCitEb2N1bWVudFR5cGUgaW1wbGVtZW50 cyBDaGlsZE5vZGU7CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50Lmlk bCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbAppbmRleCBmZmZkMWQ1Li4yMmU0NjEw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRsCkBAIC0yMjcsMyArMjI3LDUgQEAKICNlbmRpZgogfTsK IAorRWxlbWVudCBpbXBsZW1lbnRzIENoaWxkTm9kZTsKKwo=