117911 2013-06-22 08:57:26 -0700 HashMap: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods 2013-06-24 12:09:07 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca benjamin cmarcelo commit-queue darin kling oldest_to_newest 902790 0 mikhail.pozdnyakov 2013-06-22 08:57:26 -0700 Rationals: 1) callers can just pass the translator and let the compiler deduce T 2) consistency with HashSet (see bug#117830) 902793 1 205254 mikhail.pozdnyakov 2013-06-22 09:08:15 -0700 Created attachment 205254 patch 903024 2 205254 commit-queue 2013-06-24 12:09:03 -0700 Comment on attachment 205254 patch Clearing flags on attachment: 205254 Committed r151920: <http://trac.webkit.org/changeset/151920> 903025 3 commit-queue 2013-06-24 12:09:07 -0700 All reviewed patches have been landed. Closing bug. 205254 2013-06-22 09:08:15 -0700 2013-06-24 12:09:03 -0700 patch bug117911 text/plain 6222 mikhail.pozdnyakov Y29tbWl0IDNmZjdkNWI3YjM0ZDcxNjQ3MzMwODQ4NzcxMDFjNGExY2VjYmRjOWEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg U2F0IEp1biAyMiAxOTowNDoxNyAyMDEzICswMzAwCgogICAgYnVnMTE3OTExCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCA5YmNl YTBlLi4wMzZmYjk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTIyICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIEhhc2hN YXA6IHJldmVyc2UgdGhlIG9yZGVyIG9mIHRoZSB0ZW1wbGF0ZSBhcmd1bWVudHMgYXQgYWx0ZXJu YXRlICdmaW5kJywgJ2NvbnRhaW5zJyBhbmQgJ2FkZCcgbWV0aG9kcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTExCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9yZGVyIG9mIHRoZSB0ZW1wbGF0 ZSBhcmd1bWVudHMgYXQgSGFzaE1hcCBhbHRlcm5hdGUgJ2ZpbmQnLCAnY29udGFpbnMnIGFuZAor ICAgICAgICAnYWRkJyBtZXRob2RzIGlzIHJldmVyc2VkIHNvIHRoYXQgY2FsbGVycyBjYW4ganVz dCBwYXNzIHRoZSB0cmFuc2xhdG9yCisgICAgICAgIGFuZCBsZXQgdGhlIGNvbXBpbGVyIGRlZHVj ZSBpbnB1dCBhcmd1bWVudCB0eXBlLgorCisgICAgICAgIEFub3RoZXIgcmF0aW9uYWwgaXMgY29u c2lzdGVuY3kgd2l0aCBIYXNoU2V0IGNsYXNzLgorCisgICAgICAgICogd3RmL0hhc2hNYXAuaDoK KwogMjAxMy0wNi0yMCAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBvcGVuYm9zc2Eu b3JnPgogCiAgICAgICAgIFtXSzJdIExvb3BpbmcgZm9yIEVJTlRSIG9uIGNsb3NlKCkgaXMgaW5j b3JyZWN0IGZvciBMaW51eCwgYXQgbGVhc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hh c2hNYXAuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hNYXAuaAppbmRleCA3YjFlNjBiLi43MDhlOGQ4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoTWFwLmgKKysrIGIvU291cmNlL1dURi93 dGYvSGFzaE1hcC5oCkBAIC0xMTcsOSArMTE3LDkgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAg IC8vIG11c3QgaGF2ZSB0aGUgZm9sbG93aW5nIGZ1bmN0aW9uIG1lbWJlcnM6CiAgICAgICAgIC8v ICAgc3RhdGljIHVuc2lnbmVkIGhhc2goY29uc3QgVCYpOwogICAgICAgICAvLyAgIHN0YXRpYyBi b29sIGVxdWFsKGNvbnN0IFZhbHVlVHlwZSYsIGNvbnN0IFQmKTsKLSAgICAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVCwgdHlwZW5hbWUgSGFzaFRyYW5zbGF0b3I+IGl0ZXJhdG9yIGZpbmQoY29uc3Qg VCYpOwotICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBIYXNoVHJhbnNsYXRv cj4gY29uc3RfaXRlcmF0b3IgZmluZChjb25zdCBUJikgY29uc3Q7Ci0gICAgICAgIHRlbXBsYXRl PHR5cGVuYW1lIFQsIHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9yPiBib29sIGNvbnRhaW5zKGNvbnN0 IFQmKSBjb25zdDsKKyAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgSGFzaFRyYW5zbGF0b3IsIHR5 cGVuYW1lIFQ+IGl0ZXJhdG9yIGZpbmQoY29uc3QgVCYpOworICAgICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBIYXNoVHJhbnNsYXRvciwgdHlwZW5hbWUgVD4gY29uc3RfaXRlcmF0b3IgZmluZChjb25z dCBUJikgY29uc3Q7CisgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9yLCB0 eXBlbmFtZSBUPiBib29sIGNvbnRhaW5zKGNvbnN0IFQmKSBjb25zdDsKIAogICAgICAgICAvLyBB biBhbHRlcm5hdGUgdmVyc2lvbiBvZiBhZGQoKSB0aGF0IGZpbmRzIHRoZSBvYmplY3QgYnkgaGFz aGluZyBhbmQgY29tcGFyaW5nCiAgICAgICAgIC8vIHdpdGggc29tZSBvdGhlciB0eXBlLCB0byBh dm9pZCB0aGUgY29zdCBvZiB0eXBlIGNvbnZlcnNpb24gaWYgdGhlIG9iamVjdCBpcyBhbHJlYWR5 CkBAIC0xMjcsNyArMTI3LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIC8vICAgc3RhdGlj IHVuc2lnbmVkIGhhc2goY29uc3QgVCYpOwogICAgICAgICAvLyAgIHN0YXRpYyBib29sIGVxdWFs KGNvbnN0IFZhbHVlVHlwZSYsIGNvbnN0IFQmKTsKICAgICAgICAgLy8gICBzdGF0aWMgdHJhbnNs YXRlKFZhbHVlVHlwZSYsIGNvbnN0IFQmLCB1bnNpZ25lZCBoYXNoQ29kZSk7Ci0gICAgICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9yPiBBZGRSZXN1bHQgYWRk KGNvbnN0IFQmLCBNYXBwZWRQYXNzSW5UeXBlKTsKKyAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUg SGFzaFRyYW5zbGF0b3IsIHR5cGVuYW1lIFQ+IEFkZFJlc3VsdCBhZGQoY29uc3QgVCYsIE1hcHBl ZFBhc3NJblR5cGUpOwogCiAgICAgICAgIHZvaWQgY2hlY2tDb25zaXN0ZW5jeSgpIGNvbnN0Owog CkBAIC0zMTIsNyArMzEyLDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgfQogCiAgICAgdGVtcGxh dGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5hbWUgVywgdHlwZW5h bWUgWD4KLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUWVBFLCB0eXBlbmFtZSBIYXNoVHJhbnNsYXRv cj4KKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBIYXNoVHJhbnNsYXRvciwgdHlwZW5hbWUgVFlQRT4K ICAgICBpbmxpbmUgdHlwZW5hbWUgSGFzaE1hcDxULCBVLCBWLCBXLCBYPjo6aXRlcmF0b3IKICAg ICBIYXNoTWFwPFQsIFUsIFYsIFcsIFg+OjpmaW5kKGNvbnN0IFRZUEUmIHZhbHVlKQogICAgIHsK QEAgLTMyMCw3ICszMjAsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB9CiAKICAgICB0ZW1wbGF0 ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBXLCB0eXBlbmFt ZSBYPgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFRZUEUsIHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9y PgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9yLCB0eXBlbmFtZSBUWVBFPgog ICAgIGlubGluZSB0eXBlbmFtZSBIYXNoTWFwPFQsIFUsIFYsIFcsIFg+Ojpjb25zdF9pdGVyYXRv ciAKICAgICBIYXNoTWFwPFQsIFUsIFYsIFcsIFg+OjpmaW5kKGNvbnN0IFRZUEUmIHZhbHVlKSBj b25zdAogICAgIHsKQEAgLTMyOCw3ICszMjgsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB9CiAK ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFt ZSBXLCB0eXBlbmFtZSBYPgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFRZUEUsIHR5cGVuYW1lIEhh c2hUcmFuc2xhdG9yPgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9yLCB0eXBl bmFtZSBUWVBFPgogICAgIGlubGluZSBib29sCiAgICAgSGFzaE1hcDxULCBVLCBWLCBXLCBYPjo6 Y29udGFpbnMoY29uc3QgVFlQRSYgdmFsdWUpIGNvbnN0CiAgICAgewpAQCAtMzU1LDcgKzM1NSw3 IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5 cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5cGVuYW1lIFcsIHR5cGVuYW1lIFg+Ci0gICAgdGVtcGxh dGU8dHlwZW5hbWUgVFlQRSwgdHlwZW5hbWUgSGFzaFRyYW5zbGF0b3I+CisgICAgdGVtcGxhdGU8 dHlwZW5hbWUgSGFzaFRyYW5zbGF0b3IsIHR5cGVuYW1lIFRZUEU+CiAgICAgdHlwZW5hbWUgSGFz aE1hcDxULCBVLCBWLCBXLCBYPjo6QWRkUmVzdWx0CiAgICAgSGFzaE1hcDxULCBVLCBWLCBXLCBY Pjo6YWRkKGNvbnN0IFRZUEUmIGtleSwgTWFwcGVkUGFzc0luVHlwZSB2YWx1ZSkKICAgICB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjQ5MDI2Yi4uNGQyZmRhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTA2LTIyICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50 ZWwuY29tPgorCisgICAgICAgIEhhc2hNYXA6IHJldmVyc2UgdGhlIG9yZGVyIG9mIHRoZSB0ZW1w bGF0ZSBhcmd1bWVudHMgYXQgYWx0ZXJuYXRlICdmaW5kJywgJ2NvbnRhaW5zJyBhbmQgJ2FkZCcg bWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE3OTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIG9yZGVyIG9mIHRoZSB0ZW1wbGF0ZSBhcmd1bWVudHMgYXQgSGFzaE1hcCBhbHRlcm5hdGUg J2ZpbmQnLCAnY29udGFpbnMnIGFuZAorICAgICAgICAnYWRkJyBtZXRob2RzIGlzIHJldmVyc2Vk IHNvIHRoYXQgY2FsbGVycyBjYW4ganVzdCBwYXNzIHRoZSB0cmFuc2xhdG9yCisgICAgICAgIGFu ZCBsZXQgdGhlIGNvbXBpbGVyIGRlZHVjZSBpbnB1dCBhcmd1bWVudCB0eXBlLgorCisgICAgICAg IEFub3RoZXIgcmF0aW9uYWwgaXMgY29uc2lzdGVuY3kgd2l0aCBIYXNoU2V0IGNsYXNzLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUVFBIZWFkZXJNYXA6OmdldCk6CisgICAgICAgIChXZWJDb3JlOjpIVFRQSGVhZGVy TWFwOjpjb250YWlucyk6CisgICAgICAgIChXZWJDb3JlOjpIVFRQSGVhZGVyTWFwOjphZGQpOgor CiAyMDEzLTA2LTIxICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgQ3Jhc2hlcyBkdWUgdG8gTlVMTCBkZXJlZmVyZW5jZSBiZW5lYXRoIFdlYkNvcmU6OlN0eWxl UmVzb2x2ZXI6OmxvYWRQZW5kaW5nU1ZHRG9jdW1lbnRzIGFuZCByZWxhdGVkIGZ1bmN0aW9ucwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFw LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5jcHAK aW5kZXggNjQ1YTg1Yi4uZWEwNjg5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuY3BwCkBAIC05Nyw3ICs5Nyw3IEBAIHN0cnVjdCBDYXNl Rm9sZGluZ0NTdHJpbmdUcmFuc2xhdG9yIHsKIAogU3RyaW5nIEhUVFBIZWFkZXJNYXA6OmdldChj b25zdCBjaGFyKiBuYW1lKSBjb25zdAogewotICAgIGNvbnN0X2l0ZXJhdG9yIGkgPSBmaW5kPGNv bnN0IGNoYXIqLCBDYXNlRm9sZGluZ0NTdHJpbmdUcmFuc2xhdG9yPihuYW1lKTsKKyAgICBjb25z dF9pdGVyYXRvciBpID0gZmluZDxDYXNlRm9sZGluZ0NTdHJpbmdUcmFuc2xhdG9yPihuYW1lKTsK ICAgICBpZiAoaSA9PSBlbmQoKSkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIHJldHVy biBpLT52YWx1ZTsKQEAgLTEwNSwxMiArMTA1LDEyIEBAIFN0cmluZyBIVFRQSGVhZGVyTWFwOjpn ZXQoY29uc3QgY2hhciogbmFtZSkgY29uc3QKICAgICAKIGJvb2wgSFRUUEhlYWRlck1hcDo6Y29u dGFpbnMoY29uc3QgY2hhciogbmFtZSkgY29uc3QKIHsKLSAgICByZXR1cm4gZmluZDxjb25zdCBj aGFyKiwgQ2FzZUZvbGRpbmdDU3RyaW5nVHJhbnNsYXRvcj4obmFtZSkgIT0gZW5kKCk7CisgICAg cmV0dXJuIGZpbmQ8Q2FzZUZvbGRpbmdDU3RyaW5nVHJhbnNsYXRvcj4obmFtZSkgIT0gZW5kKCk7 CiB9CiAKIEhUVFBIZWFkZXJNYXA6OkFkZFJlc3VsdCBIVFRQSGVhZGVyTWFwOjphZGQoY29uc3Qg Y2hhciogbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKIHsKLSAgICByZXR1cm4gSGFzaE1hcDxB dG9taWNTdHJpbmcsIFN0cmluZywgQ2FzZUZvbGRpbmdIYXNoPjo6YWRkPGNvbnN0IGNoYXIqLCBD YXNlRm9sZGluZ0NTdHJpbmdUcmFuc2xhdG9yPihuYW1lLCB2YWx1ZSk7CisgICAgcmV0dXJuIEhh c2hNYXA8QXRvbWljU3RyaW5nLCBTdHJpbmcsIENhc2VGb2xkaW5nSGFzaD46OmFkZDxDYXNlRm9s ZGluZ0NTdHJpbmdUcmFuc2xhdG9yPihuYW1lLCB2YWx1ZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUK