<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>11790</bug_id>
          
          <creation_ts>2006-12-08 18:02:01 -0800</creation_ts>
          <short_desc>No way to initialize ResourceResponse::m_httpHeaderFields</short_desc>
          <delta_ts>2006-12-10 11:43:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>420+</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Darin Fisher (:fishd, Google)">fishd</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>42723</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2006-12-08 18:02:01 -0800</bug_when>
    <thetext>No way to initialize ResourceResponse::m_httpHeaderFields

I propose the addition of a setHTTPHeaderField method.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42724</commentid>
    <comment_count>1</comment_count>
      <attachid>11783</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2006-12-08 18:18:31 -0800</bug_when>
    <thetext>Created attachment 11783
patch

This patch adds the proposed setHTTPHeaderField method.

I understand that the mac port gets around this bug by reading fields out of the NSURLResponse, so one could argue that there should be some equivalent &apos;platform response handle&apos; that is stored on the ResourceResponse, and then the platform ports should implement updateResourceResponse.  However, that is overkill for some ports, and since everything else is settable on this class, I think it makes sense to define this method.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42559</commentid>
    <comment_count>2</comment_count>
      <attachid>11783</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2006-12-09 14:45:25 -0800</bug_when>
    <thetext>Comment on attachment 11783
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42570</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-12-10 02:30:16 -0800</bug_when>
    <thetext>Committed revision 18133.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>11783</attachid>
            <date>2006-12-08 18:18:31 -0800</date>
            <delta_ts>2006-12-09 14:45:25 -0800</delta_ts>
            <desc>patch</desc>
            <filename>resp-1.diff</filename>
            <type>text/plain</type>
            <size>1759</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDk2
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTIt
MDggIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3OTAKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv
UmVzb3VyY2VSZXNwb25zZS5jcHA6IGltcGwgc2V0SFRUUEhlYWRlckZpZWxkCisgICAgICAgIChX
ZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpzZXRIVFRQSGVhZGVyRmllbGQpOgorICAgICAgICAq
IHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZS5oOiBkZWNsIHNldEhUVFBIZWFkZXJG
aWVsZAorCiAyMDA2LTEyLTA4ICBaYWNrIFJ1c2luICA8emFja0BrZGUub3JnPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNw
b25zZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNl
LmNwcAkocmV2aXNpb24gMTgwODQpCisrKyBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9u
c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsNiArMTAwLDEzIEBAIFN0cmluZyBSZXNvdXJj
ZVJlc3BvbnNlOjpodHRwSGVhZGVyRmllbGQKICAgICByZXR1cm4gbV9odHRwSGVhZGVyRmllbGRz
LmdldChuYW1lKTsgCiB9CiAKK3ZvaWQgUmVzb3VyY2VSZXNwb25zZTo6c2V0SFRUUEhlYWRlckZp
ZWxkKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICB1cGRh
dGVSZXNvdXJjZVJlc3BvbnNlKCk7CisKKyAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KG5hbWUs
IHZhbHVlKTsKK30KKwogY29uc3QgSFRUUEhlYWRlck1hcCYgUmVzb3VyY2VSZXNwb25zZTo6aHR0
cEhlYWRlckZpZWxkcygpIGNvbnN0CiB7CiAgICAgdXBkYXRlUmVzb3VyY2VSZXNwb25zZSgpOwpJ
bmRleDogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlLmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
cGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlLmgJKHJldmlzaW9uIDE4MDg0KQorKysg
cGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTgy
LDYgKzgyLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0SFRUUFN0YXR1c1RleHQoY29uc3QgU3Ry
aW5nJik7CiAgICAgCiAgICAgU3RyaW5nIGh0dHBIZWFkZXJGaWVsZChjb25zdCBTdHJpbmcmIG5h
bWUpIGNvbnN0OworICAgIHZvaWQgc2V0SFRUUEhlYWRlckZpZWxkKGNvbnN0IFN0cmluZyYgbmFt
ZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7CiAgICAgY29uc3QgSFRUUEhlYWRlck1hcCYgaHR0cEhl
YWRlckZpZWxkcygpIGNvbnN0OwogCiAgICAgYm9vbCBpc011bHRpcGFydCgpIGNvbnN0IHsgcmV0
dXJuIG1pbWVUeXBlKCkgPT0gIm11bHRpcGFydC94LW1peGVkLXJlcGxhY2UiOyB9Cg==
</data>
<flag name="review"
          id="4270"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>