117894 2013-06-21 14:23:08 -0700 GraphicsContext3D including GraphicsContext3DNEON 2013-06-21 14:56:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 achristensen webkit-unassigned bfulgham commit-queue dino oldest_to_newest 902674 0 achristensen 2013-06-21 14:23:08 -0700 Source/WebCore/platform/graphics/GraphicsContext3D.cpp's #including GraphicsContext3DNEON.h causes compiler errors on Windows when enabling WebGL. The header itself is protected with #if HAVE(ARM_NEON_INTRINSICS) and everything in GraphicsContext3D that uses it is also protected with the macro, so I suggest the #include also be protected by this macro. 902677 1 205218 achristensen 2013-06-21 14:30:24 -0700 Created attachment 205218 Patch 902678 2 205218 bfulgham 2013-06-21 14:31:24 -0700 Comment on attachment 205218 Patch Looks fine. I'm not sure any of the build bots will verify the Neon stuff is ok... 902684 3 205218 commit-queue 2013-06-21 14:56:13 -0700 Comment on attachment 205218 Patch Clearing flags on attachment: 205218 Committed r151858: <http://trac.webkit.org/changeset/151858> 902685 4 commit-queue 2013-06-21 14:56:16 -0700 All reviewed patches have been landed. Closing bug. 205218 2013-06-21 14:30:24 -0700 2013-06-21 14:56:13 -0700 Patch bug-117894-20130621142836.patch text/plain 1424 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTg1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBHcmFwaGljc0Nv bnRleHQzRE5FT04uaCBjYW5ub3QgYmUgZm91bmQgb24gV2luZG93cyBhbmQgZG9lcyBub3QgbmVl ZCB0byBiZSBmb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNzg5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwOgorICAgICAg ICBBZGRlZCAjaWYgSEFWRShBUk1fTkVPTl9JTlRSSU5TSUNTKSBhcm91bmQgI2luY2x1ZGUgIkdy YXBoaWNzQ29udGV4dDNETkVPTi5oIgorCiAyMDEzLTA2LTIxICBSb2JlcnQgSG9nYW4gIDxyb2Jl cnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBJZ25vcmluZyBwYWRkaW5nLXJpZ2h0IG9mIGlubGlu ZSBlbGVtZW50cyBpbiBjb250YWluZXJzIHdpdGggdW5kZWZpbmVkIHdpZHRoCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0 M0QuY3BwCShyZXZpc2lvbiAxNTE4NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDYg QEAKICNpZiBVU0UoM0RfR1JBUEhJQ1MpCiAKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQzRC5o IgotI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dDNETkVPTi5oIgogCiAjaW5jbHVkZSAiQ2hlY2tl ZEludC5oIgogI2luY2x1ZGUgIkRyYXdpbmdCdWZmZXIuaCIKQEAgLTM5LDYgKzM4LDEwIEBACiAj aW5jbHVkZSAiSW1hZ2VEYXRhLmgiCiAjaW5jbHVkZSAiSW1hZ2VPYnNlcnZlci5oIgogCisjaWYg SEFWRShBUk1fTkVPTl9JTlRSSU5TSUNTKQorI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dDNETkVP Ti5oIgorI2VuZGlmCisKICNpbmNsdWRlIDx3dGYvQXJyYXlCdWZmZXJWaWV3Lmg+CiAjaW5jbHVk ZSA8d3RmL093bkFycmF5UHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25BcnJheVB0ci5oPgo=