117893 2013-06-21 14:13:38 -0700 Web Inspector: Uncaught exception when pretty printing WebInspector.Script 2013-06-21 15:13:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 902669 0 joepeck 2013-06-21 14:13:38 -0700 * DESCRIPTION I hit this debugging a page. I introduced a JS issue recently when I refactored some code to use WebInspector.script.resource. I removed a line declaring a local variable and didn't fix the other lines using the local. * STEPS TO REPRODUCE 1. Evaluation the following in the console: // testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing testing (function() { return 1+1; })(); //@ sourceURL=test 2. View the Extra Script in the inspector => it pretty prints and produces an uncaught exception Patch to follow. 902670 1 webkit-bug-importer 2013-06-21 14:13:47 -0700 <rdar://problem/14233755> 902671 2 joepeck 2013-06-21 14:15:57 -0700 Oh, the error is: [Error] ReferenceError: Can't find variable: script (Main.js, line 3527) 902672 3 205216 joepeck 2013-06-21 14:17:13 -0700 Created attachment 205216 [PATCH] Proposed Fix Simple fix. 902686 4 205216 commit-queue 2013-06-21 15:13:30 -0700 Comment on attachment 205216 [PATCH] Proposed Fix Clearing flags on attachment: 205216 Committed r151861: <http://trac.webkit.org/changeset/151861> 902687 5 commit-queue 2013-06-21 15:13:32 -0700 All reviewed patches have been landed. Closing bug. 205216 2013-06-21 14:17:13 -0700 2013-06-21 15:13:30 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 1812 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMzNmU5ZDUuLjkxYmFhN2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIHdoZW4gcHJldHR5IHByaW50aW5nIFdlYkluc3BlY3Rvci5TY3JpcHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzg5MworCisg ICAgICAgIFRoaXMgd2FzIGFuIGlzc3VlIHdpdGggYW4gZWFybGllciByZWZhY3RvcmluZy4gVGhl IHNvdXJjZUNvZGUgaXMgYSBTY3JpcHQsCisgICAgICAgIHNvIHJlcGxhY2UgdGhlIG5vbi1leGlz dGVudCBsb2NhbCB2YXJpYWJsZSAic2NyaXB0IiB3aXRoICJ0aGlzLl9zb3VyY2VDb2RlIi4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvU291cmNlQ29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291 cmNlQ29kZVRleHRFZGl0b3IucHJvdG90eXBlLnRleHRFZGl0b3JVcGRhdGVkRm9ybWF0dGluZyk6 CisKIDIwMTMtMDYtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMTc2MTU+IFdlYiBJbnNwZWN0b3I6IEpTIFBy ZXR0eVByaW50aW5nIFNob3VsZCBoYXZlIHNwYWNlIGJldHdlZW4gImRvIiBhbmQgInsiCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Tb3VyY2VDb2RlVGV4 dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1NvdXJjZUNv ZGVUZXh0RWRpdG9yLmpzCmluZGV4IGM3MzBlNmQuLjZkZjJmZmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzCkBAIC03NzksOCArNzc5LDggQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRp dG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgc2NyaXB0 cy5sZW5ndGg7ICsraSkKICAgICAgICAgICAgICAgICBzY3JpcHRzW2ldLmZvcm1hdHRlclNvdXJj ZU1hcCA9IHRoaXMuZm9ybWF0dGVyU291cmNlTWFwOwogICAgICAgICB9IGVsc2UgaWYgKHRoaXMu X3NvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuU2NyaXB0KSB7Ci0gICAgICAgICAg ICBpZiAoc2NyaXB0LnJlc291cmNlKQotICAgICAgICAgICAgICAgIHNjcmlwdC5yZXNvdXJjZS5m b3JtYXR0ZXJTb3VyY2VNYXAgPSB0aGlzLmZvcm1hdHRlclNvdXJjZU1hcDsKKyAgICAgICAgICAg IGlmICh0aGlzLl9zb3VyY2VDb2RlLnJlc291cmNlKQorICAgICAgICAgICAgICAgIHRoaXMuX3Nv dXJjZUNvZGUucmVzb3VyY2UuZm9ybWF0dGVyU291cmNlTWFwID0gdGhpcy5mb3JtYXR0ZXJTb3Vy Y2VNYXA7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBTb21lIGJyZWFrcG9pbnRzIG1heSBoYXZl IG1vdmVkLCBzb21lIG1pZ2h0IG5vdCBoYXZlLiBKdXN0IGdvIHRocm91Z2gK