117890 2013-06-21 13:26:22 -0700 [MediaStream]: Remove ``>= 0'' assertion from a size_t variable 2013-06-21 15:50:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sergio sergio abarth commit-queue eric.carlson glenn hta jer.noble tommyw oldest_to_newest 902653 0 sergio 2013-06-21 13:26:22 -0700 [MediaStream]: Remove ``>= 0'' assertion from a size_t variable 902654 1 205211 sergio 2013-06-21 13:30:13 -0700 Created attachment 205211 Patch 902663 2 205211 andersca 2013-06-21 14:06:02 -0700 Comment on attachment 205211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205211&action=review > Source/WebCore/Modules/mediastream/RTCStatsResponse.cpp:58 > + // size_t is an unsigned type, so report is always >= 0. I don’t think a comment is needed here. 902676 3 205217 sergio 2013-06-21 14:27:52 -0700 Created attachment 205217 Patch Removed comment. 902696 4 205217 commit-queue 2013-06-21 15:50:27 -0700 Comment on attachment 205217 Patch Clearing flags on attachment: 205217 Committed r151863: <http://trac.webkit.org/changeset/151863> 902697 5 commit-queue 2013-06-21 15:50:30 -0700 All reviewed patches have been landed. Closing bug. 205211 2013-06-21 13:30:13 -0700 2013-06-21 14:27:47 -0700 Patch bug-117890-20130621162821.patch text/plain 1808 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkyZjFjY2M3NzExYzU2 ZTNiOTM0MmE1YWM2ZTE2OWM5MzdjMzZjNS4uZmJhMzBkNWM5MDhmNmU4MDlhMjg5ZWRkOTJkNmQ1 ZDhlNTdlYjgxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTIxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW01l ZGlhU3RyZWFtXTogUmVtb3ZlIGBgPj0gMCcnIGFzc2VydGlvbiBmcm9tIGEgc2l6ZV90IHZhcmlh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc4 OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIGEgc3RyaWN0IGJ1aWxkIGJ5IHJlbW92aW5nIHRoZSBgYD49IDAnJyBhc3Nl cnRpb24gZnJvbQorICAgICAgICBhIHNpemVfdCAodW5zaWduZWQgdHlwZSkgdmFyaWFibGUgaW4g UlRDU3RhdHNSZXNwb25zZS5jcHAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBidWlsZCBmaXgu CisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1N0YXRzUmVzcG9uc2UuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UlRDU3RhdHNSZXNwb25zZTo6YWRkU3RhdGlzdGljKTogUmVtb3Zl IGBgPj0wJydhc3NlcnRpb24sCisgICAgICAgIHNpbmNlIHRoZSB2YXJpYWJsZSBpcyB1bnNpZ25l ZCBhbmQgaXMgYWx3YXlzID49IDAuCisKIDIwMTMtMDYtMjEgIFJ1dGggRm9uZyAgPHJ1dGhfZm9u Z0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFRleHRUcmFja0N1ZTo6Y3VlSW5kZXgoKSB0byBo YW5kbGUgdGhlIG51bGwgY2FzZSBvZiBUZXh0VHJhY2s6OmN1ZXMoKCkgcHJvcGVybHkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDU3RhdHNSZXNwb25z ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1N0YXRzUmVzcG9u c2UuY3BwCmluZGV4IGQyMzIwYmVlYmQwNzRhMTA0NTdmZmZjZjg3MGJlYjA3ZTZiNzRmMjguLjZk NzZhZTM0Mjk2MGU4NWUyZjFlMjFjYmZkZGY2MzdlOTU1ZTU3YWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDU3RhdHNSZXNwb25zZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENTdGF0c1Jlc3BvbnNlLmNwcApA QCAtNTUsNyArNTUsOCBAQCBzaXplX3QgUlRDU3RhdHNSZXNwb25zZTo6YWRkUmVwb3J0KFN0cmlu ZyBpZCwgU3RyaW5nIHR5cGUsIGRvdWJsZSB0aW1lc3RhbXApCiAKIHZvaWQgUlRDU3RhdHNSZXNw b25zZTo6YWRkU3RhdGlzdGljKHNpemVfdCByZXBvcnQsIFN0cmluZyBuYW1lLCBTdHJpbmcgdmFs dWUpCiB7Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04ocmVwb3J0ID49IDAg JiYgcmVwb3J0IDwgbV9yZXN1bHQuc2l6ZSgpKTsKKyAgICAvLyBzaXplX3QgaXMgYW4gdW5zaWdu ZWQgdHlwZSwgc28gcmVwb3J0IGlzIGFsd2F5cyA+PSAwLgorICAgIEFTU0VSVF9XSVRIX1NFQ1VS SVRZX0lNUExJQ0FUSU9OKHJlcG9ydCA8IG1fcmVzdWx0LnNpemUoKSk7CiAgICAgbV9yZXN1bHRb cmVwb3J0XS0+YWRkU3RhdGlzdGljKG5hbWUsIHZhbHVlKTsKIH0KIAo= 205217 2013-06-21 14:27:52 -0700 2013-06-21 15:50:27 -0700 Patch bug-117890-20130621172600.patch text/plain 1700 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWVkZjYwM2M2YWFkNDhi YmQzNWUxMTFlMWMxNzg3ZTM1ZTBlYjU3Zi4uNjc5MTZjZmVmMWE4MmY5ZGY1Nzk3YzFkOWJkNTMz Mjk2N2NlMjM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTIxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW01l ZGlhU3RyZWFtXTogUmVtb3ZlIGBgPj0gMCcnIGFzc2VydGlvbiBmcm9tIGEgc2l6ZV90IHZhcmlh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc4 OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIGEgc3RyaWN0IGJ1aWxkIGJ5IHJlbW92aW5nIHRoZSBgYD49IDAnJyBhc3Nl cnRpb24gZnJvbQorICAgICAgICBhIHNpemVfdCAodW5zaWduZWQgdHlwZSkgdmFyaWFibGUgaW4g UlRDU3RhdHNSZXNwb25zZS5jcHAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBidWlsZCBmaXgu CisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1N0YXRzUmVzcG9uc2UuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UlRDU3RhdHNSZXNwb25zZTo6YWRkU3RhdGlzdGljKTogUmVtb3Zl IGBgPj0wJydhc3NlcnRpb24sCisgICAgICAgIHNpbmNlIHRoZSB2YXJpYWJsZSBpcyB1bnNpZ25l ZCBhbmQgaXMgYWx3YXlzID49IDAuCisKIDIwMTMtMDYtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHBsYXRmb3JtIHRleHQgdHJhY2sg bWVudQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENT dGF0c1Jlc3BvbnNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD U3RhdHNSZXNwb25zZS5jcHAKaW5kZXggZDIzMjBiZWViZDA3NGExMDQ1N2ZmZmNmODcwYmViMDdl NmI3NGYyOC4uOGQ2ZGUxZDVmZDQxNjZhOTQ5MGYwNjdkMzcwMDFkN2I4ODhlMGE2YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENTdGF0c1Jlc3BvbnNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1N0YXRzUmVz cG9uc2UuY3BwCkBAIC01NSw3ICs1NSw3IEBAIHNpemVfdCBSVENTdGF0c1Jlc3BvbnNlOjphZGRS ZXBvcnQoU3RyaW5nIGlkLCBTdHJpbmcgdHlwZSwgZG91YmxlIHRpbWVzdGFtcCkKIAogdm9pZCBS VENTdGF0c1Jlc3BvbnNlOjphZGRTdGF0aXN0aWMoc2l6ZV90IHJlcG9ydCwgU3RyaW5nIG5hbWUs IFN0cmluZyB2YWx1ZSkKIHsKLSAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihy ZXBvcnQgPj0gMCAmJiByZXBvcnQgPCBtX3Jlc3VsdC5zaXplKCkpOworICAgIEFTU0VSVF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHJlcG9ydCA8IG1fcmVzdWx0LnNpemUoKSk7CiAgICAgbV9y ZXN1bHRbcmVwb3J0XS0+YWRkU3RhdGlzdGljKG5hbWUsIHZhbHVlKTsKIH0KIAo=