117877 2013-06-21 08:20:09 -0700 Web Inspector: REGRESSION: Breakpoints often missed when reloading page 2013-06-21 11:17:24 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 902553 0 timothy 2013-06-21 08:20:09 -0700 Setting a breakpoint to trigger on page load, it often doesn't trigger on reloads. I see this primarily in the remote scenario; most likely because of the larger delay and asynchronisity between messages. Steps: 1. On an iOS device/simulator load <http://bogojoker.com/shell/> 2. Open a remote inspector 3. Set a brekapoint on easySlider.min.js:2 or :3 (pretty printed) 4. Reload the page with Cmd+R in the inspector => sometimes the breakpoint is not hit Notes: In the protocol I'm seeing the frontend remove the breakpoint and readd it frequently. Why this extra churn? <rdar://problem/13955160> 902554 1 205186 timothy 2013-06-21 08:27:07 -0700 Created attachment 205186 Patch 902557 2 timothy 2013-06-21 08:38:18 -0700 I have a better fix. 902558 3 205188 timothy 2013-06-21 08:38:57 -0700 Created attachment 205188 Patch 902612 4 205188 joepeck 2013-06-21 10:53:37 -0700 Comment on attachment 205188 Patch r=me 902622 5 205188 commit-queue 2013-06-21 11:17:22 -0700 Comment on attachment 205188 Patch Clearing flags on attachment: 205188 Committed r151846: <http://trac.webkit.org/changeset/151846> 902623 6 commit-queue 2013-06-21 11:17:24 -0700 All reviewed patches have been landed. Closing bug. 205186 2013-06-21 08:27:07 -0700 2013-06-21 08:38:53 -0700 Patch bug-117877-20130621112516.patch text/plain 2411 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 YWJkODQzZjkzNWQwOTVkN2ZkYTI2YTA1NTVmZjNjMTM2YmExYTMyLi5mNzJmZjFlYWE5ODU2NDU2 YTQ1M2JhOGE2YmNlMjQ1N2FlNWYyZGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMy0wNi0yMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgU3RvcCByZW1vdmluZyBhbmQgcmUtYWRkaW5nIGJyZWFrcG9pbnRzIGZy b20gdGhlIGJhY2tlbmQgb24gcmVsb2FkLgorCisgICAgICAgIE9uIHJlbG9hZCB0aGUgc291cmNl Q29kZSBmb3IgYnJlYWtwb2ludHMgYXJlIG51bGxlZCBvdXQsIHdoaWNoIGZpcmVzIERpc3BsYXlM b2NhdGlvbkRpZENoYW5nZS4KKyAgICAgICAgVGhlbiB0aGUgc291cmNlQ29kZSBpcyByZWFzc29j aWF0ZWQsIGZpcmluZyBEaXNwbGF5TG9jYXRpb25EaWRDaGFuZ2UgYWdhaW4uIEluIHRoZXNlIGNh c2VzIHdlCisgICAgICAgIGRvbid0IG5lZWQgdG8gdXBkYXRlIHRoZSBiYWNrZW5kLCBzaW5jZSBu b3RoaW5nIHJlYWxseSBjaGFuZ2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc4NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuX2JyZWFrcG9pbnRE aXNwbGF5TG9jYXRpb25EaWRDaGFuZ2UpOiBSZXR1cm4gZWFybHkgd2hlbgorICAgICAgICBub3Ro aW5nIHRoZSBiYWNrZW5kIGNhcmVzIGFib3V0IGNoYW5nZWQuCisKIDIwMTMtMDYtMTkgIEFudG9p bmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBD b3B5aW5nIGFycmF5IG9yIG9iamVjdCBvdXRwdXQgZG9lcyBub3QgY29udGFpbiB2YWx1ZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyTWFu YWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyTWFu YWdlci5qcwppbmRleCAzMmU5MzRiNjU1Yzc2ODE3Y2Q2OTQ1MWI0NWY5ZTAzMjNlYzZiMzI0Li45 MjM2NmQyMDBiZjc3YjAzNjY0OTgwMzUzMDBkYzRmYjI0NzgwMWM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Z2dlck1hbmFnZXIuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzCkBA IC01MTUsNiArNTE1LDE3IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBl ID0gewogICAgICAgICBpZiAoIWJyZWFrcG9pbnQuaWQgfHwgYnJlYWtwb2ludC5kaXNhYmxlZCkK ICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICB2YXIgc291cmNlQ29kZUxvY2F0aW9uID0g YnJlYWtwb2ludC5zb3VyY2VDb2RlTG9jYXRpb247CisKKyAgICAgICAgLy8gSWYgdGhlIHNvdXJj ZUNvZGUgaXMgbm93IG51bGwsIGxpa2VseSBmcm9tIGEgY2FsbCB0byByZXNldCwgdGhlbiB3ZSBk b24ndCBuZWVkIHRvIGRvIGFueXRoaW5nLgorICAgICAgICBpZiAoIXNvdXJjZUNvZGVMb2NhdGlv bi5zb3VyY2VDb2RlKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIC8vIElmIHRoZSBz b3VyY2VDb2RlIGNoYW5nZWQsIGxpa2VseSBmcm9tIF9hc3NvY2lhdGVCcmVha3BvaW50c1dpdGhT b3VyY2VDb2RlLCBhbmQgdGhlIGJyZWFrcG9pbnQgaGFzIGEgVVJMLAorICAgICAgICAvLyB0aGVu IHdlIG9ubHkgbmVlZCB0byByZWNyZWF0ZSB0aGUgYnJlYWtwb2ludCBpZiB0aGUgbGluZSBvciBj b2x1bW4gbnVtYmVycyBjaGFuZ2VkLgorICAgICAgICBpZiAoYnJlYWtwb2ludC51cmwgJiYgZXZl bnQuZGF0YS5vbGREaXNwbGF5TGluZU51bWJlciA9PT0gc291cmNlQ29kZUxvY2F0aW9uLmRpc3Bs YXlMaW5lTnVtYmVyICYmIGV2ZW50LmRhdGEub2xkRGlzcGxheUNvbHVtbk51bWJlciA9PT0gc291 cmNlQ29kZUxvY2F0aW9uLmRpc3BsYXlDb2x1bW5OdW1iZXIpCisgICAgICAgICAgICByZXR1cm47 CisKICAgICAgICAgLy8gUmVtb3ZlIHRoZSBicmVha3BvaW50IHdpdGggaXRzIG9sZCBpZC4KICAg ICAgICAgdGhpcy5fcmVtb3ZlQnJlYWtwb2ludChicmVha3BvaW50LCBicmVha3BvaW50UmVtb3Zl ZC5iaW5kKHRoaXMpKTsKIAo= 205188 2013-06-21 08:38:57 -0700 2013-06-21 11:17:21 -0700 Patch bug-117877-20130621113705.patch text/plain 3609 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 YWJkODQzZjkzNWQwOTVkN2ZkYTI2YTA1NTVmZjNjMTM2YmExYTMyLi5lMTMyN2FmZDk5MmM5MzY3 ODkwNTJjYmMxZTFiZDg5NmI2NzhkZTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMy0wNi0yMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgU3RvcCByZW1vdmluZyBhbmQgcmUtYWRkaW5nIGJyZWFrcG9pbnRzIGZy b20gdGhlIGJhY2tlbmQgb24gcmVsb2FkLgorCisgICAgICAgIE9uIHJlbG9hZCB0aGUgc291cmNl Q29kZSBmb3IgYnJlYWtwb2ludHMgYXJlIG51bGxlZCBvdXQsIHdoaWNoIGZpcmVzIERpc3BsYXlM b2NhdGlvbkRpZENoYW5nZS4KKyAgICAgICAgVGhlbiB0aGUgc291cmNlQ29kZSBpcyByZWFzc29j aWF0ZWQsIGZpcmluZyBEaXNwbGF5TG9jYXRpb25EaWRDaGFuZ2UgYWdhaW4uIEluIHRoZXNlIGNh c2VzIHdlCisgICAgICAgIGRvbid0IG5lZWQgdG8gdXBkYXRlIHRoZSBiYWNrZW5kLCBzaW5jZSBu b3RoaW5nIHJlYWxseSBjaGFuZ2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc4NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuX2JyZWFrcG9pbnRE aXNwbGF5TG9jYXRpb25EaWRDaGFuZ2UpOiBSZXR1cm4gZWFybHkgd2hlbgorICAgICAgICBfaWdu b3JlQnJlYWtwb2ludERpc3BsYXlMb2NhdGlvbkRpZENoYW5nZUV2ZW50IGlzIHRydWUuCisgICAg ICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5yZXNldCk6IFNldCBf aWdub3JlQnJlYWtwb2ludERpc3BsYXlMb2NhdGlvbkRpZENoYW5nZUV2ZW50LgorICAgICAgICAo V2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuX2Fzc29jaWF0ZUJyZWFrcG9p bnRzV2l0aFNvdXJjZUNvZGUpOiBEaXR0by4KKwogMjAxMy0wNi0xOSAgQW50b2luZSBRdWludCAg PGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvcHlpbmcgYXJy YXkgb3Igb2JqZWN0IG91dHB1dCBkb2VzIG5vdCBjb250YWluIHZhbHVlcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzCmlu ZGV4IDMyZTkzNGI2NTVjNzY4MTdjZDY5NDUxYjQ1ZjllMDMyM2VjNmIzMjQuLmRhZmI4ZWFlZGFj YTEzY2JkMDVkMjBjYjU2OTY1ODY3NjA3MGYyODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Z2dlck1hbmFnZXIuanMKQEAgLTMwMSw2ICsz MDEsOCBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAg ICAgdGhpcy5fc2NyaXB0SWRNYXAgPSB7fTsKICAgICAgICAgdGhpcy5fc2NyaXB0VVJMTWFwID0g e307CiAKKyAgICAgICAgdGhpcy5faWdub3JlQnJlYWtwb2ludERpc3BsYXlMb2NhdGlvbkRpZENo YW5nZUV2ZW50ID0gdHJ1ZTsKKwogICAgICAgICAvLyBNYXJrIGFsbCB0aGUgYnJlYWtwb2ludHMg YXMgdW5yZXNvbHZlZC4gVGhleSB3aWxsIGJlIHJlcG9ydGVkIGFzIHJlc29sdmVkIHdoZW4KICAg ICAgICAgLy8gYnJlYWtwb2ludFJlc29sdmVkIGlzIGNhbGxlZCBhcyB0aGUgcGFnZSBsb2Fkcy4K ICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl9icmVha3BvaW50cy5sZW5ndGg7ICsr aSkgewpAQCAtMzEwLDYgKzMxMiw4IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIucHJv dG90eXBlID0gewogICAgICAgICAgICAgICAgIGJyZWFrcG9pbnQuc291cmNlQ29kZUxvY2F0aW9u LnNvdXJjZUNvZGUgPSBudWxsOwogICAgICAgICB9CiAKKyAgICAgICAgZGVsZXRlIHRoaXMuX2ln bm9yZUJyZWFrcG9pbnREaXNwbGF5TG9jYXRpb25EaWRDaGFuZ2VFdmVudDsKKwogICAgICAgICB0 aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2Vy LkV2ZW50LlNjcmlwdHNDbGVhcmVkKTsKIAogICAgICAgICBpZiAod2FzUGF1c2VkKQpAQCAtNTEx LDYgKzUxNSw5IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBlID0gewog CiAgICAgX2JyZWFrcG9pbnREaXNwbGF5TG9jYXRpb25EaWRDaGFuZ2U6IGZ1bmN0aW9uKGV2ZW50 KQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2lnbm9yZUJyZWFrcG9pbnREaXNwbGF5TG9jYXRp b25EaWRDaGFuZ2VFdmVudCkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICB2YXIgYnJl YWtwb2ludCA9IGV2ZW50LnRhcmdldDsKICAgICAgICAgaWYgKCFicmVha3BvaW50LmlkIHx8IGJy ZWFrcG9pbnQuZGlzYWJsZWQpCiAgICAgICAgICAgICByZXR1cm47CkBAIC02MjAsNiArNjI3LDgg QEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUgPSB7CiAKICAgICBfYXNz b2NpYXRlQnJlYWtwb2ludHNXaXRoU291cmNlQ29kZTogZnVuY3Rpb24oYnJlYWtwb2ludHMsIHNv dXJjZUNvZGUpCiAgICAgeworICAgICAgICB0aGlzLl9pZ25vcmVCcmVha3BvaW50RGlzcGxheUxv Y2F0aW9uRGlkQ2hhbmdlRXZlbnQgPSB0cnVlOworCiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBp IDwgYnJlYWtwb2ludHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIHZhciBicmVha3BvaW50 ID0gYnJlYWtwb2ludHNbaV07CiAgICAgICAgICAgICBpZiAoYnJlYWtwb2ludC5zb3VyY2VDb2Rl TG9jYXRpb24uc291cmNlQ29kZSA9PT0gbnVsbCkKQEAgLTYyNyw2ICs2MzYsOCBAQCBXZWJJbnNw ZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIC8vIFNvdXJj ZUNvZGVzIGNhbiBiZSB1bmVxdWFsIGlmIHRoZSBTb3VyY2VDb2RlTG9jYXRpb24gaXMgYXNzb2Np YXRlZCB3aXRoIGEgU2NyaXB0IGFuZCB3ZSBhcmUgbG9va2luZyBhdCB0aGUgUmVzb3VyY2UuCiAg ICAgICAgICAgICBjb25zb2xlLmFzc2VydChicmVha3BvaW50LnNvdXJjZUNvZGVMb2NhdGlvbi5z b3VyY2VDb2RlID09PSBzb3VyY2VDb2RlIHx8IGJyZWFrcG9pbnQuc291cmNlQ29kZUxvY2F0aW9u LnNvdXJjZUNvZGUudXJsID09PSBzb3VyY2VDb2RlLnVybCk7CiAgICAgICAgIH0KKworICAgICAg ICBkZWxldGUgdGhpcy5faWdub3JlQnJlYWtwb2ludERpc3BsYXlMb2NhdGlvbkRpZENoYW5nZUV2 ZW50OwogICAgIH0KIH07CiAK