117874 2013-06-21 06:27:13 -0700 HTMLMediaElement should inherit from MediaPlayerClient privately 2013-06-25 02:00:53 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117880 1 allan.jensen allan.jensen benjamin commit-queue eric.carlson esprehn+autocc glenn jer.noble noam oldest_to_newest 902524 0 allan.jensen 2013-06-21 06:27:13 -0700 HTMLMediaElement was stuck with public inheritance from MediaPlayerClient due to the Chromium port. This can now be fixed to a private inheritance. 902526 1 205176 allan.jensen 2013-06-21 06:30:10 -0700 Created attachment 205176 Patch 902556 2 205176 kling 2013-06-21 08:36:44 -0700 Comment on attachment 205176 Patch Sweet fix! 902570 3 205176 allan.jensen 2013-06-21 09:02:18 -0700 Comment on attachment 205176 Patch Clearing flags on attachment: 205176 Committed r151838: <http://trac.webkit.org/changeset/151838> 902571 4 allan.jensen 2013-06-21 09:02:24 -0700 All reviewed patches have been landed. Closing bug. 902592 5 commit-queue 2013-06-21 09:46:07 -0700 Re-opened since this is blocked by bug 117880 902893 6 205280 allan.jensen 2013-06-24 02:50:14 -0700 Created attachment 205280 Patch Now also fixed MediaPlayerPrivateQt 903239 7 allan.jensen 2013-06-25 02:00:53 -0700 Committed r151958: <http://trac.webkit.org/changeset/151958> 205176 2013-06-21 06:30:10 -0700 2013-06-24 02:50:10 -0700 Patch bug-117874-20130621152819.patch text/plain 2036 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NiNWY2NTRmYTYzNWMw MDJhNTY0ZmViYjNkZjlmNjcxNGFiY2ZmMC4uM2RiNjVjYWMzNThkMGI1ZDVkMjA5ZGQ0YmQxNWMw ZDFiMzY4MmM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA2LTIxICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIEhU TUxNZWRpYUVsZW1lbnQgc2hvdWxkIGluaGVyaXQgZnJvbSBNZWRpYVBsYXllckNsaWVudCBwcml2 YXRlbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx Nzg3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eGluZyBGSVhNRTogSFRNTE1lZGlhRWxlbWVudCB3YXMgc3R1Y2sgd2l0aCBwdWJsaWMgaW5oZXJp dGFuY2UgZnJvbQorICAgICAgICBNZWRpYVBsYXllckNsaWVudCBkdWUgdG8gdGhlIENocm9taXVt IHBvcnQuCisgICAgICAgIFRoaXMgY2FuIG5vdyBiZSBmaXhlZCB0byBhIHByaXZhdGUgaW5oZXJp dGFuY2UuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKworMjAxMy0wNi0y MSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KKwogICAg ICAgICBSZW1vdmUgQ2hyb21pdW0tb25seSBUb3VjaERpc2FtYmlndWF0aW9uCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc4NzMKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAppbmRleCBiY2M5NTI4ZWI4ZTIwNmU3MDc4MzhkY2M2 N2E5Mzk0YjQ5NGNlODY2Li5iNDcyNWE0YjQ3NzVkMWU0MmViYWRlNDU3NDAzNjQxMjE5YzE0NmNi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtODgsMTEgKzg4LDcg QEAgdHlwZWRlZiBDdWVJbnRlcnZhbFRyZWU6OkludGVydmFsVHlwZSBDdWVJbnRlcnZhbDsKIHR5 cGVkZWYgVmVjdG9yPEN1ZUludGVydmFsPiBDdWVMaXN0OwogI2VuZGlmCiAKLS8vIEZJWE1FOiBU aGUgaW5oZXJpdGFuY2UgZnJvbSBNZWRpYVBsYXllckNsaWVudCBoZXJlIHNob3VsZCBiZSBwcml2 YXRlIGluaGVyaXRhbmNlLgotLy8gQnV0IGl0IGNhbid0IGJlIHVudGlsIHRoZSBDaHJvbWl1bSBX ZWJNZWRpYVBsYXllckNsaWVudEltcGwgY2xhc3MgaXMgZml4ZWQgc28gaXQKLS8vIG5vIGxvbmdl ciBkZXBlbmRzIG9uIHR5cGVjYXN0aW5nIGEgTWVkaWFQbGF5ZXJDbGllbnQgdG8gYW4gSFRNTE1l ZGlhRWxlbWVudC4KLQotY2xhc3MgSFRNTE1lZGlhRWxlbWVudCA6IHB1YmxpYyBIVE1MRWxlbWVu dCwgcHVibGljIE1lZGlhUGxheWVyQ2xpZW50LCBwdWJsaWMgTWVkaWFQbGF5ZXJTdXBwb3J0c1R5 cGVDbGllbnQsIHByaXZhdGUgTWVkaWFDYW5TdGFydExpc3RlbmVyLCBwdWJsaWMgQWN0aXZlRE9N T2JqZWN0LCBwdWJsaWMgTWVkaWFDb250cm9sbGVySW50ZXJmYWNlCitjbGFzcyBIVE1MTWVkaWFF bGVtZW50IDogcHVibGljIEhUTUxFbGVtZW50LCBwcml2YXRlIE1lZGlhUGxheWVyQ2xpZW50LCBw dWJsaWMgTWVkaWFQbGF5ZXJTdXBwb3J0c1R5cGVDbGllbnQsIHByaXZhdGUgTWVkaWFDYW5TdGFy dExpc3RlbmVyLCBwdWJsaWMgQWN0aXZlRE9NT2JqZWN0LCBwdWJsaWMgTWVkaWFDb250cm9sbGVy SW50ZXJmYWNlCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgICwgcHJpdmF0ZSBBdWRpb1Ry YWNrQ2xpZW50CiAgICAgLCBwcml2YXRlIFRleHRUcmFja0NsaWVudAo= 205280 2013-06-24 02:50:14 -0700 2013-06-24 19:43:15 -0700 Patch bug-117874-20130624114819.patch text/plain 4360 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWVkNzZmMGI3ZmYzNGZl MmJjNWM5OWVkZGJhNDc4NTQ2MTM3MzY1ZC4uMmNjZmM4MTRmNTQyMzFjM2ViMDZiNDc2MjZiODg1 OGJlNGM1M2E4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTI0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIEhU TUxNZWRpYUVsZW1lbnQgc2hvdWxkIGluaGVyaXQgZnJvbSBNZWRpYVBsYXllckNsaWVudCBwcml2 YXRlbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx Nzg3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eGluZyBGSVhNRTogSFRNTE1lZGlhRWxlbWVudCB3YXMgc3R1Y2sgd2l0aCBwdWJsaWMgaW5oZXJp dGFuY2UgZnJvbQorICAgICAgICBNZWRpYVBsYXllckNsaWVudCBkdWUgdG8gdGhlIENocm9taXVt IGFuZCBRdCBwb3J0LgorCisgICAgICAgIFRoZSBRdCBwb3J0IGlzIGNoYW5nZWQgdG8gbm90IGNh c3QgZnJvbSBNZWRpYVBsYXllckNsaWVudCB0byBIVE1MTWVkaWFFbGVtZW50LgorCisgICAgICAg ICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlUXQ6OmNvbW1pdExvYWQpOgorCiAyMDEzLTA2LTI0ICBDaHJpc3RvcGhlIER1bWV6 ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBNb3ZlIElETCBpbXBsZW1l bnRzIHN0YXRlbWVudHMgdG8gSURMIGZpbGVzIHRoYXQgaW1wbGVtZW50IHRoZSBpbnRlcmZhY2UK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXggYmNjOTUyOGViOGUyMDZl NzA3ODM4ZGNjNjdhOTM5NGI0OTRjZTg2Ni4uYjQ3MjVhNGI0Nzc1ZDFlNDJlYmFkZTQ1NzQwMzY0 MTIxOWMxNDZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKQEAgLTg4 LDExICs4OCw3IEBAIHR5cGVkZWYgQ3VlSW50ZXJ2YWxUcmVlOjpJbnRlcnZhbFR5cGUgQ3VlSW50 ZXJ2YWw7CiB0eXBlZGVmIFZlY3RvcjxDdWVJbnRlcnZhbD4gQ3VlTGlzdDsKICNlbmRpZgogCi0v LyBGSVhNRTogVGhlIGluaGVyaXRhbmNlIGZyb20gTWVkaWFQbGF5ZXJDbGllbnQgaGVyZSBzaG91 bGQgYmUgcHJpdmF0ZSBpbmhlcml0YW5jZS4KLS8vIEJ1dCBpdCBjYW4ndCBiZSB1bnRpbCB0aGUg Q2hyb21pdW0gV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsIGNsYXNzIGlzIGZpeGVkIHNvIGl0Ci0v LyBubyBsb25nZXIgZGVwZW5kcyBvbiB0eXBlY2FzdGluZyBhIE1lZGlhUGxheWVyQ2xpZW50IHRv IGFuIEhUTUxNZWRpYUVsZW1lbnQuCi0KLWNsYXNzIEhUTUxNZWRpYUVsZW1lbnQgOiBwdWJsaWMg SFRNTEVsZW1lbnQsIHB1YmxpYyBNZWRpYVBsYXllckNsaWVudCwgcHVibGljIE1lZGlhUGxheWVy U3VwcG9ydHNUeXBlQ2xpZW50LCBwcml2YXRlIE1lZGlhQ2FuU3RhcnRMaXN0ZW5lciwgcHVibGlj IEFjdGl2ZURPTU9iamVjdCwgcHVibGljIE1lZGlhQ29udHJvbGxlckludGVyZmFjZQorY2xhc3Mg SFRNTE1lZGlhRWxlbWVudCA6IHB1YmxpYyBIVE1MRWxlbWVudCwgcHJpdmF0ZSBNZWRpYVBsYXll ckNsaWVudCwgcHVibGljIE1lZGlhUGxheWVyU3VwcG9ydHNUeXBlQ2xpZW50LCBwcml2YXRlIE1l ZGlhQ2FuU3RhcnRMaXN0ZW5lciwgcHVibGljIEFjdGl2ZURPTU9iamVjdCwgcHVibGljIE1lZGlh Q29udHJvbGxlckludGVyZmFjZQogI2lmIEVOQUJMRShWSURFT19UUkFDSykKICAgICAsIHByaXZh dGUgQXVkaW9UcmFja0NsaWVudAogICAgICwgcHJpdmF0ZSBUZXh0VHJhY2tDbGllbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJp dmF0ZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxh eWVyUHJpdmF0ZVF0LmNwcAppbmRleCA3ZDlmZGNkZTg4ZGNmOTZiYzM2Y2I5NzNiODg1NjQxMDRh MmExMzBjLi41ZDA3OGIwYmFlMDViMTg4OGE2YmVjYzQ1NjY4NTIxMzk0MjlhY2MwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZh dGVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQ bGF5ZXJQcml2YXRlUXQuY3BwCkBAIC0xOTUsMTcgKzE5NSwxMiBAQCB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZVF0Ojpjb21taXRMb2FkKGNvbnN0IFN0cmluZyYgdXJsKQogICAgIGNvbnN0IFFVcmwg clVybCA9IGtVcmw7CiAgICAgY29uc3QgUVN0cmluZyBzY2hlbWUgPSByVXJsLnNjaGVtZSgpLnRv TG93ZXIoKTsKIAotICAgIC8vIEdyYWIgdGhlIGNsaWVudCBtZWRpYSBlbGVtZW50Ci0gICAgSFRN TE1lZGlhRWxlbWVudCogZWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxNZWRpYUVsZW1lbnQqPiht X3dlYkNvcmVQbGF5ZXItPm1lZGlhUGxheWVyQ2xpZW50KCkpOwotCiAgICAgLy8gQ29uc3RydWN0 IHRoZSBtZWRpYSBjb250ZW50IHdpdGggYSBuZXR3b3JrIHJlcXVlc3QgaWYgdGhlIHJlc291cmNl IGlzIGh0dHBbc10KICAgICBpZiAoc2NoZW1lID09IFFTdHJpbmc6OmZyb21MYXRpbjEoImh0dHAi KSB8fCBzY2hlbWUgPT0gUVN0cmluZzo6ZnJvbUxhdGluMSgiaHR0cHMiKSkgewogICAgICAgICBR TmV0d29ya1JlcXVlc3QgcmVxdWVzdCA9IFFOZXR3b3JrUmVxdWVzdChyVXJsKTsKIAogICAgICAg ICAvLyBHcmFiIHRoZSBjdXJyZW50IGRvY3VtZW50Ci0gICAgICAgIERvY3VtZW50KiBkb2N1bWVu dCA9IGVsZW1lbnQtPmRvY3VtZW50KCk7Ci0gICAgICAgIGlmICghZG9jdW1lbnQpCi0gICAgICAg ICAgICBkb2N1bWVudCA9IGVsZW1lbnQtPm93bmVyRG9jdW1lbnQoKTsKKyAgICAgICAgRG9jdW1l bnQqIGRvY3VtZW50ID0gbV93ZWJDb3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgpLT5tZWRp YVBsYXllck93bmluZ0RvY3VtZW50KCk7CiAKICAgICAgICAgLy8gR3JhYiB0aGUgZnJhbWUgYW5k IG5ldHdvcmsgbWFuYWdlcgogICAgICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudCA/IGRvY3Vt ZW50LT5mcmFtZSgpIDogMDsKQEAgLTI0MSwxNSArMjM2LDE1IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlUXQ6OmNvbW1pdExvYWQoY29uc3QgU3RyaW5nJiB1cmwpCiAgICAgLy8gV2UgZ2V0IHRo ZXNlIGZyb20gdGhlIGVsZW1lbnQsIHJhdGhlciB0aGFuIHRoZSBwbGF5ZXIsIGluIGNhc2Ugd2Ug aGF2ZQogICAgIC8vIHRyYW5zaXRpb25lZCBmcm9tIGEgbWVkaWEgZW5naW5lIHdoaWNoIGRvZXNu J3Qgc3VwcG9ydCBtdXRpbmcsIHRvIGEgbWVkaWEKICAgICAvLyBlbmdpbmUgd2hpY2ggZG9lcy4K LSAgICBtX21lZGlhUGxheWVyLT5zZXRNdXRlZChlbGVtZW50LT5tdXRlZCgpKTsKLSAgICBtX21l ZGlhUGxheWVyLT5zZXRWb2x1bWUoc3RhdGljX2Nhc3Q8aW50PihlbGVtZW50LT52b2x1bWUoKSAq IDEwMC4wKSk7CisgICAgbV9tZWRpYVBsYXllci0+c2V0TXV0ZWQobV93ZWJDb3JlUGxheWVyLT5t dXRlZCgpKTsKKyAgICBtX21lZGlhUGxheWVyLT5zZXRWb2x1bWUoc3RhdGljX2Nhc3Q8aW50Piht X3dlYkNvcmVQbGF5ZXItPnZvbHVtZSgpICogMTAwLjApKTsKIAogICAgIC8vIERvbid0IHNlbmQg UGxheWJhY2tDaGFuZ2VkIG5vdGlmaWNhdGlvbiBmb3IgcHJlLXJvbGwuCiAgICAgbV9zdXBwcmVz c05leHRQbGF5YmFja0NoYW5nZWQgPSB0cnVlOwogCiAgICAgLy8gU2V0dGluZyBhIG1lZGlhIHNv dXJjZSB3aWxsIHN0YXJ0IGxvYWRpbmcgdGhlIG1lZGlhLCBidXQgd2UgbmVlZAogICAgIC8vIHRv IHByZS1yb2xsIGFzIHdlbGwgdG8gZ2V0IHZpZGVvIHNpemUtaGludHMgYW5kIGJ1ZmZlci1zdGF0 dXMKLSAgICBpZiAoZWxlbWVudC0+cGF1c2VkKCkpCisgICAgaWYgKG1fd2ViQ29yZVBsYXllci0+ cGF1c2VkKCkpCiAgICAgICAgIG1fbWVkaWFQbGF5ZXItPnBhdXNlKCk7CiAgICAgZWxzZQogICAg ICAgICBtX21lZGlhUGxheWVyLT5wbGF5KCk7Cg==