117860 2013-06-20 19:54:32 -0700 REGRESSION(r145788): mouse drag on canvas shouldn't start selection 2016-11-02 14:50:46 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 112319 1 rniwa rniwa benjamin commit-queue darin dino enrica esprehn+autocc sam senorblanco webkit-bug-importer oldest_to_newest 902403 0 rniwa 2013-06-20 19:54:32 -0700 Example URL: http://www.ivank.net/veci/click_test.html Steps to reproduce the problem: 1. Open the URL 2. Press mouse on the left half of canvas 3. Drag to the right half and release the mouse. 4. Keep pressing, dragging and releasing mouse on the right half on canvas. What is the expected behavior? Canvas should support mouse events. If you look into console, it should always print (down, dragging*, up)* // pseudo regular expression What went wrong? Instead, after dragging over the middle of canvas, it gets selected and "mouseup" event does not work, it prints only (down, dragging*)* 902404 1 webkit-bug-importer 2013-06-20 19:55:17 -0700 <rdar://problem/14225079> 902411 2 205143 rniwa 2013-06-20 20:30:02 -0700 Created attachment 205143 Fixes the bug 902412 3 205143 rniwa 2013-06-20 20:30:48 -0700 Comment on attachment 205143 Fixes the bug I don't know what Chromium/Blink is doing to make mouse up not fire. That problem doesn't exist in WebKit. However, we should still not select the canvas element. 902416 4 205143 benjamin 2013-06-20 20:47:41 -0700 Comment on attachment 205143 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=205143&action=review > LayoutTests/fast/events/mosuedrag-on-canvas-should-not-start-selection.html:11 > +description("This tests initiating a mouse drag on a canvas element doesn't start selection." > + + "To manually test, drag mouse on the canvas below. WebKit shouldn't select the canvas.") Missing space between the sentences (or remove the +) 902420 5 rniwa 2013-06-20 20:53:04 -0700 Committed r151822: <http://trac.webkit.org/changeset/151822> 205143 2013-06-20 20:30:02 -0700 2016-11-02 14:50:46 -0700 Fixes the bug bug-117860-20130620202812.patch text/plain 5896 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTgyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA2LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0NTc4OCk6 IG1vdXNlIGRyYWcgb24gY2FudmFzIHNob3VsZG4ndCBzdGFydCBzZWxlY3Rpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzg2MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExpa2UgSFRNTEltYWdlRWxl bWVudCwgSFRNTENhbnZhc0VsZW1lbnQgc2hvdWxkbid0IHN0YXJ0IHNlbGVjdGlvbi4KKworICAg ICAgICBBbHNvIHVuaW5saW5lIHNvbWUgdmlydHVhbCBmdW5jdGlvbiBvdmVycmlkZXMuCisKKyAg ICAgICAgVGVzdDogZmFzdC9ldmVudHMvbW9zdWVkcmFnLW9uLWNhbnZhcy1zaG91bGQtbm90LXN0 YXJ0LXNlbGVjdGlvbi5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjphcmVBdXRob3JTaGFkb3dz QWxsb3dlZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Y2FuQ29udGFp blJhbmdlRW5kUG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OmNh blN0YXJ0U2VsZWN0aW9uKToKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50Lmg6CisK IDIwMTMtMDYtMjAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNjQ5NQpJbmRleDog U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAJKHJldmlzaW9uIDE1MTgx NikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMjcsNiArMTI3LDIxIEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmF0dGFj aChjb25zdCBBdHQKICAgICBIVE1MRWxlbWVudDo6YXR0YWNoKGNvbnRleHQpOwogfQogCitib29s IEhUTUxDYW52YXNFbGVtZW50OjphcmVBdXRob3JTaGFkb3dzQWxsb3dlZCgpIGNvbnN0Cit7Cisg ICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIEhUTUxDYW52YXNFbGVtZW50OjpjYW5Db250YWlu UmFuZ2VFbmRQb2ludCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIEhU TUxDYW52YXNFbGVtZW50OjpjYW5TdGFydFNlbGVjdGlvbigpIGNvbnN0Cit7CisgICAgcmV0dXJu IGZhbHNlOworfQorCiB2b2lkIEhUTUxDYW52YXNFbGVtZW50OjphZGRPYnNlcnZlcihDYW52YXNP YnNlcnZlciogb2JzZXJ2ZXIpCiB7CiAgICAgbV9vYnNlcnZlcnMuYWRkKG9ic2VydmVyKTsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgJKHJldmlzaW9uIDE1MTgx NikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaAkod29ya2luZyBj b3B5KQpAQCAtMTQyLDE1ICsxNDIsMTYgQEAgcHVibGljOgogCiAgICAgZmxvYXQgZGV2aWNlU2Nh bGVGYWN0b3IoKSBjb25zdCB7IHJldHVybiBtX2RldmljZVNjYWxlRmFjdG9yOyB9CiAKLSAgICB2 aXJ0dWFsIGJvb2wgY2FuQ29udGFpblJhbmdlRW5kUG9pbnQoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQotCiBwcml2YXRlOgogICAgIEhUTUxDYW52YXNFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5h bWUmLCBEb2N1bWVudCopOwogCiAgICAgdmlydHVhbCB2b2lkIHBhcnNlQXR0cmlidXRlKGNvbnN0 IFF1YWxpZmllZE5hbWUmLCBjb25zdCBBdG9taWNTdHJpbmcmKSBPVkVSUklERTsKICAgICB2aXJ0 dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqLCBSZW5kZXJTdHls ZSopOwogICAgIHZpcnR1YWwgdm9pZCBhdHRhY2goY29uc3QgQXR0YWNoQ29udGV4dCYgPSBBdHRh Y2hDb250ZXh0KCkpIE9WRVJSSURFOwotICAgIHZpcnR1YWwgYm9vbCBhcmVBdXRob3JTaGFkb3dz QWxsb3dlZCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIGZhbHNlOyB9CisgICAgdmlydHVhbCBi b29sIGFyZUF1dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3QgT1ZFUlJJREU7CisKKyAgICB2aXJ0 dWFsIGJvb2wgY2FuQ29udGFpblJhbmdlRW5kUG9pbnQoKSBjb25zdCBPVkVSUklERTsKKyAgICB2 aXJ0dWFsIGJvb2wgY2FuU3RhcnRTZWxlY3Rpb24oKSBjb25zdCBPVkVSUklERTsKIAogICAgIHZv aWQgcmVzZXQoKTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxODIwKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDYtMjAgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTQ1 Nzg4KTogbW91c2UgZHJhZyBvbiBjYW52YXMgc2hvdWxkbid0IHN0YXJ0IHNlbGVjdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3ODYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVz c2lvbiB0ZXN0IGZvciBkcmFnZ2luZyBtb3VzZSBpbnNpZGUgYSBjYW52YXMuCisgICAgICAgIFRo ZSBjYW52YXMgc2hvdWxkIG5vdCBiZSBzZWxlY3RlZCBhbmQgbW91c2V1cCBldmVudCBzaG91bGQg ZmlyZS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL21vc3VlZHJhZy1vbi1jYW52YXMtc2hvdWxk LW5vdC1zdGFydC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2V2ZW50cy9tb3N1ZWRyYWctb24tY2FudmFzLXNob3VsZC1ub3Qtc3RhcnQtc2VsZWN0aW9uLmh0 bWw6IEFkZGVkLgorCiAyMDEzLTA2LTIwICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbQ01BS0VdW0VGTF0gRW5hYmxlIERPTTQgRXZlbnRzIENvbnN0cnVj dG9yCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tb3N1ZWRyYWctb24tY2FudmFzLXNo b3VsZC1ub3Qtc3RhcnQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9tb3N1ZWRyYWctb24tY2FudmFzLXNob3VsZC1ub3Qtc3RhcnQt c2VsZWN0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL21vc3VlZHJhZy1vbi1jYW52YXMtc2hvdWxkLW5vdC1zdGFydC1zZWxlY3Rpb24tZXhw ZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKK1RoaXMgdGVzdHMgaW5p dGlhdGluZyBhIG1vdXNlIGRyYWcgb24gYSBjYW52YXMgZWxlbWVudCBkb2Vzbid0IHN0YXJ0IHNl bGVjdGlvbi5UbyBtYW51YWxseSB0ZXN0LCBkcmFnIG1vdXNlIG9uIHRoZSBjYW52YXMgYmVsb3cu IFdlYktpdCBzaG91bGRuJ3Qgc2VsZWN0IHRoZSBjYW52YXMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KKworCitnZXRTZWxlY3Rpb24oKS5yZW1vdmVBbGxSYW5nZXMoKTsgbW91c2VEb3du ID0gZmFsc2U7IG1vdXNlVXAgPSBmYWxzZQorUEFTUyBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhj YW52YXMub2Zmc2V0TGVmdCArIDEwLCBjYW52YXMub2Zmc2V0VG9wICsgMTApOyBldmVudFNlbmRl ci5tb3VzZURvd24oKTsgbW91c2VEb3duIGlzIHRydWUKK1BBU1MgZXZlbnRTZW5kZXIubW91c2VN b3ZlVG8oY2FudmFzLm9mZnNldExlZnQgKyAxMDAsIGNhbnZhcy5vZmZzZXRUb3AgKyAxMDApOyBl dmVudFNlbmRlci5tb3VzZVVwKCk7IG1vdXNlVXAgaXMgdHJ1ZQorUEFTUyBnZXRTZWxlY3Rpb24o KS5pc0NvbGxhcHNlZCBpcyB0cnVlCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21v c3VlZHJhZy1vbi1jYW52YXMtc2hvdWxkLW5vdC1zdGFydC1zZWxlY3Rpb24uaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tb3N1ZWRyYWctb24tY2FudmFzLXNob3Vs ZC1ub3Qtc3RhcnQtc2VsZWN0aW9uLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9tb3N1ZWRyYWctb24tY2FudmFzLXNob3VsZC1ub3Qtc3RhcnQtc2VsZWN0aW9u Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPGRpdiBpZD0iZWRpdG9yIiBjb250ZW50ZWRpdGFibGU+Cis8Y2FudmFz IHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgYmxhY2si IG9ubW91c2Vkb3duPSJtb3VzZURvd249dHJ1ZTsiIG9ubW91c2V1cD0ibW91c2VVcD10cnVlOyI+ PC9jYW52YXM+Cis8L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1w cmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgaW5p dGlhdGluZyBhIG1vdXNlIGRyYWcgb24gYSBjYW52YXMgZWxlbWVudCBkb2Vzbid0IHN0YXJ0IHNl bGVjdGlvbi4iCisgICAgKyAiVG8gbWFudWFsbHkgdGVzdCwgZHJhZyBtb3VzZSBvbiB0aGUgY2Fu dmFzIGJlbG93LiBXZWJLaXQgc2hvdWxkbid0IHNlbGVjdCB0aGUgY2FudmFzLiIpCisKK2lmICh3 aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQucXVlcnlTZWxl Y3RvcignY2FudmFzJyk7CisKKyAgICBldmFsQW5kTG9nKCdnZXRTZWxlY3Rpb24oKS5yZW1vdmVB bGxSYW5nZXMoKTsgbW91c2VEb3duID0gZmFsc2U7IG1vdXNlVXAgPSBmYWxzZScpOworICAgIHNo b3VsZEJlVHJ1ZSgiZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oY2FudmFzLm9mZnNldExlZnQgKyAx MCwgY2FudmFzLm9mZnNldFRvcCArIDEwKTsgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7IG1vdXNl RG93biIpOworICAgIGV2ZW50U2VuZGVyLmxlYXBGb3J3YXJkKDIwMCk7CisgICAgc2hvdWxkQmVU cnVlKCJldmVudFNlbmRlci5tb3VzZU1vdmVUbyhjYW52YXMub2Zmc2V0TGVmdCArIDEwMCwgY2Fu dmFzLm9mZnNldFRvcCArIDEwMCk7IGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsgbW91c2VVcCIpOwor ICAgIHNob3VsZEJlVHJ1ZSgiZ2V0U2VsZWN0aW9uKCkuaXNDb2xsYXBzZWQiKTsKK30KKworPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==