117858 2013-06-20 18:25:36 -0700 [CMAKE][EFL] Enable DOM4 Events Constructor 2013-06-20 19:27:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue dbates gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 902383 0 ryuan.choi 2013-06-20 18:25:36 -0700 Patch will be added. 902385 1 205135 ryuan.choi 2013-06-20 18:54:52 -0700 Created attachment 205135 Patch 902388 2 205135 laszlo.gombos 2013-06-20 19:12:51 -0700 Comment on attachment 205135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205135&action=review r=me. > Source/cmake/WebKitFeatures.cmake:50 > + WEBKIT_OPTION_DEFINE(ENABLE_DOM4_EVENTS_CONSTRUCTOR "Expose DOM4 Events constructors" OFF) Nit: "Toggle DOM4 Events constructor" to be consistent. 902395 3 ryuan.choi 2013-06-20 19:27:22 -0700 Committed r151815: <http://trac.webkit.org/changeset/151815> 902396 4 205135 ryuan.choi 2013-06-20 19:27:58 -0700 Comment on attachment 205135 Patch Thank you. I landed manually after fixed like you suggested. 205135 2013-06-20 18:54:52 -0700 2013-06-20 19:27:58 -0700 Patch bug-117858-20130621105301.patch text/plain 6412 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDBjNzFm MGJkOGMwZWVjOTg4N2IzOTgzNTVkNmViZTVhZGUzMDRlZmIuLjVhZGI1NDk5Mjg5MDJkY2YyNjQw NjYzZWY0YzMyZDVhODY5NjcxZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC02NSw2ICs2NSw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfU1RJQ0tZX1BP U0lUSU9OIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19W QVJJQUJMRVMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1VT VE9NX1NDSEVNRV9IQU5ETEVSIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo RU5BQkxFX0RBVEFMSVNUX0VMRU1FTlQgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfRE9NNF9FVkVOVFNfQ09OU1RSVUNUT1IgT04pCiBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRE9XTkxPQURfQVRUUklCVVRFIE9OKQogV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RSQUdfU1VQUE9SVCBPTikKIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkcgT04p CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2Uv Y21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5kZXggNDQ3NjZlYTZiMTcwMTQ5YTFhNzMzNTkw MGVjZDA3ZTgyOGY4MTRhZi4uOWFlOTlkNzUyNTM3YzM3NGFkYzU5OWQ5NTcxMTdlMTY0Nzk2NzZl NyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQpAQCAtNDcsNiArNDcsNyBAQCBtYWNybyhX RUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9ERVZJ Q0VfT1JJRU5UQVRJT04gIlRvZ2dsZSBEZXZpY2VPcmllbnRhdGlvbiBzdXBwb3J0IiBPRkYpCiAg ICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RJQUxPR19FTEVNRU5UICJUb2dnbGUgRGlh bG9nIEVsZW1lbnQgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJM RV9ESVJFQ1RPUllfVVBMT0FEICJUb2dnbGUgRGlyZWN0b3J5IHVwbG9hZCBzdXBwb3J0IiBPRkYp CisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RPTTRfRVZFTlRTX0NPTlNUUlVDVE9S ICJFeHBvc2UgRE9NNCBFdmVudHMgY29uc3RydWN0b3JzIiBPRkYpCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX0RPV05MT0FEX0FUVFJJQlVURSAiVG9nZ2xlIGRvd25sb2FkIGF0dHJp YnV0ZSBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RSQUdf U1VQUE9SVCAiVG9nZ2xlIERyYWcgU3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVG SU5FKEVOQUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkcgIlRvZ2dsZSBGYXN0IE1vYmlsZSBTY3Jv bGxpbmcgc3VwcG9ydCIgT0ZGKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21h a2UgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCBhNzc1OTBhMGE2ZDVkOGI5NjQ5 ZjcyNDdjMzYxZmU2YzBlYWY3YmQ1Li5iOWQwNmNlNjc2OWYzYWQ3ODMyYWU1MGM4ZTRkMjBjMGRi YWE0ODMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3Vy Y2UvY21ha2Vjb25maWcuaC5jbWFrZQpAQCAtMzgsNiArMzgsNyBAQAogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0RFVEFJTFNfRUxFTUVOVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0RFVklDRV9PUklF TlRBVElPTgogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0RJQUxPR19FTEVNRU5UCisjY21ha2VkZWZp bmUwMSBFTkFCTEVfRE9NNF9FVkVOVFNfQ09OU1RSVUNUT1IKICNjbWFrZWRlZmluZTAxIEVOQUJM RV9ET1dOTE9BRF9BVFRSSUJVVEUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9EUkFHX1NVUFBPUlQK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9FVkVOVF9NT0RFX01FVEFUQUdTCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODYzM2Y1M2NiOWY0ZGFmOWE3 YmY3YTcwMTc1ZTcxMDNjY2Y5ZjYzMC4uN2JiMzUxMzczODJmMGFhODMyZDk3NmNmNmYyMDczOGZm ZjgwN2FhZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA2LTIwICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBz YW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdW0VGTF0gRW5hYmxlIERPTTQgRXZlbnRzIENv bnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc4NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbTogRW5hYmxlIHRoZSBmZWF0dXJl IGZvciB0aGUgRUZMIHBvcnQuCisKIDIwMTMtMDYtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBIYW5kbGUgdGVzdFJ1 bm5lci5zZXRXaWxsU2VuZFJlcXVlc3RSZXR1cm5zTnVsbCgpIGluIERSVApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IGZhODY0NDA0YmEyNjY1ODBmOTZlYTlmYzAz Y2I1MDk2ODFkMWNlMDkuLjBlMzkxMDJlZDk1ZTkxZWM3YjEyMzQ5OTRjY2QxN2JlMGU1YTBjNTEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTI1NSw3ICsyNTUs NyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9ESVJFQ1RPUllf VVBMT0FEIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJGRpcmVjdG9yeVVwbG9hZFN1cHBvcnQg fSwKIAogICAgIHsgb3B0aW9uID0+ICJkb200LWV2ZW50cy1jb25zdHJ1Y3RvciIsIGRlc2MgPT4g IkV4cG9zZSBET000IEV2ZW50cyBjb25zdHJ1Y3RvcnMiLAotICAgICAgZGVmaW5lID0+ICJFTkFC TEVfRE9NNF9FVkVOVFNfQ09OU1RSVUNUT1IiLCBkZWZhdWx0ID0+IChpc0FwcGxlV2ViS2l0KCkg fHwgaXNHdGsoKSksIHZhbHVlID0+IFwkZG9tNEV2ZW50c0NvbnN0cnVjdG9yIH0sCisgICAgICBk ZWZpbmUgPT4gIkVOQUJMRV9ET000X0VWRU5UU19DT05TVFJVQ1RPUiIsIGRlZmF1bHQgPT4gKGlz QXBwbGVXZWJLaXQoKSB8fCBpc0d0aygpIHx8IGlzRWZsKCkpLCB2YWx1ZSA9PiBcJGRvbTRFdmVu dHNDb25zdHJ1Y3RvciB9LAogCiAgICAgeyBvcHRpb24gPT4gImRvd25sb2FkLWF0dHJpYnV0ZSIs IGRlc2MgPT4gIlRvZ2dsZSBEb3dubG9hZCBBdHRyaWJ1dGUgc3VwcG9ydCIsCiAgICAgICBkZWZp bmUgPT4gIkVOQUJMRV9ET1dOTE9BRF9BVFRSSUJVVEUiLCBkZWZhdWx0ID0+IChpc0JsYWNrQmVy cnkoKSB8fCBpc0VmbCgpKSwgdmFsdWUgPT4gXCRkb3dubG9hZEF0dHJpYnV0ZVN1cHBvcnQgfSwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzY2E3MWY2YWZlMTE4YTI3ZjdhYmI0MmU5ZjYyYmQyYzMwNGJhNDU4Li5kMzY4ZThh ZWY2YmM1M2Q5MDUzMzhhMzBlMzc1ZjQxZTM2MDRjNmQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTMtMDYtMjAgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFtDTUFLRV1bRUZMXSBFbmFibGUgRE9NNCBFdmVudHMgQ29uc3RydWN0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzg1OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rl c3RFeHBlY3RhdGlvbnM6IFVuc2tpcCB0aGUgcmVsYXRlZCB0ZXN0cy4KKwogMjAxMy0wNi0yMCAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NDk1CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDUyODI5Y2IxMTNkNGZiMmE0YTgzZTM2Njc4OWM1 N2I5OWQ1OGQ1OWYuLjgyODY3YzU3NzRmMjg0YzMzYjE1ZTNhOTEyYzM4NzFlZWM5NjY0YWQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMTY0LDE0ICsx MTY0LDYgQEAgd2Via2l0Lm9yZy9iLzg3NjYyIGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9tZWRp YS1zdHJlYW0tZXZlbnQtY29uc3RydWN0b3IuaHRtbAogd2Via2l0Lm9yZy9iLzk1MzAyIGZhc3Qv c3BlZWNoIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvOTUzMDIgZmFzdC9ldmVudHMvY29uc3RydWN0 b3JzL3NwZWVjaC1yZWNvZ25pdGlvbi1ldmVudC1jb25zdHJ1Y3Rvci5odG1sIFsgU2tpcCBdCiAK LSMgRE9NNF9FVkVOVFNfQ09OU1RSVUNUT1IgaXMgbm90IHlldCBlbmFibGVkLgotd2Via2l0Lm9y Zy9iLzEwNzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvdWktZXZlbnQtY29uc3RydWN0b3Iu aHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzEwNzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1Y3Rv cnMvbW91c2UtZXZlbnQtY29uc3RydWN0b3IuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzEw NzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvd2hlZWwtZXZlbnQtY29uc3RydWN0b3IuaHRt bCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzEwNzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMv a2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0b3IuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzEw NzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY29tcG9zaXRpb24tZXZlbnQtY29uc3RydWN0 b3IuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzEwNzQyOCBmYXN0L2V2ZW50cy9jb25zdHJ1 Y3RvcnMvZm9jdXMtZXZlbnQtY29uc3RydWN0b3IuaHRtbCBbIFNraXAgXQotCiAjIFJlcXVpcmVz IHN1cHBvcnQgZm9yIFdlYiBub3RpZmljYXRpb25zCiB3ZWJraXQub3JnL2IvNzM1NDQgZmFzdC9u b3RpZmljYXRpb25zIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvNzM1NDQgaHR0cC90ZXN0cy9ub3Rp ZmljYXRpb25zIFsgU2tpcCBdCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggNDk5NzY1YTI5ZmYwYjVlNDQ1MjZkOGI5ODFhM2I1MWJlMzE1ZDMwZC4uNTNkNGM2NjU1Mzc5 NmJjZGQ0OWMzYzhkNjA5ZWQ1ZTMyMWI5ZWE5YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTIwICBSeXVhbiBDaG9pICA8cnl1 YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdW0VGTF0gRW5hYmxlIERPTTQg RXZlbnRzIENvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTc4NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOiBFbmFibGVkIEVOQUJM RV9ET000X0VWRU5UU19DT05TVFJVQ1RPUi4KKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0 RmVhdHVyZXMuY21ha2U6IEFkZGVkIEVOQUJMRV9ET000X0VWRU5UU19DT05TVFJVQ1RPUi4KKyAg ICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZTogRGl0dG8uCisKIDIwMTMtMDYtMjAg IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIHJl bW92ZSBiYXNoaXNtIGZyb20gY29uZmlndXJlCg==