117828 2013-06-20 05:35:04 -0700 [EFL][WK2] Update text checker documentation 2013-06-20 07:32:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117794 1 g.czajkowski g.czajkowski cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco ryuan.choi oldest_to_newest 902098 0 g.czajkowski 2013-06-20 05:35:04 -0700 eina_list_free() needs to be to called to free an entire spelling suggestions list. The data contained in the list are already freed. 902110 1 205079 g.czajkowski 2013-06-20 06:01:43 -0700 Created attachment 205079 proposed patch 902121 2 205079 cdumez 2013-06-20 06:27:28 -0700 Comment on attachment 205079 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304 > + eina_list_free(loadedLanguages); I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc? 902131 3 ryuan.choi 2013-06-20 06:47:35 -0700 (In reply to comment #2) > (From update of attachment 205079 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304 > > + eina_list_free(loadedLanguages); > > I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc? +1. EINA_LIST_FREE = eina_list_free() + chance to release data. http://docs.enlightenment.org/stable/eina/group__Eina__List__Group.html#ga608bd2fbf06293a1b794648990703ab4 902141 4 205087 g.czajkowski 2013-06-20 06:57:56 -0700 Created attachment 205087 just update the doc 902145 5 205087 cdumez 2013-06-20 07:03:49 -0700 Comment on attachment 205087 just update the doc View in context: https://bugs.webkit.org/attachment.cgi?id=205087&action=review LGTM. r=me. with nit. > Source/WebKit2/UIProcess/API/efl/ewk_text_checker.h:100 > + * a list and its items will be freed by WebKit. *the* list and its items... 902146 6 g.czajkowski 2013-06-20 07:12:17 -0700 Committed r151775: <http://trac.webkit.org/changeset/151775> 205079 2013-06-20 06:01:43 -0700 2013-06-20 06:57:56 -0700 proposed patch spelling-suggestions-need-to-freed.patch text/plain 5094 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZmU3YzQzLi42NzVmMGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDYtMjAgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBUZXh0Q2hlY2tlckNsaWVudEVmbCBkb2Vzbid0 IGZyZWUgRWluYV9MaXN0IHRoYXQgc3RvcmUgY2xpZW50IHNwZWxsaW5nIHN1Z2dlc3Rpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzgyOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5oOgorICAgICAgICBVcGRhdGUgdGhlIGRvY3VtZW50 YXRpb24sIHRoZSBjbGllbnQgaXMgbm90IHJlc3BvbnNpYmxlIGZvciBkZXN0cm95aW5nIHRoZSBt ZW1vcnkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1RleHRDaGVja2VyQ2xpZW50RWZsLmNw cDoKKyAgICAgICAgKFRleHRDaGVja2VyQ2xpZW50RWZsOjpndWVzc2VzRm9yV29yZENhbGxiYWNr KToKKyAgICAgICAgQ2FsbCBlaW5hX2xpc3RfZnJlZSgpIHRvIGZyZWUgYW4gZW50aXJlIGxpc3Qu CisgICAgICAgIFRoZSBkYXRhIGNvbnRhaW5lZCBpbiB0aGUgbGlzdCBhcmUgYWxyZWFkeSBmcmVl ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl90ZXh0X2No ZWNrZXIuY3BwOgorICAgICAgICBVbml0IFRlc3RzIGhhdmUgdGhlIHNhbWUgaXNzdWUuIFRleHQg Y2hlY2tlciBsYW5ndWFnZXMgbmVlZCB0byBiZSBwcm9wZXJseSBmcmVlZAorICAgICAgICBvbiB0 aGUgY2xpZW50IHNpZGUuCisKIDIwMTMtMDYtMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBFeHBvc2UgcGx1Zy1pbnMgQ0ZCdW5kbGVTaG9ydFZlcnNpb25TdHJpbmcg aW4gdGhlIFdLUGx1Z2luSW5mb3JtYXRpb24gZGljdGlvbmFyeQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5oCmluZGV4IDA0YjdkMGQu LjA3ZjA0MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a190ZXh0X2NoZWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdGV4dF9jaGVja2VyLmgKQEAgLTk2LDggKzk2LDggQEAgdHlwZWRlZiB2b2lkICgqRXdrX1Rl eHRfQ2hlY2tlcl9TdHJpbmdfU3BlbGxpbmdfQ2hlY2tfQ2IpKHVpbnQ2NF90IHRhZywgY29uc3Qg Y2gKICAqIEBwYXJhbSB0YWcgdW5pcXVlIHRhZyB0byBub3RpZnkgdGhlIHNwZWxsIGNoZWNrZXIg d2hpY2ggZG9jdW1lbnQgdGhhdCBAYSB0ZXh0IGlzIGFzc29jaWF0ZWQsCiAgKiAgICAgICAgQGMg MCBjYW4gYmUgcGFzc2VkIGZvciB0ZXh0IG5vdCBhc3NvY2lhdGVkIHdpdGggYSBwYXJ0aWN1bGFy IGRvY3VtZW50CiAgKiBAcGFyYW0gd29yZCB0aGUgd29yZCB0byBnZXQgZ3Vlc3NlcwotICogQHJl dHVybiBhIGxpc3Qgb2YgZHluYW1pY2FsbHkgYWxsb2NhdGVkIHN0cmluZ3MgKGFzIGNoYXIqKSBh bmQKLSAqICAgICAgICAgY2FsbGVyIGlzIHJlc3BvbnNpYmxlIGZvciBkZXN0cm95aW5nIHRoZW0u CisgKiBAcmV0dXJuIGEgbGlzdCBvZiBkeW5hbWljYWxseSBhbGxvY2F0ZWQgc3RyaW5ncyAoYXMg Y2hhciopLAorICogICAgICAgICBhIGxpc3QgYW5kIGl0cyBpdGVtcyB3aWxsIGJlIGZyZWVkIGJ5 IFdlYktpdC4KICAqLwogdHlwZWRlZiBFaW5hX0xpc3QgKigqRXdrX1RleHRfQ2hlY2tlcl9Xb3Jk X0d1ZXNzZXNfR2V0X0NiKSh1aW50NjRfdCB0YWcsIGNvbnN0IGNoYXIgKndvcmQpOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJf dGV4dF9jaGVja2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz L3Rlc3RfZXdrMl90ZXh0X2NoZWNrZXIuY3BwCmluZGV4IDZiNDMxZmQuLmJlMWQ1YWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl90 ZXh0X2NoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rl c3RzL3Rlc3RfZXdrMl90ZXh0X2NoZWNrZXIuY3BwCkBAIC0zMDEsNiArMzAxLDggQEAgVEVTVF9G KEVXSzJVbml0VGVzdEJhc2UsIGV3a190ZXh0X2NoZWNrZXJfc3BlbGxfY2hlY2tpbmdfbGFuZ3Vh Z2VzX2dldCkKICAgICBFSU5BX0xJU1RfRlJFRShsb2FkZWRMYW5ndWFnZXMsIGRhdGEpCiAgICAg ICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN0YXRpY19jYXN0PEVpbmFfU3RyaW5nc2hhcmUqPihk YXRhKSk7CiAKKyAgICBlaW5hX2xpc3RfZnJlZShsb2FkZWRMYW5ndWFnZXMpOworCiAgICAgLy8g UmVwZWF0IHRoZSBjaGVja2luZyB3aGVuIGNvbnRpbnVvdXMgc3BlbGwgY2hlY2tpbmcgc2V0dGlu ZyBpcyBvbi4KICAgICBld2tfdGV4dF9jaGVja2VyX2NvbnRpbnVvdXNfc3BlbGxfY2hlY2tpbmdf ZW5hYmxlZF9zZXQodHJ1ZSk7CiAgICAgdGltZW91dFRpbWVyID0gZWNvcmVfdGltZXJfYWRkKGRl ZmF1bHRUaW1lb3V0SW5TZWNvbmRzLCBvblRpbWVvdXQsIDApOwpAQCAtMzE0LDYgKzMxNiw4IEBA IFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdGV4dF9jaGVja2VyX3NwZWxsX2NoZWNraW5n X2xhbmd1YWdlc19nZXQpCiAKICAgICBFSU5BX0xJU1RfRlJFRShsb2FkZWRMYW5ndWFnZXMsIGRh dGEpCiAgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN0YXRpY19jYXN0PEVpbmFfU3RyaW5n c2hhcmUqPihkYXRhKSk7CisKKyAgICBlaW5hX2xpc3RfZnJlZShsb2FkZWRMYW5ndWFnZXMpOwog fQogCiAvKioKQEAgLTQ2NCw4ICs0NjgsMTIgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3 a190ZXh0X2NoZWNrZXJfc3BlbGxfY2hlY2tpbmdfYXZhaWxhYmxlX2xhbmd1YWdlc19nZXQKICAg ICBFSU5BX0xJU1RfRlJFRShhdmFpbGFibGVMYW5ndWFnZXMsIGFjdHVhbCkKICAgICAgICAgZWlu YV9zdHJpbmdzaGFyZV9kZWwoc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KGFjdHVhbCkpOwogCisg ICAgZWluYV9saXN0X2ZyZWUoYXZhaWxhYmxlTGFuZ3VhZ2VzKTsKKwogICAgIEVJTkFfTElTVF9G UkVFKGxvYWRlZExhbmd1YWdlcywgYWN0dWFsKQogICAgICAgICBlaW5hX3N0cmluZ3NoYXJlX2Rl bChzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oYWN0dWFsKSk7CisKKyAgICBlaW5hX2xpc3RfZnJl ZShsb2FkZWRMYW5ndWFnZXMpOwogfQogCiAvKioKQEAgLTQ5NCw2ICs1MDIsOCBAQCBURVNUX0Yo RVdLMlVuaXRUZXN0QmFzZSwgZXdrX3RleHRfY2hlY2tlcl9zcGVsbF9jaGVja2luZ19sYW5ndWFn ZXMpCiAgICAgRUlOQV9MSVNUX0ZSRUUobG9hZGVkTGFuZ3VhZ2VzLCBhY3R1YWwpCiAgICAgICAg IGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihhY3R1YWwpKTsK IAorICAgIGVpbmFfbGlzdF9mcmVlKGxvYWRlZExhbmd1YWdlcyk7CisKICAgICAvLyBHZXQgdGhl IGZpcnN0IGFuZCBsYXN0IGxhbmd1YWdlIGZyb20gaW5zdGFsbGVkIGRpY3Rpb25hcmllcy4KICAg ICBFaW5hX0xpc3QqIGF2YWlsYWJsZUxhbmd1YWdlcyA9IGV3a190ZXh0X2NoZWNrZXJfc3BlbGxf Y2hlY2tpbmdfYXZhaWxhYmxlX2xhbmd1YWdlc19nZXQoKTsKICAgICB1bnNpZ25lZCBudW1iZXJP ZkF2YWlsYWJsZUxhbmd1YWdlcyA9IGVpbmFfbGlzdF9jb3VudChhdmFpbGFibGVMYW5ndWFnZXMp OwpAQCAtNTI3LDggKzUzNywxMiBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3RleHRf Y2hlY2tlcl9zcGVsbF9jaGVja2luZ19sYW5ndWFnZXMpCiAgICAgRUlOQV9MSVNUX0ZSRUUoYXZh aWxhYmxlTGFuZ3VhZ2VzLCBhY3R1YWwpCiAgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKHN0 YXRpY19jYXN0PGNvbnN0IGNoYXIqPihhY3R1YWwpKTsKIAorICAgIGVpbmFfbGlzdF9mcmVlKGF2 YWlsYWJsZUxhbmd1YWdlcyk7CisKICAgICBFSU5BX0xJU1RfRlJFRShsb2FkZWRMYW5ndWFnZXMs IGFjdHVhbCkKICAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoc3RhdGljX2Nhc3Q8Y29uc3Qg Y2hhcio+KGFjdHVhbCkpOworCisgICAgZWluYV9saXN0X2ZyZWUobG9hZGVkTGFuZ3VhZ2VzKTsK IH0KIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1RleHRD aGVja2VyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVGV4dENo ZWNrZXJDbGllbnRFZmwuY3BwCmluZGV4IDUzYzIyMGUuLmExNTI0ZDIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVGV4dENoZWNrZXJDbGllbnRFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVGV4dENoZWNrZXJDbGllbnRFZmwuY3BwCkBA IC0xNzksNiArMTc5LDcgQEAgV0tBcnJheVJlZiBUZXh0Q2hlY2tlckNsaWVudEVmbDo6Z3Vlc3Nl c0ZvcldvcmRDYWxsYmFjayh1aW50NjRfdCB0YWcsIFdLU3RyaW5nUmUKICAgICAgICAgICAgIFdL QXJyYXlBcHBlbmRJdGVtKHN1Z2dlc3Rpb25zRm9yV29yZCwgc3VnZ2VzdGlvbi5nZXQoKSk7CiAg ICAgICAgICAgICBmcmVlKGl0ZW0pOwogICAgICAgICB9CisgICAgICAgIGVpbmFfbGlzdF9mcmVl KGxpc3QpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBndWVz c2VzID0gdGV4dENoZWNrZXJDbGllbnQtPm1fdGV4dENoZWNrZXJFbmNoYW50LT5nZXRHdWVzc2Vz Rm9yV29yZCh0b1dURlN0cmluZyh3b3JkKSk7CiAgICAgICAgIHNpemVfdCBudW1iZXJPZkd1ZXNz ZXMgPSBndWVzc2VzLnNpemUoKTsK 205087 2013-06-20 06:57:56 -0700 2013-06-20 07:32:49 -0700 just update the doc spelling_update_doc.patch text/plain 1566 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZmU3YzQzLi41YmNhMjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDYtMjAgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBVcGRhdGUgdGV4dCBjaGVja2VyIGRvY3VtZW50 YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTc4MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNrZXIuaDoKKyAgICAgICAgVGhlIGNsaWVu dCBpcyBub3QgcmVzcG9uc2libGUgZm9yIGRlc3Ryb3lpbmcgdGhlIG1lbW9yeS4KKwogMjAxMy0w Ni0xOSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9zZSBwbHVn LWlucyBDRkJ1bmRsZVNob3J0VmVyc2lvblN0cmluZyBpbiB0aGUgV0tQbHVnaW5JbmZvcm1hdGlv biBkaWN0aW9uYXJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdGV4dF9jaGVja2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdGV4dF9jaGVja2VyLmgKaW5kZXggMDRiN2QwZC4uMDdmMDQzMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNrZXIuaApAQCAtOTYs OCArOTYsOCBAQCB0eXBlZGVmIHZvaWQgKCpFd2tfVGV4dF9DaGVja2VyX1N0cmluZ19TcGVsbGlu Z19DaGVja19DYikodWludDY0X3QgdGFnLCBjb25zdCBjaAogICogQHBhcmFtIHRhZyB1bmlxdWUg dGFnIHRvIG5vdGlmeSB0aGUgc3BlbGwgY2hlY2tlciB3aGljaCBkb2N1bWVudCB0aGF0IEBhIHRl eHQgaXMgYXNzb2NpYXRlZCwKICAqICAgICAgICBAYyAwIGNhbiBiZSBwYXNzZWQgZm9yIHRleHQg bm90IGFzc29jaWF0ZWQgd2l0aCBhIHBhcnRpY3VsYXIgZG9jdW1lbnQKICAqIEBwYXJhbSB3b3Jk IHRoZSB3b3JkIHRvIGdldCBndWVzc2VzCi0gKiBAcmV0dXJuIGEgbGlzdCBvZiBkeW5hbWljYWxs eSBhbGxvY2F0ZWQgc3RyaW5ncyAoYXMgY2hhciopIGFuZAotICogICAgICAgICBjYWxsZXIgaXMg cmVzcG9uc2libGUgZm9yIGRlc3Ryb3lpbmcgdGhlbS4KKyAqIEByZXR1cm4gYSBsaXN0IG9mIGR5 bmFtaWNhbGx5IGFsbG9jYXRlZCBzdHJpbmdzIChhcyBjaGFyKiksCisgKiAgICAgICAgIGEgbGlz dCBhbmQgaXRzIGl0ZW1zIHdpbGwgYmUgZnJlZWQgYnkgV2ViS2l0LgogICovCiB0eXBlZGVmIEVp bmFfTGlzdCAqKCpFd2tfVGV4dF9DaGVja2VyX1dvcmRfR3Vlc3Nlc19HZXRfQ2IpKHVpbnQ2NF90 IHRhZywgY29uc3QgY2hhciAqd29yZCk7CiAK