117820 2013-06-19 22:15:48 -0700 The order of the generated supplemental code is not guaranteed 2013-06-20 09:09:13 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117785 1 cdumez cdumez benjamin commit-queue darin haraken laszlo.gombos oldest_to_newest 902014 0 cdumez 2013-06-19 22:15:48 -0700 The order of the generated supplemental code (partial interfaces and implements statements) is not guaranteed. This causes the bindings tests to sometimes fail because the code is generated in a different order. 902015 1 haraken 2013-06-19 22:19:00 -0700 ah, good point. I remembered that I spent one day and noticed this issue when I implemented [Supplemental] for GObject build bots... 902016 2 205057 cdumez 2013-06-19 22:19:49 -0700 Created attachment 205057 Patch 902024 3 205057 commit-queue 2013-06-19 22:45:06 -0700 Comment on attachment 205057 Patch Clearing flags on attachment: 205057 Committed r151771: <http://trac.webkit.org/changeset/151771> 902025 4 commit-queue 2013-06-19 22:45:08 -0700 All reviewed patches have been landed. Closing bug. 902174 5 benjamin 2013-06-20 09:09:13 -0700 Thanks! All bots are green. 205057 2013-06-19 22:19:49 -0700 2013-06-19 22:45:06 -0700 Patch 117820_supplemental_order.patch text/plain 1390 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiM2U0NDNiZi4uMjA5NzFjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA2LTE5ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5n LmNvbT4KKworICAgICAgICBUaGUgb3JkZXIgb2YgdGhlIGdlbmVyYXRlZCBzdXBwbGVtZW50YWwg Y29kZSBpcyBub3QgZ3VhcmFudGVlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE3ODIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU29ydCB0aGUgc3VwcGxlbWVudGFsIGlkbCBmaWxlcyBiZWZvcmUgZ2Vu ZXJhdGluZyB0aGUgY29kZSBzbyB0aGF0IGl0IGlzCisgICAgICAgIGdlbmVyYXRlZCBpbiBhIGNv bnNpc3RlbnQgb3JkZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0 aW5nIGJpbmRpbmdzIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0 ZS1iaW5kaW5ncy5wbDoKKwogMjAxMy0wNi0xOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFw cGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBDb21tb24gY3Jhc2hlcyB3aGVuIHBsYXlpbmcgbWVk aWEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUt YmluZGluZ3MucGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRlLWJp bmRpbmdzLnBsCmluZGV4IDBkNDgxZTUuLjQ5ZDgxZGIgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbApAQCAtMTAwLDcgKzEw MCw3IEBAIGlmICgkc3VwcGxlbWVudGFsRGVwZW5kZW5jeUZpbGUpIHsKICAgICAgICAgbXkgKCRp ZGxGaWxlLCBAZm9sbG93aW5nSWRsRmlsZXMpID0gc3BsaXQoL1xzKy8sICRsaW5lKTsKICAgICAg ICAgaWYgKCRpZGxGaWxlIGFuZCBiYXNlbmFtZSgkaWRsRmlsZSkgZXEgYmFzZW5hbWUoJHRhcmdl dElkbEZpbGUpKSB7CiAgICAgICAgICAgICAkaWRsRm91bmQgPSAxOwotICAgICAgICAgICAgQHN1 cHBsZW1lbnRlZElkbEZpbGVzID0gQGZvbGxvd2luZ0lkbEZpbGVzOworICAgICAgICAgICAgQHN1 cHBsZW1lbnRlZElkbEZpbGVzID0gc29ydCBAZm9sbG93aW5nSWRsRmlsZXM7CiAgICAgICAgIH0K ICAgICB9CiAgICAgY2xvc2UgRkg7Cg==