117818 2013-06-19 21:23:48 -0700 [Mac] Downloaded file name encoding is incorrect when download link opens in a new window 2013-06-20 13:06:36 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue japhet oldest_to_newest 901996 0 ap 2013-06-19 21:23:48 -0700 We set up downloaded file name encoding via FrameLoader::addExtraFieldsToRequest(), and one of the options is referring document's encoding. But FrameLoader::addExtraFieldsToRequest() is called at poorly defined times, one of which is after policy delegate. If the download link is target="_blank", then this happens after a new tab opens, and we overwrite a perfectly good fallback encoding array with one from a blank document. <rdar://problem/14212635> 902012 1 205056 ap 2013-06-19 22:08:01 -0700 Created attachment 205056 proposed fix 902272 2 205056 beidson 2013-06-20 12:42:37 -0700 Comment on attachment 205056 proposed fix This code is gross. This fix is good for this bug, though. 902277 3 ap 2013-06-20 13:06:36 -0700 Committed <http://trac.webkit.org/r151793>. 205056 2013-06-19 22:08:01 -0700 2013-06-20 12:42:37 -0700 proposed fix DownloadTargetBlank.txt text/plain 2530 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTc2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA2LTE5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIERvd25sb2FkZWQg ZmlsZSBuYW1lIGVuY29kaW5nIGlzIGluY29ycmVjdCB3aGVuIGRvd25sb2FkIGxpbmsgb3BlbnMg aW4gYSBuZXcgd2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTc4MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0MjEyNjM1PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIHRlc3RzIGFkZGVk LiBUaGUgbWFjaGluZXJ5IHdlIGhhdmUgZm9yIGxvZ2dpbmcgZG93bmxvYWRlZCBmaWxlIG5hbWUg aXMgdmVyeQorICAgICAgICBmYXIgZnJvbSBiZWluZyBhYmxlIHRvIHdvcmsgaW4gYSBzZWNvbmRh cnkgd2luZG93LgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDogKFdlYkNvcmU6 OkZyYW1lTG9hZGVyOjphZGRFeHRyYUZpZWxkc1RvUmVxdWVzdCk6CisgICAgICAgIE1hZGUgYSB0 YXJnZXRlZCBmaXggLSBkb24ndCB1cGRhdGUgZW5jb2RpbmcgZmFsbGJhY2sgYXJyYXkgaWYgd2Ug YWxyZWFkeSBoYXZlIG9uZSwKKyAgICAgICAgdGhlcmUgaXMgbm8gY2hhbmNlIGZvciBpdCB0byBi ZSBtb3JlIGNvcnJlY3QuIEluIHRoaXMgY2FzZSwgaXQncyBpbmNvcnJlY3QgYmVjYXVzZQorICAg ICAgICBpdCBjb21lcyBmcm9tIGEgbmV3IGJsYW5rIHdpbmRvdywgaW5zdGVhZCBvZiBvcmlnaW5h bCByZWZlcmVyLgorICAgICAgICBXZSBoYXZlIGEgbG90IG9mIGNvZGUgaW4gYWRkRXh0cmFGaWVs ZHNUb1JlcXVlc3QoKSB0byBzdHJ1Z2dsZSB3aXRoIHRoaXMsIGFuZCB3ZSBoYXZlCisgICAgICAg IGEgRklYTUUgdG8gdHJ5IG5vdCBjYWxsaW5nIGl0IGZyb20gcG9saWN5IGRlbGVnYXRlLgorCiAy MDEzLTA2LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAg IFtNYWNdIENvbW1vbiBjcmFzaGVzIHdoZW4gcGxheWluZyBtZWRpYQpJbmRleDogU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiAxNTE3NjEpCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTAwLDkgKzI1 MDAsMTIgQEAgdm9pZCBGcmFtZUxvYWRlcjo6YWRkRXh0cmFGaWVsZHNUb1JlcXVlcwogICAgIC8v IE1ha2Ugc3VyZSB3ZSBzZW5kIHRoZSBPcmlnaW4gaGVhZGVyLgogICAgIGFkZEhUVFBPcmlnaW5J Zk5lZWRlZChyZXF1ZXN0LCBTdHJpbmcoKSk7CiAKLSAgICAvLyBBbHdheXMgdHJ5IFVURi04LiBJ ZiB0aGF0IGZhaWxzLCB0cnkgZnJhbWUgZW5jb2RpbmcgKGlmIGFueSkgYW5kIHRoZW4gdGhlIGRl ZmF1bHQuCi0gICAgU2V0dGluZ3MqIHNldHRpbmdzID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKLSAg ICByZXF1ZXN0LnNldFJlc3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5jb2RpbmdGYWxsYmFja0Fy cmF5KCJVVEYtOCIsIG1fZnJhbWUtPmRvY3VtZW50KCktPmVuY29kaW5nKCksIHNldHRpbmdzID8g c2V0dGluZ3MtPmRlZmF1bHRUZXh0RW5jb2RpbmdOYW1lKCkgOiBTdHJpbmcoKSk7CisgICAgLy8g T25seSBzZXQgZmFsbGJhY2sgYXJyYXkgaWYgaXQncyBzdGlsbCBlbXB0eSAobGF0ZXIgYXR0ZW1w dHMgbWF5IGJlIGluY29ycmVjdCwgc2VlIGJ1ZyAxMTc4MTgpLgorICAgIGlmIChyZXF1ZXN0LnJl c3BvbnNlQ29udGVudERpc3Bvc2l0aW9uRW5jb2RpbmdGYWxsYmFja0FycmF5KCkuaXNFbXB0eSgp KSB7CisgICAgICAgIC8vIEFsd2F5cyB0cnkgVVRGLTguIElmIHRoYXQgZmFpbHMsIHRyeSBmcmFt ZSBlbmNvZGluZyAoaWYgYW55KSBhbmQgdGhlbiB0aGUgZGVmYXVsdC4KKyAgICAgICAgU2V0dGlu Z3MqIHNldHRpbmdzID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKKyAgICAgICAgcmVxdWVzdC5zZXRS ZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheSgiVVRGLTgiLCBt X2ZyYW1lLT5kb2N1bWVudCgpLT5lbmNvZGluZygpLCBzZXR0aW5ncyA/IHNldHRpbmdzLT5kZWZh dWx0VGV4dEVuY29kaW5nTmFtZSgpIDogU3RyaW5nKCkpOworICAgIH0KIH0KIAogdm9pZCBGcmFt ZUxvYWRlcjo6YWRkSFRUUE9yaWdpbklmTmVlZGVkKFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwg Y29uc3QgU3RyaW5nJiBvcmlnaW4pCg==