117808 2013-06-19 15:20:51 -0700 Remove the SegmentedVector inline segment to shrink CodeBlock by 6X 2014-06-17 07:20:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren benjamin cmarcelo commit-queue k.gurpreet oliver webkit-bug-importer oldest_to_newest 901921 0 ggaren 2013-06-19 15:20:51 -0700 Remove the SegmentedVector inline segment to shrink CodeBlock by 6X 901922 1 205033 ggaren 2013-06-19 15:25:49 -0700 Created attachment 205033 Patch 901923 2 205033 ggaren 2013-06-19 15:26:14 -0700 Comment on attachment 205033 Patch Oliver Hunt reviewed this. 901924 3 webkit-bug-importer 2013-06-19 15:26:38 -0700 <rdar://problem/14209227> 901925 4 ggaren 2013-06-19 15:29:34 -0700 Committed revision <http://trac.webkit.org/changeset/151755>. 1016115 5 k.gurpreet 2014-06-17 07:20:20 -0700 Hi Geoffrey. I have few doubts regarding this patch. I merged this patch to my old webkit version but did not see any improvement in peak memory. 1) Does it reduce peak memory? 2) If not then how can we quantify the CodeBlock memory targeted by the patch? 3) Is there any other live site other than google where this can be verified? 4) Can it applied on rev 124*(series) and would that show any improvement? Thanks. 205033 2013-06-19 15:25:49 -0700 2013-06-19 15:26:14 -0700 Patch bug-117808-20130619152400.patch text/plain 4605 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTE3NTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDEzLTA2LTE5ICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSBTZWdtZW50ZWRWZWN0b3IgaW5s aW5lIHNlZ21lbnQgdG8gc2hyaW5rIENvZGVCbG9jayBieSA2WAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3ODA4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VnbWVudGVkVmVjdG9yIGFsbG9jYXRpb24g aXNuJ3Qgc3VwZXIgaG90LCBidXQgd2UgZG8gdGVuZCB0byBoYXZlIG1hbnkKKyAgICAgICAgbGl2 ZSBTZWdtZW50ZWRWZWN0b3JzIGF0IHJ1bnRpbWUsIHBhcnRpY3VsYXJseSBpbiBDb2RlQmxvY2tz LCBzbyB0aGUKKyAgICAgICAgcmlnaHQgdHJhZGVvZmYgaXMgdG8gYWxsb2NhdGUgc2VnbWVudHMg b3V0LW9mLWxpbmUgYXMgbmVlZGVkLgorCisgICAgICAgIFRoaXMgcmVkdWNlcyBzdGFydHVwIG1l bW9yeSB1c2FnZSBAIGdvb2dsZS5jb20gYnkgYWJvdXQgNk1CLgorCisgICAgICAgIE5vIHJlZ3Jl c3Npb24gb24gU3VuU3BpZGVyLgorCisgICAgICAgICogd3RmL1NlZ21lbnRlZFZlY3Rvci5oOgor ICAgICAgICAoV1RGOjpTZWdtZW50ZWRWZWN0b3I6OlNlZ21lbnRlZFZlY3Rvcik6CisgICAgICAg IChXVEY6OlNlZ21lbnRlZFZlY3Rvcjo6YXQpOgorICAgICAgICAoV1RGOjpTZWdtZW50ZWRWZWN0 b3I6OmFwcGVuZCk6CisgICAgICAgIChXVEY6OlNlZ21lbnRlZFZlY3Rvcjo6cmVtb3ZlTGFzdCk6 CisgICAgICAgIChXVEY6OlNlZ21lbnRlZFZlY3Rvcjo6Y2xlYXIpOgorICAgICAgICAoV1RGOjpT ZWdtZW50ZWRWZWN0b3I6OmRlbGV0ZUFsbFNlZ21lbnRzKTogTm8gbW9yZSBpbmxpbmUgc2VnbWVu dC4KKworICAgICAgICAoV1RGOjpTZWdtZW50ZWRWZWN0b3I6OmVuc3VyZVNlZ21lbnRzRm9yKTog VGhpcyBjb2RlIHVzZWQgdG8gYXNzdW1lCisgICAgICAgIHRoYXQgdGhlcmUgd2FzIGFsd2F5cyBh IDAgc2VnbWVudCwgc28gdGhlIG1hdGggd291bGQgdW5kZXJmbG93IGlmIHRoZXJlCisgICAgICAg IHdlcmUgbm8gMCBzZWdtZW50LiBJIHVkcGF0ZWQgdGhlIG1hdGggdG8gYWNjb3VudCBmb3IgaGF2 aW5nIG5vIHNlZ21lbnRzLgorCiAyMDEzLTA2LTE5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CiAKICAgICAgICAgQlVJTEQgRklYIChyMTUxNjYzKTogRml4IGJ1aWxkIGZvciBp T1MgV2ViS2l0CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9TZWdtZW50ZWRWZWN0b3IuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TZWdtZW50ZWRWZWN0b3IuaAkocmV2aXNpb24gMTUxNjg3 KQorKysgU291cmNlL1dURi93dGYvU2VnbWVudGVkVmVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAg LTExMyw3ICsxMTMsNiBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgU2VnbWVudGVkVmVjdG9y KCkKICAgICAgICAgICAgIDogbV9zaXplKDApCiAgICAgICAgIHsKLSAgICAgICAgICAgIG1fc2Vn bWVudHMuYXBwZW5kKCZtX2lubGluZVNlZ21lbnQpOwogICAgICAgICB9CiAKICAgICAgICAgflNl Z21lbnRlZFZlY3RvcigpCkBAIC0xMjYsOCArMTI1LDYgQEAgbmFtZXNwYWNlIFdURiB7CiAKICAg ICAgICAgVCYgYXQoc2l6ZV90IGluZGV4KQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoaW5k ZXggPCBTZWdtZW50U2l6ZSkKLSAgICAgICAgICAgICAgICByZXR1cm4gbV9pbmxpbmVTZWdtZW50 W2luZGV4XTsKICAgICAgICAgICAgIHJldHVybiBzZWdtZW50Rm9yKGluZGV4KS0+YXQoc3Vic2Ny aXB0Rm9yKGluZGV4KSk7CiAgICAgICAgIH0KIApAQCAtMTU1LDExICsxNTIsNiBAQCBuYW1lc3Bh Y2UgV1RGIHsKICAgICAgICAgewogICAgICAgICAgICAgKyttX3NpemU7CiAKLSAgICAgICAgICAg IGlmIChtX3NpemUgPD0gU2VnbWVudFNpemUpIHsKLSAgICAgICAgICAgICAgICBtX2lubGluZVNl Z21lbnQudW5jaGVja2VkQXBwZW5kKHZhbHVlKTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0g ICAgICAgICAgICB9Ci0KICAgICAgICAgICAgIGlmICghc2VnbWVudEV4aXN0c0ZvcihtX3NpemUg LSAxKSkKICAgICAgICAgICAgICAgICBtX3NlZ21lbnRzLmFwcGVuZChuZXcgU2VnbWVudCk7CiAg ICAgICAgICAgICBzZWdtZW50Rm9yKG1fc2l6ZSAtIDEpLT51bmNoZWNrZWRBcHBlbmQodmFsdWUp OwpAQCAtMTczLDEwICsxNjUsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgICAgICB2b2lkIHJl bW92ZUxhc3QoKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAobV9zaXplIDw9IFNlZ21lbnRT aXplKQotICAgICAgICAgICAgICAgIG1faW5saW5lU2VnbWVudC5yZW1vdmVMYXN0KCk7Ci0gICAg ICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgc2VnbWVudEZvcihtX3NpemUgLSAxKS0+cmVt b3ZlTGFzdCgpOworICAgICAgICAgICAgc2VnbWVudEZvcihtX3NpemUgLSAxKS0+cmVtb3ZlTGFz dCgpOwogICAgICAgICAgICAgLS1tX3NpemU7CiAgICAgICAgIH0KIApAQCAtMTkwLDggKzE3OSw3 IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICB2b2lkIGNsZWFyKCkKICAgICAgICAgewogICAg ICAgICAgICAgZGVsZXRlQWxsU2VnbWVudHMoKTsKLSAgICAgICAgICAgIG1fc2VnbWVudHMucmVz aXplKDEpOwotICAgICAgICAgICAgbV9pbmxpbmVTZWdtZW50LmNsZWFyKCk7CisgICAgICAgICAg ICBtX3NlZ21lbnRzLmNsZWFyKCk7CiAgICAgICAgICAgICBtX3NpemUgPSAwOwogICAgICAgICB9 CiAKQEAgLTIxNSw5ICsyMDMsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgICAgICB2b2lkIGRl bGV0ZUFsbFNlZ21lbnRzKCkKICAgICAgICAgewotICAgICAgICAgICAgLy8gU2tpcCB0aGUgZmly c3Qgc2VnbWVudCwgYmVjYXVzZSBpdCdzIG91ciBpbmxpbmUgc2VnbWVudCwgd2hpY2ggd2FzCi0g ICAgICAgICAgICAvLyBub3QgY3JlYXRlZCBieSBuZXcuCi0gICAgICAgICAgICBmb3IgKHNpemVf dCBpID0gMTsgaSA8IG1fc2VnbWVudHMuc2l6ZSgpOyBpKyspCisgICAgICAgICAgICBmb3IgKHNp emVfdCBpID0gMDsgaSA8IG1fc2VnbWVudHMuc2l6ZSgpOyBpKyspCiAgICAgICAgICAgICAgICAg ZGVsZXRlIG1fc2VnbWVudHNbaV07CiAgICAgICAgIH0KIApAQCAtMjM4LDE4ICsyMjQsMTIgQEAg bmFtZXNwYWNlIFdURiB7CiAKICAgICAgICAgdm9pZCBlbnN1cmVTZWdtZW50c0ZvcihzaXplX3Qg c2l6ZSkKICAgICAgICAgewotICAgICAgICAgICAgc2l6ZV90IHNlZ21lbnRDb3VudCA9IG1fc2l6 ZSAvIFNlZ21lbnRTaXplOwotICAgICAgICAgICAgaWYgKG1fc2l6ZSAlIFNlZ21lbnRTaXplKQot ICAgICAgICAgICAgICAgICsrc2VnbWVudENvdW50OwotICAgICAgICAgICAgc2VnbWVudENvdW50 ID0gc3RkOjptYXg8c2l6ZV90PihzZWdtZW50Q291bnQsIDEpOyAvLyBXZSBhbHdheXMgaGF2ZSBh dCBsZWFzdCBvdXIgaW5saW5lIHNlZ21lbnQuCi0KLSAgICAgICAgICAgIHNpemVfdCBuZWVkZWRT ZWdtZW50Q291bnQgPSBzaXplIC8gU2VnbWVudFNpemU7Ci0gICAgICAgICAgICBpZiAoc2l6ZSAl IFNlZ21lbnRTaXplKQotICAgICAgICAgICAgICAgICsrbmVlZGVkU2VnbWVudENvdW50OworICAg ICAgICAgICAgc2l6ZV90IHNlZ21lbnRDb3VudCA9IChtX3NpemUgKyBTZWdtZW50U2l6ZSAtIDEp IC8gU2VnbWVudFNpemU7CisgICAgICAgICAgICBzaXplX3QgbmVlZGVkU2VnbWVudENvdW50ID0g KHNpemUgKyBTZWdtZW50U2l6ZSAtIDEpIC8gU2VnbWVudFNpemU7CiAKICAgICAgICAgICAgIC8v IEZpbGwgdXAgdG8gTiAtIDEgc2VnbWVudHMuCiAgICAgICAgICAgICBzaXplX3QgZW5kID0gbmVl ZGVkU2VnbWVudENvdW50IC0gMTsKLSAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSBzZWdtZW50 Q291bnQgLSAxOyBpIDwgZW5kOyArK2kpCisgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gc2Vn bWVudENvdW50ID8gc2VnbWVudENvdW50IC0gMSA6IDA7IGkgPCBlbmQ7ICsraSkKICAgICAgICAg ICAgICAgICBlbnN1cmVTZWdtZW50KGksIFNlZ21lbnRTaXplKTsKIAogICAgICAgICAgICAgLy8g R3JvdyBzZWdtZW50IE4gdG8gYWNjb21vZGF0ZSB0aGUgcmVtYWluZGVyLgpAQCAtMjY1LDggKzI0 NSw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICB9CiAKICAgICAgICAgc2l6ZV90IG1fc2l6 ZTsKLSAgICAgICAgU2VnbWVudCBtX2lubGluZVNlZ21lbnQ7Ci0gICAgICAgIFZlY3RvcjxTZWdt ZW50KiwgSW5saW5lQ2FwYWNpdHk+IG1fc2VnbWVudHM7CisgICAgICAgIFZlY3RvcjxTZWdtZW50 Kj4gbV9zZWdtZW50czsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXVEYK