117800 2013-06-19 10:15:19 -0700 FTL: arm build is broken in ToT 2013-06-19 10:43:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 901834 0 msaboff 2013-06-19 10:15:19 -0700 There are three errors I find building JSC for arm in the FTL branch: compiling Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/bytecode/CodeBlock.h:36: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/bytecode/CallLinkInfo.h:29: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/jit/ClosureCallStubRoutine.h:33: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/bytecode/CodeOrigin.h:31: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/bytecode/ValueRecovery.h:31: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/assembler/MacroAssembler.h:34: In file included from /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:32: /Volumes/Data/src/webkit.ftl/Source/JavaScriptCore/assembler/ARMv7Assembler.h:2089:16: error: non-const lvalue reference to type 'Vector<[2 * ...], struct WTF::UnsafeVectorOverflow>' cannot bind to a value of unrelated type 'Vector<[2 * ...], (default) class WTF::CrashOnOverflow>' return m_jumpsToLink; ^~~~~~~~~~~~~ 1 error generated. compiling Source/JavaScriptCore/ftl/WebKitLLVMLibraryAnchor.cpp:30:10: fatal error: 'WebKitLLVMLibraryToken.h' file not found #include "WebKitLLVMLibraryToken.h" ^ 1 error generated. compiling Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:1116:14: error: unused variable 'op1' [-Werror,-Wunused-variable] unsigned op1 = currentInstruction[2].u.operand; ^ 1 error generated. 901844 1 205014 msaboff 2013-06-19 10:40:37 -0700 Created attachment 205014 Patch that will land. This addresses the errors compiling Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp and Source/JavaScriptCore/jit/JITArithmetic32_64.cpp. The error compiling Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp is addressed if we could run build-webkit for arm. The missing header file is created via the build script Tools/Scripts/copy-webkitlibraries-to-product-directory. A workaround is to create the file manually: echo "/* This file fools WebKit's build system into relinking JavaScriptCore if the LLVM libraries changed. */" > WebKitBuild/{Debug,Release}-iphoneos/usr/local/include/WebKitLLVMLibraryToken.h 901848 2 msaboff 2013-06-19 10:43:56 -0700 Fixed landed in in change set <http://trac.webkit.org/changeset/151741>. 205014 2013-06-19 10:40:37 -0700 2013-06-19 10:40:37 -0700 Patch that will land. 117800.patch text/plain 2062 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxNzM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA2LTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEZUTDogYXJtIGJ1aWxkIGlzIGJyb2tlbiBpbiBUb1QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzgwMAorCisgICAgICAgIFVucmV2aWV3ZWQg YnVpbGQgZml4ZXMuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaDoKKyAg ICAgICAgKEFSTXY3QXNzZW1ibGVyKTogTWVyZ2Ugb2YgcjE0Nzk0MQorICAgICAgICAqIGppdC9K SVRBcml0aG1ldGljMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfbW9kKTog TW92ZWQgdmFyaWFibGUgZGVjbGFyYXRpb24gYmFjayBpbnNpZGUgI2lmZGVmIHdoZXJlIHVzZWQu CisKIDIwMTMtMDYtMTcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAg ICAgICAgRlRMOiBBZGQgYW5vdGhlciB0ZW1wIHJlZ2lzdGVyIHJlZ1Q0IHRvIEpTSW50ZXJmYWNl SklUCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fz c2VtYmxlci5oCShyZXZpc2lvbiAxNTE3MDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4MTAsNyArMjgxMCw3 IEBAIHByaXZhdGU6CiAgICAgICAgIEFzc2VtYmxlckJ1ZmZlciBtX2J1ZmZlcjsKICAgICB9IG1f Zm9ybWF0dGVyOwogCi0gICAgVmVjdG9yPExpbmtSZWNvcmQ+IG1fanVtcHNUb0xpbms7CisgICAg VmVjdG9yPExpbmtSZWNvcmQsIDAsIFVuc2FmZVZlY3Rvck92ZXJmbG93PiBtX2p1bXBzVG9MaW5r OwogICAgIFZlY3RvcjxpbnQzMl90PiBtX29mZnNldHM7CiAgICAgaW50IG1faW5kZXhPZkxhc3RX YXRjaHBvaW50OwogICAgIGludCBtX2luZGV4T2ZUYWlsT2ZMYXN0V2F0Y2hwb2ludDsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYzMyXzY0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMzMl82NC5jcHAJ KHJldmlzaW9uIDE1MTcwNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGht ZXRpYzMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTExMiwxMSArMTExMiwxMSBAQCB2b2lk IEpJVDo6ZW1pdFNsb3dfb3BfZGl2KEluc3RydWN0aW9uKiBjCiAKIHZvaWQgSklUOjplbWl0X29w X21vZChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogeworI2lmIENQVShYODYpIHx8 IENQVShYODZfNjQpCiAgICAgdW5zaWduZWQgZHN0ID0gY3VycmVudEluc3RydWN0aW9uWzFdLnUu b3BlcmFuZDsKICAgICB1bnNpZ25lZCBvcDEgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVy YW5kOwogICAgIHVuc2lnbmVkIG9wMiA9IGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJhbmQ7 CiAKLSNpZiBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KQogICAgIC8vIE1ha2Ugc3VyZSByZWdpc3Rl cnMgYXJlIGNvcnJlY3QgZm9yIHg4NiBJRElWIGluc3RydWN0aW9ucy4KICAgICBBU1NFUlQocmVn VDAgPT0gWDg2UmVnaXN0ZXJzOjplYXgpOwogICAgIEFTU0VSVChyZWdUMSA9PSBYODZSZWdpc3Rl cnM6OmVkeCk7Cg==