117799 2013-06-19 07:55:19 -0700 [BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render() 2013-06-19 08:30:49 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson cgarcia commit-queue rwlbuis xren oldest_to_newest 901795 0 jpetsovits 2013-06-19 07:55:19 -0700 Discovered by Xuefei Ren. If, in rare cases, BackingStorePrivate::renderContents() returns false, the for() loop in render() will take a tile buffer from the surface pool but due to aborting the iteration early, won't put it into the new tile map. In order to prevent losing the buffer, we need to put it back into the surface pool before continuing. Patch below. 901796 1 205006 jpetsovits 2013-06-19 07:59:55 -0700 Created attachment 205006 Patch 901806 2 205006 commit-queue 2013-06-19 08:30:47 -0700 Comment on attachment 205006 Patch Clearing flags on attachment: 205006 Committed r151735: <http://trac.webkit.org/changeset/151735> 901807 3 commit-queue 2013-06-19 08:30:49 -0700 All reviewed patches have been landed. Closing bug. 205006 2013-06-19 07:59:55 -0700 2013-06-19 08:30:47 -0700 Patch bug-117799-20130619145737.patch text/plain 2437 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4YmZhNjAzZTI2ZjM3NjI0ZTYxMWMyNDkxODUwMTk3OTUyYTI3NjNkLi4yYTU2MWE4MzI1 YThmZDc5ZTdkMTFkNTA0ZmZhYTJmNjFmNTJlNmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMy0wNi0xOSAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0BibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUHJldmVudCBs b3NzIG9mIHRpbGUgYnVmZmVycyBpbiBCYWNraW5nU3RvcmVQcml2YXRlOjpyZW5kZXIoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Nzk5CisgICAg ICAgIGh0dHBzOi8vamlyYS5iYnFueC5uZXQvYnJvd3NlL0JSV1NSLTExNzEyCisgICAgICAgIEpJ UkE0MTMyODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEaXNjb3ZlcmVkIGJ5IFh1ZWZlaSBSZW4uCisKKyAgICAgICAgSWYsIGluIHJhcmUgY2FzZXMs IHJlbmRlckNvbnRlbnRzKCkgcmV0dXJucyBmYWxzZSwKKyAgICAgICAgdGhlIGZvcigpIGxvb3Ag aW4gcmVuZGVyKCkgd2lsbCB0YWtlIGEgdGlsZSBidWZmZXIgZnJvbQorICAgICAgICB0aGUgc3Vy ZmFjZSBwb29sIGJ1dCBkdWUgdG8gYWJvcnRpbmcgdGhlIGl0ZXJhdGlvbiBlYXJseSwKKyAgICAg ICAgd29uJ3QgcHV0IGl0IGludG8gdGhlIG5ldyB0aWxlIG1hcC4gSW4gb3JkZXIgdG8gcHJldmVu dAorICAgICAgICBsb3NpbmcgdGhlIGJ1ZmZlciwgd2UgbmVlZCB0byBwdXQgaXQgYmFjayBpbnRv IHRoZQorICAgICAgICBzdXJmYWNlIHBvb2wgYmVmb3JlIGNvbnRpbnVpbmcuCisKKyAgICAgICAg KiBBcGkvQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFj a2luZ1N0b3JlUHJpdmF0ZTo6cmVuZGVyKToKKwogMjAxMy0wNi0xMiAgSmFrb2IgUGV0c292aXRz ICA8anBldHNvdml0c0BibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU21h cnRlciBhbGdvcml0aG0gdG8gZGV0ZXJtaW5lIHRoZSBiYWNraW5nc3RvcmUgcmVjdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCmluZGV4IDY4Yzg4OTVj Yjk2NTJkNDZhZGIyMjM0OWRjMzFlN2RkZmZmYTUxMTkuLmY3NTkxZmFjNDUwZWM3NTFhMGM3YzQx NTdmMjhkNDg0M2Y1MzA0YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZS5jcHAKQEAgLTExNzEsOCArMTE3MSwxMSBAQCBUaWxlSW5kZXhMaXN0IEJhY2tp bmdTdG9yZVByaXZhdGU6OnJlbmRlcihjb25zdCBUaWxlSW5kZXhMaXN0JiB0aWxlSW5kZXhMaXN0 KQogICAgICAgICBjb25zdCBQbGF0Zm9ybTo6RmxvYXRQb2ludCBkb2N1bWVudERpcnR5UmVjdE9y aWdpbiA9IHZpZXdwb3J0QWNjZXNzb3ItPnRvRG9jdW1lbnRDb250ZW50cyhkaXJ0eVJlY3QubG9j YXRpb24oKSwgY3VycmVudFNjYWxlKTsKICAgICAgICAgY29uc3QgUGxhdGZvcm06OkludFJlY3Qg ZHN0UmVjdChkaXJ0eVJlY3QubG9jYXRpb24oKSAtIHRpbGVPcmlnaW4sIGRpcnR5UmVjdC5zaXpl KCkpOwogCi0gICAgICAgIGlmICghcmVuZGVyQ29udGVudHMobmF0aXZlQnVmZmVyLCBkc3RSZWN0 LCBjdXJyZW50U2NhbGUsIGRvY3VtZW50RGlydHlSZWN0T3JpZ2luLCBSZW5kZXJSb290TGF5ZXIp KQorICAgICAgICBpZiAoIXJlbmRlckNvbnRlbnRzKG5hdGl2ZUJ1ZmZlciwgZHN0UmVjdCwgY3Vy cmVudFNjYWxlLCBkb2N1bWVudERpcnR5UmVjdE9yaWdpbiwgUmVuZGVyUm9vdExheWVyKSkgewor ICAgICAgICAgICAgLy8gUHV0IHRoZSBidWZmZXIgYmFjayBpbnRvIHRoZSBzdXJmYWNlIHBvb2wg c28gaXQgZG9lc24ndCBnZXQgbG9zdC4KKyAgICAgICAgICAgIFN1cmZhY2VQb29sOjpnbG9iYWxT dXJmYWNlUG9vbCgpLT5hZGRCYWNrQnVmZmVyKGJhY2tCdWZmZXIpOwogICAgICAgICAgICAgY29u dGludWU7CisgICAgICAgIH0KIAogICAgICAgICAvLyBBZGQgdGhlIG5ld2x5IHJlbmRlcmVkIHJl Z2lvbiB0byB0aGUgdGlsZSBzbyBpdCBjYW4ga2VlcCB0cmFjayBmb3IgYmxpdHMuCiAgICAgICAg IGJhY2tCdWZmZXItPmFkZFJlbmRlcmVkUmVnaW9uKGRpcnR5UmVjdCk7Cg==