117798 2013-06-19 07:01:15 -0700 [WinCairo] Does not compile. 2013-06-19 11:06:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue roger_fong oldest_to_newest 901780 0 peavo 2013-06-19 07:01:15 -0700 Some of the errors: WebFrameNetworkingContext.h(51): error C3668: 'WebFrameNetworkingContext::storageSession' : method with override specifier 'override' did not override any base class methods WebKitSystemInterface.h(74): error C2065: 'CGFloat' : undeclared identifier WebKitSystemInterface.h(74): error C2182: 'wkSetFontSmoothingContrast' : illegal use of type 'void' 901791 1 205005 peavo 2013-06-19 07:27:19 -0700 Created attachment 205005 Patch 901851 2 205005 bfulgham 2013-06-19 10:53:12 -0700 Comment on attachment 205005 Patch r=me 901860 3 205005 commit-queue 2013-06-19 11:06:14 -0700 Comment on attachment 205005 Patch Clearing flags on attachment: 205005 Committed r151742: <http://trac.webkit.org/changeset/151742> 901861 4 commit-queue 2013-06-19 11:06:16 -0700 All reviewed patches have been landed. Closing bug. 205005 2013-06-19 07:27:19 -0700 2013-06-19 11:06:13 -0700 Patch bug-117798-20130619162523.patch text/plain 2596 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTczMSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTE5 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gRG9lcyBub3QgY29tcGlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNzc5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBVU0UoQ0ZORVRXT1JLKSBndWFyZHMuCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcDogQWRkIFVTRShDRk5F VFdPUkspIGd1YXJkLgorICAgICAgICAoV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dDo6ZW5zdXJl UHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbik6IENoYW5nZSBVU0UoQ0ZfTkVUV09SSykgdG8gVVNFKENG TkVUV09SSykuCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVOZXR3b3JraW5nQ29u dGV4dC5oOiBBZGQgVVNFKENGTkVUV09SSykgZ3VhcmQuCisKIDIwMTMtMDYtMTggIFJvZ2VyIEZv bmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBCdWlsZCBm aXggZm9yIEFwcGxlIFdpbmRvd3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3Vw cG9ydC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcAko cmV2aXNpb24gMTUxNzI3KQorKysgU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVOZXR3b3JraW5nQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDkg QEAKICNpbmNsdWRlIDxXZWJDb3JlL1BhZ2UuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNl RXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1NldHRpbmdzLmg+CisjaWYgVVNFKENGTkVUV09S SykKICNpbmNsdWRlIDxXZWJLaXRTeXN0ZW1JbnRlcmZhY2UvV2ViS2l0U3lzdGVtSW50ZXJmYWNl Lmg+CisjZW5kaWYKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTY0LDcgKzY2LDcg QEAgdm9pZCBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpzZXRQcml2YQogCiB2b2lkIFdlYkZy YW1lTmV0d29ya2luZ0NvbnRleHQ6OmVuc3VyZVByaXZhdGVCcm93c2luZ1Nlc3Npb24oKQogewot I2lmIFVTRShDRl9ORVRXT1JLKQorI2lmIFVTRShDRk5FVFdPUkspCiAgICAgQVNTRVJUKGlzTWFp blRocmVhZCgpKTsKIAogICAgIGlmIChwcml2YXRlU2Vzc2lvbikKQEAgLTk4LDYgKzEwMCw3IEBA IFN0cmluZyBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpyZWZlcnIKICAgICByZXR1cm4gZnJh bWUoKS0+bG9hZGVyKCktPnJlZmVycmVyKCk7CiB9CiAKKyNpZiBVU0UoQ0ZORVRXT1JLKQogTmV0 d29ya1N0b3JhZ2VTZXNzaW9uJiBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpzdG9yYWdlU2Vz c2lvbigpIGNvbnN0CiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKQEAgLTEwNywzICsx MTAsNCBAQCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIFdlYkZyYW1lTmV0d29ya2luCiAKICAgICBy ZXR1cm4gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpkZWZhdWx0U3RvcmFnZVNlc3Npb24oKTsKIH0K KyNlbmRpZgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVO ZXR3b3JraW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuaAkocmV2aXNpb24gMTUxNzI3KQor KysgU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVOZXR3b3JraW5nQ29u dGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw3ICs0OCw5IEBAIHByaXZhdGU6CiAgICAgfQog CiAgICAgdmlydHVhbCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yIGJsb2NrZWRFcnJvcihjb25zdCBX ZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKSBjb25zdCBPVkVSUklERTsKKyNpZiBVU0UoQ0ZORVRX T1JLKQogICAgIHZpcnR1YWwgV2ViQ29yZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBzdG9yYWdl U2Vzc2lvbigpIGNvbnN0IE9WRVJSSURFOworI2VuZGlmCiAgICAgdmlydHVhbCBTdHJpbmcgcmVm ZXJyZXIoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIFN0cmluZyB1c2VyQWdlbnQoKSBj b25zdCB7IHJldHVybiBtX3VzZXJBZ2VudDsgfQogCg==