117797 2013-06-19 06:28:03 -0700 [CSS Regions] fast/regions/seamless-iframe-flowed-into-regions.html asserts 2013-06-26 09:06:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 abucur abucur commit-queue esprehn+autocc glenn koivisto WebkitBugTracker oldest_to_newest 901771 0 abucur 2013-06-19 06:28:03 -0700 When enabling seamless iframes fast/regions/seamless-iframe-flowed-into-regions.html fails. This happens because the RenderFlowThread objects are shared between the root RenderView and the iframe RenderView but they have different layout state objects. 902485 1 205161 abucur 2013-06-21 02:37:56 -0700 Created attachment 205161 Patch 903742 2 koivisto 2013-06-26 08:51:28 -0700 r=me 903756 3 205161 commit-queue 2013-06-26 09:05:58 -0700 Comment on attachment 205161 Patch Clearing flags on attachment: 205161 Committed r151992: <http://trac.webkit.org/changeset/151992> 903757 4 commit-queue 2013-06-26 09:06:01 -0700 All reviewed patches have been landed. Closing bug. 205161 2013-06-21 02:37:56 -0700 2013-06-26 09:05:57 -0700 Patch bug-117797-20130621123604.patch text/plain 4332 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM5YmQ5MzViNjU4MWQ1 ODY2NzIzMDZlYzMyMDQxZThjZjkyZjgxMy4uZDI0YTljMTVhN2JhMjI2MjdiN2IyMDNmYjI3ZTkx NzlhMGI2MmZmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA2LTIxICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gZmFz dC9yZWdpb25zL3NlYW1sZXNzLWlmcmFtZS1mbG93ZWQtaW50by1yZWdpb25zLmh0bWwgYXNzZXJ0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Nzk3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNl YW1sZXNzIGlmcmFtZXMgaW5oZXJpdCB0aGUgY3VycmVudCBSZW5kZXJGbG93VGhyZWFkIGR1cmlu ZyBsYXlvdXQuIFRoaXMgbWVhbnMgZ2V0dGluZworICAgICAgICB0aGUgTGF5b3V0U3RhdGUgb2Jq ZWN0IGZyb20gdGhlIGZsb3cgdGhyZWFkIFJlbmRlclZpZXcgb2JqZWN0IGlzIG5vdCBhbHdheXMg Y29ycmVjdC4KKyAgICAgICAgRm9yIFJlbmRlck9iamVjdHMgaW5zaWRlIHRoZSBzZWFtbGVzcyBp ZnJhbWVzIHRoZSB2aWV3KCkvTGF5b3V0U3RhdGUgb2JqZWN0IGlzIGRpZmZlcmVudCB0aGFuIHRo ZSBvbmUKKyAgICAgICAgb2YgdGhlIFJlbmRlckZsb3dUaHJlYWQuIFRoZSBwYXRjaCBjaGFuZ2Vz IHRoZSBjb2RlIHRvIHVzZSB0aGUgY29ycmVjdCBMYXlvdXRTdGF0ZSBvYmplY3QgZHVyaW5nCisg ICAgICAgIGxheW91dCB3aGVuIHB1c2hpbmcgYSBuZXcgc3RhdGUuCisKKyAgICAgICAgVGVzdHM6 IGNvdmVyZWQgYnkgZmFzdC9yZWdpb25zL3NlYW1sZXNzLWlmcmFtZS1mbG93ZWQtaW50by1yZWdp b25zLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6OmN1cnJlbnRBY3RpdmVSZW5kZXJCb3gp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1RocmVhZDo6cHVzaEZsb3dUaHJlYWRMYXlv dXRTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFkOjpwb3BGbG93VGhy ZWFkTGF5b3V0U3RhdGUpOgorCiAyMDEzLTA2LTE5ICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExl YWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gUG90ZW50aWFs IHJhY2UgY29uZGl0aW9uIHdoZW4gZ2V0dGluZyB0aGUgdmlkZW8gc2luayBjYXBzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCmluZGV4IDcwMjA4ZjY2 ZTY1YTRjYTVhOGRkYjQxNDI4YmI4NmQxZThmY2Y1YmIuLjQ4ZjFjYjM5MDJjMzk2YTNhMTlmMWUy NmNjNzIzODcwMDQ3MjVhYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Rmxvd1RocmVhZC5jcHAKQEAgLTEwNzIsMjEgKzEwNzIsMjIgQEAgdm9pZCBSZW5kZXJGbG93VGhy ZWFkOjpjbGVhck9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFJlZ2lvbihjb25zdCBSZW5kZXJC b3gqIGIKIAogY29uc3QgUmVuZGVyQm94KiBSZW5kZXJGbG93VGhyZWFkOjpjdXJyZW50QWN0aXZl UmVuZGVyQm94KCkgY29uc3QKIHsKLSAgICBjb25zdCBSZW5kZXJPYmplY3QqIGN1cnJlbnRPYmpl Y3QgPSBtX2FjdGl2ZU9iamVjdHNTdGFjay5pc0VtcHR5KCkgPyAwIDogbV9hY3RpdmVPYmplY3Rz U3RhY2subGFzdCgpOwotICAgIGlmIChjdXJyZW50T2JqZWN0ICYmIGN1cnJlbnRPYmplY3QtPmlz Qm94KCkpCi0gICAgICAgIHJldHVybiB0b1JlbmRlckJveChjdXJyZW50T2JqZWN0KTsKKyAgICBp ZiAobV9hY3RpdmVPYmplY3RzU3RhY2suaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gMDsKIAot ICAgIHJldHVybiAwOworICAgIGNvbnN0IFJlbmRlck9iamVjdCogY3VycmVudE9iamVjdCA9IG1f YWN0aXZlT2JqZWN0c1N0YWNrLmxhc3QoKTsKKyAgICByZXR1cm4gY3VycmVudE9iamVjdC0+aXNC b3goKSA/IHRvUmVuZGVyQm94KGN1cnJlbnRPYmplY3QpIDogMDsKIH0KIAogdm9pZCBSZW5kZXJG bG93VGhyZWFkOjpwdXNoRmxvd1RocmVhZExheW91dFN0YXRlKGNvbnN0IFJlbmRlck9iamVjdCog b2JqZWN0KQogewotICAgIGNvbnN0IFJlbmRlckJveCogY3VycmVudEJveERlc2NlbmRhbnQgPSBj dXJyZW50QWN0aXZlUmVuZGVyQm94KCk7Ci0gICAgTGF5b3V0U3RhdGUqIGxheW91dFN0YXRlID0g dmlldygpLT5sYXlvdXRTdGF0ZSgpOwotICAgIGlmIChjdXJyZW50Qm94RGVzY2VuZGFudCAmJiBs YXlvdXRTdGF0ZSAmJiBsYXlvdXRTdGF0ZS0+aXNQYWdpbmF0ZWQoKSkgewotICAgICAgICBBU1NF UlQobGF5b3V0U3RhdGUtPm1fcmVuZGVyZXIgPT0gY3VycmVudEJveERlc2NlbmRhbnQpOwotICAg ICAgICBMYXlvdXRTaXplIG9mZnNldERlbHRhID0gbGF5b3V0U3RhdGUtPm1fbGF5b3V0T2Zmc2V0 IC0gbGF5b3V0U3RhdGUtPm1fcGFnZU9mZnNldDsKLSAgICAgICAgc2V0T2Zmc2V0RnJvbUxvZ2lj YWxUb3BPZkZpcnN0UmVnaW9uKGN1cnJlbnRCb3hEZXNjZW5kYW50LCBjdXJyZW50Qm94RGVzY2Vu ZGFudC0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IG9mZnNldERlbHRhLmhlaWdodCgpIDog b2Zmc2V0RGVsdGEud2lkdGgoKSk7CisgICAgaWYgKGNvbnN0IFJlbmRlckJveCogY3VycmVudEJv eERlc2NlbmRhbnQgPSBjdXJyZW50QWN0aXZlUmVuZGVyQm94KCkpIHsKKyAgICAgICAgTGF5b3V0 U3RhdGUqIGxheW91dFN0YXRlID0gY3VycmVudEJveERlc2NlbmRhbnQtPnZpZXcoKS0+bGF5b3V0 U3RhdGUoKTsKKyAgICAgICAgaWYgKGxheW91dFN0YXRlICYmIGxheW91dFN0YXRlLT5pc1BhZ2lu YXRlZCgpKSB7CisgICAgICAgICAgICBBU1NFUlQobGF5b3V0U3RhdGUtPm1fcmVuZGVyZXIgPT0g Y3VycmVudEJveERlc2NlbmRhbnQpOworICAgICAgICAgICAgTGF5b3V0U2l6ZSBvZmZzZXREZWx0 YSA9IGxheW91dFN0YXRlLT5tX2xheW91dE9mZnNldCAtIGxheW91dFN0YXRlLT5tX3BhZ2VPZmZz ZXQ7CisgICAgICAgICAgICBzZXRPZmZzZXRGcm9tTG9naWNhbFRvcE9mRmlyc3RSZWdpb24oY3Vy cmVudEJveERlc2NlbmRhbnQsIGN1cnJlbnRCb3hEZXNjZW5kYW50LT5pc0hvcml6b250YWxXcml0 aW5nTW9kZSgpID8gb2Zmc2V0RGVsdGEuaGVpZ2h0KCkgOiBvZmZzZXREZWx0YS53aWR0aCgpKTsK KyAgICAgICAgfQogICAgIH0KIAogICAgIG1fYWN0aXZlT2JqZWN0c1N0YWNrLmFkZChvYmplY3Qp OwpAQCAtMTA5NiwxMCArMTA5NywxMSBAQCB2b2lkIFJlbmRlckZsb3dUaHJlYWQ6OnBvcEZsb3dU aHJlYWRMYXlvdXRTdGF0ZSgpCiB7CiAgICAgbV9hY3RpdmVPYmplY3RzU3RhY2sucmVtb3ZlTGFz dCgpOwogCi0gICAgY29uc3QgUmVuZGVyQm94KiBjdXJyZW50Qm94RGVzY2VuZGFudCA9IGN1cnJl bnRBY3RpdmVSZW5kZXJCb3goKTsKLSAgICBMYXlvdXRTdGF0ZSogbGF5b3V0U3RhdGUgPSB2aWV3 KCktPmxheW91dFN0YXRlKCk7Ci0gICAgaWYgKGN1cnJlbnRCb3hEZXNjZW5kYW50ICYmIGxheW91 dFN0YXRlICYmIGxheW91dFN0YXRlLT5pc1BhZ2luYXRlZCgpKQotICAgICAgICBjbGVhck9mZnNl dEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFJlZ2lvbihjdXJyZW50Qm94RGVzY2VuZGFudCk7CisgICAg aWYgKGNvbnN0IFJlbmRlckJveCogY3VycmVudEJveERlc2NlbmRhbnQgPSBjdXJyZW50QWN0aXZl UmVuZGVyQm94KCkpIHsKKyAgICAgICAgTGF5b3V0U3RhdGUqIGxheW91dFN0YXRlID0gY3VycmVu dEJveERlc2NlbmRhbnQtPnZpZXcoKS0+bGF5b3V0U3RhdGUoKTsKKyAgICAgICAgaWYgKGxheW91 dFN0YXRlICYmIGxheW91dFN0YXRlLT5pc1BhZ2luYXRlZCgpKQorICAgICAgICAgICAgY2xlYXJP ZmZzZXRGcm9tTG9naWNhbFRvcE9mRmlyc3RSZWdpb24oY3VycmVudEJveERlc2NlbmRhbnQpOwor ICAgIH0KIH0KIAogTGF5b3V0VW5pdCBSZW5kZXJGbG93VGhyZWFkOjpvZmZzZXRGcm9tTG9naWNh bFRvcE9mRmlyc3RSZWdpb24oY29uc3QgUmVuZGVyQmxvY2sqIGN1cnJlbnRCbG9jaykgY29uc3QK