117796 2013-06-19 06:24:46 -0700 [GTK] remove bashism from configure 2013-10-09 23:01:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 420+ All Other RESOLVED FIXED P3 Trivial --- 0 ajacoutot zan landry zan oldest_to_newest 901770 0 ajacoutot 2013-06-19 06:24:46 -0700 Hi. Would it be possible to use something like this in the configure script: - FREETYPE_CFLAGS+=" $HARFBUZZ_ICU_CFLAGS" - FREETYPE_LIBS+=" $HARFBUZZ_ICU_LIBS" + FREETYPE_CFLAGS="$FREETYPE_CFLAGS $HARFBUZZ_ICU_CFLAGS" + FREETYPE_LIBS="$FREETYPE_LIBS $HARFBUZZ_ICU_LIBS" On OpenBSD (and other BSDs for that matter), we don't use bash so the current construct breaks. Using FREETYPE_CFLAGS="$FREETYPE_CFLAGS ..." fixes it for me. Thanks. 902161 1 205094 zan 2013-06-20 08:39:20 -0700 Created attachment 205094 Patch 902234 2 205094 gustavo 2013-06-20 11:44:14 -0700 Comment on attachment 205094 Patch LGTM! 902268 3 205094 zan 2013-06-20 12:32:54 -0700 Comment on attachment 205094 Patch Clearing flags on attachment: 205094 Committed r151791: <http://trac.webkit.org/changeset/151791> 902269 4 zan 2013-06-20 12:32:59 -0700 All reviewed patches have been landed. Closing bug. 938216 5 zan 2013-10-09 23:01:50 -0700 *** Bug 111879 has been marked as a duplicate of this bug. *** 205094 2013-06-20 08:39:20 -0700 2013-06-20 12:32:54 -0700 Patch bug-117796-20130620083730.patch text/plain 3492 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTc3 NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2 LTIwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSByZW1vdmUgYmFzaGlzbSBmcm9tIGNvbmZpZ3VyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNp ZXMubTQ6IFBlcmZvcm0gc3RyaW5nIGFwcGVuZGluZyBieSByZWRlY2xhcmluZyB0aGUgYmFzZSBz dHJpbmcgdG8gdGhlIHZhbHVlCisgICAgICAgIG9mIHRoZSBiYXNlIHN0cmluZyBmb2xsb3dlZCBi eSB0aGUgc3RyaW5nIHRoYXQncyBiZWluZyBhcHBlbmRlZC4gVGhpcyByZXBsYWNlcyB0aGUgdXNl IG9mIHRoZSAnKz0nIG9wZXJhdG9yCisgICAgICAgIHRoYXQgd29ya3MgdW5kZXIgYmFzaCBidXQg aXMgbm90IHN1cHBvcnRlZCBieSBvdGhlciBzaGVsbHMuCisKIDIwMTMtMDYtMTggIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTQ3NjAyKTog U2VhcmNoIHRleHQgZmllbGQgZG9lc24ndCByZW5kZXIgc2VsZWN0aW9uIHdoZW4gaXQgaGFzIHNv bWUgOmZvY3VzIHJ1bGVzCkluZGV4OiBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMu bTQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CShy ZXZpc2lvbiAxNTE3NzUpCisrKyBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQJ KHdvcmtpbmcgY29weSkKQEAgLTM3OSw4ICszNzksOCBAQCBmaQogIyBTaW5jZSB3ZSBzdXBwb3J0 IGVhcmxpZXIgSGFyZkJ1enogdmVyc2lvbnMgd2Uga2VlcCB0aGlzIGNvbmRpdGlvbmFsIGZvciBu b3cuCiBpZiAkUEtHX0NPTkZJRyAtLWF0bGVhc3QtdmVyc2lvbiAwLjkuMTggaGFyZmJ1eno7IHRo ZW4KICAgICBQS0dfQ0hFQ0tfTU9EVUxFUyhIQVJGQlVaWl9JQ1UsIGhhcmZidXp6LWljdSA+PSAk aGFyZmJ1enpfcmVxdWlyZWRfdmVyc2lvbikKLSAgICBGUkVFVFlQRV9DRkxBR1MrPSIgJEhBUkZC VVpaX0lDVV9DRkxBR1MiCi0gICAgRlJFRVRZUEVfTElCUys9IiAkSEFSRkJVWlpfSUNVX0xJQlMi CisgICAgRlJFRVRZUEVfQ0ZMQUdTPSIkRlJFRVRZUEVfQ0ZMQUdTICRIQVJGQlVaWl9JQ1VfQ0ZM QUdTIgorICAgIEZSRUVUWVBFX0xJQlM9IiRGUkVFVFlQRV9MSUJTICRIQVJGQlVaWl9JQ1VfTElC UyIKIGZpCiBBQ19TVUJTVChbRlJFRVRZUEVfQ0ZMQUdTXSkKIEFDX1NVQlNUKFtGUkVFVFlQRV9M SUJTXSkKQEAgLTQ0OSwxOCArNDQ5LDE4IEBAIGZpCiAKIGlmIHRlc3QgIiR3aXRoX2FjY2VsZXJh dGlvbl9iYWNrZW5kIiA9ICJvcGVuZ2wiOyB0aGVuCiAgICAgaWYgdGVzdCAiJGVuYWJsZV9nbGVz MiIgPSAieWVzIjsgdGhlbgotICAgICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlv bis9IihnbGVzMiIKKyAgICAgICAgYWNjZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb249IiRh Y2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbiAoZ2xlczIiCiAgICAgICAgIE9QRU5HTF9M SUJTPSItbEdMRVN2MiIKICAgICBlbHNlCi0gICAgICAgIGFjY2VsZXJhdGlvbl9iYWNrZW5kX2Rl c2NyaXB0aW9uKz0iKGdsIgorICAgICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlv bj0iJGFjY2VsZXJhdGlvbl9iYWNrZW5kX2Rlc2NyaXB0aW9uIChnbCIKICAgICAgICAgT1BFTkdM X0xJQlM9Ii1sR0wiCiAgICAgZmkKICAgICBpZiB0ZXN0ICIkZW5hYmxlX2VnbCIgPSAieWVzIjsg dGhlbgotICAgICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbis9IiwgZWdsIgot ICAgICAgICBPUEVOR0xfTElCUys9IiAtbEVHTCIKKyAgICAgICAgYWNjZWxlcmF0aW9uX2JhY2tl bmRfZGVzY3JpcHRpb249IiRhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbiwgZWdsIgor ICAgICAgICBPUEVOR0xfTElCUz0iJE9QRU5HTF9MSUJTIC1sRUdMIgogICAgIGZpCiAgICAgaWYg dGVzdCAiJGVuYWJsZV9nbHgiID0gInllcyI7IHRoZW4KLSAgICAgICAgYWNjZWxlcmF0aW9uX2Jh Y2tlbmRfZGVzY3JpcHRpb24rPSIsIGdseCIKKyAgICAgICAgYWNjZWxlcmF0aW9uX2JhY2tlbmRf ZGVzY3JpcHRpb249IiRhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbiwgZ2x4IgogICAg IGZpCiAKICAgICAjIENoZWNrIHdoZXRoZXIgZGxvcGVuKCkgaXMgaW4gdGhlIGNvcmUgbGliYyBs aWtlIG9uIEZyZWVCU0QsIG9yIGluIGEgc2VwYXJhdGUKQEAgLTQ2OCw4ICs0NjgsOCBAQCBpZiB0 ZXN0ICIkd2l0aF9hY2NlbGVyYXRpb25fYmFja2VuZCIgPSAiCiAgICAgQUNfQ0hFQ0tfRlVOQyhb ZGxvcGVuXSwgW10sIFtBQ19DSEVDS19MSUIoW2RsXSwgW2Rsb3Blbl0sIFtETE9QRU5fTElCUz0i LWxkbCJdKV0pCiAgICAgQUNfU1VCU1QoW0RMT1BFTl9MSUJTXSkKIAotICAgIE9QRU5HTF9MSUJT Kz0iICRETE9QRU5fTElCUyIKLSAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbis9 IikiCisgICAgT1BFTkdMX0xJQlM9IiRPUEVOR0xfTElCUyAkRExPUEVOX0xJQlMiCisgICAgYWNj ZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb249IiRhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNj cmlwdGlvbikiCiBmaQogQUNfU1VCU1QoW09QRU5HTF9MSUJTXSkKIApAQCAtNDc3LDEwICs0Nzcs MTAgQEAgZW5hYmxlX2FjY2VsZXJhdGVkX2NhbnZhcz1ubwogaWYgdGVzdCAiJGVuYWJsZV9hY2Nl bGVyYXRlZF9jb21wb3NpdGluZyIgPSAieWVzIiAmJiB0ZXN0ICIkd2l0aF9hY2NlbGVyYXRpb25f YmFja2VuZCIgPSAib3BlbmdsIjsgdGhlbgogICAgIENBSVJPX0dMX0xJQlM9ImNhaXJvLWdsIgog ICAgIGlmIHRlc3QgIiRlbmFibGVfZ2x4IiA9ICJ5ZXMiOyB0aGVuCi0gICAgICAgIENBSVJPX0dM X0xJQlMrPSIgY2Fpcm8tZ2x4IgorICAgICAgICBDQUlST19HTF9MSUJTPSIkQ0FJUk9fR0xfTElC UyBjYWlyby1nbHgiCiAgICAgZmkKICAgICBpZiB0ZXN0ICIkZW5hYmxlX2VnbCIgPSAieWVzIjsg dGhlbgotICAgICAgICBDQUlST19HTF9MSUJTKz0iIGNhaXJvLWVnbCIKKyAgICAgICAgQ0FJUk9f R0xfTElCUz0iJENBSVJPX0dMX0xJQlMgY2Fpcm8tZWdsIgogICAgIGZpCiAKICAgICAjIEF0IHRo ZSBtb21lbnQgQ2Fpcm9HTCBkb2VzIG5vdCBhZGQgYW55IGV4dHJhIGNmbGFncyBhbmQgbGlicmFy aWVzLCBzbyB3ZSBjYW4K