117755 2013-06-18 14:23:43 -0700 Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector 2013-06-18 15:44:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 901510 0 joepeck 2013-06-18 14:23:43 -0700 I've been able to somewhat reliably reproduce an uncaught exception with debugger popovers: [Error] TypeError: 'undefined' is not a function (evaluating 'bestFrame.minX()') _update (Popover.js, line 228) present (Popover.js, line 117) _showPopover (SourceCodeTextEditor.js, line 982) _showPopoverForUndefined (SourceCodeTextEditor.js, line 1089) populate (SourceCodeTextEditor.js, line 952) populate dispatch (InspectorBackend.js, line 209) dispatchNextQueuedMessageFromBackend (Main.js, line 290) (anonymous function) I threw in some logging and caught what was happening: // Logging: console.log("FRAME", JSON.stringify(bestFrame), typeof bestFrame.minX); [Log] FRAME {"origin":{"x":427,"y":235},"size":{"width":83,"height":51}} function (Popover.js, line 229, x3) [Log] FRAME {"origin":{"x":427,"y":67},"size":{"width":83,"height":51}} function (Popover.js, line 229, x10) [Log] FRAME {"origin":{"x":0,"y":0},"size":{"width":0,"height":0}} undefined (Popover.js, line 229) // ERROR Because WebInspector.Rect.ZERO_RECT was constructed before we replace the WebInspector.Rect.prototype it didn't get the methods we expected it to have! js> WebInspector.Rect.ZERO_RECT instanceof WebInspector.Rect false 901514 1 webkit-bug-importer 2013-06-18 14:24:24 -0700 <rdar://problem/14194615> 901519 2 joepeck 2013-06-18 14:26:52 -0700 Doing a quick search through the code base, ZERO_SIZE and ZERO_RECT were the only 2 objects being initialized before we reassigned the prototype. There were only a few other objects, all safe. shell> ack '^WebInsp.*?= new' Geometry.js 87:WebInspector.Size.ZERO_SIZE = new WebInspector.Size(0, 0); 178:WebInspector.Rect.ZERO_RECT = new WebInspector.Rect(0, 0, 0, 0); Object.js 235:WebInspector.notifications = new WebInspector.Object; Popover.js 56:WebInspector.Popover.AnchorSize = new WebInspector.Size(22, 11); 57:WebInspector.Popover.ShadowEdgeInsets = new WebInspector.EdgeInsets(WebInspector.Popover.ShadowPadding); 901520 3 webkit-bug-importer 2013-06-18 14:27:16 -0700 <rdar://problem/14194674> 901522 4 joepeck 2013-06-18 14:28:10 -0700 Also the only non-WebInspector namespaced object (InspectorBackend) was correct. 901551 5 204948 joepeck 2013-06-18 15:23:53 -0700 Created attachment 204948 [PATCH] Proposed Fix 901563 6 204948 commit-queue 2013-06-18 15:44:46 -0700 Comment on attachment 204948 [PATCH] Proposed Fix Clearing flags on attachment: 204948 Committed r151704: <http://trac.webkit.org/changeset/151704> 901564 7 commit-queue 2013-06-18 15:44:48 -0700 All reviewed patches have been landed. Closing bug. 204948 2013-06-18 15:23:53 -0700 2013-06-18 15:44:45 -0700 [PATCH] Proposed Fix popover-debug.patch text/plain 6533 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMzNmU5ZDUuLjZiNGRmZGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW5mcmVx dWVudCB1bmNhdWdodCBleGNlcHRpb24gd2l0aCBkZWJ1Z2dlciBwb3BvdmVycyBicmVha3MgaW5z cGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTc3NTUKKworICAgICAgICBDcmVhdGUgdGhlIFpFUk9fU0laRSBhbmQgWkVST19SRUNUIG9iamVj dHMgYWZ0ZXIgd2UndmUgc2V0dXAgdGhlIFNpemUKKyAgICAgICAgYW5kIFJlY3QgcHJvdG90eXBl cywgc28gdGhleSBnZXQgdGhlIGV4cGVjdGVkIG1ldGhvZHMuIFdlIHRoZW4gbmVlZCB0bworICAg ICAgICBoYW5kbGUgdGhlIFpFUk9fUkVDVCBjYXNlIGJldHRlciwgYW5kIG5vdCBhdHRlbXB0IHRv IGRyYXcgYSBiYWNrZ3JvdW5kCisgICAgICAgIGluIGEgY2FudmFzIHdpdGggYSAwIHNpemUsIHdo aWNoIHdvdWxkIHByb2R1Y2UgYW4gZXhjZXB0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9HZW9tZXRyeS5qczoKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1BvcG92ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu UG9wb3Zlci5wcm90b3R5cGUuX3VwZGF0ZSk6CisKIDIwMTMtMDYtMTMgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8x MTc2MTU+IFdlYiBJbnNwZWN0b3I6IEpTIFByZXR0eVByaW50aW5nIFNob3VsZCBoYXZlIHNwYWNl IGJldHdlZW4gImRvIiBhbmQgInsiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9HZW9tZXRyeS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0dlb21ldHJ5LmpzCmluZGV4IDAzZmYyYjYuLmFiYWJiMjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0dlb21ldHJ5LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0dlb21ldHJ5LmpzCkBAIC02NSw4ICs2NSw2 IEBAIFdlYkluc3BlY3Rvci5TaXplID0gZnVuY3Rpb24od2lkdGgsIGhlaWdodCkKICAgICB0aGlz LmhlaWdodCA9IGhlaWdodCB8fCAwOwogfTsKIAotV2ViSW5zcGVjdG9yLlNpemUuWkVST19TSVpF ID0gbmV3IFdlYkluc3BlY3Rvci5TaXplKDAsIDApOwotCiBXZWJJbnNwZWN0b3IuU2l6ZS5wcm90 b3R5cGUgPSB7CiAgICAgY29uc3RydWN0b3I6IFdlYkluc3BlY3Rvci5TaXplLAogCkBAIC04Niwx NCArODQsMTUgQEAgV2ViSW5zcGVjdG9yLlNpemUucHJvdG90eXBlID0gewogICAgIH0KIH07CiAK K1dlYkluc3BlY3Rvci5TaXplLlpFUk9fU0laRSA9IG5ldyBXZWJJbnNwZWN0b3IuU2l6ZSgwLCAw KTsKKworCiBXZWJJbnNwZWN0b3IuUmVjdCA9IGZ1bmN0aW9uKHgsIHksIHdpZHRoLCBoZWlnaHQp CiB7CiAgICAgdGhpcy5vcmlnaW4gPSBuZXcgV2ViSW5zcGVjdG9yLlBvaW50KHggfHwgMCwgeSB8 fCAwKTsKICAgICB0aGlzLnNpemUgPSBuZXcgV2ViSW5zcGVjdG9yLlNpemUod2lkdGggfHwgMCwg aGVpZ2h0IHx8IDApOwogfTsKIAotV2ViSW5zcGVjdG9yLlJlY3QuWkVST19SRUNUID0gbmV3IFdl Ykluc3BlY3Rvci5SZWN0KDAsIDAsIDAsIDApOwotCiBXZWJJbnNwZWN0b3IuUmVjdC5yZWN0RnJv bUNsaWVudFJlY3QgPSBmdW5jdGlvbihjbGllbnRSZWN0KQogewogICAgIHJldHVybiBuZXcgV2Vi SW5zcGVjdG9yLlJlY3QoY2xpZW50UmVjdC5sZWZ0LCBjbGllbnRSZWN0LnRvcCwgY2xpZW50UmVj dC53aWR0aCwgY2xpZW50UmVjdC5oZWlnaHQpOwpAQCAtMTc2LDYgKzE3NSw5IEBAIFdlYkluc3Bl Y3Rvci5SZWN0LnByb3RvdHlwZSA9IHsKICAgICB9CiB9OwogCitXZWJJbnNwZWN0b3IuUmVjdC5a RVJPX1JFQ1QgPSBuZXcgV2ViSW5zcGVjdG9yLlJlY3QoMCwgMCwgMCwgMCk7CisKKwogV2ViSW5z cGVjdG9yLkVkZ2VJbnNldHMgPSBmdW5jdGlvbih0b3AsIHJpZ2h0LCBib3R0b20sIGxlZnQpCiB7 CiAgICAgY29uc29sZS5hc3NlcnQoYXJndW1lbnRzLmxlbmd0aCA9PT0gMSB8fCBhcmd1bWVudHMu bGVuZ3RoID09PSA0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1BvcG92ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Q b3BvdmVyLmpzCmluZGV4IGI1OGIwZjQuLmNmNDM1YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1BvcG92ZXIuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvUG9wb3Zlci5qcwpAQCAtMjE3LDM3ICsyMTcsNDMgQEAgV2Vi SW5zcGVjdG9yLlBvcG92ZXIucHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciBhbmNob3JQb2lu dDsKICAgICAgICAgdmFyIGJlc3RGcmFtZSA9IGJlc3RNZXRyaWNzLmZyYW1lOwotICAgICAgICBz d2l0Y2ggKGJlc3RFZGdlKSB7Ci0gICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlJlY3RFZGdlLk1J Tl9YOiAvLyBEaXNwbGF5ZWQgb24gdGhlIGxlZnQgb2YgdGhlIHRhcmdldCwgYXJyb3cgcG9pbnRz IHJpZ2h0LgotICAgICAgICAgICAgYW5jaG9yUG9pbnQgPSBuZXcgV2ViSW5zcGVjdG9yLlBvaW50 KGJlc3RGcmFtZS5zaXplLndpZHRoIC0gV2ViSW5zcGVjdG9yLlBvcG92ZXIuU2hhZG93UGFkZGlu ZywgdGFyZ2V0RnJhbWUubWlkWSgpIC0gYmVzdEZyYW1lLm1pblkoKSk7Ci0gICAgICAgICAgICBi cmVhazsKLSAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuUmVjdEVkZ2UuTUFYX1g6IC8vIERpc3Bs YXllZCBvbiB0aGUgcmlnaHQgb2YgdGhlIHRhcmdldCwgYXJyb3cgcG9pbnRzIGxlZnQuCi0gICAg ICAgICAgICBhbmNob3JQb2ludCA9IG5ldyBXZWJJbnNwZWN0b3IuUG9pbnQoV2ViSW5zcGVjdG9y LlBvcG92ZXIuU2hhZG93UGFkZGluZywgdGFyZ2V0RnJhbWUubWlkWSgpIC0gYmVzdEZyYW1lLm1p blkoKSk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuUmVj dEVkZ2UuTUlOX1k6IC8vIERpc3BsYXllZCBhYm92ZSB0aGUgdGFyZ2V0LCBhcnJvdyBwb2ludHMg ZG93bi4KLSAgICAgICAgICAgIGFuY2hvclBvaW50ID0gbmV3IFdlYkluc3BlY3Rvci5Qb2ludCh0 YXJnZXRGcmFtZS5taWRYKCkgLSBiZXN0RnJhbWUubWluWCgpLCBiZXN0RnJhbWUuc2l6ZS5oZWln aHQgLSBXZWJJbnNwZWN0b3IuUG9wb3Zlci5TaGFkb3dQYWRkaW5nKTsKLSAgICAgICAgICAgIGJy ZWFrOwotICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5SZWN0RWRnZS5NQVhfWTogLy8gRGlzcGxh eWVkIGJlbG93IHRoZSB0YXJnZXQsIGFycm93IHBvaW50cyB1cC4KLSAgICAgICAgICAgIGFuY2hv clBvaW50ID0gbmV3IFdlYkluc3BlY3Rvci5Qb2ludCh0YXJnZXRGcmFtZS5taWRYKCkgLSBiZXN0 RnJhbWUubWluWCgpLCBXZWJJbnNwZWN0b3IuUG9wb3Zlci5TaGFkb3dQYWRkaW5nKTsKLSAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICB9CiAKICAgICAgICAgdmFyIG5lZWRzVG9EcmF3QmFja2dy b3VuZCA9ICF0aGlzLl9mcmFtZS5zaXplLmVxdWFscyhiZXN0RnJhbWUuc2l6ZSkgfHwgdGhpcy5f ZWRnZSAhPT0gYmVzdEVkZ2U7CiAKICAgICAgICAgdGhpcy5mcmFtZSA9IGJlc3RGcmFtZTsKICAg ICAgICAgdGhpcy5fZWRnZSA9IGJlc3RFZGdlOwogCi0gICAgICAgIHRoaXMuX2VsZW1lbnQuY2xh c3NMaXN0LmFkZCh0aGlzLl9jc3NDbGFzc05hbWVGb3JFZGdlKCkpOworICAgICAgICBpZiAodGhp cy5mcmFtZSA9PT0gV2ViSW5zcGVjdG9yLlJlY3QuWkVST19SRUNUKSB7CisgICAgICAgICAgICAv LyBUaGUgdGFyZ2V0IGZvciB0aGUgcG9wb3ZlciBpcyBvZmZzY3JlZW4uCisgICAgICAgICAgICB0 aGlzLmRpc21pc3MoKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHN3aXRjaCAoYmVz dEVkZ2UpIHsKKyAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlJlY3RFZGdlLk1JTl9YOiAv LyBEaXNwbGF5ZWQgb24gdGhlIGxlZnQgb2YgdGhlIHRhcmdldCwgYXJyb3cgcG9pbnRzIHJpZ2h0 LgorICAgICAgICAgICAgICAgIGFuY2hvclBvaW50ID0gbmV3IFdlYkluc3BlY3Rvci5Qb2ludChi ZXN0RnJhbWUuc2l6ZS53aWR0aCAtIFdlYkluc3BlY3Rvci5Qb3BvdmVyLlNoYWRvd1BhZGRpbmcs IHRhcmdldEZyYW1lLm1pZFkoKSAtIGJlc3RGcmFtZS5taW5ZKCkpOworICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuUmVjdEVkZ2UuTUFYX1g6IC8v IERpc3BsYXllZCBvbiB0aGUgcmlnaHQgb2YgdGhlIHRhcmdldCwgYXJyb3cgcG9pbnRzIGxlZnQu CisgICAgICAgICAgICAgICAgYW5jaG9yUG9pbnQgPSBuZXcgV2ViSW5zcGVjdG9yLlBvaW50KFdl Ykluc3BlY3Rvci5Qb3BvdmVyLlNoYWRvd1BhZGRpbmcsIHRhcmdldEZyYW1lLm1pZFkoKSAtIGJl c3RGcmFtZS5taW5ZKCkpOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2Fz ZSBXZWJJbnNwZWN0b3IuUmVjdEVkZ2UuTUlOX1k6IC8vIERpc3BsYXllZCBhYm92ZSB0aGUgdGFy Z2V0LCBhcnJvdyBwb2ludHMgZG93bi4KKyAgICAgICAgICAgICAgICBhbmNob3JQb2ludCA9IG5l dyBXZWJJbnNwZWN0b3IuUG9pbnQodGFyZ2V0RnJhbWUubWlkWCgpIC0gYmVzdEZyYW1lLm1pblgo KSwgYmVzdEZyYW1lLnNpemUuaGVpZ2h0IC0gV2ViSW5zcGVjdG9yLlBvcG92ZXIuU2hhZG93UGFk ZGluZyk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIFdlYkluc3Bl Y3Rvci5SZWN0RWRnZS5NQVhfWTogLy8gRGlzcGxheWVkIGJlbG93IHRoZSB0YXJnZXQsIGFycm93 IHBvaW50cyB1cC4KKyAgICAgICAgICAgICAgICBhbmNob3JQb2ludCA9IG5ldyBXZWJJbnNwZWN0 b3IuUG9pbnQodGFyZ2V0RnJhbWUubWlkWCgpIC0gYmVzdEZyYW1lLm1pblgoKSwgV2ViSW5zcGVj dG9yLlBvcG92ZXIuU2hhZG93UGFkZGluZyk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB9CiAKLSAgICAgICAgaWYgKG5lZWRzVG9EcmF3QmFja2dyb3VuZCkKLSAgICAgICAg ICAgIHRoaXMuX2RyYXdCYWNrZ3JvdW5kKGJlc3RFZGdlLCBhbmNob3JQb2ludCk7CisgICAgICAg ICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC5hZGQodGhpcy5fY3NzQ2xhc3NOYW1lRm9yRWRn ZSgpKTsKKworICAgICAgICAgICAgaWYgKG5lZWRzVG9EcmF3QmFja2dyb3VuZCkKKyAgICAgICAg ICAgICAgICB0aGlzLl9kcmF3QmFja2dyb3VuZChiZXN0RWRnZSwgYW5jaG9yUG9pbnQpOworCisg ICAgICAgICAgICAvLyBNYWtlIHN1cmUgY29udGVudCBpcyBjZW50ZXJlZCBpbiBjYXNlIGVpdGhl ciBvZiB0aGUgZGltZW5zaW9uIGlzIHNtYWxsZXIgdGhhbiB0aGUgbWluaW1hbCBib3VuZHMuCisg ICAgICAgICAgICBpZiAodGhpcy5fcHJlZmVycmVkU2l6ZS53aWR0aCA8IFdlYkluc3BlY3Rvci5Q b3BvdmVyLk1pbldpZHRoIHx8IHRoaXMuX3ByZWZlcnJlZFNpemUuaGVpZ2h0IDwgV2ViSW5zcGVj dG9yLlBvcG92ZXIuTWluSGVpZ2h0KQorICAgICAgICAgICAgICAgIHRoaXMuX2NvbnRhaW5lci5j bGFzc0xpc3QuYWRkKCJjZW50ZXIiKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAg ICB0aGlzLl9jb250YWluZXIuY2xhc3NMaXN0LnJlbW92ZSgiY2VudGVyIik7CisgICAgICAgIH0K IAotICAgICAgICAvLyBNYWtlIHN1cmUgY29udGVudCBpcyBjZW50ZXJlZCBpbiBjYXNlIGVpdGhl ciBvZiB0aGUgZGltZW5zaW9uIGlzIHNtYWxsZXIgdGhhbiB0aGUgbWluaW1hbCBib3VuZHMuCi0g ICAgICAgIGlmICh0aGlzLl9wcmVmZXJyZWRTaXplLndpZHRoIDwgV2ViSW5zcGVjdG9yLlBvcG92 ZXIuTWluV2lkdGggfHwgdGhpcy5fcHJlZmVycmVkU2l6ZS5oZWlnaHQgPCBXZWJJbnNwZWN0b3Iu UG9wb3Zlci5NaW5IZWlnaHQpCi0gICAgICAgICAgICB0aGlzLl9jb250YWluZXIuY2xhc3NMaXN0 LmFkZCgiY2VudGVyIik7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHRoaXMuX2NvbnRhaW5l ci5jbGFzc0xpc3QucmVtb3ZlKCJjZW50ZXIiKTsKLSAgICAgICAgCiAgICAgICAgIC8vIFdyYXAg dGhlIGNvbnRlbnQgaW4gdGhlIGNvbnRhaW5lciBzbyB0aGF0IGl0J3MgbG9jYXRlZCBjb3JyZWN0 bHkuCiAgICAgICAgIGlmICh0aGlzLl9jb250ZW50TmVlZHNVcGRhdGUpIHsKICAgICAgICAgICAg IHRoaXMuX2NvbnRhaW5lci50ZXh0Q29udGVudCA9ICIiOwo=