117746 2013-06-18 12:01:13 -0700 Web Inspector: REGRESSION: Attempting to select a breakpoint in the Debugger sidebar selects the Resource 2013-06-20 06:18:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 timothy timothy graouts joepeck timothy webkit-bug-importer oldest_to_newest 901467 0 timothy 2013-06-18 12:01:13 -0700 I think this is a recent regression related to tieing ContentViews with particular Sidebars. Following the steps to reproduce I select a breakpoint and I would expect that breakpoint to be selected after the click. Instead the inspector makes the resource the breakpoint belongs to selected. Steps: 1. Inspect <http://pecoraro.apple.com/source-map-tests/reasonable-example/> 2. Set a breakpoint in SourceMapResource script-1.js:14 3. Switch to the Debugger sidebar 4. Reload the page => content view switches to the DOM content view, I'd expect it to keep showing the Script 5. Select the Breakpoint => sidebar selects the script resource instead of the breakpoint I just clicked on <rdar://problem/14090263> 901469 1 204928 timothy 2013-06-18 12:14:51 -0700 Created attachment 204928 Patch 901471 2 204928 joepeck 2013-06-18 12:20:37 -0700 Comment on attachment 204928 Patch r=me. Seems a little obtuse, but it looks fine to me. 902115 3 timothy 2013-06-20 06:18:32 -0700 http://trac.webkit.org/changeset/151688 204928 2013-06-18 12:14:51 -0700 2013-06-18 12:20:37 -0700 Patch bug-117746-20130618151304.patch text/plain 3102 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 MDY1NzAxMTVmNzZlN2RmYmY1ZTljMzA4ZWE5Y2VjMDhmYjViNjgwLi4xODUzNjQyNjU1NTRiZWMx ODNkYzdiMDc0OTRjZjFlYWFkOTBkZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxMy0wNi0xOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgSWYgdGhlIHRyZWUgb3V0bGluZSBpcyBwcm9jZXNzaW5nIGEgc2VsZWN0 aW9uIGN1cnJlbnRseSwgdGhlbiBkb24ndCBjaGFuZ2UgdGhlIHNlbGVjdGlvbi4KKworICAgICAg ICBUaGlzIGlzIG5lZWRlZCB0byBhbGxvdyBicmVha3BvaW50cyB0cmVlIGVsZW1lbnRzIHRvIGJl IHNlbGVjdGVkIHdpdGhvdXQganVtcGluZyBiYWNrIHRvCisgICAgICAgIHNlbGVjdGluZyB0aGUg cmVzb3VyY2UgdHJlZSBlbGVtZW50LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc3NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTWFpbi5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5fcmV2ZWFsQW5kU2VsZWN0UmVwcmVzZW50ZWRPYmplY3RJbk5hdmlnYXRpb25TaWRl YmFyKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAo VHJlZUVsZW1lbnQucHJvdG90eXBlLnNlbGVjdCk6CisKKzIwMTMtMDYtMTggIFRpbW90aHkgSGF0 Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIFVwZGF0ZSBicmVha3BvaW50cyB0 byBtYXRjaCBYY29kZSA1LgogCiAgICAgICAgIFRoaXMgdXBkYXRlcyB0aGUgYnJlYWtwb2ludCBp bWFnZXMsIGxpbmUgY29sb3JzLCBhbmQgbW92ZXMgYnJlYWtwb2ludHMgdG9nZ2xlIGJ1dHRvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKaW5kZXggODRjZjZi YmI2NjkyZTI5NTE2ZDBiZWVkMGM2ZjIzYTY2MWE0MmIzOC4uNjEzYTU1NmE1MDE2YzI1ZWI0NTFi NGI0NDVhMzQzMDQ0YjQwODQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9NYWluLmpzCkBAIC04MjcsNiArODI3LDEzIEBAIFdlYkluc3BlY3Rvci5fcmV2ZWFsQW5k U2VsZWN0UmVwcmVzZW50ZWRPYmplY3RJbk5hdmlnYXRpb25TaWRlYmFyID0gZnVuY3Rpb24ocmVw CiAgICAgICAgIHJldHVybjsKIAogICAgIHZhciBzZWxlY3RlZFNpZGViYXJQYW5lbCA9IHRoaXMu bmF2aWdhdGlvblNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWw7CisKKyAgICAvLyBJZiB0aGUg dHJlZSBvdXRsaW5lIGlzIHByb2Nlc3NpbmcgYSBzZWxlY3Rpb24gY3VycmVudGx5IHRoZW4gd2Ug Y2FuIGFzc3VtZSB0aGUgc2VsZWN0aW9uIGRvZXMgbm90CisgICAgLy8gbmVlZCB0byBiZSBjaGFu Z2VkLiBUaGlzIGlzIG5lZWRlZCB0byBhbGxvdyBicmVha3BvaW50cyB0cmVlIGVsZW1lbnRzIHRv IGJlIHNlbGVjdGVkIHdpdGhvdXQganVtcGluZworICAgIC8vIGJhY2sgdG8gc2VsZWN0aW5nIHRo ZSByZXNvdXJjZSB0cmVlIGVsZW1lbnQuCisgICAgaWYgKHNlbGVjdGVkU2lkZWJhclBhbmVsLmNv bnRlbnRUcmVlT3V0bGluZS5wcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdlKQorICAgICAgICByZXR1 cm47CisKICAgICB2YXIgdHJlZUVsZW1lbnQgPSBzZWxlY3RlZFNpZGViYXJQYW5lbC50cmVlRWxl bWVudEZvclJlcHJlc2VudGVkT2JqZWN0KHJlcHJlc2VudGVkT2JqZWN0KTsKICAgICBpZiAodHJl ZUVsZW1lbnQpCiAgICAgICAgIHRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVjdCh0cnVlLCBmYWxz ZSwgdHJ1ZSwgdHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1RyZWVPdXRsaW5lLmpzCmluZGV4IDA1NzY2M2ZlODU4ZDU2NTQ2MzE1YzYxYTI1NGIwYWE3 NTQ4OTBmZTYuLjA0OGNkNWIwMzI4OWVmZTJhNjk3MTYyNzFkYjJjMzAzYjBhOWQ0ODUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1RyZWVPdXRsaW5lLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1RyZWVPdXRsaW5lLmpz CkBAIC05NDksNiArOTQ5LDggQEAgVHJlZUVsZW1lbnQucHJvdG90eXBlLnNlbGVjdCA9IGZ1bmN0 aW9uKG9taXRGb2N1cywgc2VsZWN0ZWRCeVVzZXIsIHN1cHByZXNzT25TZWwKICAgICBpZiAoIXRo aXMudHJlZU91dGxpbmUpCiAgICAgICAgIHJldHVybjsKIAorICAgIHRoaXMudHJlZU91dGxpbmUu cHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZSA9IHRydWU7CisKICAgICBpZiAoIXRoaXMuc2VsZWN0 ZWQpIHsKICAgICAgICAgaWYgKHRoaXMudHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCkK ICAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudC5kZXNlbGVj dChzdXBwcmVzc09uRGVzZWxlY3QpOwpAQCAtOTY1LDYgKzk2Nyw4IEBAIFRyZWVFbGVtZW50LnBy b3RvdHlwZS5zZWxlY3QgPSBmdW5jdGlvbihvbWl0Rm9jdXMsIHNlbGVjdGVkQnlVc2VyLCBzdXBw cmVzc09uU2VsCiAKICAgICBpZiAodGhpcy50cmVlT3V0bGluZS5vbnNlbGVjdCAmJiAhc3VwcHJl c3NPblNlbGVjdCkKICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5vbnNlbGVjdCh0aGlzLCBzZWxl Y3RlZEJ5VXNlcik7CisKKyAgICBkZWxldGUgdGhpcy50cmVlT3V0bGluZS5wcm9jZXNzaW5nU2Vs ZWN0aW9uQ2hhbmdlOwogfQogCiAvKioK