117719 2013-06-17 16:14:10 -0700 FTL: Add another temp register regT4 to JSInterfaceJIT 2013-06-17 16:50:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 116888 117102 1 msaboff msaboff fpizlo ggaren mark.lam mhahnenberg oliver oldest_to_newest 901195 0 msaboff 2013-06-17 16:14:10 -0700 The arity fixup thunk as currently envisioned needs 5 temp registers. Other code may need another temp register as well. We can use bucketCounterRegister since its current use only really needs some entropy and that it isn't overwritten during value profiling. 901196 1 204865 msaboff 2013-06-17 16:18:23 -0700 Created attachment 204865 Patch 901197 2 204865 ggaren 2013-06-17 16:24:55 -0700 Comment on attachment 204865 Patch You should also make the emitValueProfilingSite() callers pass the scratch register (regT4) to emitValueProfilingSite(). That way, it will be clear if an opcode allocates regT4 for two uses. 901198 3 msaboff 2013-06-17 16:25:39 -0700 (In reply to comment #2) > (From update of attachment 204865 [details]) > You should also make the emitValueProfilingSite() callers pass the scratch register (regT4) to emitValueProfilingSite(). That way, it will be clear if an opcode allocates regT4 for two uses. Will do. 901202 4 msaboff 2013-06-17 16:50:43 -0700 Committed r151658: <http://trac.webkit.org/changeset/151658> 204865 2013-06-17 16:18:23 -0700 2013-06-17 16:24:54 -0700 Patch 117719.patch text/plain 5778 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxNjU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTA2LTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEZUTDogQWRkIGFub3RoZXIgdGVtcCByZWdpc3RlciByZWdUNCB0byBKU0ludGVyZmFjZUpJ VAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NzE5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFkZSB0 aGUgZGVkaWNhdGVkIGJ1Y2tldENvdW50ZXJSZWdpc3RlciB0byBiZSByZWdUNCBhbmQgdGhlbiB1 c2VkIHJlZ1Q0IHdoZXJldmVyCisgICAgICAgIGJ1Y2tldENvdW50ZXJSZWdpc3RlciBoYWQgYmVl biB1c2VkLiAgU2luY2UgaXQgaXMgbWFza2VkIHdoZW5ldmVyIGl0IGlzIHVzZWQgYW5kCisgICAg ICAgIHdlIGFyZSBsb29raW5nIGZvciBzb21lIHJhbmRvbW5lc3MgaW4gdGhlIHJlZ2lzdGVyIGFu eXdheSwgd2UgY2FuIHVzZSBpdCB3aXRob3V0CisgICAgICAgIGFueSBpc3N1ZXMuCisKKyAgICAg ICAgKiBqaXQvSklUSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRWYWx1ZVByb2Zp bGluZ1NpdGUpOgorICAgICAgICAqIGppdC9KU0ludGVyZmFjZUpJVC5oOgorICAgICAgICAoSlNJ bnRlcmZhY2VKSVQpOgorCiAyMDEzLTA2LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBSb2xsaW5nIHIxNTE0NTYsIHIxNTE0MjAgYmFjayBpbiB3aXRoIHNvbWUg Zml4ZXMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAkocmV2aXNp b24gMTUxNTc2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgJKHdv cmtpbmcgY29weSkKQEAgLTM1NywxNiArMzU3LDE2IEBAIGlubGluZSB2b2lkIEpJVDo6ZW1pdFZh bHVlUHJvZmlsaW5nU2l0ZSgKICAgICB9CiAgICAgCiAgICAgaWYgKG1fcmFuZG9tR2VuZXJhdG9y LmdldFVpbnQzMigpICYgMSkKLSAgICAgICAgYWRkMzIoVHJ1c3RlZEltbTMyKDEpLCBidWNrZXRD b3VudGVyUmVnaXN0ZXIpOworICAgICAgICBhZGQzMihUcnVzdGVkSW1tMzIoMSksIHJlZ1Q0KTsK ICAgICBlbHNlCi0gICAgICAgIGFkZDMyKFRydXN0ZWRJbW0zMigzKSwgYnVja2V0Q291bnRlclJl Z2lzdGVyKTsKLSAgICBhbmQzMihUcnVzdGVkSW1tMzIoVmFsdWVQcm9maWxlOjpidWNrZXRJbmRl eE1hc2spLCBidWNrZXRDb3VudGVyUmVnaXN0ZXIpOworICAgICAgICBhZGQzMihUcnVzdGVkSW1t MzIoMyksIHJlZ1Q0KTsKKyAgICBhbmQzMihUcnVzdGVkSW1tMzIoVmFsdWVQcm9maWxlOjpidWNr ZXRJbmRleE1hc2spLCByZWdUNCk7CiAgICAgbW92ZShUcnVzdGVkSW1tUHRyKHZhbHVlUHJvZmls ZS0+bV9idWNrZXRzKSwgc2NyYXRjaCk7CiAjaWYgVVNFKEpTVkFMVUU2NCkKLSAgICBzdG9yZTY0 KHZhbHVlLCBCYXNlSW5kZXgoc2NyYXRjaCwgYnVja2V0Q291bnRlclJlZ2lzdGVyLCBUaW1lc0Vp Z2h0KSk7CisgICAgc3RvcmU2NCh2YWx1ZSwgQmFzZUluZGV4KHNjcmF0Y2gsIHJlZ1Q0LCBUaW1l c0VpZ2h0KSk7CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQotICAgIHN0b3JlMzIodmFsdWUsIEJh c2VJbmRleChzY3JhdGNoLCBidWNrZXRDb3VudGVyUmVnaXN0ZXIsIFRpbWVzRWlnaHQsIE9CSkVD VF9PRkZTRVRPRihKU1ZhbHVlLCB1LmFzQml0cy5wYXlsb2FkKSkpOwotICAgIHN0b3JlMzIodmFs dWVUYWcsIEJhc2VJbmRleChzY3JhdGNoLCBidWNrZXRDb3VudGVyUmVnaXN0ZXIsIFRpbWVzRWln aHQsIE9CSkVDVF9PRkZTRVRPRihKU1ZhbHVlLCB1LmFzQml0cy50YWcpKSk7CisgICAgc3RvcmUz Mih2YWx1ZSwgQmFzZUluZGV4KHNjcmF0Y2gsIHJlZ1Q0LCBUaW1lc0VpZ2h0LCBPQkpFQ1RfT0ZG U0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMucGF5bG9hZCkpKTsKKyAgICBzdG9yZTMyKHZhbHVlVGFn LCBCYXNlSW5kZXgoc2NyYXRjaCwgcmVnVDQsIFRpbWVzRWlnaHQsIE9CSkVDVF9PRkZTRVRPRihK U1ZhbHVlLCB1LmFzQml0cy50YWcpKSk7CiAjZW5kaWYKIH0KIApJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KU0ludGVyZmFjZUpJVC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaAkocmV2aXNpb24gMTUxNTc2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KU0ludGVyZmFjZUpJVC5oCSh3b3JraW5nIGNvcHkpCkBA IC02NSwxMCArNjUsNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgc3RhdGljIGNvbnN0IFJl Z2lzdGVySUQgc2Vjb25kQXJndW1lbnRSZWdpc3RlciA9IFg4NlJlZ2lzdGVyczo6ZWR4OwogI2Vu ZGlmCiAKLSNpZiBFTkFCTEUoVkFMVUVfUFJPRklMRVIpCi0gICAgICAgIHN0YXRpYyBjb25zdCBS ZWdpc3RlcklEIGJ1Y2tldENvdW50ZXJSZWdpc3RlciA9IFg4NlJlZ2lzdGVyczo6cjEwOwotI2Vu ZGlmCi0KICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgY2FsbEZyYW1lUmVnaXN0ZXIg PSBYODZSZWdpc3RlcnM6OnIxMzsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgdGFn VHlwZU51bWJlclJlZ2lzdGVyID0gWDg2UmVnaXN0ZXJzOjpyMTQ7CiAgICAgICAgIHN0YXRpYyBj b25zdCBSZWdpc3RlcklEIHRhZ01hc2tSZWdpc3RlciA9IFg4NlJlZ2lzdGVyczo6cjE1OwpAQCAt NzcsNiArNzMsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lz dGVySUQgcmVnVDEgPSBYODZSZWdpc3RlcnM6OmVkeDsKICAgICAgICAgc3RhdGljIGNvbnN0IFJl Z2lzdGVySUQgcmVnVDIgPSBYODZSZWdpc3RlcnM6OmVjeDsKICAgICAgICAgc3RhdGljIGNvbnN0 IFJlZ2lzdGVySUQgcmVnVDMgPSBYODZSZWdpc3RlcnM6OmVieDsKKyAgICAgICAgc3RhdGljIGNv bnN0IFJlZ2lzdGVySUQgcmVnVDQgPSBYODZSZWdpc3RlcnM6OnIxMDsKIAogICAgICAgICBzdGF0 aWMgY29uc3QgRlBSZWdpc3RlcklEIGZwUmVnVDAgPSBYODZSZWdpc3RlcnM6OnhtbTA7CiAgICAg ICAgIHN0YXRpYyBjb25zdCBGUFJlZ2lzdGVySUQgZnBSZWdUMSA9IFg4NlJlZ2lzdGVyczo6eG1t MTsKQEAgLTkyLDEzICs4OSwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgc3RhdGljIGNv bnN0IFJlZ2lzdGVySUQgZmlyc3RBcmd1bWVudFJlZ2lzdGVyID0gWDg2UmVnaXN0ZXJzOjplY3g7 CiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHNlY29uZEFyZ3VtZW50UmVnaXN0ZXIg PSBYODZSZWdpc3RlcnM6OmVkeDsKICAgICAgICAgCi0gICAgICAgIHN0YXRpYyBjb25zdCBSZWdp c3RlcklEIGJ1Y2tldENvdW50ZXJSZWdpc3RlciA9IFg4NlJlZ2lzdGVyczo6ZXNpOwogICAgICAg ICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCBjYWxsRnJhbWVSZWdpc3RlciA9IFg4NlJlZ2lzdGVy czo6ZWRpOwogICAgICAgICAKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDAg PSBYODZSZWdpc3RlcnM6OmVheDsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVn VDEgPSBYODZSZWdpc3RlcnM6OmVkeDsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQg cmVnVDIgPSBYODZSZWdpc3RlcnM6OmVjeDsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVy SUQgcmVnVDMgPSBYODZSZWdpc3RlcnM6OmVieDsKKyAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lz dGVySUQgcmVnVDQgPSBYODZSZWdpc3RlcnM6OmVzaTsKICAgICAgICAgCiAgICAgICAgIHN0YXRp YyBjb25zdCBGUFJlZ2lzdGVySUQgZnBSZWdUMCA9IFg4NlJlZ2lzdGVyczo6eG1tMDsKICAgICAg ICAgc3RhdGljIGNvbnN0IEZQUmVnaXN0ZXJJRCBmcFJlZ1QxID0gWDg2UmVnaXN0ZXJzOjp4bW0x OwpAQCAtMTExLDEzICsxMDgsMTMgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHN0YXRpYyBj b25zdCBSZWdpc3RlcklEIHNlY29uZEFyZ3VtZW50UmVnaXN0ZXIgPSBBUk1SZWdpc3RlcnM6OnIx OwogCiAjaWYgRU5BQkxFKFZBTFVFX1BST0ZJTEVSKQotICAgICAgICBzdGF0aWMgY29uc3QgUmVn aXN0ZXJJRCBidWNrZXRDb3VudGVyUmVnaXN0ZXIgPSBBUk1SZWdpc3RlcnM6OnI3OwogI2VuZGlm CiAKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDAgPSBBUk1SZWdpc3RlcnM6 OnIwOwogICAgICAgICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCByZWdUMSA9IEFSTVJlZ2lzdGVy czo6cjE7CiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1QyID0gQVJNUmVnaXN0 ZXJzOjpyMjsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDMgPSBBUk1SZWdp c3RlcnM6OnI0OworICAgICAgICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCByZWdUNCA9IEFSTVJl Z2lzdGVyczo6cjc7CiAKICAgICAgICAgLy8gVXBkYXRlIGN0aVRyYW1wb2xpbmUgaW4gSklUU3R1 YnMuY3BwIGlmIHRoZXNlIHZhbHVlcyBhcmUgY2hhbmdlZCEKICAgICAgICAgc3RhdGljIGNvbnN0 IFJlZ2lzdGVySUQgY2FsbEZyYW1lUmVnaXN0ZXIgPSBBUk1SZWdpc3RlcnM6OnI1OwpAQCAtMTMy LDEwICsxMjksNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lz dGVySUQgZmlyc3RBcmd1bWVudFJlZ2lzdGVyID0gTUlQU1JlZ2lzdGVyczo6YTA7CiAgICAgICAg IHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHNlY29uZEFyZ3VtZW50UmVnaXN0ZXIgPSBNSVBTUmVn aXN0ZXJzOjphMTsKICAgICAgICAgCi0jaWYgRU5BQkxFKFZBTFVFX1BST0ZJTEVSKQotICAgICAg ICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCBidWNrZXRDb3VudGVyUmVnaXN0ZXIgPSBNSVBTUmVn aXN0ZXJzOjpzMzsKLSNlbmRpZgotCiAgICAgICAgIC8vIHJlZ1QwIG11c3QgYmUgdjAgZm9yIHJl dHVybmluZyBhIDMyLWJpdCB2YWx1ZS4KICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQg cmVnVDAgPSBNSVBTUmVnaXN0ZXJzOjp2MDsKICAgICAgICAgCkBAIC0xNDcsNiArMTQwLDggQEAg bmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIC8vIHJlZ1QzIG11c3QgYmUgc2F2ZWQgaW4gdGhlIGNh bGxlZSwgc28gdXNlIGFuIFMgcmVnaXN0ZXIuCiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3Rl cklEIHJlZ1QzID0gTUlQU1JlZ2lzdGVyczo6czI7CiAgICAgICAgIAorICAgICAgICBzdGF0aWMg Y29uc3QgUmVnaXN0ZXJJRCByZWdUNCA9IE1JUFNSZWdpc3RlcnM6OnMzOworCiAgICAgICAgIHN0 YXRpYyBjb25zdCBSZWdpc3RlcklEIGNhbGxGcmFtZVJlZ2lzdGVyID0gTUlQU1JlZ2lzdGVyczo6 czA7CiAgICAgICAgIAogICAgICAgICBzdGF0aWMgY29uc3QgRlBSZWdpc3RlcklEIGZwUmVnVDAg PSBNSVBTUmVnaXN0ZXJzOjpmNDsK