117711 2013-06-17 11:48:59 -0700 [CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt 2013-06-20 11:08:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ralpht+bugs webkit-unassigned commit-queue gyuyoung.kim paroga rakuco ralpht+bugs oldest_to_newest 901130 0 ralpht+bugs 2013-06-17 11:48:59 -0700 [CMake][CSS Shaders] Conditionally add WebCore files for CSS Shaders to CMakeLists.txt 901131 1 204845 ralpht+bugs 2013-06-17 11:51:44 -0700 Created attachment 204845 Patch 901409 2 204845 ralpht+bugs 2013-06-18 08:19:51 -0700 Comment on attachment 204845 Patch Since all of the files included are guarded with #if ENABLE(CSS_SHADERS) I can just add them to WebCore_SOURCES unconditionally -- I'll submit a new patch that does this later today. Thanks to Patrick Gansterer and Raphael Kubo da Costa for review. 901474 3 204929 ralpht+bugs 2013-06-18 12:27:44 -0700 Created attachment 204929 Patch 901477 4 ralpht+bugs 2013-06-18 12:37:32 -0700 New patch adds files to the build unconditionally, since they're all guarded with #if ENABLE(CSS_SHADERS). 902177 5 204929 laszlo.gombos 2013-06-20 09:09:56 -0700 Comment on attachment 204929 Patch r=me. 902219 6 204929 commit-queue 2013-06-20 11:08:10 -0700 Comment on attachment 204929 Patch Clearing flags on attachment: 204929 Committed r151784: <http://trac.webkit.org/changeset/151784> 902220 7 commit-queue 2013-06-20 11:08:14 -0700 All reviewed patches have been landed. Closing bug. 204845 2013-06-17 11:51:44 -0700 2013-06-18 08:19:51 -0700 Patch bug-117711-20130617114958.patch text/plain 1918 ralpht+bugs U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRiOTNiM2UwMDVkNzky MmMzM2U1ZTk5YThiNjI1MDhhZGM3ZjkyOC4uZmJiZmQ0N2M1YWQ1ZDVjZjgyMGNjODc3OGRhZDY0 NjA5ODEyM2NiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTE3ICBSYWxw aCBUaG9tYXMgIDxyYWxwaHRAZ21haWwuY29tPgorCisgICAgICAgIFtDTWFrZV1bQ1NTIFNoYWRl cnNdIENvbmRpdGlvbmFsbHkgYWRkIFdlYkNvcmUgZmlsZXMgZm9yIENTUyBTaGFkZXJzIHRvIENN YWtlTGlzdHMudHh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTc3MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIENNYWtlIHBsYXRmb3JtcyBjdXJyZW50bHkgZW5hYmxlIHRo aXMgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEzLTA2 LTE3ICBJZ29yIE9saXZlaXJhICA8aWdvci5vQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0NTUyBSZWdpb25zXSA6OmJlZm9yZSBhbmQgOjphZnRlciBwc2V1ZG8tZWxlbWVudHMgYXJlIG5v dCBkaXNwbGF5ZWQgZm9yIHJlZ2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtl TGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzg1YTZhNzFi N2UxYjk5MDM5ZmRlODcyZDUzNWUzYTIzMjEwNjRiMS4uZGEyYmM1YzMyMDQ3NTk1YWU0YWQ4OTU1 YTRhZTdiYTVjOGQ0MjkwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTI5MDksNiArMjkwOSwy MSBAQCBpZiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0QuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3 aW5nQnVmZmVyLmNwcAogICAgICkKKworICAgIGlmIChFTkFCTEVfQ1NTX1NIQURFUlMpCisgICAg ICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICAgICAgY3NzL1dlYktpdENT U0FycmF5RnVuY3Rpb25WYWx1ZS5jcHAKKyAgICAgICAgICAgIGNzcy9XZWJLaXRDU1NNYXRGdW5j dGlvblZhbHVlLmNwcAorICAgICAgICAgICAgY3NzL1dlYktpdENTU01peEZ1bmN0aW9uVmFsdWUu Y3BwCisgICAgICAgICAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDYWNoZWRTaGFkZXIuY3BwCisg ICAgICAgICAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDdXN0b21GaWx0ZXJQcm9ncmFtQ2FjaGUu Y3BwCisgICAgICAgICAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDdXN0b21GaWx0ZXJQcm9ncmFt LmNwcAorICAgICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJW YWxpZGF0ZWRQcm9ncmFtLmNwcAorICAgICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVy cy90ZXhtYXAvQ3VzdG9tRmlsdGVyVmFsaWRhdGVkUHJvZ3JhbVRleHR1cmVNYXBwZXIuY3BwCisg ICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlck1lc2guY3Bw CisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlck1lc2hH ZW5lcmF0b3IuY3BwCisgICAgICAgICkKKyAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAogc2V0KFdl YkNvcmVUZXN0U3VwcG9ydF9JTkNMVURFX0RJUkVDVE9SSUVTCg== 204929 2013-06-18 12:27:44 -0700 2013-06-20 11:08:10 -0700 Patch bug-117711-20130618122559.patch text/plain 2784 ralpht+bugs U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEwNjEzNTcxMTU2ZTU5 MjE5Mjk0ZDFjYmJhNWM4Y2M4NDIxODI1Zi4uNDNiNDdhMDA3NzBiMjE2YzEzYTMyZmM5Y2FmMDFi MWUzODc2ZWJmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTE4ICBSYWxw aCBUaG9tYXMgIDxyYWxwaHRAZ21haWwuY29tPgorCisgICAgICAgIFtDTWFrZV1bQ1NTIFNoYWRl cnNdIEFkZCBXZWJDb3JlIGZpbGVzIGZvciBDU1MgU2hhZGVycyB0byBDTWFrZUxpc3RzLnR4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NzExCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBDTWFrZSBwbGF0Zm9ybXMgY3VycmVudGx5IGVuYWJsZSB0aGlzIGZ1bmN0aW9uYWxp dHkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMy0wNi0xOCAgQ29tbWl0IFF1 ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE1MTU0OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzg1YTZhNzFiN2UxYjk5 MDM5ZmRlODcyZDUzNWUzYTIzMjEwNjRiMS4uMGQ4ZWE5YzE3YTQzMTdjOGZjMjM3MmQyZTk0OGUz MzVjOTQ1ODM5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysr IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEwOTQsMTEgKzEwOTQsMTQgQEAg c2V0KFdlYkNvcmVfU09VUkNFUwogICAgIGNzcy9TVkdDU1NTdHlsZVNlbGVjdG9yLmNwcAogICAg IGNzcy9UcmFuc2Zvcm1GdW5jdGlvbnMuY3BwCiAgICAgY3NzL1ZpZXdwb3J0U3R5bGVSZXNvbHZl ci5jcHAKKyAgICBjc3MvV2ViS2l0Q1NTQXJyYXlGdW5jdGlvblZhbHVlLmNwcAogICAgIGNzcy9X ZWJLaXRDU1NGaWx0ZXJSdWxlLmNwcAogICAgIGNzcy9XZWJLaXRDU1NGaWx0ZXJWYWx1ZS5jcHAK ICAgICBjc3MvV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlLmNwcAogICAgIGNzcy9XZWJLaXRDU1NLZXlm cmFtZXNSdWxlLmNwcAogICAgIGNzcy9XZWJLaXRDU1NNYXRyaXguY3BwCisgICAgY3NzL1dlYktp dENTU01hdEZ1bmN0aW9uVmFsdWUuY3BwCisgICAgY3NzL1dlYktpdENTU01peEZ1bmN0aW9uVmFs dWUuY3BwCiAgICAgY3NzL1dlYktpdENTU1JlZ2lvblJ1bGUuY3BwCiAgICAgY3NzL1dlYktpdENT U1NWR0RvY3VtZW50VmFsdWUuY3BwCiAgICAgY3NzL1dlYktpdENTU1NoYWRlclZhbHVlLmNwcApA QCAtMTkzMywxMiArMTkzNiwxNCBAQCBzZXQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJDb21waWxlZFByb2dyYW0uY3BwCiAgICAgcGxh dGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJHbG9iYWxDb250ZXh0LmNwcAogICAg IHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyTWVzaC5jcHAKKyAgICBwbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlck1lc2hHZW5lcmF0b3IuY3BwCiAgICAg cGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJPcGVyYXRpb24uY3BwCiAgICAg cGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJQYXJhbWV0ZXJMaXN0LmNwcAog ICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvVmFsaWRhdGVkQ3VzdG9tRmlsdGVyT3BlcmF0 aW9uLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyUHJvZ3Jh bS5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlclByb2dyYW1J bmZvLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyUmVuZGVy ZXIuY3BwCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJWYWxpZGF0 ZWRQcm9ncmFtLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRGlzdGFudExpZ2h0 U291cmNlLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVCbGVuZC5jcHAKICAg ICBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29sb3JNYXRyaXguY3BwCkBAIC0yMjI5LDYg KzIyMzQsOSBAQCBzZXQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgcmVuZGVyaW5nL3N0eWxlL1N0eWxl Qm94RGF0YS5jcHAKICAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDYWNoZWRJbWFnZS5jcHAKICAg ICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDYWNoZWRJbWFnZVNldC5jcHAKKyAgICByZW5kZXJpbmcv c3R5bGUvU3R5bGVDYWNoZWRTaGFkZXIuY3BwCisgICAgcmVuZGVyaW5nL3N0eWxlL1N0eWxlQ3Vz dG9tRmlsdGVyUHJvZ3JhbS5jcHAKKyAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVDdXN0b21GaWx0 ZXJQcm9ncmFtQ2FjaGUuY3BwCiAgICAgcmVuZGVyaW5nL3N0eWxlL1N0eWxlRGVwcmVjYXRlZEZs ZXhpYmxlQm94RGF0YS5jcHAKICAgICByZW5kZXJpbmcvc3R5bGUvU3R5bGVGaWx0ZXJEYXRhLmNw cAogICAgIHJlbmRlcmluZy9zdHlsZS9TdHlsZUZsZXhpYmxlQm94RGF0YS5jcHAK