117705 2013-06-17 09:44:12 -0700 Shader compiler not properly configured for GLES on cairo based ports 2013-10-30 10:51:00 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mario webkit-unassigned cidorvan.leite commit-queue dino d-r mrobinson oldest_to_newest 901068 0 mario 2013-06-17 09:44:12 -0700 At the moment, the ANGLE shader compiler used in GraphicsContext3D for cairo based ports is always speaking GLSL, no matter WebKit is configured to use a GLES2 or an GL backend. This is causing some problems such as that the "precision mediump float;" bit in the fragment shader template used by TextureMapper(see TextureMapperShaderProgram.cpp) gets ignored when compiled by ANGLE, causing problems with some graphics drivers because that will mean that float precision for fragment shaders won't be explicitly specified, which seems to be a requirement for GLES2 (even if some implementations are more relaxed about it). The solution seems to be as simple as properly configuring the ANGLE compiler when creating the graphics context, to use SH_ESSL_OUTPUT instead of SH_GLSL_OUTPUT when GLES2 is used. 901071 1 204829 mario 2013-06-17 09:48:05 -0700 Created attachment 204829 Patch proposal Here comes the patch. It addresses the issue in a similar fashion to the Qt and EFL ports, and also clearly fixes an obscure issue for us as well, so I hope it'll be the right one. Now kindly asking for review... 901310 2 mario 2013-06-18 01:35:43 -0700 Committed r151676: <http://trac.webkit.org/changeset/151676> 945008 3 cidorvan.leite 2013-10-30 10:51:00 -0700 *** Bug 117804 has been marked as a duplicate of this bug. *** 204829 2013-06-17 09:48:05 -0700 2013-06-17 09:52:38 -0700 Patch proposal 0001-2013-06-17-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 2406 mario RnJvbSBmMDAwMTA3OWFhZTNmOGI4YTVhY2QwYzIyMTUwNmQwZWE3MDFkYjY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogTW9uLCAxNyBKdW4gMjAxMyAxNzo0NDoxMCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDYtMTcgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgU2hhZGVyIGNvbXBpbGVyIG5vdCBwcm9wZXJseSBjb25maWd1cmVk IGZvciBHTEVTIG9uIGNhaXJvIGJhc2VkIHBvcnRzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzcwNQoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiAgICAgICAgQ29uZmlndXJlIHRoZSBzaGFkZXIgY29tcGlsZXIgd2l0aCBTSF9F U1NMX09VVFBVVCBmb3IgR0xFU3YyCiAgICAgICAgY29tcGxpYW50IHBsYXRmb3JtcywgYW5kIHdp dGggU0hfR0xTTF9PVVRQVVQgb3RoZXJ3aXNlLgoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYXBoaWNzQ29udGV4dDNEQ2Fpcm8uY3BwOgogICAgICAgIChXZWJDb3JlOjpHcmFw aGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysr KysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dDNEQ2Fpcm8u Y3BwICAgIHwgICAgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggZmNhYTgzZS4uNmJhN2ZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEzLTA2LTE3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgU2hhZGVyIGNvbXBpbGVyIG5vdCBwcm9wZXJseSBjb25maWd1cmVkIGZvciBH TEVTIG9uIGNhaXJvIGJhc2VkIHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc3MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDb25maWd1cmUgdGhlIHNoYWRlciBjb21waWxlciB3aXRoIFNIX0VT U0xfT1VUUFVUIGZvciBHTEVTdjIKKyAgICAgICAgY29tcGxpYW50IHBsYXRmb3JtcywgYW5kIHdp dGggU0hfR0xTTF9PVVRQVVQgb3RoZXJ3aXNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QpOgorCiAyMDEzLTA2LTE3ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KIAogICAgICAgICBbTWFj XSBSZW1vdmUgdW5tYWludGFpbmVkIEdTdHJlYW1lciBzcGVjaWZpYyB2aWRlbyBjb2RlLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0M0RDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAppbmRleCBhNjhiNTNiLi5hOWNhYzZhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0Nv bnRleHQzRENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcApAQCAtNzUsNiArNzUsNyBAQCBQYXNzUmVm UHRyPEdyYXBoaWNzQ29udGV4dDNEPiBHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlKEdyYXBoaWNz Q29udGV4dDNEOjpBdHRyaQogR3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKEdy YXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMsIEhvc3RXaW5kb3cqLCBHcmFw aGljc0NvbnRleHQzRDo6UmVuZGVyU3R5bGUgcmVuZGVyU3R5bGUpCiAgICAgOiBtX2N1cnJlbnRX aWR0aCgwKQogICAgICwgbV9jdXJyZW50SGVpZ2h0KDApCisgICAgLCBtX2NvbXBpbGVyKGlzR0xF UzJDb21wbGlhbnQoKSA/IFNIX0VTU0xfT1VUUFVUIDogU0hfR0xTTF9PVVRQVVQpCiAgICAgLCBt X2F0dHJzKGF0dHJpYnV0ZXMpCiAgICAgLCBtX3RleHR1cmUoMCkKICAgICAsIG1fZmJvKDApCi0t IAoxLjcuMTAuNAoK