117698 2013-06-17 08:37:17 -0700 [New multicol] Change test to follow the pattern of the other tests 2013-07-05 03:27:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116614 1 mmaerean mmaerean commit-queue WebkitBugTracker oldest_to_newest 901045 0 mmaerean 2013-06-17 08:37:17 -0700 Change LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html to follow the pattern of the other tests: the expected result is using the old multicol code. 901051 1 204826 mmaerean 2013-06-17 08:49:26 -0700 Created attachment 204826 patch test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/ 901184 2 204826 zoltan 2013-06-17 15:38:52 -0700 Comment on attachment 204826 patch View in context: https://bugs.webkit.org/attachment.cgi?id=204826&action=review > LayoutTests/ChangeLog:3 > + [New multicol] Change test to follow the pattern of the other tests I would call this bug to something like: Turn fast/multicol/newmulticol/direct-child-column-span-all.html into a reftest > LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html:13 > + test passes if it doesn't crash or assert. Since you have a reftest now I would add a small explanation what is happening here (description of http://trac.webkit.org/changeset/150611) and a reference to the original bug where the test has been added (https://bugs.webkit.org/show_bug.cgi?id=116614), so we can easily see what's going on if it fails in the future. 901283 3 204884 mmaerean 2013-06-17 23:56:36 -0700 Created attachment 204884 patch that integrates the feedback from Zoltan. 906348 4 204884 commit-queue 2013-07-05 03:27:29 -0700 Comment on attachment 204884 patch that integrates the feedback from Zoltan. Clearing flags on attachment: 204884 Committed r152413: <http://trac.webkit.org/changeset/152413> 906349 5 commit-queue 2013-07-05 03:27:31 -0700 All reviewed patches have been landed. Closing bug. 204826 2013-06-17 08:49:26 -0700 2013-06-17 23:56:36 -0700 patch patch117698NewMultiColDirectChild.diff text/plain 2526 mmaerean ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZmJmN2Y3Li43NDZlMzI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDYt MTcgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW05ldyBt dWx0aWNvbF0gQ2hhbmdlIHRlc3QgdG8gZm9sbG93IHRoZSBwYXR0ZXJuIG9mIHRoZSBvdGhlciB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3 Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdGVz dCBpcyBhIHJlZiB0ZXN0IGFnYWluc3QgdGhlIG9sZCBtdWx0aWNvbCBjb2RlLCBsaWtlIGFsbCB0 aGUgb3RoZXIgdGVzdHMgaW4gTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9uZXdtdWx0aWNvbC8K KworICAgICAgICAqIGZhc3QvbXVsdGljb2wvbmV3bXVsdGljb2wvZGlyZWN0LWNoaWxkLWNvbHVt bi1zcGFuLWFsbC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L211bHRpY29s L25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwtZXhwZWN0ZWQudHh0OiBS ZW1vdmVkLgorICAgICAgICAqIGZhc3QvbXVsdGljb2wvbmV3bXVsdGljb2wvZGlyZWN0LWNoaWxk LWNvbHVtbi1zcGFuLWFsbC5odG1sOgorCiAyMDEzLTA2LTE3ICBab2x0YW4gQXJ2YWkgIDx6YXJ2 YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcu IENvcnJlY3RpbmcgcmViYXNlbGluaW5nIGFmdGVyIHIxNTE2MzQuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bh bi1hbGwtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvbmV3bXVsdGlj b2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmI1YzkyODQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bh bi1hbGwtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE1IEBACis8IWRvY3R5cGUgaHRtbD4KKzxo dG1sPgorCTxoZWFkPgorCQk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorCQkJI2FydGljbGUxIHsg LXdlYmtpdC1jb2x1bW5zOiAxOyB9CisJCQkjcDEgeyAtd2Via2l0LWNvbHVtbi1zcGFuOiBhbGw7 IH0KKwkJPC9zdHlsZT4KKwk8L2hlYWQ+CisJPGJvZHk+CisJCTxkaXYgaWQ9ImFydGljbGUxIj4K KwkJCTxwIGlkPSJwMSI+UEFTUzwvcD4KKwkJPC9kaXY+CisJCXRlc3QgcGFzc2VzIGlmIGl0IGRv ZXNuJ3QgY3Jhc2ggb3IgYXNzZXJ0LgorCTwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0 IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25ld211 bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9tdWx0aWNvbC9uZXdtdWx0aWNvbC9kaXJlY3QtY2hpbGQtY29sdW1uLXNwYW4t YWxsLWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZDViY2MyMi4u MDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVj dC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwtZXhwZWN0ZWQudHh0CisrKyAvZGV2L251bGwKQEAgLTEs MyArMCwwIEBACi1QQVNTCi0KLXRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgY3Jhc2ggb3IgYXNz ZXJ0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9uZXdtdWx0aWNvbC9k aXJlY3QtY2hpbGQtY29sdW1uLXNwYW4tYWxsLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L211bHRp Y29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwuaHRtbAppbmRleCBk ODAyMzRkLi40NDdjNmMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25l d211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1h bGwuaHRtbApAQCAtNyw4ICs3LDYgQEAKIAkJPC9zdHlsZT4KIAogCQk8c2NyaXB0IHR5cGU9InRl eHQvamF2YXNjcmlwdCI+Ci0JCSAgICBpZih3aW5kb3cudGVzdFJ1bm5lcikKLQkJICAgIAl3aW5k b3cudGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAJCSAgICBpZih3aW5kb3cuaW50ZXJuYWxzKQog CQkgICAgCWludGVybmFscy5zZXR0aW5ncy5zZXRSZWdpb25CYXNlZENvbHVtbnNFbmFibGVkKHRy dWUpOwogCQk8L3NjcmlwdD4K 204884 2013-06-17 23:56:36 -0700 2013-07-05 03:27:29 -0700 patch that integrates the feedback from Zoltan. patch117698NewMultiColDirectChild.diff text/plain 3884 mmaerean ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZmJmN2Y3Li5kYWNmYmQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDYt MTcgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW05ldyBt dWx0aWNvbF0gQ2hhbmdlIHRlc3QgdG8gZm9sbG93IHRoZSBwYXR0ZXJuIG9mIHRoZSBvdGhlciB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3 Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dCBpcyBhIHJlZiB0ZXN0IGFnYWluc3QgdGhlIG9sZCBtdWx0aWNvbCBjb2RlLCBsaWtlIGFsbCB0 aGUgb3RoZXIgdGVzdHMgaW4gTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9uZXdtdWx0aWNvbC8K KyAgICAgICAgVGhpcyBpcyBhIGZvbGxvdyB1cCBvZiBidWcgMTE2NjE0LCB0ZXN0aW5nIHRoYXQg ZmxvdyB0aHJlYWRzIGRvbid0IGVuZCB1cCBiZWluZyBjbG9uZWQgaW4gcmVnaW9uIGJhc2VkIG11 bHRpCisgICAgICAgIGNvbHVtbnMgd2l0aCBjb2x1bW5zOjEgd2hlcmUgdGhlIG9ubHkgY2hpbGQg aGFzIGNvbHVtbi1zcGFuOmFsbC4KKworICAgICAgICAqIGZhc3QvbXVsdGljb2wvbmV3bXVsdGlj b2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bh bi1hbGwtZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIGZhc3QvbXVsdGljb2wvbmV3 bXVsdGljb2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC5odG1sOgorCiAyMDEzLTA2LTE3 ICBab2x0YW4gQXJ2YWkgIDx6YXJ2YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0g VW5yZXZpZXdlZCBnYXJkZW5pbmcuIENvcnJlY3RpbmcgcmViYXNlbGluaW5nIGFmdGVyIHIxNTE2 MzQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2Rp cmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvbXVsdGljb2wvbmV3bXVsdGljb2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC1leHBl Y3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjc1ODViYzkKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2Rp cmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE3IEBA Cis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorCTxoZWFkPgorCQk8c3R5bGUgdHlwZT0idGV4dC9j c3MiPgorCQkJI2FydGljbGUxIHsgLXdlYmtpdC1jb2x1bW5zOiAxOyB9CisJCQkjcDEgeyAtd2Vi a2l0LWNvbHVtbi1zcGFuOiBhbGw7IH0KKwkJPC9zdHlsZT4KKwk8L2hlYWQ+CisJPGJvZHk+CisJ CTxkaXYgaWQ9ImFydGljbGUxIj4KKwkJCTxwIGlkPSJwMSI+UEFTUzwvcD4KKwkJPC9kaXY+CisJ CTxkaXY+VGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaCBvciBhc3NlcnQuPC9kaXY+CisJ CTxkaXY+VGVzdCBhZGRlZCBhcyBwYXJ0IG9mIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2OTgiPjExNzY5OCAtIFtOZXcgbXVsdGljb2xdIENoYW5n ZSB0ZXN0IHRvIGZvbGxvdyB0aGUgcGF0dGVybiBvZiB0aGUgb3RoZXIgdGVzdHM8L2E+PC9kaXY+ CisJCTxkaXY+VGhpcyBpcyBhIGZvbGxvdyB1cCBvZiA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjE0Ij4xMTY2MTQ8L2E+LCB0ZXN0aW5nIHRoYXQg ZmxvdyB0aHJlYWRzIGRvbid0IGVuZCB1cCBiZWluZyBjbG9uZWQgaW4gcmVnaW9uIGJhc2VkIG11 bHRpIGNvbHVtbnMgd2l0aCBjb2x1bW5zOjEgd2hlcmUgdGhlIG9ubHkgY2hpbGQgaGFzIGNvbHVt bi1zcGFuOmFsbC48L2Rpdj4gCisJPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5k IG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvbmV3bXVsdGlj b2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVjdC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwt ZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBkNWJjYzIyLi4wMDAw MDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvbmV3bXVsdGljb2wvZGlyZWN0LWNo aWxkLWNvbHVtbi1zcGFuLWFsbC1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSwzICsw LDAgQEAKLVBBU1MKLQotdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaCBvciBhc3NlcnQu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL25ld211bHRpY29sL2RpcmVj dC1jaGlsZC1jb2x1bW4tc3Bhbi1hbGwuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wv bmV3bXVsdGljb2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC5odG1sCmluZGV4IGQ4MDIz NGQuLjg5NzlhZmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvbmV3bXVs dGljb2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC5odG1sCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvbXVsdGljb2wvbmV3bXVsdGljb2wvZGlyZWN0LWNoaWxkLWNvbHVtbi1zcGFuLWFsbC5o dG1sCkBAIC03LDE2ICs3LDE2IEBACiAJCTwvc3R5bGU+CiAKIAkJPHNjcmlwdCB0eXBlPSJ0ZXh0 L2phdmFzY3JpcHQiPgotCQkgICAgaWYod2luZG93LnRlc3RSdW5uZXIpCi0JCSAgICAJd2luZG93 LnRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwotCQkgICAgaWYod2luZG93LmludGVybmFscykKLQkJ ICAgIAlpbnRlcm5hbHMuc2V0dGluZ3Muc2V0UmVnaW9uQmFzZWRDb2x1bW5zRW5hYmxlZCh0cnVl KTsKKwkJCWlmKHdpbmRvdy5pbnRlcm5hbHMpCisJCQkJaW50ZXJuYWxzLnNldHRpbmdzLnNldFJl Z2lvbkJhc2VkQ29sdW1uc0VuYWJsZWQodHJ1ZSk7CiAJCTwvc2NyaXB0PgogCTwvaGVhZD4KIAk8 Ym9keT4KIAkJPGRpdiBpZD0iYXJ0aWNsZTEiPgogCQkgICAgPHAgaWQ9InAxIj5QQVNTPC9wPgog CQk8L2Rpdj4KLQkJdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaCBvciBhc3NlcnQuCisJ CTxkaXY+VGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaCBvciBhc3NlcnQuPC9kaXY+CisJ CTxkaXY+VGVzdCBhZGRlZCBhcyBwYXJ0IG9mIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2OTgiPjExNzY5OCAtIFtOZXcgbXVsdGljb2xdIENoYW5n ZSB0ZXN0IHRvIGZvbGxvdyB0aGUgcGF0dGVybiBvZiB0aGUgb3RoZXIgdGVzdHM8L2E+PC9kaXY+ CisJCTxkaXY+VGhpcyBpcyBhIGZvbGxvdyB1cCBvZiA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2NjE0Ij4xMTY2MTQ8L2E+LCB0ZXN0aW5nIHRoYXQg ZmxvdyB0aHJlYWRzIGRvbid0IGVuZCB1cCBiZWluZyBjbG9uZWQgaW4gcmVnaW9uIGJhc2VkIG11 bHRpIGNvbHVtbnMgd2l0aCBjb2x1bW5zOjEgd2hlcmUgdGhlIG9ubHkgY2hpbGQgaGFzIGNvbHVt bi1zcGFuOmFsbC48L2Rpdj4KIAk8L2JvZHk+CiA8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQo=