117687 2013-06-16 23:32:36 -0700 [BlackBerry] only notify download client when download error 2013-06-18 02:13:36 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mawu mawu charles.wei commit-queue joenotcharles rwlbuis staikos oldest_to_newest 900938 0 mawu 2013-06-16 23:32:36 -0700 when met network error in downloading, we notify the error to download client through download stream, we shouldn't notify page client the error. 900952 1 204798 mawu 2013-06-17 00:38:23 -0700 Created attachment 204798 webkit patch 900954 2 204799 mawu 2013-06-17 00:40:13 -0700 Created attachment 204799 patch correct patch 901019 3 204799 rwlbuis 2013-06-17 07:03:17 -0700 Comment on attachment 204799 patch LGTM. 901314 4 204799 mawu 2013-06-18 01:53:19 -0700 Comment on attachment 204799 patch thanks, Rob 901321 5 204799 commit-queue 2013-06-18 02:13:34 -0700 Comment on attachment 204799 patch Clearing flags on attachment: 204799 Committed r151677: <http://trac.webkit.org/changeset/151677> 901322 6 commit-queue 2013-06-18 02:13:36 -0700 All reviewed patches have been landed. Closing bug. 204798 2013-06-17 00:38:23 -0700 2013-06-17 00:40:13 -0700 webkit patch webkit.patch text/plain 5131 mawu RnJvbSBmNTIxMjUxZWMwODJjODY1YThjMDdlNTFjMjU5ZmFlOTNjN2E3YzQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiZGlub0BhcHBsZS5jb20iIDxkaW5vQGFwcGxlLmNvbUAyNjhm NDVjYy1jZDA5LTA0MTAtYWIzYy1kNTI2OTFiNGRiZmM+CkRhdGU6IEZyaSwgMTQgSnVuIDIwMTMg MDE6MjA6NDQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBDbGlja2luZyBvbiBzbmFwc2hvdHRpbmcg cGx1Zy1pbnMgZG9lcyBub3QgcmVzdGFydCB0aGVtCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE3NjIwCiA8cmRhcjovL3Byb2JsZW0vMTM4MjE3Mjk+CgpSZXZpZXdl ZCBieSBTaW1vbiBGcmFzZXIuCgpIVE1MUGx1Z0luRWxlbWVudCBoYXMgYW4gZXZlbnQgaGFuZGxl ciB3aGljaCB3b3VsZCByZXR1cm4KaW1tZWRpYXRlbHkgaWYgdGhlIGVsZW1lbnQgd2FzIG5vdCBz bmFwc2hvdHRlZCwgcmVzdGFydGluZwpvciBwbGF5aW5nLiBUaGVyZSBpcyBhIGNhc2UgaXQgbWlz c2VkLCB3aGljaCB3YXMgc25hcHNob3R0aW5nCihXYWl0aW5nRm9yU25hcHNob3QgdG8gYmUgcHJl Y2lzZSkuIElmIHdlIGdldCBhIGNsaWNrIGluIHRoaXMKc3RhdGUgdGhlbiBpdCBzaG91bGQgaW1t ZWRpYXRlbHkgcmVzdGFydC4KCiogaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5oOiBNb3ZlIGRlZmF1 bHRFdmVudEhhbmRsZXIgdG8gcHVibGljICh3ZSBjYWxsIGl0IGZyb20gdGhlIGNoaWxkIGNsYXNz KS4KKiBodG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwOgooV2ViQ29yZTo6SFRNTFBsdWdJ bkltYWdlRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6IElmIHRoZXJlIGlzIGEgY2xpY2sg b24gYSBzbmFwc2hvdHRpbmcKcGx1Zy1pbiwgdGhlbiBjYWxsIHJlc3RhcnQuCiogaHRtbC9IVE1M UGx1Z0luSW1hZ2VFbGVtZW50Lmg6IFZpcnR1YWwgZGVmYXVsdEV2ZW50SGFuZGxlciBkZWNsYXJh dGlvbi4KCmdpdC1zdm4taWQ6IGh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtp dC90cnVua0AxNTE1NzYgMjY4ZjQ1Y2MtY2QwOS0wNDEwLWFiM2MtZDUyNjkxYjRkYmZjCi0tLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysr KysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQu aCAgICAgICAgfCAgICA0ICsrLS0KIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdl RWxlbWVudC5jcHAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmggICB8ICAgIDIgKysKIDQgZmlsZXMgY2hhbmdlZCwg NDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y1NzFjZC4u NThhNmI1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA2LTEzICBEZWFuIEph Y2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBDbGlja2luZyBvbiBzbmFwc2hvdHRp bmcgcGx1Zy1pbnMgZG9lcyBub3QgcmVzdGFydCB0aGVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2MjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzEzODIxNzI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAg ICBIVE1MUGx1Z0luRWxlbWVudCBoYXMgYW4gZXZlbnQgaGFuZGxlciB3aGljaCB3b3VsZCByZXR1 cm4KKyAgICAgICAgaW1tZWRpYXRlbHkgaWYgdGhlIGVsZW1lbnQgd2FzIG5vdCBzbmFwc2hvdHRl ZCwgcmVzdGFydGluZworICAgICAgICBvciBwbGF5aW5nLiBUaGVyZSBpcyBhIGNhc2UgaXQgbWlz c2VkLCB3aGljaCB3YXMgc25hcHNob3R0aW5nCisgICAgICAgIChXYWl0aW5nRm9yU25hcHNob3Qg dG8gYmUgcHJlY2lzZSkuIElmIHdlIGdldCBhIGNsaWNrIGluIHRoaXMKKyAgICAgICAgc3RhdGUg dGhlbiBpdCBzaG91bGQgaW1tZWRpYXRlbHkgcmVzdGFydC4KKworICAgICAgICAqIGh0bWwvSFRN TFBsdWdJbkVsZW1lbnQuaDogTW92ZSBkZWZhdWx0RXZlbnRIYW5kbGVyIHRvIHB1YmxpYyAod2Ug Y2FsbCBpdCBmcm9tIHRoZSBjaGlsZCBjbGFzcykuCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0lu SW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOiBJZiB0aGVyZSBpcyBhIGNsaWNrIG9uIGEgc25hcHNo b3R0aW5nCisgICAgICAgIHBsdWctaW4sIHRoZW4gY2FsbCByZXN0YXJ0LgorICAgICAgICAqIGh0 bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5oOiBWaXJ0dWFsIGRlZmF1bHRFdmVudEhhbmRsZXIg ZGVjbGFyYXRpb24uCisKIDIwMTMtMDYtMTMgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVXNlIGJvcmRlckFuZFBhZGRpbmdbQmVmb3JlLEFmdGVyXSgpIGlu c3RlYWQgb2YgYm9yZGVyW0JlZm9yZSxBZnRlcl0oKSArIHBhZGRpbmdbQmVmb3JlLEFmdGVyXSgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmggYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmgKaW5kZXggMTdiYjc0MC4uYmM4 MmJkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQuaApAQCAtODAsNiAr ODAsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNQbHVnSW5JbWFnZUVsZW1lbnQo KSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCisgICAgdmlydHVhbCB2b2lkIGRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQqKTsKKwogcHJvdGVjdGVkOgogICAgIEhUTUxQbHVnSW5FbGVtZW50KGNv bnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50Kik7CiAKQEAgLTk5LDggKzEwMSw2 IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgYXJlQXV0aG9yU2hhZG93c0FsbG93ZWQo KSBjb25zdCBPVkVSUklERSB7IHJldHVybiBmYWxzZTsgfQogCi0gICAgdmlydHVhbCB2b2lkIGRl ZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsKLQogICAgIHZpcnR1YWwgUmVuZGVyV2lkZ2V0KiBy ZW5kZXJXaWRnZXRGb3JKU0JpbmRpbmdzKCkgY29uc3QgPSAwOwogCiAgICAgdmlydHVhbCBib29s IHN1cHBvcnRzRm9jdXMoKSBjb25zdCBPVkVSUklERTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCmluZGV4IDMxYTNmMzQuLmViYjhmYTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcApAQCAtMjMs NiArMjMsOCBAQAogCiAjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50 LmgiCisjaW5jbHVkZSAiRXZlbnQuaCIKKyNpbmNsdWRlICJFdmVudEhhbmRsZXIuaCIKICNpbmNs dWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyLmgiCiAjaW5jbHVkZSAiRnJhbWVM b2FkZXJDbGllbnQuaCIKQEAgLTcwNyw0ICs3MDksMjAgQEAgdm9pZCBIVE1MUGx1Z0luSW1hZ2VF bGVtZW50OjpzdWJmcmFtZUxvYWRlckRpZENyZWF0ZVBsdWdJbihjb25zdCBXaWRnZXQqIHdpZGdl dCkKICAgICB9CiB9CiAKK3ZvaWQgSFRNTFBsdWdJbkltYWdlRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcihFdmVudCogZXZlbnQpCit7CisgICAgUmVuZGVyT2JqZWN0KiByID0gcmVuZGVyZXIo KTsKKyAgICBpZiAociAmJiByLT5pc0VtYmVkZGVkT2JqZWN0KCkpIHsKKyAgICAgICAgaWYgKGlz UGx1Z0luSW1hZ2VFbGVtZW50KCkgJiYgZGlzcGxheVN0YXRlKCkgPT0gV2FpdGluZ0ZvclNuYXBz aG90ICYmIGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmNsaWNrRXZlbnQpIHsKKyAgICAg ICAgICAgIE1vdXNlRXZlbnQqIG1vdXNlRXZlbnQgPSBzdGF0aWNfY2FzdDxNb3VzZUV2ZW50Kj4o ZXZlbnQpOworICAgICAgICAgICAgaWYgKG1vdXNlRXZlbnQtPmJ1dHRvbigpID09IExlZnRCdXR0 b24pIHsKKyAgICAgICAgICAgICAgICB1c2VyRGlkQ2xpY2tTbmFwc2hvdChtb3VzZUV2ZW50LCB0 cnVlKTsKKyAgICAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKKyAgICAg ICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisgICAg SFRNTFBsdWdJbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoZXZlbnQpOworfQorICAgIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5J bWFnZUVsZW1lbnQuaAppbmRleCAxNWFjNTA0Li5kZDgxNTZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuaApAQCAtMTI1LDYgKzEyNSw4IEBAIHByb3Rl Y3RlZDoKIAogICAgIHZpcnR1YWwgYm9vbCBpc1Jlc3RhcnRlZFBsdWdpbigpIGNvbnN0IE9WRVJS SURFIHsgcmV0dXJuIG1faXNSZXN0YXJ0ZWRQbHVnaW47IH0KIAorICAgIHZpcnR1YWwgdm9pZCBk ZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CisKIHByaXZhdGU6CiAgICAgdmlydHVhbCBSZW5k ZXJPYmplY3QqIGNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiwgUmVuZGVyU3R5bGUqKTsKICAg ICB2aXJ0dWFsIGJvb2wgd2lsbFJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlKTsKLS0gCjEuNy45LjUK Cg== 204799 2013-06-17 00:40:13 -0700 2013-06-18 02:13:34 -0700 patch webkit.patch text/plain 2179 mawu RnJvbSAyYTkwOTMzMDA2MmI2NDNjYTI0YTAxY2QxYTUyOTJkOTQ1ZWU5ZjljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ5IFd1IDxtYXd1QGJsYWNrYmVycnkuY29tPgpEYXRlOiBN b24sIDE3IEp1biAyMDEzIDE1OjM3OjEzICswODAwClN1YmplY3Q6IFtQQVRDSF0gYWIKCi0tLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0 ICsrKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtK b2IuY3BwICAgICB8ICAgMTAgKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU4YTZiNTkuLmYzZWVkNWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNi0xNyAgTWFyeSBXdSAgPG1hcnkud3VA dG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBvbmx5IG5vdGlmeSBk b3dubG9hZCBjbGllbnQgd2hlbiBkb3dubG9hZCBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBtZXQgbmV0d29yayBlcnJvciBpbiBkb3du bG9hZGluZywgd2Ugbm90aWZ5IHRoZSBlcnJvciB0byBkb3dubG9hZAorICAgICAgICBjbGllbnQg dGhyb3VnaCBkb3dubG9hZCBzdHJlYW0sIHdlIHNob3VsZG4ndCBub3RpZnkgcGFnZSBjbGllbnQg dGhlIGVycm9yLgorICAgICAgICBSSU0gSklSQSA0MTk5ODUKKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5l dHdvcmtKb2I6OnNob3VsZE5vdGlmeUNsaWVudEZhaWxlZCk6CisKIDIwMTMtMDYtMTMgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIENsaWNraW5nIG9uIHNuYXBzaG90 dGluZyBwbHVnLWlucyBkb2VzIG5vdCByZXN0YXJ0IHRoZW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRl eCBjMGQ1YTBkLi4yZDY0Zjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC02MDEsNyArNjAxLDE1 IEBAIGJvb2wgTmV0d29ya0pvYjo6c2hvdWxkUmVsZWFzZUNsaWVudFJlc291cmNlKCkKIAogYm9v bCBOZXR3b3JrSm9iOjpzaG91bGROb3RpZnlDbGllbnRGYWlsZWQoKSBjb25zdAogewotICAgIHJl dHVybiBtX2V4dGVuZGVkU3RhdHVzQ29kZSA8IDAgfHwgKGlzRXJyb3IobV9leHRlbmRlZFN0YXR1 c0NvZGUpICYmICFtX2RhdGFSZWNlaXZlZCAmJiAhbV9pc0hlYWRNZXRob2QgJiYgbV9oYW5kbGUt PmZpcnN0UmVxdWVzdCgpLnRhcmdldFR5cGUoKSAhPSBSZXNvdXJjZVJlcXVlc3Q6OlRhcmdldElz WEhSKTsKKyAgICBSZXNvdXJjZVJlcXVlc3QgcmVxdWVzdCA9IG1faGFuZGxlLT5maXJzdFJlcXVl c3QoKTsKKyAgICBpZiAocmVxdWVzdC5mb3JjZURvd25sb2FkKCkpCisgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICBpZiAobV9leHRlbmRlZFN0YXR1c0NvZGUgPCAwKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICBpZiAoaXNFcnJvcihtX2V4dGVuZGVkU3RhdHVzQ29kZSkgJiYgIW1fZGF0YVJl Y2VpdmVkICYmICFtX2lzSGVhZE1ldGhvZCAmJiByZXF1ZXN0LnRhcmdldFR5cGUoKSAhPSBSZXNv dXJjZVJlcXVlc3Q6OlRhcmdldElzWEhSKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIHJl dHVybiBmYWxzZTsKIH0KIAogYm9vbCBOZXR3b3JrSm9iOjpyZXRyeUFzRlRQRGlyZWN0b3J5KCkK LS0gCjEuNy45LjUKCg==