117685 2013-06-16 18:33:35 -0700 Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect() 2013-06-16 20:56:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue kling oldest_to_newest 900919 0 gyuyoung.kim 2013-06-16 18:33:35 -0700 Avoid duplicating hostWindow() call. Merge with https://src.chromium.org/viewvc/blink?view=rev&revision=152490 900920 1 204794 gyuyoung.kim 2013-06-16 18:37:43 -0700 Created attachment 204794 Patch 900921 2 gyuyoung.kim 2013-06-16 18:38:53 -0700 CC'ing Kling. could you take a look at this ? 900925 3 204794 kling 2013-06-16 19:30:20 -0700 Comment on attachment 204794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review r=me > Source/WebCore/ChangeLog:3 > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()" 900928 4 204796 gyuyoung.kim 2013-06-16 20:16:30 -0700 Created attachment 204796 Patch for landing 900929 5 gyuyoung.kim 2013-06-16 20:17:37 -0700 (In reply to comment #3) > (From update of attachment 204794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review > > r=me > > > Source/WebCore/ChangeLog:3 > > + Minor refactoring with FrameView::InvalidateRect() for hostWindow call > > The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring." > FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()" Ok, thanks. I fixed. 900930 6 204796 commit-queue 2013-06-16 20:56:57 -0700 Comment on attachment 204796 Patch for landing Clearing flags on attachment: 204796 Committed r151628: <http://trac.webkit.org/changeset/151628> 900931 7 commit-queue 2013-06-16 20:56:59 -0700 All reviewed patches have been landed. Closing bug. 204794 2013-06-16 18:37:43 -0700 2013-06-16 20:16:23 -0700 Patch bug-117685-20130617103556.patch text/plain 1458 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU2M2FhN2E2OGE1MTIx NmM0YTlmODNjYzM5ZjRjZjIyMDYxNzdlZC4uZDJhYzE1NjQxNzlmNjdjMDAxNWY0NjIxYzBiODlm OWU1NjFlM2NhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTE2ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgTWlub3IgcmVm YWN0b3Jpbmcgd2l0aCBGcmFtZVZpZXc6OkludmFsaWRhdGVSZWN0KCkgZm9yIGhvc3RXaW5kb3cg Y2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3 Njg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJv bSBCbGluayByMTUyNDkwIGJ5IDx2aXZlay52Z0BzYW1zdW5nLmNvbT4KKworICAgICAgICAqIHBh Z2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6aW52YWxpZGF0 ZVJlY3QpOiBBdm9pZCBob3N0V2luZG93KCkgdHdpY2UgY2FsbC4KKwogMjAxMy0wNi0xNiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXhlZCBiYWNr Z3JvdW5kcyBpbiBjb21wb3NpdGVkIGxheWVycyBub3QgcmVwYWludGVkIG9uIHNjcm9sbGluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDA5NWJhNGU1MDVlY2RhNTNkZDM0NTM0NGM0 YjJmZGM5MjQ4YzFjM2YuLjA1OTQyYTVlOTNkODJhZDhhMjI4YTA5ZTRmZGIyNjJjYjllYmMwYTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTQyOSw4ICs0MjksOCBAQCBib29sIEZy YW1lVmlldzo6ZGlkRmlyc3RMYXlvdXQoKSBjb25zdAogdm9pZCBGcmFtZVZpZXc6OmludmFsaWRh dGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAgICAgaWYgKCFwYXJlbnQoKSkgewotICAg ICAgICBpZiAoaG9zdFdpbmRvdygpKQotICAgICAgICAgICAgaG9zdFdpbmRvdygpLT5pbnZhbGlk YXRlQ29udGVudHNBbmRSb290VmlldyhyZWN0LCBmYWxzZSAvKmltbWVkaWF0ZSovKTsKKyAgICAg ICAgaWYgKEhvc3RXaW5kb3cqIHdpbmRvdyA9IGhvc3RXaW5kb3coKSkKKyAgICAgICAgICAgIHdp bmRvdy0+aW52YWxpZGF0ZUNvbnRlbnRzQW5kUm9vdFZpZXcocmVjdCwgZmFsc2UgLyppbW1lZGlh dGUqLyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK 204796 2013-06-16 20:16:30 -0700 2013-06-16 20:56:57 -0700 Patch for landing bug-117685-20130617121443.patch text/plain 1442 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmM4NDFkNDAwNzU0MGQ0 MTU4ZGY5ZWUxMWZlZGUxNTZmYjA1ODQ4My4uMzdkM2RmNDdkNDJiOWMwM2Q4MzVhOTlkZTU3Zjhl OTNiYzZlMGJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTE2ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIGEg cmVkdW5kYW50IHZpcnR1YWwgY2FsbCB0byBob3N0V2luZG93KCkgaW4gRnJhbWVWaWV3OjppbnZh bGlkYXRlUmVjdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTc2ODUKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAg ICAgIEZyb20gQmxpbmsgcjE1MjQ5MCBieSA8dml2ZWsudmdAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6Omlu dmFsaWRhdGVSZWN0KTogQXZvaWQgaG9zdFdpbmRvdygpIHR3aWNlIGNhbGwuCisKIDIwMTMtMDYt MTYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB0d28g YXNzZXJ0aW9uIGZhaWx1cmVzIGluIFJhbmdlOjppbnNlcnROb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggMDk1YmE0ZTUwNWVjZGE1M2RkMzQ1MzQ0YzRiMmZkYzkyNDhjMWMzZi4u MDU5NDJhNWU5M2Q4MmFkOGEyMjhhMDllNGZkYjI2MmNiOWViYzBhOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtNDI5LDggKzQyOSw4IEBAIGJvb2wgRnJhbWVWaWV3OjpkaWRGaXJz dExheW91dCgpIGNvbnN0CiB2b2lkIEZyYW1lVmlldzo6aW52YWxpZGF0ZVJlY3QoY29uc3QgSW50 UmVjdCYgcmVjdCkKIHsKICAgICBpZiAoIXBhcmVudCgpKSB7Ci0gICAgICAgIGlmIChob3N0V2lu ZG93KCkpCi0gICAgICAgICAgICBob3N0V2luZG93KCktPmludmFsaWRhdGVDb250ZW50c0FuZFJv b3RWaWV3KHJlY3QsIGZhbHNlIC8qaW1tZWRpYXRlKi8pOworICAgICAgICBpZiAoSG9zdFdpbmRv dyogd2luZG93ID0gaG9zdFdpbmRvdygpKQorICAgICAgICAgICAgd2luZG93LT5pbnZhbGlkYXRl Q29udGVudHNBbmRSb290VmlldyhyZWN0LCBmYWxzZSAvKmltbWVkaWF0ZSovKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAo=