117681 2013-06-16 08:57:20 -0700 Improve style of null checks in FrameView::setFrameRect 2013-06-18 18:52:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue oldest_to_newest 900876 0 darin 2013-06-16 08:57:20 -0700 Improve style of null checks in FrameView::setFrameRect 900877 1 204789 darin 2013-06-16 08:57:59 -0700 Created attachment 204789 Patch 901625 2 204789 commit-queue 2013-06-18 18:52:06 -0700 Comment on attachment 204789 Patch Clearing flags on attachment: 204789 Committed r151715: <http://trac.webkit.org/changeset/151715> 901626 3 commit-queue 2013-06-18 18:52:07 -0700 All reviewed patches have been landed. Closing bug. 204789 2013-06-16 08:57:59 -0700 2013-06-18 18:52:06 -0700 Patch bug-117681-20130616085614.patch text/plain 1968 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQyNDgwMjU0OWI0Njlm MzM4NWU4ZmIzYTYyMzE0NmUzMGVjYjlkMy4uNTY1NDVjNWM1NzdmMDRjY2FiNTU4NzMwZDU5MTYw ZjE0NWExOGI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTE2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBJbXByb3ZlIHN0eWxlIG9mIG51 bGwgY2hlY2tzIGluIEZyYW1lVmlldzo6c2V0RnJhbWVSZWN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2ODEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2V0RnJhbWVSZWN0KTogVXNlZCBuZXN0ZWQgaWYgc3Rh dGVtZW50cyBhbmQgbG9jYWwgdmFyaWFibGVzCisgICAgICAgIHRvIHRpZ2h0ZW4gdGhpcyBjb2Rl IHVwIGEgbGl0dGxlLgorCiAyMDEzLTA2LTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBUcnkgdG8gZml4IGlPUyBhZnRlciBsYXN0IFBhc3RlYm9hcmQgY2hhbmdl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDhhOTI0ZmVkNzQzOTI0NjVlNjJiZWM1 OWUwOWFlNTAwNWMzNGE1ZDUuLmU5NTU5OTllODBiMDBhODVmZTE3MmIyNzRjYTQ4NWQzNDllNzZj MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTQ3NiwxMiArNDc2LDE2IEBAIHZv aWQgRnJhbWVWaWV3OjpzZXRGcmFtZVJlY3QoY29uc3QgSW50UmVjdCYgbmV3UmVjdCkKICAgICB9 CiAjZW5kaWYKIAotICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1fZnJhbWUgPyBtX2ZyYW1lLT5k b2N1bWVudCgpIDogMDsKLQogICAgIC8vIFZpZXdwb3J0LWRlcGVuZGVudCBtZWRpYSBxdWVyaWVz IG1heSBjYXVzZSB1cyB0byBuZWVkIGNvbXBsZXRlbHkgZGlmZmVyZW50IHN0eWxlIGluZm9ybWF0 aW9uLgotICAgIGlmIChkb2N1bWVudCAmJiBkb2N1bWVudC0+c3R5bGVSZXNvbHZlcklmRXhpc3Rz KCkgJiYgZG9jdW1lbnQtPnN0eWxlUmVzb2x2ZXJJZkV4aXN0cygpLT5hZmZlY3RlZEJ5Vmlld3Bv cnRDaGFuZ2UoKSkgewotICAgICAgICBkb2N1bWVudC0+c3R5bGVSZXNvbHZlckNoYW5nZWQoRGVm ZXJSZWNhbGNTdHlsZSk7Ci0gICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6bWVkaWFR dWVyeVJlc3VsdENoYW5nZWQoZG9jdW1lbnQpOworICAgIGlmIChtX2ZyYW1lKSB7CisgICAgICAg IGlmIChEb2N1bWVudCogZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CisgICAgICAg ICAgICBpZiAoU3R5bGVSZXNvbHZlciogcmVzb2x2ZXIgPSBkb2N1bWVudC0+c3R5bGVSZXNvbHZl cklmRXhpc3RzKCkpIHsKKyAgICAgICAgICAgICAgICBpZiAocmVzb2x2ZXItPmFmZmVjdGVkQnlW aWV3cG9ydENoYW5nZSgpKSB7CisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LT5zdHlsZVJl c29sdmVyQ2hhbmdlZChEZWZlclJlY2FsY1N0eWxlKTsKKyAgICAgICAgICAgICAgICAgICAgSW5z cGVjdG9ySW5zdHJ1bWVudGF0aW9uOjptZWRpYVF1ZXJ5UmVzdWx0Q2hhbmdlZChkb2N1bWVudCk7 CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9CiAgICAgfQogCiAg ICAgc2VuZFJlc2l6ZUV2ZW50SWZOZWVkZWQoKTsK