117676 2013-06-15 17:06:39 -0700 Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy 2013-06-15 18:49:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 900818 0 fpizlo 2013-06-15 17:06:39 -0700 Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy 900819 1 204776 fpizlo 2013-06-15 17:08:15 -0700 Created attachment 204776 Patch 900837 2 204776 sam 2013-06-15 18:43:09 -0700 Comment on attachment 204776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554 > +#if ENABLE(JIT) > + , m_capabilityLevelState(DFG::CapabilityLevelNotSet) > +#endif Is this related? If not, you should call it out in your changelog or commit it separately. 900838 3 fpizlo 2013-06-15 18:46:31 -0700 (In reply to comment #2) > (From update of attachment 204776 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554 > > +#if ENABLE(JIT) > > + , m_capabilityLevelState(DFG::CapabilityLevelNotSet) > > +#endif > > Is this related? If not, you should call it out in your changelog or commit it separately. No - while messing around with the constructor I realized that this field wasn't being initialized in all constructors. 900839 4 fpizlo 2013-06-15 18:49:54 -0700 Landed in http://trac.webkit.org/changeset/151618 204776 2013-06-15 17:08:15 -0700 2013-06-15 18:43:09 -0700 Patch bug-117676-20130615170631.patch text/plain 6719 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxNjE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTA2LTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q29uY3VycmVudCBKSVQgc2hvdWxkbid0IHRyeSB0byByZWNvbXB1dGUgdGhlIENvZGVCbG9ja0hh c2ggYXMgcGFydCBvZiBkZWJ1ZyBkdW1wcywgc2luY2UgZG9pbmcgc28gbWF5IGZhaWwgaWYgZGVh bGluZyB3aXRoIGEgQ2FjaGVkU2NyaXB0IHRoYXQgZG9lc24ndCBoYXZlIGl0cyBzY3JpcHQgc3Ry aW5nIGhhbmR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc2NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb2RlQmxvY2sgbm93IGNhY2hlcyBtX2hhc2gsIGFuZCB0aGUgREZHIERyaXZlciB3aWxsIGZv cmNlIGl0cyBjb21wdXRhdGlvbiBpZiB3ZSdyZSBkb2luZyBkZWJ1ZyBkdW1wcyBvZiBhbnkga2lu ZC4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OkNv ZGVCbG9jazo6aGFzaCk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6Q29kZUJsb2NrKToKKyAg ICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDoKKyAgICAgICAgKENvZGVCbG9jayk6CisgICAg ICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9j a0hhc2g6OkNvZGVCbG9ja0hhc2gpOgorICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9ja0hhc2gu aDoKKyAgICAgICAgKENvZGVCbG9ja0hhc2gpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2tIYXNo Ojppc1NldCk6CisgICAgICAgIChKU0M6OkNvZGVCbG9ja0hhc2g6Om9wZXJhdG9yISk6CisgICAg ICAgICogZGZnL0RGR0RyaXZlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Y29tcGlsZSk6CisK IDIwMTMtMDYtMTMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBm b3VydGhUaWVyOiBERkcgc2hvdWxkIHN1cHBvcnQgb3Bfc3dpdGNoX2ltbQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlzaW9uIDE1MTYx NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC04Myw3ICs4MywxMSBAQCBDU3RyaW5nIENvZGVCbG9jazo6aW5mZXJyZWRO YW1lKCkgY29uc3QKIAogQ29kZUJsb2NrSGFzaCBDb2RlQmxvY2s6Omhhc2goKSBjb25zdAogewot ICAgIHJldHVybiBDb2RlQmxvY2tIYXNoKG93bmVyRXhlY3V0YWJsZSgpLT5zb3VyY2UoKSwgc3Bl Y2lhbGl6YXRpb25LaW5kKCkpOworICAgIGlmICghbV9oYXNoKSB7CisgICAgICAgIFJFTEVBU0Vf QVNTRVJUKCFpc0NvbXBpbGF0aW9uVGhyZWFkKCkpOworICAgICAgICBtX2hhc2ggPSBDb2RlQmxv Y2tIYXNoKG93bmVyRXhlY3V0YWJsZSgpLT5zb3VyY2UoKSwgc3BlY2lhbGl6YXRpb25LaW5kKCkp OworICAgIH0KKyAgICByZXR1cm4gbV9oYXNoOwogfQogCiBDU3RyaW5nIENvZGVCbG9jazo6c291 cmNlQ29kZUZvclRvb2xzKCkgY29uc3QKQEAgLTE1MDQsNiArMTUwOCw3IEBAIENvZGVCbG9jazo6 Q29kZUJsb2NrKENvcHlQYXJzZWRCbG9ja1RhZywKICAgICAsIG1fb3NyRXhpdENvdW50ZXIoMCkK ICAgICAsIG1fb3B0aW1pemF0aW9uRGVsYXlDb3VudGVyKDApCiAgICAgLCBtX3Jlb3B0aW1pemF0 aW9uUmV0cnlDb3VudGVyKDApCisgICAgLCBtX2hhc2gob3RoZXIubV9oYXNoKQogI2lmIEVOQUJM RShKSVQpCiAgICAgLCBtX2NhcGFiaWxpdHlMZXZlbFN0YXRlKERGRzo6Q2FwYWJpbGl0eUxldmVs Tm90U2V0KQogI2VuZGlmCkBAIC0xNTQ0LDYgKzE1NDksOSBAQCBDb2RlQmxvY2s6OkNvZGVCbG9j ayhTY3JpcHRFeGVjdXRhYmxlKiBvCiAgICAgLCBtX29zckV4aXRDb3VudGVyKDApCiAgICAgLCBt X29wdGltaXphdGlvbkRlbGF5Q291bnRlcigwKQogICAgICwgbV9yZW9wdGltaXphdGlvblJldHJ5 Q291bnRlcigwKQorI2lmIEVOQUJMRShKSVQpCisgICAgLCBtX2NhcGFiaWxpdHlMZXZlbFN0YXRl KERGRzo6Q2FwYWJpbGl0eUxldmVsTm90U2V0KQorI2VuZGlmCiB7CiAgICAgbV92bS0+c3RhcnRl ZENvbXBpbGluZyh0aGlzKTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Db2RlQmxvY2suaAkocmV2aXNpb24gMTUxNjE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDgxLDYgKzEwODEsOCBA QCBwcml2YXRlOgogICAgIHVpbnQzMl90IG1fb3NyRXhpdENvdW50ZXI7CiAgICAgdWludDE2X3Qg bV9vcHRpbWl6YXRpb25EZWxheUNvdW50ZXI7CiAgICAgdWludDE2X3QgbV9yZW9wdGltaXphdGlv blJldHJ5Q291bnRlcjsKKyAgICAKKyAgICBtdXRhYmxlIENvZGVCbG9ja0hhc2ggbV9oYXNoOwog CiAgICAgc3RydWN0IFJhcmVEYXRhIHsKICAgICAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9ja0hh c2guY3BwCShyZXZpc2lvbiAxNTE2MTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZUJsb2NrSGFzaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDEwIEBAIENv ZGVCbG9ja0hhc2g6OkNvZGVCbG9ja0hhc2goY29uc3QgU291cmMKICAgICBzaGExLmNvbXB1dGVI YXNoKGRpZ2VzdCk7CiAgICAgbV9oYXNoICs9IGRpZ2VzdFswXSB8IChkaWdlc3RbMV0gPDwgOCkg fCAoZGlnZXN0WzJdIDw8IDE2KSB8IChkaWdlc3RbM10gPDwgMjQpOwogICAgIG1faGFzaCBePSBz dGF0aWNfY2FzdDx1bnNpZ25lZD4oa2luZCk7CisgICAgCisgICAgLy8gRW5zdXJlIHRoYXQgMCBj b3JyZXNwb25kcyB0byB0aGUgaGFzaCBub3QgaGF2aW5nIGJlZW4gY29tcHV0ZWQuCisgICAgaWYg KCFtX2hhc2gpCisgICAgICAgIG1faGFzaCA9IDE7CiB9CiAKIHZvaWQgQ29kZUJsb2NrSGFzaDo6 ZHVtcChQcmludFN0cmVhbSYgb3V0KSBjb25zdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9ja0hhc2guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5oCShyZXZpc2lvbiAxNTE2MTYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5oCSh3b3JraW5nIGNvcHkp CkBAIC01Niw2ICs1Niw5IEBAIHB1YmxpYzoKICAgICBDb2RlQmxvY2tIYXNoKGNvbnN0IFNvdXJj ZUNvZGUmLCBDb2RlU3BlY2lhbGl6YXRpb25LaW5kKTsKICAgICAKICAgICBleHBsaWNpdCBDb2Rl QmxvY2tIYXNoKGNvbnN0IGNoYXIqKTsKKworICAgIGJvb2wgaXNTZXQoKSBjb25zdCB7IHJldHVy biAhIW1faGFzaDsgfQorICAgIGJvb2wgb3BlcmF0b3IhKCkgY29uc3QgeyByZXR1cm4gIWlzU2V0 KCk7IH0KICAgICAKICAgICB1bnNpZ25lZCBoYXNoKCkgY29uc3QgeyByZXR1cm4gbV9oYXNoOyB9 CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RyaXZlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEcml2ZXIuY3BwCShyZXZp c2lvbiAxNTE2MTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RyaXZlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDIwIEBAIHN0YXRpYyBDb21waWxhdGlvblJlc3Vs dCBjb21waWxlKENvbXBpbGUKICAgICBpZiAoIU9wdGlvbnM6OnVzZURGR0pJVCgpIHx8ICFNYWNy b0Fzc2VtYmxlcjo6c3VwcG9ydHNGbG9hdGluZ1BvaW50KCkpCiAgICAgICAgIHJldHVybiBDb21w aWxhdGlvbkZhaWxlZDsKICAgICAKKyAgICAvLyBJZiB0aGUgY29uY3VycmVudCB0aHJlYWQgd2ls bCB3YW50IHRoZSBjb2RlIGJsb2NrJ3MgaGFzaCwgdGhlbiBjb21wdXRlIGl0IGhlcmUKKyAgICAv LyBzeW5jaHJvbm91c2x5LgorICAgIGlmIChPcHRpb25zOjpzaG93RGlzYXNzZW1ibHkoKQorICAg ICAgICB8fCBPcHRpb25zOjpzaG93REZHRGlzYXNzZW1ibHkoKQorICAgICAgICB8fCBPcHRpb25z OjpkdW1wQnl0ZWNvZGVBdERGR1RpbWUoKQorICAgICAgICB8fCBPcHRpb25zOjp2ZXJib3NlQ29t cGlsYXRpb24oKQorICAgICAgICB8fCBPcHRpb25zOjpsb2dDb21waWxhdGlvbkNoYW5nZXMoKQor ICAgICAgICB8fCBPcHRpb25zOjp2YWxpZGF0ZUdyYXBoKCkKKyAgICAgICAgfHwgT3B0aW9uczo6 dmFsaWRhdGVHcmFwaEF0RWFjaFBoYXNlKCkKKyAgICAgICAgfHwgT3B0aW9uczo6dmVyYm9zZU9T UigpCisgICAgICAgIHx8IE9wdGlvbnM6OnZlcmJvc2VDb21waWxhdGlvblF1ZXVlKCkKKyAgICAg ICAgfHwgT3B0aW9uczo6cmVwb3J0Q29tcGlsZVRpbWVzKCkpCisgICAgICAgIGNvZGVCbG9jay0+ aGFzaCgpOworICAgIAogICAgIGlmIChsb2dDb21waWxhdGlvbkNoYW5nZXMoKSkKICAgICAgICAg ZGF0YUxvZygiREZHKERyaXZlcikgY29tcGlsaW5nICIsICpjb2RlQmxvY2ssICIsIG51bWJlciBv ZiBpbnN0cnVjdGlvbnMgPSAiLCBjb2RlQmxvY2stPmluc3RydWN0aW9uQ291bnQoKSwgIlxuIik7 CiAgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTE2MTcpCisrKyBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNi0xNSAg RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIENvbmN1cnJlbnQgSklU IHNob3VsZG4ndCB0cnkgdG8gcmVjb21wdXRlIHRoZSBDb2RlQmxvY2tIYXNoIGFzIHBhcnQgb2Yg ZGVidWcgZHVtcHMsIHNpbmNlIGRvaW5nIHNvIG1heSBmYWlsIGlmIGRlYWxpbmcgd2l0aCBhIENh Y2hlZFNjcmlwdCB0aGF0IGRvZXNuJ3QgaGF2ZSBpdHMgc2NyaXB0IHN0cmluZyBoYW5keQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Njc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBi cm9rZW4gaGFjayBmb3IgdGhlIGNvbmN1cnJlbnQgSklULCBzaW5jZSBub3cgdGhlIGNvbmN1cnJl bnQgSklUIHdvbid0IHVzZSB0aGlzIGNvZGUgYW55bW9yZS4KKworICAgICAgICBObyBuZXcgdGVz dHMgYmVjYXVzZSBubyBuZXcgYmVoYXZpb3IuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2Fj aGVkU2NyaXB0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFNjcmlwdDo6c2NyaXB0KToK KwogMjAxMy0wNi0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGVkIG91dCByMTUxNDU2LCByMTUxNDIwOgpJbmRleDogU291cmNlL1dl YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFNjcmlwdC5jcHAJKHJldmlzaW9uIDE1MTYxNikK KysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRTY3JpcHQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC03MCwxMSArNzAsNiBAQCBTdHJpbmcgQ2FjaGVkU2NyaXB0OjptaW1lVHlwZSgp IGNvbnN0CiAKIGNvbnN0IFN0cmluZyYgQ2FjaGVkU2NyaXB0OjpzY3JpcHQoKQogewotICAgIGlm IChpc0NvbXBpbGF0aW9uVGhyZWFkKCkpIHsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9zY3Jp cHQpOwotICAgICAgICByZXR1cm4gbV9zY3JpcHQ7Ci0gICAgfQotICAgIAogICAgIEFTU0VSVCgh aXNQdXJnZWFibGUoKSk7CiAKICAgICBpZiAoIW1fc2NyaXB0ICYmIG1fZGF0YSkgewo=