117674 2013-06-15 10:45:27 -0700 Support using clang instead of gcc for bindings preprocessing 2013-06-16 08:42:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 darin darin cdumez commit-queue ddkilzer mrowe oldest_to_newest 900786 0 darin 2013-06-15 10:45:27 -0700 Support using clang instead of gcc for bindings preprocessing 900787 1 204771 darin 2013-06-15 10:46:08 -0700 Created attachment 204771 Patch 900843 2 204771 commit-queue 2013-06-15 19:15:58 -0700 Comment on attachment 204771 Patch Clearing flags on attachment: 204771 Committed r151619: <http://trac.webkit.org/changeset/151619> 900844 3 commit-queue 2013-06-15 19:16:00 -0700 All reviewed patches have been landed. Closing bug. 900849 4 ddkilzer 2013-06-15 20:09:46 -0700 The 'CC' environment variable should have been set to the correct compiler by the "Generate Derived Sources" build phase script (unless you were running the scripts outside of an Xcode build). In the case of running the scripts outside of Xcode, the proper way to fix this for Mac OS X is to use 'xcrun' to find 'cc', which maps to the default compiler for the specified SDK (or the "current" SDK on Mac OS X) rather than to hard-code paths that assume the "CLTools" package is installed with Xcode (which isn't always true): xcrun -find cc 900850 5 mrowe 2013-06-15 20:17:22 -0700 Yeah, I'm also surprised that the CC environment variable wasn't taking care of this. 900874 6 darin 2013-06-16 08:42:11 -0700 (In reply to comment #4) > The 'CC' environment variable should have been set to the correct compiler by the "Generate Derived Sources" build phase script (unless you were running the scripts outside of an Xcode build). I was. This is to make run-bindings-tests work. Sorry, I should have said that. > In the case of running the scripts outside of Xcode, the proper way to fix this for Mac OS X is to use 'xcrun' to find 'cc', which maps to the default compiler for the specified SDK (or the "current" SDK on Mac OS X) rather than to hard-code paths that assume the "CLTools" package is installed with Xcode (which isn't always true): > > xcrun -find cc We could put a Mac-specific fix like that into these two perl scripts, or add Mac-specific code to run-bindings-tests so it sets CC. Do you have a preference, Dave? 204771 2013-06-15 10:46:08 -0700 2013-06-15 19:15:58 -0700 Patch bug-117674-20130615104425.patch text/plain 2224 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc3ODkzZWNkYjdiYmJm MmNlZGY3ZWJhMTExMzJjMzhkN2ZmOTYxNC4uZjgzNTI2YmNjN2M0MTNmYTNjMmUyMzc2MmNmYjY2 MTcwNzBmMGU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTE1ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTdXBwb3J0IHVzaW5nIGNsYW5n IGluc3RlYWQgb2YgZ2NjIGZvciBiaW5kaW5ncyBwcmVwcm9jZXNzaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2NzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGNvdWxkbid0IGJ1aWxkIG9uIG15 IGNvbXB1dGVyIGJlY2F1c2UgSSBkb24ndCBoYXZlIGdjYyBpbnN0YWxsZWQuCisgICAgICAgIFRo aXMgaXMgbXkgY3V0IGF0IGZpeGluZyBpdC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvck9iakMucG06CisgICAgICAgIChSZWFkUHVibGljSW50ZXJmYWNlcyk6IFVz ZSBjbGFuZyBpZiBwcmVzZW50LgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vz c29yLnBtOgorICAgICAgICAoYXBwbHlQcmVwcm9jZXNzb3IpOiBEaXR0by4KKwogMjAxMy0wNi0x NCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2xpY2tpbmcgb24g c25hcHNob3R0aW5nIHBsdWctaW5zIGRvZXMgbm90IHJlc3RhcnQgdGhlbQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KaW5kZXgg MjliMTM1MjM1MTQ1ODhmYjk3NmIwZWY0YWEzMzBhN2FjMGUzNTI3Zi4uMzdiZTQ0MWRhOTc5MzMx NmRhNmIyYWQ0ZGYyNzE3ZDhmNzk5MTE2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCkBAIC0yMjAsNiArMjIwLDggQEAg c3ViIFJlYWRQdWJsaWNJbnRlcmZhY2VzCiAgICAgICAgICRnY2NMb2NhdGlvbiA9ICRFTlZ7Q0N9 OwogICAgIH0gZWxzaWYgKCgkQ29uZmlnOjpDb25maWd7J29zbmFtZSd9KSA9fiAvc29sYXJpcy9p KSB7CiAgICAgICAgICRnY2NMb2NhdGlvbiA9ICIvdXNyL3Nmdy9iaW4vZ2NjIjsKKyAgICB9IGVs c2lmICgteCAiL3Vzci9iaW4vY2xhbmciKSB7CisgICAgICAgICRnY2NMb2NhdGlvbiA9ICIvdXNy L2Jpbi9jbGFuZyI7CiAgICAgfSBlbHNlIHsKICAgICAgICAgJGdjY0xvY2F0aW9uID0gIi91c3Iv YmluL2djYyI7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9wcmVwcm9jZXNzb3IucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3By ZXByb2Nlc3Nvci5wbQppbmRleCA5NTk5NWYwMGFmMDI3YTdhNmUwZWRkYzE3NDVlNDA2M2NkOWZi ZDBiLi5jYjMwZjgwYzAxNmZmNzYyM2E5MGQzYzlhOTlkYmM4YzQ5MzcyY2QyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQpAQCAtNDksNiAr NDksOCBAQCBzdWIgYXBwbHlQcmVwcm9jZXNzb3IKICAgICAgICAgICAgICRwcmVwcm9jZXNzb3Ig PSAkRU5We0NDfTsKICAgICAgICAgfSBlbHNpZiAoKCRDb25maWc6OkNvbmZpZ3snb3NuYW1lJ30p ID1+IC9zb2xhcmlzL2kpIHsKICAgICAgICAgICAgICRwcmVwcm9jZXNzb3IgPSAiL3Vzci9zZncv YmluL2djYyI7CisgICAgICAgIH0gZWxzaWYgKC14ICIvdXNyL2Jpbi9jbGFuZyIpIHsKKyAgICAg ICAgICAgICRwcmVwcm9jZXNzb3IgPSAiL3Vzci9iaW4vY2xhbmciOwogICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgJHByZXByb2Nlc3NvciA9ICIvdXNyL2Jpbi9nY2MiOwogICAgICAgICB9 Cg==