117665 2013-06-14 16:56:04 -0700 Crash in loadPendingShaders 2013-06-17 15:42:58 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino achicu allan.jensen commit-queue esprehn+autocc glenn macpherson menard mvujovic WebkitBugTracker oldest_to_newest 900707 0 dino 2013-06-14 16:56:04 -0700 We're getting many reports of a crash in loadPendingShaders. Alas, we don't have the content or URLs - it's an automated system. Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00007fff8c2f19d8 WebCore::StyleResolver::loadPendingShaders() + 24 1 com.apple.WebCore 0x00007fff8c2e4f71 WebCore::StyleResolver::applyMatchedProperties(WebCore::StyleResolver::MatchResult const&, WebCore::Element const*) + 1089 2 com.apple.WebCore 0x00007fff8c2e0a0c WebCore::StyleResolver::styleForElement(WebCore::Element*, WebCore::RenderStyle*, WebCore::StyleSharingBehavior, WebCore::RuleMatchingBehavior, WebCore::RenderRegion*) + 3404 3 com.apple.WebCore 0x00007fff8bd4044a WebCore::Element::styleForRenderer() + 122 4 com.apple.WebCore 0x00007fff8c1246c0 WebCore::NodeRenderingContext::createRendererForElementIfNeeded() + 48 5 com.apple.WebCore 0x00007fff8b6b57e7 WebCore::Element::attach() + 55 6 com.apple.WebCore 0x00007fff8bdc894c WebCore::executeTask(WebCore::HTMLConstructionSiteTask&) + 172 7 com.apple.WebCore 0x00007fff8bdc886c WebCore::HTMLConstructionSite::executeQueuedTasks() + 108 8 com.apple.WebCore 0x00007fff8b6b4d0a WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) + 74 9 com.apple.WebCore 0x00007fff8b69a700 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) + 352 10 com.apple.WebCore 0x00007fff8b6fd2b3 WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) + 243 11 com.apple.WebCore 0x00007fff8bc493be WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, unsigned long) + 126 12 com.apple.WebCore 0x00007fff8bc5f6f7 WebCore::DocumentLoader::commitData(char const*, unsigned long) + 327 13 com.apple.WebKit2 0x00007fff87bdfd18 WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 74 14 com.apple.WebCore 0x00007fff8b6f88eb WebCore::DocumentLoader::commitLoad(char const*, int) + 139 15 com.apple.WebCore 0x00007fff8c0efd11 WebCore::MainResourceLoader::dataReceived(WebCore::CachedResource*, char const*, int) + 657 16 com.apple.WebCore 0x00007fff8bb842f3 WebCore::CachedRawResource::data(WTF::PassRefPtr<WebCore::ResourceBuffer>, bool) + 387 17 com.apple.WebCore 0x00007fff8c30381b WebCore::SubresourceLoader::sendDataToResource(char const*, int) + 139 18 com.apple.WebCore 0x00007fff8b733ebc WebCore::SubresourceLoader::didReceiveData(char const*, int, long long, bool) + 76 900708 1 dino 2013-06-14 16:56:32 -0700 <rdar://problem/12936342> 900777 2 achicu 2013-06-15 08:29:47 -0700 I will take a look on Monday. 901178 3 204858 mvujovic 2013-06-17 15:03:24 -0700 Created attachment 204858 Patch Speculative fix. My build isn't done yet, so hopefully this compiles :) 901181 4 204858 mvujovic 2013-06-17 15:15:49 -0700 Comment on attachment 204858 Patch My build looks good. Setting cq+. 901185 5 204858 commit-queue 2013-06-17 15:42:56 -0700 Comment on attachment 204858 Patch Clearing flags on attachment: 204858 Committed r151657: <http://trac.webkit.org/changeset/151657> 901186 6 commit-queue 2013-06-17 15:42:58 -0700 All reviewed patches have been landed. Closing bug. 204858 2013-06-17 15:03:24 -0700 2013-06-17 15:42:56 -0700 Patch 117665-1.patch text/plain 1678 mvujovic ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNGY2OGU4Li5lY2ZmYWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDYtMTcgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAg ICAgIENyYXNoIGluIGxvYWRQZW5kaW5nU2hhZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY3VsYXRpdmUgZml4IGJlY2F1c2UgdGhlIGNyYXNo IHJlcG9ydHMgZG8gbm90IGNvbnRhaW4gYSB0ZXN0IGNhc2UuCisKKyAgICAgICAgUmVhcnJhbmdl IHRoZSBjb25kaXRpb25zIHRvIGNoZWNrIG1fc3RhdGUuaGFzUGVuZGluZ1NoYWRlcnMoKSBmaXJz dC4gQWRkaXRpb25hbGx5LCBjaGVjayBpZgorICAgICAgICBtX3N0YXRlLnN0eWxlKCkgaXMgbm9u LW51bGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBXZSBkb24ndCBrbm93IGhvdyB0byByZXBy b2R1Y2UgdGhpcyBjcmFzaCB5ZXQuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpsb2FkUGVuZGluZ1NoYWRlcnMpOgor CiAyMDEzLTA2LTE3ICBSdXRoIEZvbmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT046IEltcG9ydGFudCBjb250cm9scyBhcmUgbWlzc2luZyBmcm9tIDx2aWRlbz4g ZWxlbWVudCBVSSwgd2hlbiBjb21wYXJlZCB0byBRdWlja1RpbWUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmNwcAppbmRleCAyZGE4MDNkLi41YzM4YmVhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwCkBAIC0zNjIyLDcgKzM2MjIsOSBAQCBQYXNzUmVmUHRyPEN1c3RvbUZp bHRlclByb2dyYW0+IFN0eWxlUmVzb2x2ZXI6Omxvb2t1cEN1c3RvbUZpbHRlclByb2dyYW0oV2Vi S2l0QwogCiB2b2lkIFN0eWxlUmVzb2x2ZXI6OmxvYWRQZW5kaW5nU2hhZGVycygpCiB7Ci0gICAg aWYgKCFtX3N0YXRlLnN0eWxlKCktPmhhc0ZpbHRlcigpIHx8ICFtX3N0YXRlLmhhc1BlbmRpbmdT aGFkZXJzKCkpCisgICAgLy8gRklYTUU6IFdlIHNob3VsZG4ndCBoYXZlIHRvIGNoZWNrIHRoYXQg c3R5bGUgaXMgbm9uLW51bGwuIFRoaXMgaXMgYSBzcGVjdWxhdGl2ZSBmaXggZm9yOgorICAgIC8v IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2NjUKKyAgICBpZiAo IW1fc3RhdGUuaGFzUGVuZGluZ1NoYWRlcnMoKSB8fCAhbV9zdGF0ZS5zdHlsZSgpIHx8ICFtX3N0 YXRlLnN0eWxlKCktPmhhc0ZpbHRlcigpKQogICAgICAgICByZXR1cm47CiAKICAgICBDYWNoZWRS ZXNvdXJjZUxvYWRlciogY2FjaGVkUmVzb3VyY2VMb2FkZXIgPSBtX3N0YXRlLmRvY3VtZW50KCkt PmNhY2hlZFJlc291cmNlTG9hZGVyKCk7Cg==