11765 2006-12-05 17:15:58 -0800 REGRESSION: Clicking on a select with size other than 1 and no children results in a crash 2006-12-08 15:07:42 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 jlukas webkit-unassigned mitz oldest_to_newest 43186 0 jlukas 2006-12-05 17:15:58 -0800 Clicking on a select with size other than 1 and no children results in a crash. This is reproducible every time. 43159 1 11747 jlukas 2006-12-05 17:16:33 -0800 Created attachment 11747 Reduced test case 43157 2 dev+webkit 2006-12-05 17:44:34 -0800 Confirming - I also get the following assertion failure ASSERTION FAILED: i < size() (/Users/matt/Code/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/PrivateHeaders/Vector.h:387 const T& WTF::Vector<T, inlineCapacity>::at(size_t) const [with T = WebCore::HTMLElement*, long unsigned int inlineCapacity = 0ul]) 42933 3 11771 rwlbuis 2006-12-08 05:17:38 -0800 Created attachment 11771 First attempt This patch should fix it. The testcase is a bit tricky but I think it does the job, with ToT it shows the crash, with my patch it will say Passed. Cheers, Rob. 42756 4 rwlbuis 2006-12-08 15:07:42 -0800 Landed in r18089. 11747 2006-12-05 17:16:33 -0800 2006-12-05 17:16:33 -0800 Reduced test case test.xhtml application/xhtml+xml 650 jlukas PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCFET0NUWVBFIGh0bWwgUFVC TElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAKCSJodHRwOi8vd3d3LnczLm9yZy9UUi94 aHRtbDExL0RURC94aHRtbDExLmR0ZCI+CjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8x OTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPgoJPGhlYWQ+CgkJPHRpdGxlPnVudGl0bGVkPC90aXRs ZT4KCQkKCQk8bWV0YSBodHRwLWVxdWl2PSJpbWFnZXRvb2xiYXIiIGNvbnRlbnQ9Im5vIiAvPgoJ CTxtZXRhIG5hbWU9Ik1TU21hcnRUYWdzUHJldmVudFBhcnNpbmciIGNvbnRlbnQ9InRydWUiIC8+ CgkJCgkJPGxpbmsgaHJlZj0ic3R5bGUvbWFzdGVyLmNzcyIgcmVsPSJzdHlsZXNoZWV0IiB0eXBl PSJ0ZXh0L2NzcyIgbWVkaWE9ImFsbCIgLz4KCQk8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCIgc3JjPSJzY3JpcHQvYmFzaWMuanMiPjwvc2NyaXB0PgoJPC9oZWFkPgoJPGJvZHk+CgkJPHNl bGVjdCBzdHlsZT0id2lkdGg6MTAwcHg7aGVpZ2h0OjEwMHB4OyIgc2l6ZT0iMiI+PC9zZWxlY3Q+ CgkJPHNlbGVjdCBzdHlsZT0id2lkdGg6MTAwcHg7aGVpZ2h0OjEwMHB4OyIgc2l6ZT0iMSI+PC9z ZWxlY3Q+Cgk8L2JvZHk+CjwvaHRtbD4= 11771 2006-12-08 05:17:38 -0800 2006-12-08 14:25:06 -0800 First attempt 11765.diff text/plain 4118 rwlbuis SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4MDc1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMTItMDggIFJvYiBCdWlzICA8YnVpc0Br ZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3RjYXNlIGZvcjoKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE3NjUKKyAgICAgICAgUkVHUkVTU0lPTjogQ2xpY2tpbmcgb24gYSBzZWxlY3Qgd2l0 aCBzaXplIG90aGVyIHRoYW4gMSBhbmQgbm8gY2hpbGRyZW4gcmVzdWx0cyBpbiBhIGNyYXNoCisK KyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlbGVjdC1lbXB0eS1saXN0LWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWxlY3QtZW1wdHktbGlzdC5odG1sOiBBZGRlZC4K KwogMjAwNi0xMi0wOCAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1lbXB0eS1s aXN0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nl bGVjdC1lbXB0eS1saXN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZm9ybXMvc2VsZWN0LWVtcHR5LWxpc3QtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDcgQEAKK1RoaXMgdGVzdHMgY2xpY2tpbmcgb24gYW4gZW1wdHkgc2VsZWN0LiBJ ZiBzdWNjZXNzZnVsLCB0aGUgY29uc29sZSBtZXNzYWdlIHNheXMgUGFzc2VkLiBTZWUgYnVnIDEx NzY1LgorCisKK1Bhc3NlZAorCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxl Y3QtZW1wdHktbGlzdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMv c2VsZWN0LWVtcHR5LWxpc3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvc2VsZWN0LWVtcHR5LWxpc3QuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOSBA QAorPGhlYWQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gdGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgZXZlbnRTZW5k ZXIubW91c2VNb3ZlVG8oMjAsIDcwKTsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7 CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIHNl bGVjdENsaWNrZWQoKSB7CisgICAgdmFyIG1lc3NhZ2UgPSAiUGFzc2VkIjsKKyAgICB2YXIgcGFy YWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgncCcpOworICAgIHBhcmFncmFwaC5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtZXNzYWdlKSk7CisgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5hcHBlbmRDaGlsZChwYXJhZ3JhcGgpOworfQorPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgorPHA+VGhpcyB0ZXN0cyBj bGlja2luZyBvbiBhbiBlbXB0eSBzZWxlY3QuIElmIHN1Y2Nlc3NmdWwsIHRoZSBjb25zb2xlIG1l c3NhZ2Ugc2F5cyBQYXNzZWQuIFNlZSBidWcgMTE3NjUuCis8Zm9ybT4KKzxzZWxlY3QgIG9uY2xp Y2s9InNlbGVjdENsaWNrZWQoKSIgc3R5bGU9IndpZHRoOjEwMHB4O2hlaWdodDoxMDBweDsiIGlk PSJzZWxlY3QiIHNpemU9Mj4KKzwvc2VsZWN0PgorPC9mb3JtPgorPHAgaWQ9ImNvbnNvbGUiPjwv cD4KKzwvYm9keT4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODA3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMTItMDggIFJvYiBCdWlzICA8YnVpc0Br ZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzY1CisgICAgICAgIFJF R1JFU1NJT046IENsaWNraW5nIG9uIGEgc2VsZWN0IHdpdGggc2l6ZSBvdGhlciB0aGFuIDEgYW5k IG5vIGNoaWxkcmVuIHJlc3VsdHMgaW4gYSBjcmFzaAorCisgICAgICAgIE1ha2Ugc3VyZSByZXR1 cm5lZCB2YWx1ZSBpcyAtMSBmb3Igc2VsZWN0cyB3aXRob3V0IGNoaWxkcmVuLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TGlzdEJveDo6bGlzdEluZGV4QXRPZmZzZXQpOgorCiAyMDA2LTEyLTA4ICBNaXR6IFBldHRlbCAg PG1pdHpAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBoeWF0dC4KSW5kZXg6IFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCShyZXZpc2lvbiAxODA3MykKKysrIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxpc3RCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTEsMTEgKzM1 MSwxMyBAQCBpbnQgUmVuZGVyTGlzdEJveDo6bGlzdEluZGV4QXRPZmZzZXQoaW50CiAgICAgSFRN TFNlbGVjdEVsZW1lbnQqIHNlbGVjdCA9IHN0YXRpY19jYXN0PEhUTUxTZWxlY3RFbGVtZW50Kj4o bm9kZSgpKTsKICAgICBjb25zdCBWZWN0b3I8SFRNTEVsZW1lbnQqPiYgbGlzdEl0ZW1zID0gc2Vs ZWN0LT5saXN0SXRlbXMoKTsKIAotICAgIGludCBuZXdPZmZzZXQgPSBtYXgoMCwgb2Zmc2V0WSAv IChzdHlsZSgpLT5mb250KCkuaGVpZ2h0KCkgKyBvcHRpb25zU3BhY2luZ01pZGRsZSkpICsgbV9p bmRleE9mZnNldDsKLSAgICBuZXdPZmZzZXQgPSBtYXgoMCwgbWluKChpbnQpbGlzdEl0ZW1zLnNp emUoKSAtIDEsIG5ld09mZnNldCkpOwotICAgIGludCBzY3JvbGxiYXJXaWR0aCA9IG1fdkJhciA/ IG1fdkJhci0+d2lkdGgoKSA6IDA7Ci0gICAgaWYgKG9mZnNldFggPj0gYm9yZGVyTGVmdCgpICsg cGFkZGluZ0xlZnQoKSAmJiBvZmZzZXRYIDwgYWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKS53aWR0 aCgpIC0gYm9yZGVyUmlnaHQoKSAtIHBhZGRpbmdSaWdodCgpIC0gc2Nyb2xsYmFyV2lkdGgpCi0g ICAgICAgIHJldHVybiBuZXdPZmZzZXQ7CisgICAgaWYgKChpbnQpbGlzdEl0ZW1zLnNpemUoKSA+ IDApIHsKKyAgICAgICAgaW50IG5ld09mZnNldCA9IG1heCgwLCBvZmZzZXRZIC8gKHN0eWxlKCkt PmZvbnQoKS5oZWlnaHQoKSArIG9wdGlvbnNTcGFjaW5nTWlkZGxlKSkgKyBtX2luZGV4T2Zmc2V0 OworICAgICAgICBuZXdPZmZzZXQgPSBtYXgoMCwgbWluKChpbnQpbGlzdEl0ZW1zLnNpemUoKSAt IDEsIG5ld09mZnNldCkpOworICAgICAgICBpbnQgc2Nyb2xsYmFyV2lkdGggPSBtX3ZCYXIgPyBt X3ZCYXItPndpZHRoKCkgOiAwOworICAgICAgICBpZiAob2Zmc2V0WCA+PSBib3JkZXJMZWZ0KCkg KyBwYWRkaW5nTGVmdCgpICYmIG9mZnNldFggPCBhYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpLndp ZHRoKCkgLSBib3JkZXJSaWdodCgpIC0gcGFkZGluZ1JpZ2h0KCkgLSBzY3JvbGxiYXJXaWR0aCkK KyAgICAgICAgICAgIHJldHVybiBuZXdPZmZzZXQ7CisgICAgfQogICAgICAgICAgICAgCiAgICAg cmV0dXJuIC0xOwogfQo=