117638 2013-06-14 05:52:26 -0700 [GTK] Let F5 refresh the page in MiniBrowser 2013-07-03 00:31:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mstensho mstensho berto cgarcia commit-queue oldest_to_newest 900522 0 mstensho 2013-06-14 05:52:26 -0700 Useful when playing with test cases and you want to reload conveniently and quickly. :) 900525 1 204707 mstensho 2013-06-14 05:57:33 -0700 Created attachment 204707 Patch 905359 2 berto 2013-07-02 05:24:14 -0700 Looks good to me. Maybe we could have both the load and reload icons? Anyway it's weird that we were using the wrong icon there :) 905361 3 mstensho 2013-07-02 05:29:31 -0700 Do you want me to add another button with the load icon (which actually performs a load action rather than reloading)? What's that for anyway? For those with trouble finding the Enter key? :) Touch UI? 905369 4 berto 2013-07-02 05:46:07 -0700 Yeah, I don't know, if no one missed it in all this time I guess it's not so important :) 905380 5 204707 cgarcia 2013-07-02 06:08:32 -0700 Comment on attachment 204707 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204707&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:528 > + GtkAccelGroup *accelGroup = gtk_accel_group_new(); > + gtk_window_add_accel_group(GTK_WINDOW(window), accelGroup); gtk_window_add_accel_group takes a reference of the accel group, so you need to call g_object_unref(). 905400 6 205905 mstensho 2013-07-02 06:46:22 -0700 Created attachment 205905 Patch 905495 7 205905 cgarcia 2013-07-02 11:01:02 -0700 Comment on attachment 205905 Patch LGTM 905715 8 205905 commit-queue 2013-07-03 00:31:09 -0700 Comment on attachment 205905 Patch Clearing flags on attachment: 205905 Committed r152341: <http://trac.webkit.org/changeset/152341> 905716 9 commit-queue 2013-07-03 00:31:12 -0700 All reviewed patches have been landed. Closing bug. 204707 2013-06-14 05:57:33 -0700 2013-07-02 06:46:17 -0700 Patch bug-117638-20130614145600.patch text/plain 2323 mstensho U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTVlODBlZmI3MDIxNzQyMDgzYjczZmQyOWIwZDFlNzYw MjkyYTFmYy4uMWQwMDQyMGU5MmRmMDg0M2QyZDFhYmE5YmE4YjdkZmEzMTQ2OWJlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA2LTE0ICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4K KworICAgICAgICBbR1RLXSBMZXQgRjUgcmVmcmVzaCB0aGUgcGFnZSBpbiBNaW5pQnJvd3Nlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NjM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyB1c2Ug dGhlIGNvcnJlY3QgaWNvbiBmb3IgdGhlIHJlZnJlc2ggYnV0dG9uIHRoYXQgd2FzIGFscmVhZHkg dGhlcmUuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgorICAg ICAgICAoYnJvd3Nlcl93aW5kb3dfaW5pdCk6CisKIDIwMTMtMDYtMTQgIFRvciBBcm5lIFZlc3Ri w7ggIDx0b3IuYXJuZS52ZXN0Ym9AZGlnaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBteXNlbGYg ZnJvbSBRdCBidWlsZCBzeXN0ZW0gd2F0Y2hsaXN0CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJv d3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJX aW5kb3cuYwppbmRleCA1NWY5MDY4MjBjOWQ2MTU4ZDNjNTU3NzMzMDJmZjgwYWI2ZWFlYjZmLi4z YzcwOTVjODhkOWY5MzlhMGU3MTUxMjc3YjE2YmM0NTFlOGY0ZjYxIDEwMDY0NAotLS0gYS9Ub29s cy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2Vy L2d0ay9Ccm93c2VyV2luZG93LmMKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2luY2x1ZGUgIkJyb3dz ZXJEb3dubG9hZHNCYXIuaCIKICNpbmNsdWRlICJCcm93c2VyU2V0dGluZ3NEaWFsb2cuaCIKKyNp bmNsdWRlIDxnZGsvZ2Rra2V5c3ltcy5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgogCiBlbnVtIHsK QEAgLTUyMiw2ICs1MjMsMTAgQEAgc3RhdGljIHZvaWQgYnJvd3Nlcl93aW5kb3dfaW5pdChCcm93 c2VyV2luZG93ICp3aW5kb3cpCiAgICAgZ3RrX2VudHJ5X3NldF9pY29uX2FjdGl2YXRhYmxlKEdU S19FTlRSWSh3aW5kb3ctPnVyaUVudHJ5KSwgR1RLX0VOVFJZX0lDT05fUFJJTUFSWSwgRkFMU0Up OwogICAgIHVwZGF0ZVVyaUVudHJ5SWNvbih3aW5kb3cpOwogCisgICAgLyogS2V5Ym9hcmQgYWNj ZWxlcmF0b3JzICovCisgICAgR3RrQWNjZWxHcm91cCAqYWNjZWxHcm91cCA9IGd0a19hY2NlbF9n cm91cF9uZXcoKTsKKyAgICBndGtfd2luZG93X2FkZF9hY2NlbF9ncm91cChHVEtfV0lORE9XKHdp bmRvdyksIGFjY2VsR3JvdXApOworCiAgICAgR3RrV2lkZ2V0ICp0b29sYmFyID0gZ3RrX3Rvb2xi YXJfbmV3KCk7CiAgICAgd2luZG93LT50b29sYmFyID0gdG9vbGJhcjsKICAgICBndGtfb3JpZW50 YWJsZV9zZXRfb3JpZW50YXRpb24oR1RLX09SSUVOVEFCTEUodG9vbGJhciksIEdUS19PUklFTlRB VElPTl9IT1JJWk9OVEFMKTsKQEAgLTU2NSw5ICs1NzAsMTAgQEAgc3RhdGljIHZvaWQgYnJvd3Nl cl93aW5kb3dfaW5pdChCcm93c2VyV2luZG93ICp3aW5kb3cpCiAgICAgZ3RrX3Rvb2xiYXJfaW5z ZXJ0KEdUS19UT09MQkFSKHRvb2xiYXIpLCBpdGVtLCAtMSk7CiAgICAgZ3RrX3dpZGdldF9zaG93 KEdUS19XSURHRVQoaXRlbSkpOwogCi0gICAgaXRlbSA9IGd0a190b29sX2J1dHRvbl9uZXdfZnJv bV9zdG9jayhHVEtfU1RPQ0tfT0spOworICAgIGl0ZW0gPSBndGtfdG9vbF9idXR0b25fbmV3X2Zy b21fc3RvY2soR1RLX1NUT0NLX1JFRlJFU0gpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBl ZChpdGVtLCAiY2xpY2tlZCIsIEdfQ0FMTEJBQ0socmVsb2FkQ2FsbGJhY2spLCB3aW5kb3cpOwog ICAgIGd0a190b29sYmFyX2luc2VydChHVEtfVE9PTEJBUih0b29sYmFyKSwgaXRlbSwgLTEpOwor ICAgIGd0a193aWRnZXRfYWRkX2FjY2VsZXJhdG9yKEdUS19XSURHRVQoaXRlbSksICJjbGlja2Vk IiwgYWNjZWxHcm91cCwgR0RLX0tFWV9GNSwgMCwgR1RLX0FDQ0VMX1ZJU0lCTEUpOwogICAgIGd0 a193aWRnZXRfc2hvdyhHVEtfV0lER0VUKGl0ZW0pKTsKIAogICAgIEd0a1dpZGdldCAqdmJveCA9 IGd0a19ib3hfbmV3KEdUS19PUklFTlRBVElPTl9WRVJUSUNBTCwgMCk7Cg== 205905 2013-07-02 06:46:22 -0700 2013-07-03 00:31:09 -0700 Patch bug-117638-20130702154429.patch text/plain 2355 mstensho U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzJjYWU3Yzc2NzQxMGY3N2YwMjkxOTlhOTQ2YTcwZjkw OTliZWQ3YS4uMGZkYTVlY2I2ZDNjOThlMmQzYmI5OTI1OGJlNjRiYzc1YzJiNDFiZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTAyICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4K KworICAgICAgICBbR1RLXSBMZXQgRjUgcmVmcmVzaCB0aGUgcGFnZSBpbiBNaW5pQnJvd3Nlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NjM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyB1c2Ug dGhlIGNvcnJlY3QgaWNvbiBmb3IgdGhlIHJlZnJlc2ggYnV0dG9uIHRoYXQgd2FzIGFscmVhZHkg dGhlcmUuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgorICAg ICAgICAoYnJvd3Nlcl93aW5kb3dfaW5pdCk6CisKIDIwMTMtMDctMDIgIEFsbGFuIFNhbmRmZWxk IEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzFdIFN1 cHBvcnQgV2ViR0wgd2l0aCBFR0wgb24gTGludXgKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93 c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3Nlcldp bmRvdy5jCmluZGV4IDU1ZjkwNjgyMGM5ZDYxNThkM2M1NTc3MzMwMmZmODBhYjZlYWViNmYuLmM5 NWY0OWM5ODU1ZjNlYzA5N2I4ZGU4NzgzMmM0Njc3YmY5NmE3NDkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIv Z3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtMjksNiArMjksNyBAQAogCiAjaW5jbHVkZSAiQnJvd3Nl ckRvd25sb2Fkc0Jhci5oIgogI2luY2x1ZGUgIkJyb3dzZXJTZXR0aW5nc0RpYWxvZy5oIgorI2lu Y2x1ZGUgPGdkay9nZGtrZXlzeW1zLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAKIGVudW0gewpA QCAtNTIyLDYgKzUyMywxMSBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dz ZXJXaW5kb3cgKndpbmRvdykKICAgICBndGtfZW50cnlfc2V0X2ljb25fYWN0aXZhdGFibGUoR1RL X0VOVFJZKHdpbmRvdy0+dXJpRW50cnkpLCBHVEtfRU5UUllfSUNPTl9QUklNQVJZLCBGQUxTRSk7 CiAgICAgdXBkYXRlVXJpRW50cnlJY29uKHdpbmRvdyk7CiAKKyAgICAvKiBLZXlib2FyZCBhY2Nl bGVyYXRvcnMgKi8KKyAgICBHdGtBY2NlbEdyb3VwICphY2NlbEdyb3VwID0gZ3RrX2FjY2VsX2dy b3VwX25ldygpOworICAgIGd0a193aW5kb3dfYWRkX2FjY2VsX2dyb3VwKEdUS19XSU5ET1cod2lu ZG93KSwgYWNjZWxHcm91cCk7CisgICAgZ19vYmplY3RfdW5yZWYoYWNjZWxHcm91cCk7CisKICAg ICBHdGtXaWRnZXQgKnRvb2xiYXIgPSBndGtfdG9vbGJhcl9uZXcoKTsKICAgICB3aW5kb3ctPnRv b2xiYXIgPSB0b29sYmFyOwogICAgIGd0a19vcmllbnRhYmxlX3NldF9vcmllbnRhdGlvbihHVEtf T1JJRU5UQUJMRSh0b29sYmFyKSwgR1RLX09SSUVOVEFUSU9OX0hPUklaT05UQUwpOwpAQCAtNTY1 LDkgKzU3MSwxMCBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5k b3cgKndpbmRvdykKICAgICBndGtfdG9vbGJhcl9pbnNlcnQoR1RLX1RPT0xCQVIodG9vbGJhciks IGl0ZW0sIC0xKTsKICAgICBndGtfd2lkZ2V0X3Nob3coR1RLX1dJREdFVChpdGVtKSk7CiAKLSAg ICBpdGVtID0gZ3RrX3Rvb2xfYnV0dG9uX25ld19mcm9tX3N0b2NrKEdUS19TVE9DS19PSyk7Cisg ICAgaXRlbSA9IGd0a190b29sX2J1dHRvbl9uZXdfZnJvbV9zdG9jayhHVEtfU1RPQ0tfUkVGUkVT SCk7CiAgICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVkKGl0ZW0sICJjbGlja2VkIiwgR19DQUxM QkFDSyhyZWxvYWRDYWxsYmFjayksIHdpbmRvdyk7CiAgICAgZ3RrX3Rvb2xiYXJfaW5zZXJ0KEdU S19UT09MQkFSKHRvb2xiYXIpLCBpdGVtLCAtMSk7CisgICAgZ3RrX3dpZGdldF9hZGRfYWNjZWxl cmF0b3IoR1RLX1dJREdFVChpdGVtKSwgImNsaWNrZWQiLCBhY2NlbEdyb3VwLCBHREtfS0VZX0Y1 LCAwLCBHVEtfQUNDRUxfVklTSUJMRSk7CiAgICAgZ3RrX3dpZGdldF9zaG93KEdUS19XSURHRVQo aXRlbSkpOwogCiAgICAgR3RrV2lkZ2V0ICp2Ym94ID0gZ3RrX2JveF9uZXcoR1RLX09SSUVOVEFU SU9OX1ZFUlRJQ0FMLCAwKTsK