117630 2013-06-14 01:22:01 -0700 Fix WebKitTestRunner crashes. 2013-07-02 09:19:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bw80.lee bw80.lee commit-queue oldest_to_newest 900455 0 bw80.lee 2013-06-14 01:22:01 -0700 WebKitTestRunner will crash when WebProcess is not responsible. 900457 1 204683 bw80.lee 2013-06-14 01:45:11 -0700 Created attachment 204683 Patch 900581 2 204683 darin 2013-06-14 09:22:26 -0700 Comment on attachment 204683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204683&action=review > Tools/WebKitTestRunner/TestController.cpp:757 > + TestInvocation::dumpWebProcessUnresponsiveness("<unknown> - TestController::run - Failed to reset state to consistent values\n"); Should this string have a newline in it? 902865 3 204683 bw80.lee 2013-06-23 23:25:11 -0700 Comment on attachment 204683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204683&action=review Thanks for the r+ >> Tools/WebKitTestRunner/TestController.cpp:757 >> + TestInvocation::dumpWebProcessUnresponsiveness("<unknown> - TestController::run - Failed to reset state to consistent values\n"); > > Should this string have a newline in it? Yes, the string will be passed to the TestInvocation::dump() through the argument 'textToStdout', and the tailing newline will separate the string and the '#EOF' string that the dump() function prints after the string. (All the stdout messages passed to the dump() function contains tailing newline with the current dump() implementation) 905413 4 204683 commit-queue 2013-07-02 07:24:39 -0700 Comment on attachment 204683 Patch Rejecting attachment 204683 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 204683, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1014522 905429 5 205914 bw80.lee 2013-07-02 07:47:24 -0700 Created attachment 205914 Patch Fix ChangeLog error 905460 6 205914 commit-queue 2013-07-02 09:19:47 -0700 Comment on attachment 205914 Patch Clearing flags on attachment: 205914 Committed r152295: <http://trac.webkit.org/changeset/152295> 905461 7 commit-queue 2013-07-02 09:19:49 -0700 All reviewed patches have been landed. Closing bug. 204683 2013-06-14 01:45:11 -0700 2013-07-02 07:47:24 -0700 Patch bug-117630-20130614174342.patch text/plain 3341 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGZlMWMzZjU2NGQ0ZGRlNTgxZGIwNmRiMTIxMGVlYWUy MTAwZThiOC4uYzBkZTM0MzE2MmU0Y2Y5MTlkNDBiMGIyMzJjZmQ3ZjAxNmY0YWE5NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTA2LTE0ICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBGaXggV2ViS2l0VGVzdFJ1bm5lciBjcmFzaGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NjMwCisKKyAgICAgICAgQ3JlYXRlIHN0 YXRpYyBmdW5jdGlvbiB0byBkdW1wIGZvciBXZWJQcm9jZXNzIHVucmVzcG9uc2l2ZW5lc3Mgc3Rh dHVzLAorICAgICAgICBhbmQgdXNlIGl0IGJlZm9yZSBjYWxsaW5nIFRlc3RDb250cm9sbGVyOjpy dW5UZXN0KCkuCisKKyAgICAgICAgQWNjZXNzaW5nIFRlc3RDb250cm9sbGVyOjptX2N1cnJlbnRJ bnZvY2F0aW9uIGJlZm9yZSBjYWxsaW5nCisgICAgICAgIFRlc3RDb250cm9sbGVyOjpydW5UZXN0 KCkgY2FuIG1ha2UgY3Jhc2ggYmVjYXVzZSB0aGUgaW52b2NhdGlvbgorICAgICAgICBpbnN0YW5j ZSB3aWxsIGJlIGFzc2lnbmVkIGF0IHRoZSBmdW5jdGlvbi4KKworICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxl cjo6cnVuKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcDoK KyAgICAgICAgKFdUUjo6VGVzdEludm9jYXRpb246OmR1bXBXZWJQcm9jZXNzVW5yZXNwb25zaXZl bmVzcyk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5oOgorCiAy MDEzLTA2LTEzICBNaWNoYWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4K IAogICAgICAgICBbUXRdW01hY10gRGlzYWJsZSBRVEtpdCB2aWRlbyBvbiBPUyBYLgpkaWZmIC0t Z2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRleCAwOTY0N2ExNjAxNzM4NDE3 Y2ZmZGYwMzY2ZTRkOTkxODAzZDY0OTIzLi4wZDMxY2ZjMjdmODA3MDM0NDE2OWE0MjEwMmQ2Njgz MjkxODNhMGNkIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcApA QCAtNzU0LDcgKzc1NCw3IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OnJ1blRlc3RpbmdTZXJ2ZXJM b29wKCkKIHZvaWQgVGVzdENvbnRyb2xsZXI6OnJ1bigpCiB7CiAgICAgaWYgKCFyZXNldFN0YXRl VG9Db25zaXN0ZW50VmFsdWVzKCkpIHsKLSAgICAgICAgbV9jdXJyZW50SW52b2NhdGlvbi0+ZHVt cFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCk7CisgICAgICAgIFRlc3RJbnZvY2F0aW9uOjpk dW1wV2ViUHJvY2Vzc1VucmVzcG9uc2l2ZW5lc3MoIjx1bmtub3duPiAtIFRlc3RDb250cm9sbGVy OjpydW4gLSBGYWlsZWQgdG8gcmVzZXQgc3RhdGUgdG8gY29uc2lzdGVudCB2YWx1ZXNcbiIpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL1Rlc3RJbnZvY2F0aW9uLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9j YXRpb24uY3BwCmluZGV4IDM5MzA0MDgzMjQ2MWZiZWNhMjQ2NWYwNjJkNTZmYWY5MDEwM2M1MTQu LmNlOWY1NTE4ZTc1ZmM0YjQyYTM0ZTJiMzk1YzZkNzBmYTIxZDBkOTQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCisrKyBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCkBAIC0yNzYsNiArMjc2LDExIEBAIGVuZDoK IAogdm9pZCBUZXN0SW52b2NhdGlvbjo6ZHVtcFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCkK IHsKKyAgICBkdW1wV2ViUHJvY2Vzc1VucmVzcG9uc2l2ZW5lc3MobV9lcnJvck1lc3NhZ2UuY19z dHIoKSk7Cit9CisKK3ZvaWQgVGVzdEludm9jYXRpb246OmR1bXBXZWJQcm9jZXNzVW5yZXNwb25z aXZlbmVzcyhjb25zdCBjaGFyKiBlcnJvck1lc3NhZ2UpCit7CiAgICAgY29uc3QgY2hhciogZXJy b3JNZXNzYWdlVG9TdGRlcnIgPSAwOwogI2lmIFBMQVRGT1JNKE1BQykKICAgICBjaGFyIGJ1ZmZl cls2NF07CkBAIC0yODYsNyArMjkxLDcgQEAgdm9pZCBUZXN0SW52b2NhdGlvbjo6ZHVtcFdlYlBy b2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCkKICAgICBlcnJvck1lc3NhZ2VUb1N0ZGVyciA9ICIjUFJP Q0VTUyBVTlJFU1BPTlNJVkUgLSBXZWJQcm9jZXNzIjsKICNlbmRpZgogCi0gICAgZHVtcChtX2Vy cm9yTWVzc2FnZS5jX3N0cigpLCBlcnJvck1lc3NhZ2VUb1N0ZGVyciwgdHJ1ZSk7CisgICAgZHVt cChlcnJvck1lc3NhZ2UsIGVycm9yTWVzc2FnZVRvU3RkZXJyLCB0cnVlKTsKIH0KIAogdm9pZCBU ZXN0SW52b2NhdGlvbjo6ZHVtcChjb25zdCBjaGFyKiB0ZXh0VG9TdGRvdXQsIGNvbnN0IGNoYXIq IHRleHRUb1N0ZGVyciwgYm9vbCBzZWVuRXJyb3IpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJ bnZvY2F0aW9uLmgKaW5kZXggMWFlN2YzMzMzNDEyYTZiNjAzOGNhZTFmMGJlNzg1MzZkN2Y4NThk ZC4uMWI0MTVlZmMxYTU4NDEzMWVmNzZhNWJmZGMyYzA2ZmU3NzVhNGZhYyAxMDA2NDQKLS0tIGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5oCisrKyBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaApAQCAtNDksNiArNDksNyBAQCBwdWJsaWM6CiAg ICAgV0tSZXRhaW5QdHI8V0tUeXBlUmVmPiBkaWRSZWNlaXZlU3luY2hyb25vdXNNZXNzYWdlRnJv bUluamVjdGVkQnVuZGxlKFdLU3RyaW5nUmVmIG1lc3NhZ2VOYW1lLCBXS1R5cGVSZWYgbWVzc2Fn ZUJvZHkpOwogCiAgICAgdm9pZCBkdW1wV2ViUHJvY2Vzc1VucmVzcG9uc2l2ZW5lc3MoKTsKKyAg ICBzdGF0aWMgdm9pZCBkdW1wV2ViUHJvY2Vzc1VucmVzcG9uc2l2ZW5lc3MoY29uc3QgY2hhciog ZXJyb3JNZXNzYWdlKTsKICAgICB2b2lkIG91dHB1dFRleHQoY29uc3QgV1RGOjpTdHJpbmcmKTsK IHByaXZhdGU6CiAgICAgdm9pZCBkdW1wUmVzdWx0cygpOwo= 205914 2013-07-02 07:47:24 -0700 2013-07-02 09:19:47 -0700 Patch patch.diff text/plain 3090 bw80.lee ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MmNh ZTdjLi4zODY2OTNjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMDctMDIgIEJ5dW5nd29vIExlZSAgPGJ3ODAu bGVlQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBXZWJLaXRUZXN0UnVubmVyIGNyYXNoZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2MzAK KworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBDcmVhdGUgc3Rh dGljIGZ1bmN0aW9uIHRvIGR1bXAgZm9yIFdlYlByb2Nlc3MgdW5yZXNwb25zaXZlbmVzcyBzdGF0 dXMsCisgICAgICAgIGFuZCB1c2UgaXQgYmVmb3JlIGNhbGxpbmcgVGVzdENvbnRyb2xsZXI6OnJ1 blRlc3QoKS4KKworICAgICAgICBBY2Nlc3NpbmcgVGVzdENvbnRyb2xsZXI6Om1fY3VycmVudElu dm9jYXRpb24gYmVmb3JlIGNhbGxpbmcKKyAgICAgICAgVGVzdENvbnRyb2xsZXI6OnJ1blRlc3Qo KSBjYW4gbWFrZSBjcmFzaCBiZWNhdXNlIHRoZSBpbnZvY2F0aW9uCisgICAgICAgIGluc3RhbmNl IHdpbGwgYmUgYXNzaWduZWQgYXQgdGhlIGZ1bmN0aW9uLgorCisgICAgICAgICogV2ViS2l0VGVz dFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVy OjpydW4pOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwOgor ICAgICAgICAoV1RSOjpUZXN0SW52b2NhdGlvbjo6ZHVtcFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVu ZXNzKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmg6CisKIDIw MTMtMDctMDIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+ CiAKICAgICAgICAgW1F0XVtXSzFdIFN1cHBvcnQgV2ViR0wgd2l0aCBFR0wgb24gTGludXgKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggMDk2NDdhMS4uMGQz MWNmYyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTc1 NCw3ICs3NTQsNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpydW5UZXN0aW5nU2VydmVyTG9vcCgp CiB2b2lkIFRlc3RDb250cm9sbGVyOjpydW4oKQogewogICAgIGlmICghcmVzZXRTdGF0ZVRvQ29u c2lzdGVudFZhbHVlcygpKSB7Ci0gICAgICAgIG1fY3VycmVudEludm9jYXRpb24tPmR1bXBXZWJQ cm9jZXNzVW5yZXNwb25zaXZlbmVzcygpOworICAgICAgICBUZXN0SW52b2NhdGlvbjo6ZHVtcFdl YlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCI8dW5rbm93bj4gLSBUZXN0Q29udHJvbGxlcjo6cnVu IC0gRmFpbGVkIHRvIHJlc2V0IHN0YXRlIHRvIGNvbnNpc3RlbnQgdmFsdWVzXG4iKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0SW52b2NhdGlvbi5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9u LmNwcAppbmRleCAzOTMwNDA4Li5jZTlmNTUxIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rl c3RJbnZvY2F0aW9uLmNwcApAQCAtMjc2LDYgKzI3NiwxMSBAQCBlbmQ6CiAKIHZvaWQgVGVzdElu dm9jYXRpb246OmR1bXBXZWJQcm9jZXNzVW5yZXNwb25zaXZlbmVzcygpCiB7CisgICAgZHVtcFdl YlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKG1fZXJyb3JNZXNzYWdlLmNfc3RyKCkpOworfQorCit2 b2lkIFRlc3RJbnZvY2F0aW9uOjpkdW1wV2ViUHJvY2Vzc1VucmVzcG9uc2l2ZW5lc3MoY29uc3Qg Y2hhciogZXJyb3JNZXNzYWdlKQorewogICAgIGNvbnN0IGNoYXIqIGVycm9yTWVzc2FnZVRvU3Rk ZXJyID0gMDsKICNpZiBQTEFURk9STShNQUMpCiAgICAgY2hhciBidWZmZXJbNjRdOwpAQCAtMjg2 LDcgKzI5MSw3IEBAIHZvaWQgVGVzdEludm9jYXRpb246OmR1bXBXZWJQcm9jZXNzVW5yZXNwb25z aXZlbmVzcygpCiAgICAgZXJyb3JNZXNzYWdlVG9TdGRlcnIgPSAiI1BST0NFU1MgVU5SRVNQT05T SVZFIC0gV2ViUHJvY2VzcyI7CiAjZW5kaWYKIAotICAgIGR1bXAobV9lcnJvck1lc3NhZ2UuY19z dHIoKSwgZXJyb3JNZXNzYWdlVG9TdGRlcnIsIHRydWUpOworICAgIGR1bXAoZXJyb3JNZXNzYWdl LCBlcnJvck1lc3NhZ2VUb1N0ZGVyciwgdHJ1ZSk7CiB9CiAKIHZvaWQgVGVzdEludm9jYXRpb246 OmR1bXAoY29uc3QgY2hhciogdGV4dFRvU3Rkb3V0LCBjb25zdCBjaGFyKiB0ZXh0VG9TdGRlcnIs IGJvb2wgc2VlbkVycm9yKQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0 SW52b2NhdGlvbi5oIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5oCmlu ZGV4IDFhZTdmMzMuLjFiNDE1ZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdEludm9jYXRpb24uaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0 aW9uLmgKQEAgLTQ5LDYgKzQ5LDcgQEAgcHVibGljOgogICAgIFdLUmV0YWluUHRyPFdLVHlwZVJl Zj4gZGlkUmVjZWl2ZVN5bmNocm9ub3VzTWVzc2FnZUZyb21JbmplY3RlZEJ1bmRsZShXS1N0cmlu Z1JlZiBtZXNzYWdlTmFtZSwgV0tUeXBlUmVmIG1lc3NhZ2VCb2R5KTsKIAogICAgIHZvaWQgZHVt cFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCk7CisgICAgc3RhdGljIHZvaWQgZHVtcFdlYlBy b2Nlc3NVbnJlc3BvbnNpdmVuZXNzKGNvbnN0IGNoYXIqIGVycm9yTWVzc2FnZSk7CiAgICAgdm9p ZCBvdXRwdXRUZXh0KGNvbnN0IFdURjo6U3RyaW5nJik7CiBwcml2YXRlOgogICAgIHZvaWQgZHVt cFJlc3VsdHMoKTsK