117629 2013-06-14 00:16:38 -0700 [GTK][WK1] Missing symbols 2013-06-14 01:20:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rego webkit-unassigned commit-queue oldest_to_newest 900442 0 rego 2013-06-14 00:16:38 -0700 Compiling only WK1 like it's doing by the bots is not working due to missing symbols: Tools/Scripts/build-webkit --release --gtk --no-webkit2 ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore41setJSTypeConversionsTestEnforceRangeOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore29setJSTypeConversionsTestOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore40setJSTypeConversionsTestEnforceRangeByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' ./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore28setJSTypeConversionsTestByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE' 900443 1 rego 2013-06-14 00:17:28 -0700 (In reply to comment #0) > Compiling only WK1 like it's doing by the bots is not working due to missing symbols: > Tools/Scripts/build-webkit --release --gtk --no-webkit2 By bots I mean the GTK+ WK1 EWS. 900444 2 204678 rego 2013-06-14 00:20:15 -0700 Created attachment 204678 Patch 900445 3 204679 rego 2013-06-14 00:42:45 -0700 Created attachment 204679 Patch WK1 build fails without this symbols while WK2 build works properly. As expxpected WK1 + WK2 build fails too. 900446 4 204679 cgarcia 2013-06-14 00:46:35 -0700 Comment on attachment 204679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204679&action=review > ChangeLog:9 > + * Source/autotools/symbols.filter: Added missing symbols when compiling > + only WK1. This comment is confusing, because this file is common for wk1 and wk2, I would say something like: Added missing symbols *needed* when compiling WK1. Removing also the "only" because they are also needed when building both wk1 and wk2. 900447 5 204680 rego 2013-06-14 00:49:07 -0700 Created attachment 204680 Patch Fix ChangeLog message. 900453 6 204680 commit-queue 2013-06-14 01:20:35 -0700 Comment on attachment 204680 Patch Clearing flags on attachment: 204680 Committed r151583: <http://trac.webkit.org/changeset/151583> 900454 7 commit-queue 2013-06-14 01:20:36 -0700 All reviewed patches have been landed. Closing bug. 204678 2013-06-14 00:20:15 -0700 2013-06-14 00:42:39 -0700 Patch bug-117629-20130614091859.patch text/plain 1361 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgppbmRleCBm Nzc0ZGMwODFjYzdhZmJiYzMzNzcyNTI4NDU1OWQyOTg5MGZkNTIwLi40YTdhNDE5MGQzYTg2OWRi YWNmODNkMTI1ZmNhZWM1NzU1YWNhZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL3N5 bWJvbHMuZmlsdGVyCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIKQEAgLTMy MSw2ICszMjEsOCBAQCBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIxNHN1cHBsZW1lbnRO YW1lRXY7CiBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIyMmRpZENoYW5nZUJhdHRlcnlT dGF0dXNFUktOM1dURjEyQXRvbWljU3RyaW5nRU5TMV8xMFBhc3NSZWZQdHJJTlNfMTNCYXR0ZXJ5 U3RhdHVzRUVFOwogX1pON1dlYkNvcmUxM1NjcmlwdEdDRXZlbnQxMWdldEhlYXBTaXplRVJOU184 SGVhcEluZm9FOwogX1pON1dlYkNvcmUyOG5vdEltcGxlbWVudGVkTG9nZ2luZ0NoYW5uZWxFdjsK K19aTjdXZWJDb3JlN3RvVUludDhFUE4zSlNDOUV4ZWNTdGF0ZUVOUzBfN0pTVmFsdWVFTlNfMzBJ bnRlZ2VyQ29udmVyc2lvbkNvbmZpZ3VyYXRpb25FOworX1pON1dlYkNvcmU2dG9JbnQ4RVBOM0pT QzlFeGVjU3RhdGVFTlMwXzdKU1ZhbHVlRU5TXzMwSW50ZWdlckNvbnZlcnNpb25Db25maWd1cmF0 aW9uRTsKIAogbG9jYWw6CiBfWio7CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggOWFhMjUwOGQ2M2VhMDFkMzk1NWU4MjM2ZGMxMTU4MzY4NTU4MzczNy4uZjI0YjIzMGE3 YjI0ZTUyMmNmMmM1NjFiMmNkZmNjN2FhOTI2MDk5OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTE0ICBNYW51ZWwgUmVnbyBD YXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dLMV0gTWlzc2lu ZyBzeW1ib2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc2MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXI6IEFkZGVkIG1pc3Npbmcgc3ltYm9s cyB3aGVuIGNvbXBpbGluZworICAgICAgICBvbmx5IFdLMS4KKwogMjAxMy0wNi0xMyAgTWF4IFZ1 am92aWMgIDxtdnVqb3ZpY0BhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBTZWxl Y3Rpb24gZHJhZ2dlZCBmcm9tIGEgcmVnaW9uIHBhaW50cyBpdHMgYmFja2dyb3VuZAo= 204679 2013-06-14 00:42:45 -0700 2013-06-14 00:49:00 -0700 Patch bug-117629-20130614094129.patch text/plain 1360 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgppbmRleCBm Nzc0ZGMwODFjYzdhZmJiYzMzNzcyNTI4NDU1OWQyOTg5MGZkNTIwLi40YTdhNDE5MGQzYTg2OWRi YWNmODNkMTI1ZmNhZWM1NzU1YWNhZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL3N5 bWJvbHMuZmlsdGVyCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIKQEAgLTMy MSw2ICszMjEsOCBAQCBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIxNHN1cHBsZW1lbnRO YW1lRXY7CiBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIyMmRpZENoYW5nZUJhdHRlcnlT dGF0dXNFUktOM1dURjEyQXRvbWljU3RyaW5nRU5TMV8xMFBhc3NSZWZQdHJJTlNfMTNCYXR0ZXJ5 U3RhdHVzRUVFOwogX1pON1dlYkNvcmUxM1NjcmlwdEdDRXZlbnQxMWdldEhlYXBTaXplRVJOU184 SGVhcEluZm9FOwogX1pON1dlYkNvcmUyOG5vdEltcGxlbWVudGVkTG9nZ2luZ0NoYW5uZWxFdjsK K19aTjdXZWJDb3JlN3RvVUludDhFUE4zSlNDOUV4ZWNTdGF0ZUVOUzBfN0pTVmFsdWVFTlNfMzBJ bnRlZ2VyQ29udmVyc2lvbkNvbmZpZ3VyYXRpb25FOworX1pON1dlYkNvcmU2dG9JbnQ4RVBOM0pT QzlFeGVjU3RhdGVFTlMwXzdKU1ZhbHVlRU5TXzMwSW50ZWdlckNvbnZlcnNpb25Db25maWd1cmF0 aW9uRTsKIAogbG9jYWw6CiBfWio7CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggOWFhMjUwOGQ2M2VhMDFkMzk1NWU4MjM2ZGMxMTU4MzY4NTU4MzczNy4uOTEwNDI3NmNi MmI5NDQxYzBiMDNmNGVjYzIwMGJkYTBjM2RlZTg1ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTE0ICBNYW51ZWwgUmVnbyBD YXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dLMV0gTWlzc2lu ZyBzeW1ib2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc2MjkKKworICAgICAgICBVbnJldmlld2VkIEdUSysgYnVpbGQgZml4LgorCisgICAgICAg ICogU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcjogQWRkZWQgbWlzc2luZyBzeW1ib2xz IHdoZW4gY29tcGlsaW5nCisgICAgICAgIG9ubHkgV0sxLgorCiAyMDEzLTA2LTEzICBNYXggVnVq b3ZpYyAgPG12dWpvdmljQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIFNlbGVj dGlvbiBkcmFnZ2VkIGZyb20gYSByZWdpb24gcGFpbnRzIGl0cyBiYWNrZ3JvdW5kCg== 204680 2013-06-14 00:49:07 -0700 2013-06-14 01:20:35 -0700 Patch bug-117629-20130614094751.patch text/plain 1362 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgppbmRleCBm Nzc0ZGMwODFjYzdhZmJiYzMzNzcyNTI4NDU1OWQyOTg5MGZkNTIwLi40YTdhNDE5MGQzYTg2OWRi YWNmODNkMTI1ZmNhZWM1NzU1YWNhZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL3N5 bWJvbHMuZmlsdGVyCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIKQEAgLTMy MSw2ICszMjEsOCBAQCBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIxNHN1cHBsZW1lbnRO YW1lRXY7CiBfWk43V2ViQ29yZTE3QmF0dGVyeUNvbnRyb2xsZXIyMmRpZENoYW5nZUJhdHRlcnlT dGF0dXNFUktOM1dURjEyQXRvbWljU3RyaW5nRU5TMV8xMFBhc3NSZWZQdHJJTlNfMTNCYXR0ZXJ5 U3RhdHVzRUVFOwogX1pON1dlYkNvcmUxM1NjcmlwdEdDRXZlbnQxMWdldEhlYXBTaXplRVJOU184 SGVhcEluZm9FOwogX1pON1dlYkNvcmUyOG5vdEltcGxlbWVudGVkTG9nZ2luZ0NoYW5uZWxFdjsK K19aTjdXZWJDb3JlN3RvVUludDhFUE4zSlNDOUV4ZWNTdGF0ZUVOUzBfN0pTVmFsdWVFTlNfMzBJ bnRlZ2VyQ29udmVyc2lvbkNvbmZpZ3VyYXRpb25FOworX1pON1dlYkNvcmU2dG9JbnQ4RVBOM0pT QzlFeGVjU3RhdGVFTlMwXzdKU1ZhbHVlRU5TXzMwSW50ZWdlckNvbnZlcnNpb25Db25maWd1cmF0 aW9uRTsKIAogbG9jYWw6CiBfWio7CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggOWFhMjUwOGQ2M2VhMDFkMzk1NWU4MjM2ZGMxMTU4MzY4NTU4MzczNy4uY2NkYmZkN2My ZWUzZjc5MThlNWRlZDdiNmYyZjNkOTVkZDg4MzY1OSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTE0ICBNYW51ZWwgUmVnbyBD YXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dLMV0gTWlzc2lu ZyBzeW1ib2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc2MjkKKworICAgICAgICBVbnJldmlld2VkIEdUSysgYnVpbGQgZml4LgorCisgICAgICAg ICogU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcjogQWRkZWQgbWlzc2luZyBzeW1ib2xz IG5lZWRlZCB3aGVuCisgICAgICAgIGNvbXBpbGluZyBXSzEuCisKIDIwMTMtMDYtMTMgIE1heCBW dWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gU2Vs ZWN0aW9uIGRyYWdnZWQgZnJvbSBhIHJlZ2lvbiBwYWludHMgaXRzIGJhY2tncm91bmQK