117612 2013-06-13 15:39:42 -0700 Web Inspector: "Search Resource Content" should cancel when I remove all text search text 2013-06-13 16:33:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy oldest_to_newest 900303 0 joepeck 2013-06-13 15:39:42 -0700 * SUMMARY When I clear the "Search Resource Content" search box, I expect the sidebar to return to showing all resources. Currently I have to hit "Enter" after I clear the content for sidebar to return as expected, we should detect when you've removed all content and clear it. * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Focus the search all box and search "click" 3. Select all text in the search box and delete => expect the sidebar to return to the normal Resources view, but it didn't. * RADAR <rdar://problem/14067434> "Search Resource Content" should cancel when I remove all text search text 900304 1 joepeck 2013-06-13 15:40:07 -0700 I had a patch for this but it didn't land before WebInspectorUI was upstreamed. So I'll go through the new process. 900305 2 204647 joepeck 2013-06-13 15:43:08 -0700 Created attachment 204647 [PATCH] Proposed Fix 900324 3 204647 commit-queue 2013-06-13 16:33:19 -0700 Comment on attachment 204647 [PATCH] Proposed Fix Clearing flags on attachment: 204647 Committed r151573: <http://trac.webkit.org/changeset/151573> 900325 4 commit-queue 2013-06-13 16:33:20 -0700 All reviewed patches have been landed. Closing bug. 204647 2013-06-13 15:43:08 -0700 2013-06-13 16:33:19 -0700 [PATCH] Proposed Fix 117612-1.patch text/plain 2227 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZkODBhY2IuLmUyOWNkOGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSArMSwxMSBAQAorMjAxMy0wNi0xMyAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEx NzYxMj4gV2ViIEluc3BlY3RvcjogIlNlYXJjaCBSZXNvdXJjZSBDb250ZW50IiBzaG91bGQgY2Fu Y2VsIHdoZW4gSSByZW1vdmUgYWxsIHRleHQgc2VhcmNoIHRleHQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUmVzb3VyY2VT aWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFu ZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlw ZS5fc2VhcmNoRmllbGRJbnB1dCk6CisKID09IFJvbGxlZCBvdmVyIHRvIENoYW5nZUxvZy0yMDEz LTA2LTExID09CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9SZXNvdXJjZVNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCmluZGV4IDI1NzljMmEuLmU4OTA0OTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jlc291cmNlU2lk ZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jl c291cmNlU2lkZWJhclBhbmVsLmpzCkBAIC0zNCw3ICszNCw4IEBAIFdlYkluc3BlY3Rvci5SZXNv dXJjZVNpZGViYXJQYW5lbCA9IGZ1bmN0aW9uKCkgewogICAgIHRoaXMuX2lucHV0RWxlbWVudC50 eXBlID0gInNlYXJjaCI7CiAgICAgdGhpcy5faW5wdXRFbGVtZW50LnJlcXVpcmVkID0gdHJ1ZTsK ICAgICB0aGlzLl9pbnB1dEVsZW1lbnQuc3BlbGxjaGVjayA9IGZhbHNlOwotICAgIHRoaXMuX2lu cHV0RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJzZWFyY2giLCB0aGlzLl9zZWFyY2hGaWVsZENo YW5nZWQuYmluZCh0aGlzKSwgZmFsc2UpOworICAgIHRoaXMuX2lucHV0RWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJzZWFyY2giLCB0aGlzLl9zZWFyY2hGaWVsZENoYW5nZWQuYmluZCh0aGlzKSk7 CisgICAgdGhpcy5faW5wdXRFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImlucHV0IiwgdGhpcy5f c2VhcmNoRmllbGRJbnB1dC5iaW5kKHRoaXMpKTsKICAgICB0aGlzLl9pbnB1dEVsZW1lbnQuc2V0 QXR0cmlidXRlKCJyZXN1bHRzIiwgNSk7CiAgICAgdGhpcy5faW5wdXRFbGVtZW50LnNldEF0dHJp YnV0ZSgiYXV0b3NhdmUiLCAiaW5zcGVjdG9yLXNlYXJjaCIpOwogICAgIHRoaXMuX2lucHV0RWxl bWVudC5zZXRBdHRyaWJ1dGUoInBsYWNlaG9sZGVyIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJT ZWFyY2ggUmVzb3VyY2UgQ29udGVudCIpKTsKQEAgLTU1OSw2ICs1NjAsMTMgQEAgV2ViSW5zcGVj dG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5wZXJm b3JtU2VhcmNoKGV2ZW50LnRhcmdldC52YWx1ZSk7CiAgICAgfSwKIAorICAgIF9zZWFyY2hGaWVs ZElucHV0OiBmdW5jdGlvbihldmVudCkKKyAgICB7CisgICAgICAgIC8vIElmIHRoZSBzZWFyY2gg ZmllbGQgaXMgY2xlYXJlZCwgaW1tZWRpYXRlbHkgY2xlYXIgdGhlIHNlYXJjaCByZXN1bHRzIHRy ZWUgb3V0bGluZS4KKyAgICAgICAgaWYgKCFldmVudC50YXJnZXQudmFsdWUubGVuZ3RoICYmIHRo aXMuY29udGVudFRyZWVPdXRsaW5lID09PSB0aGlzLl9zZWFyY2hDb250ZW50VHJlZU91dGxpbmUp CisgICAgICAgICAgICB0aGlzLnBlcmZvcm1TZWFyY2goIiIpOworICAgIH0sCisKICAgICBfc2Vh cmNoVHJlZUVsZW1lbnRGb3JSZXNvdXJjZTogZnVuY3Rpb24ocmVzb3VyY2UpCiAgICAgewogICAg ICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgdGFrZSBhIGZyYW1lIElEIChpZiBvbmUgaXMgYXZh aWxhYmxlKSAtIHNvIHdlIGNhbiBkaWZmZXJlbnRpYXRlIGJldHdlZW4gbXVsdGlwbGUgcmVzb3Vy Y2VzCg==