117602 2013-06-13 10:35:57 -0700 Going to google.com/trends causes a crash 2013-06-18 17:36:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) OS X 10.8 RESOLVED FIXED InRadar P1 Normal --- 1 cococohen1122 oliver fpizlo oliver oldest_to_newest 900192 0 cococohen1122 2013-06-13 10:35:57 -0700 Going to google.com/trends force closes the browser 900905 1 ap 2013-06-16 14:52:19 -0700 <rdar://problem/13910521> 901231 2 oliver 2013-06-17 18:17:04 -0700 function g() { f() } function f() { doStuff(); arguments = undefined; } function doStuff() { throw {} } for (var i = 0; i < 100; i++) { try { g() } catch (e) {} } 901470 3 oliver 2013-06-18 12:17:40 -0700 Okay, so if we have: function g() { f() } function f() { doStuff(); arguments; } function doStuff() { throw {} } for (var i = 0; i < 100; i++) { try { g() } catch (e) {} } The initial graph is: DFG for g#BBXOF8:[0x7fe6ad00f000->0x10935fd70, DFGFunctionCall]: Fixpoint state: BeforeFixpoint; Form: LoadStore; Unification state: LocallyUnified; Ref count state: EverythingIsLive ArgumentPosition size: 3 #0: #1: #2: Block #0 (bc#0): (OSR target) Predecessors: Phi Nodes: vars before: <empty> var links: arg0:- : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- 0: < 1:-> SetArgument(arg0(a), bc#0) predicting None 1: < 1:-> JSConstant(JS|PureInt, $0 = Undefined, bc#1) 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) 3: < 1:-> WeakJSConstant(JS|PureInt, 0x1092decb0, bc#1) 4: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(B~), bc#1) predicting None 5: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(C~), bc#1) predicting None 6: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(D~), bc#1) predicting None 7: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(E~), bc#1) predicting None 8: <!0:-> Phantom(@3, @1, MustGen|CanExit, bc#7) --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> 9: <!0:-> InlineStart(MustGen, bc#0) 10: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r8(F*), bc#0) predicting None 11: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r9(G*), bc#0) predicting None 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) 13: <!0:-> Flush(MustGen, r9(G*), bc#1) predicting None 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting None 15: <!0:-> Flush(MustGen, r8(F*), bc#3) predicting None 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting None 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) 18: < 1:-> WeakJSConstant(JS|PureInt, 0x1092dec70, bc#5) 19: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(J~), bc#5) predicting None 20: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(K~), bc#5) predicting None 21: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(L~), bc#5) predicting None 22: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(M~), bc#5) predicting None 23: <!0:-> Phantom(@18, @1, MustGen|CanExit, bc#11) --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> 24: <!0:-> InlineStart(MustGen, bc#0) 25: < 1:-> NewObject(JS|PureInt|CanExit, struct(0x105ddb6c8: NonArray), bc#1) 26: < 1:-> SetLocal(@25, CanExit|NodeExitsForward, r18(N~), bc#1) predicting None 27: <!0:-> Throw(@25, MustGen|CanExit, bc#5) Which eventually becomes: var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- 0: < 1:-> SetArgument(arg0(a), bc#0) predicting Other 1: < 1:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) 4: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(B~<Other>), bc#1) predicting Other 5: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(C~<Function>), bc#1) predicting Function 6: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(D~<Other>), bc#1) predicting Other 7: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(E~<Function>), bc#1) predicting Function 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen|CanExit, bc#7) --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> 9: <!0:-> InlineStart(MustGen, bc#0) 10: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r8(F*<Other>), bc#0) predicting Other 11: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r9(G*<Other>), bc#0) predicting Other 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) 13: <!0:-> Flush(@11, MustGen, r9(G*<Other>), bc#1) predicting Other 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting Empty 15: <!0:-> Flush(@10, MustGen, r8(F*<Other>), bc#3) predicting Other 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting Empty 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) 19: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(J~<Other>), bc#5) predicting Other 20: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(K~<Function>), bc#5) predicting Function 21: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(L~<Other>), bc#5) predicting Other 22: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(M~<Function>), bc#5) predicting Function 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen|CanExit, bc#11) --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> 24: <!0:-> InlineStart(MustGen, bc#0) 25: < 1:-> NewObject(JS|UseAsOther|CanExit, struct(0x105ddb6c8: NonArray), bc#1) 26: < 1:-> SetLocal(@25<Final>, CanExit|NodeExitsForward, r18(N~<Final>), bc#1) predicting Final 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) And then after DCE var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- 0: skipped < 0:-> SetArgument(arg0(a), bc#0) 1: < 4:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) 4: skipped < 0:-> MovHint(@1<Other>, r1(B~<Other>), bc#1) 5: skipped < 0:-> MovHint(@3<Function>, r0(C~<Function>), bc#1) 6: skipped < 0:-> MovHint(@1<Other>, r1(D~<Other>), bc#1) 7: skipped < 0:-> MovHint(@3<Function>, r0(E~<Function>), bc#1) 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen, bc#7) --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> 9: <!0:-> InlineStart(MustGen, bc#0) 10: skipped < 0:-> MovHint(@1<Other>, r8(F*<Other>), bc#0) 11: skipped < 0:-> MovHint(@1<Other>, r9(G*<Other>), bc#0) 12: <!0:-> Phantom(MustGen|CanExit, bc#1) 13: <!0:-> Phantom(@1<Other>, MustGen, bc#1) 14: skipped < 0:-> ZombieHint(r9(H*), bc#1) 15: <!0:-> Phantom(@1<Other>, MustGen, bc#3) 16: skipped < 0:-> ZombieHint(r8(I*), bc#3) 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) 19: skipped < 0:-> MovHint(@1<Other>, r11(J~<Other>), bc#5) 20: skipped < 0:-> MovHint(@18<Function>, r10(K~<Function>), bc#5) 21: skipped < 0:-> MovHint(@1<Other>, r11(L~<Other>), bc#5) 22: skipped < 0:-> MovHint(@18<Function>, r10(M~<Function>), bc#5) 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen, bc#11) --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> 24: <!0:-> InlineStart(MustGen, bc#0) 25: < 1:-> NewObject(JS|UseAsOther, struct(0x105ddb6c8: NonArray), bc#1) 26: skipped < 0:-> MovHint(@25<Final>, r18(N~<Final>), bc#1) 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) Nodes @14 and @16 were responsible for initializing the lazy argument slots, but they have been elided, despite being necessary for correct behavior. I can add addToGraph(Phantom, get(currentInstruction[1].u.operand)); To init_lazy_reg, and that makes this crash go away, but it feels jacky, and looking at the output graph it is not obvious _why_ we end up with the correct behavior. 901559 4 fpizlo 2013-06-18 15:40:08 -0700 (In reply to comment #3) > Okay, so if we have: > function g() { f() } > function f() { doStuff(); arguments; } > function doStuff() { throw {} } > > for (var i = 0; i < 100; i++) { try { g() } catch (e) {} } > > > > The initial graph is: > DFG for g#BBXOF8:[0x7fe6ad00f000->0x10935fd70, DFGFunctionCall]: > Fixpoint state: BeforeFixpoint; Form: LoadStore; Unification state: LocallyUnified; Ref count state: EverythingIsLive > ArgumentPosition size: 3 > #0: > #1: > #2: > Block #0 (bc#0): (OSR target) > Predecessors: > Phi Nodes: > vars before: <empty> > var links: arg0:- : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > 0: < 1:-> SetArgument(arg0(a), bc#0) predicting None > 1: < 1:-> JSConstant(JS|PureInt, $0 = Undefined, bc#1) > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > 3: < 1:-> WeakJSConstant(JS|PureInt, 0x1092decb0, bc#1) > 4: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(B~), bc#1) predicting None > 5: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(C~), bc#1) predicting None > 6: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(D~), bc#1) predicting None > 7: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(E~), bc#1) predicting None > 8: <!0:-> Phantom(@3, @1, MustGen|CanExit, bc#7) > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > 9: <!0:-> InlineStart(MustGen, bc#0) > 10: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r8(F*), bc#0) predicting None > 11: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r9(G*), bc#0) predicting None > 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) > 13: <!0:-> Flush(MustGen, r9(G*), bc#1) predicting None > 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting None > 15: <!0:-> Flush(MustGen, r8(F*), bc#3) predicting None > 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting None Are 14 and 16 flushed? > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > 18: < 1:-> WeakJSConstant(JS|PureInt, 0x1092dec70, bc#5) > 19: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(J~), bc#5) predicting None > 20: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(K~), bc#5) predicting None > 21: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(L~), bc#5) predicting None > 22: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(M~), bc#5) predicting None > 23: <!0:-> Phantom(@18, @1, MustGen|CanExit, bc#11) > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > 24: <!0:-> InlineStart(MustGen, bc#0) > 25: < 1:-> NewObject(JS|PureInt|CanExit, struct(0x105ddb6c8: NonArray), bc#1) > 26: < 1:-> SetLocal(@25, CanExit|NodeExitsForward, r18(N~), bc#1) predicting None > 27: <!0:-> Throw(@25, MustGen|CanExit, bc#5) > > > Which eventually becomes: > var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > 0: < 1:-> SetArgument(arg0(a), bc#0) predicting Other > 1: < 1:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) > 4: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(B~<Other>), bc#1) predicting Other > 5: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(C~<Function>), bc#1) predicting Function > 6: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(D~<Other>), bc#1) predicting Other > 7: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(E~<Function>), bc#1) predicting Function > 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen|CanExit, bc#7) > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > 9: <!0:-> InlineStart(MustGen, bc#0) > 10: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r8(F*<Other>), bc#0) predicting Other > 11: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r9(G*<Other>), bc#0) predicting Other > 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) > 13: <!0:-> Flush(@11, MustGen, r9(G*<Other>), bc#1) predicting Other > 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting Empty > 15: <!0:-> Flush(@10, MustGen, r8(F*<Other>), bc#3) predicting Other > 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting Empty > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) > 19: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(J~<Other>), bc#5) predicting Other > 20: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(K~<Function>), bc#5) predicting Function > 21: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(L~<Other>), bc#5) predicting Other > 22: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(M~<Function>), bc#5) predicting Function > 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen|CanExit, bc#11) > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > 24: <!0:-> InlineStart(MustGen, bc#0) > 25: < 1:-> NewObject(JS|UseAsOther|CanExit, struct(0x105ddb6c8: NonArray), bc#1) > 26: < 1:-> SetLocal(@25<Final>, CanExit|NodeExitsForward, r18(N~<Final>), bc#1) predicting Final > 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) > > > And then after DCE > var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > 0: skipped < 0:-> SetArgument(arg0(a), bc#0) > 1: < 4:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) > 4: skipped < 0:-> MovHint(@1<Other>, r1(B~<Other>), bc#1) > 5: skipped < 0:-> MovHint(@3<Function>, r0(C~<Function>), bc#1) > 6: skipped < 0:-> MovHint(@1<Other>, r1(D~<Other>), bc#1) > 7: skipped < 0:-> MovHint(@3<Function>, r0(E~<Function>), bc#1) > 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen, bc#7) > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > 9: <!0:-> InlineStart(MustGen, bc#0) > 10: skipped < 0:-> MovHint(@1<Other>, r8(F*<Other>), bc#0) > 11: skipped < 0:-> MovHint(@1<Other>, r9(G*<Other>), bc#0) > 12: <!0:-> Phantom(MustGen|CanExit, bc#1) > 13: <!0:-> Phantom(@1<Other>, MustGen, bc#1) > 14: skipped < 0:-> ZombieHint(r9(H*), bc#1) > 15: <!0:-> Phantom(@1<Other>, MustGen, bc#3) > 16: skipped < 0:-> ZombieHint(r8(I*), bc#3) > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) > 19: skipped < 0:-> MovHint(@1<Other>, r11(J~<Other>), bc#5) > 20: skipped < 0:-> MovHint(@18<Function>, r10(K~<Function>), bc#5) > 21: skipped < 0:-> MovHint(@1<Other>, r11(L~<Other>), bc#5) > 22: skipped < 0:-> MovHint(@18<Function>, r10(M~<Function>), bc#5) > 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen, bc#11) > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > 24: <!0:-> InlineStart(MustGen, bc#0) > 25: < 1:-> NewObject(JS|UseAsOther, struct(0x105ddb6c8: NonArray), bc#1) > 26: skipped < 0:-> MovHint(@25<Final>, r18(N~<Final>), bc#1) > 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) > > > Nodes @14 and @16 were responsible for initializing the lazy argument slots, but they have been elided, despite being necessary for correct behavior. > > I can add > addToGraph(Phantom, get(currentInstruction[1].u.operand)); > > To init_lazy_reg, and that makes this crash go away, but it feels jacky, and looking at the output graph it is not obvious _why_ we end up with the correct behavior. No that is definitely not the right solution. Why aren't those two nodes flushed? Does the inkined functional ways end in Throw? If so maybe it's that op_throw (and ThrowReferenceError) aren't doing the Flushing that op_ret and op_end do? 901561 5 fpizlo 2013-06-18 15:41:43 -0700 (In reply to comment #4) > (In reply to comment #3) > > Okay, so if we have: > > function g() { f() } > > function f() { doStuff(); arguments; } > > function doStuff() { throw {} } > > > > for (var i = 0; i < 100; i++) { try { g() } catch (e) {} } > > > > > > > > The initial graph is: > > DFG for g#BBXOF8:[0x7fe6ad00f000->0x10935fd70, DFGFunctionCall]: > > Fixpoint state: BeforeFixpoint; Form: LoadStore; Unification state: LocallyUnified; Ref count state: EverythingIsLive > > ArgumentPosition size: 3 > > #0: > > #1: > > #2: > > Block #0 (bc#0): (OSR target) > > Predecessors: > > Phi Nodes: > > vars before: <empty> > > var links: arg0:- : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > > 0: < 1:-> SetArgument(arg0(a), bc#0) predicting None > > 1: < 1:-> JSConstant(JS|PureInt, $0 = Undefined, bc#1) > > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > > 3: < 1:-> WeakJSConstant(JS|PureInt, 0x1092decb0, bc#1) > > 4: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(B~), bc#1) predicting None > > 5: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(C~), bc#1) predicting None > > 6: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r1(D~), bc#1) predicting None > > 7: < 1:-> SetLocal(@3, CanExit|NodeExitsForward, r0(E~), bc#1) predicting None > > 8: <!0:-> Phantom(@3, @1, MustGen|CanExit, bc#7) > > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > > 9: <!0:-> InlineStart(MustGen, bc#0) > > 10: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r8(F*), bc#0) predicting None > > 11: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r9(G*), bc#0) predicting None > > 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) > > 13: <!0:-> Flush(MustGen, r9(G*), bc#1) predicting None > > 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting None > > 15: <!0:-> Flush(MustGen, r8(F*), bc#3) predicting None > > 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting None > > Are 14 and 16 flushed? > > > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > > 18: < 1:-> WeakJSConstant(JS|PureInt, 0x1092dec70, bc#5) > > 19: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(J~), bc#5) predicting None > > 20: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(K~), bc#5) predicting None > > 21: < 1:-> SetLocal(@1, CanExit|NodeExitsForward, r11(L~), bc#5) predicting None > > 22: < 1:-> SetLocal(@18, CanExit|NodeExitsForward, r10(M~), bc#5) predicting None > > 23: <!0:-> Phantom(@18, @1, MustGen|CanExit, bc#11) > > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > > 24: <!0:-> InlineStart(MustGen, bc#0) > > 25: < 1:-> NewObject(JS|PureInt|CanExit, struct(0x105ddb6c8: NonArray), bc#1) > > 26: < 1:-> SetLocal(@25, CanExit|NodeExitsForward, r18(N~), bc#1) predicting None > > 27: <!0:-> Throw(@25, MustGen|CanExit, bc#5) > > > > > > Which eventually becomes: > > var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > > 0: < 1:-> SetArgument(arg0(a), bc#0) predicting Other > > 1: < 1:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) > > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > > 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) > > 4: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(B~<Other>), bc#1) predicting Other > > 5: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(C~<Function>), bc#1) predicting Function > > 6: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r1(D~<Other>), bc#1) predicting Other > > 7: < 1:-> SetLocal(@3<Function>, CanExit|NodeExitsForward, r0(E~<Function>), bc#1) predicting Function > > 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen|CanExit, bc#7) > > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > > 9: <!0:-> InlineStart(MustGen, bc#0) > > 10: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r8(F*<Other>), bc#0) predicting Other > > 11: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r9(G*<Other>), bc#0) predicting Other > > 12: < 1:-> JSConstant(JS|PureInt, $1 = <JSValue()>, bc#1) > > 13: <!0:-> Flush(@11, MustGen, r9(G*<Other>), bc#1) predicting Other > > 14: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r9(H*), bc#1) predicting Empty > > 15: <!0:-> Flush(@10, MustGen, r8(F*<Other>), bc#3) predicting Other > > 16: < 1:-> SetLocal(@12, CanExit|NodeExitsForward, r8(I*), bc#3) predicting Empty > > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > > 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) > > 19: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(J~<Other>), bc#5) predicting Other > > 20: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(K~<Function>), bc#5) predicting Function > > 21: < 1:-> SetLocal(@1<Other>, CanExit|NodeExitsForward, r11(L~<Other>), bc#5) predicting Other > > 22: < 1:-> SetLocal(@18<Function>, CanExit|NodeExitsForward, r10(M~<Function>), bc#5) predicting Function > > 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen|CanExit, bc#11) > > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > > 24: <!0:-> InlineStart(MustGen, bc#0) > > 25: < 1:-> NewObject(JS|UseAsOther|CanExit, struct(0x105ddb6c8: NonArray), bc#1) > > 26: < 1:-> SetLocal(@25<Final>, CanExit|NodeExitsForward, r18(N~<Final>), bc#1) predicting Final > > 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) > > > > > > And then after DCE > > var links: arg0:@0 : r0:- r1:- r2:- r3:- r4:- r5:- r6:- r7:- r8:- r9:- r10:- r11:- r12:- r13:- r14:- r15:- r16:- r17:- r18:- > > 0: skipped < 0:-> SetArgument(arg0(a), bc#0) > > 1: < 4:-> JSConstant(JS|UseAsOther, $0 = Undefined, bc#1) > > 2: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global4(0x105dff9c8), bc#1) > > 3: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092decb0, bc#1) > > 4: skipped < 0:-> MovHint(@1<Other>, r1(B~<Other>), bc#1) > > 5: skipped < 0:-> MovHint(@3<Function>, r0(C~<Function>), bc#1) > > 6: skipped < 0:-> MovHint(@1<Other>, r1(D~<Other>), bc#1) > > 7: skipped < 0:-> MovHint(@3<Function>, r0(E~<Function>), bc#1) > > 8: <!0:-> Phantom(@3<Function>, @1<Other>, MustGen, bc#7) > > --> f#AmUsAH:<0x10935fc70, bc#7, Call, known callee: Cell: 0x1092decb0 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r8> > > 9: <!0:-> InlineStart(MustGen, bc#0) > > 10: skipped < 0:-> MovHint(@1<Other>, r8(F*<Other>), bc#0) > > 11: skipped < 0:-> MovHint(@1<Other>, r9(G*<Other>), bc#0) > > 12: <!0:-> Phantom(MustGen|CanExit, bc#1) > > 13: <!0:-> Phantom(@1<Other>, MustGen, bc#1) > > 14: skipped < 0:-> ZombieHint(r9(H*), bc#1) > > 15: <!0:-> Phantom(@1<Other>, MustGen, bc#3) > > 16: skipped < 0:-> ZombieHint(r8(I*), bc#3) > > 17: <!0:-> GlobalVarWatchpoint(MustGen|CanExit, global5(0x105dff9d0), bc#5) > > 18: < 1:-> WeakJSConstant(JS|UseAsOther, 0x1092dec70, bc#5) > > 19: skipped < 0:-> MovHint(@1<Other>, r11(J~<Other>), bc#5) > > 20: skipped < 0:-> MovHint(@18<Function>, r10(K~<Function>), bc#5) > > 21: skipped < 0:-> MovHint(@1<Other>, r11(L~<Other>), bc#5) > > 22: skipped < 0:-> MovHint(@18<Function>, r10(M~<Function>), bc#5) > > 23: <!0:-> Phantom(@18<Function>, @1<Other>, MustGen, bc#11) > > --> doStuff#ASE1VK:<0x10935fb70, bc#11, Call, known callee: Cell: 0x1092dec70 (0x105ddf420: Function, NonArray), numArgs+this = 1, stack >= r18> > > 24: <!0:-> InlineStart(MustGen, bc#0) > > 25: < 1:-> NewObject(JS|UseAsOther, struct(0x105ddb6c8: NonArray), bc#1) > > 26: skipped < 0:-> MovHint(@25<Final>, r18(N~<Final>), bc#1) > > 27: <!0:-> Throw(@25<Final>, MustGen|CanExit, bc#5) > > > > > > Nodes @14 and @16 were responsible for initializing the lazy argument slots, but they have been elided, despite being necessary for correct behavior. > > > > I can add > > addToGraph(Phantom, get(currentInstruction[1].u.operand)); > > > > To init_lazy_reg, and that makes this crash go away, but it feels jacky, and looking at the output graph it is not obvious _why_ we end up with the correct behavior. > > No that is definitely not the right solution. Why aren't those two nodes flushed? Does the inkined functional ways end in Throw? If so maybe it's that op_throw (and ThrowReferenceError) aren't doing the Flushing that op_ret and op_end do? Just reread the original bug code. Yeah, the bug is that op_throw doesn't do the flushing that op_ret does. This can be fixed by either copying or abstracting the code in ByteCodeParser for flushing in return, so that throwing also does it. 901566 6 oliver 2013-06-18 15:48:51 -0700 > Just reread the original bug code. Yeah, the bug is that op_throw doesn't do the flushing that op_ret does. This can be fixed by either copying or abstracting the code in ByteCodeParser for flushing in return, so that throwing also does it. Yeah, i was coming to the conclusion as well (there's another bug i cc'd you on which I think is just another symptom of this) randomly should op_throw be flagged as clobbers the world? 901567 7 oliver 2013-06-18 15:52:05 -0700 (In reply to comment #6) > > Just reread the original bug code. Yeah, the bug is that op_throw doesn't do the flushing that op_ret does. This can be fixed by either copying or abstracting the code in ByteCodeParser for flushing in return, so that throwing also does it. > > Yeah, i was coming to the conclusion as well (there's another bug i cc'd you on which I think is just another symptom of this) > > randomly should op_throw be flagged as clobbers the world? Although my reading of the code implies that throw, etc think that they _are_ flushing everything 901568 8 fpizlo 2013-06-18 15:59:44 -0700 (In reply to comment #6) > > Just reread the original bug code. Yeah, the bug is that op_throw doesn't do the flushing that op_ret does. This can be fixed by either copying or abstracting the code in ByteCodeParser for flushing in return, so that throwing also does it. > > Yeah, i was coming to the conclusion as well (there's another bug i cc'd you on which I think is just another symptom of this) > > randomly should op_throw be flagged as clobbers the world? No, throwing doesn't clobber, for the same reason that return doesn't: it's a terminal. 901570 9 fpizlo 2013-06-18 16:07:54 -0700 (In reply to comment #7) > (In reply to comment #6) > > > Just reread the original bug code. Yeah, the bug is that op_throw doesn't do the flushing that op_ret does. This can be fixed by either copying or abstracting the code in ByteCodeParser for flushing in return, so that throwing also does it. > > > > Yeah, i was coming to the conclusion as well (there's another bug i cc'd you on which I think is just another symptom of this) > > > > randomly should op_throw be flagged as clobbers the world? > > Although my reading of the code implies that throw, etc think that they _are_ flushing everything Lololololo. I see the bug and its awesome. Throw is doing the right thing, if throw behaved like return. Return just "pops" the function you're returning from. But throw pops all functions we've inkined: it is a hard terminal. So throw must flush eveything but it only flushes things from inline stack top. That's why the bug manifests if you throw from something that is inlined into an arguments-using function; presumably throwing directly won't break it. Just make throw flush things for all inline stack entries and not just the top one. 901573 10 oliver 2013-06-18 16:09:15 -0700 *** Bug 117749 has been marked as a duplicate of this bug. *** 901575 11 oliver 2013-06-18 16:22:00 -0700 Okay I believe i have this fixed 901592 12 204956 oliver 2013-06-18 17:11:32 -0700 Created attachment 204956 Patch 901595 13 204956 ggaren 2013-06-18 17:27:20 -0700 Comment on attachment 204956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204956&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:452 > + for (InlineStackEntry* stack = m_inlineStackTop; stack; stack = stack->m_caller) { I'd call this variable "entry", not "stack", since it's an entry in the stack, and not the whole stack. 901599 14 204958 oliver 2013-06-18 17:31:49 -0700 Created attachment 204958 Patch 901601 15 204958 ggaren 2013-06-18 17:33:53 -0700 Comment on attachment 204958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204958&action=review r=me > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:458 > + void flushInlineStackEntry(InlineStackEntry* inlineStackEntry) You can just call this "flush", since the type disambiguates in C++. 901603 16 oliver 2013-06-18 17:36:22 -0700 Committed r151709: <http://trac.webkit.org/changeset/151709> 204956 2013-06-18 17:11:32 -0700 2013-06-18 17:31:47 -0700 Patch bug-117602-20130618171115.patch text/plain 5862 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2ZkODU1MzA4NzYwNDM3MDY2NjUyOGY2YmZhZWNmMWM2ZGM3Njg5Li5kMTg0YWQ1ODAzYjUzZDZj ZGJlMTQ0Y2E3NWRkYjllMjk2MzYzYmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0wNi0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEdvaW5nIHRvIGdvb2dsZS5jb20vdHJlbmRzIGNhdXNlcyBhIGNyYXNoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2MDIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGhhbmRsaW5n IG9wX3Rocm93LCBldGMgd2UgbmVlZCB0byBmbHVzaCB0aGUgdmFyaWFibGVzIGFuZCBhcmd1bWVu dHMKKyAgICAgICAgZm9yIHRoZSBlbnRpcmUgaW5saW5lIHN0YWNrLCBub3QganVzdCB0aGUgdG9w IGZyYW1lLgorCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6Zmx1c2hBbGxBcmd1bWVudHNBbmRDYXB0dXJlZFZh cmlhYmxlc0luSW5saW5lU3RhY2spOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2Vy OjpwYXJzZUJsb2NrKToKKwogMjAxMy0wNi0xOCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFJlcGxhY2UgdG9vbHMzMiBmb2xkZXIgd2l0aCB0b29scyBhbmQg dXBkYXRlIFdlYktpdCBXaW5kb3dzIHNvbHV0aW9uIGFjY29yZGluZ2x5LgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAppbmRleCAwZDQ2YzgxNjJj NWU4MzIzZWM3MGYxMzA2ODc2MjQzODYyMTk4YWY3Li42MGRiNGZiNjk5MjAxZjQyYzk2OWExMzVh MDg4MzI3ZmU4YzczZTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0J5dGVDb2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5 dGVDb2RlUGFyc2VyLmNwcApAQCAtNDQ2LDcgKzQ0NiwyNSBAQCBwcml2YXRlOgogICAgICAgICBp ZiAoYXJndW1lbnRQb3NpdGlvbikKICAgICAgICAgICAgIGFyZ3VtZW50UG9zaXRpb24tPmFkZFZh cmlhYmxlKHZhcmlhYmxlKTsKICAgICB9Ci0gICAgCisKKyAgICB2b2lkIGZsdXNoQWxsQXJndW1l bnRzQW5kQ2FwdHVyZWRWYXJpYWJsZXNJbklubGluZVN0YWNrKCkKKyAgICB7CisgICAgICAgIGZv ciAoSW5saW5lU3RhY2tFbnRyeSogc3RhY2sgPSBtX2lubGluZVN0YWNrVG9wOyBzdGFjazsgc3Rh Y2sgPSBzdGFjay0+bV9jYWxsZXIpIHsKKyAgICAgICAgICAgIGludCBudW1Bcmd1bWVudHM7Cisg ICAgICAgICAgICBpZiAoSW5saW5lQ2FsbEZyYW1lKiBpbmxpbmVDYWxsRnJhbWUgPSBzdGFjay0+ bV9pbmxpbmVDYWxsRnJhbWUpCisgICAgICAgICAgICAgICAgbnVtQXJndW1lbnRzID0gaW5saW5l Q2FsbEZyYW1lLT5hcmd1bWVudHMuc2l6ZSgpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIG51bUFyZ3VtZW50cyA9IHN0YWNrLT5tX2NvZGVCbG9jay0+bnVtUGFyYW1ldGVycygp OworICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBhcmd1bWVudCA9IG51bUFyZ3VtZW50czsgYXJn dW1lbnQtLSA+IDE7KQorICAgICAgICAgICAgICAgIGZsdXNoRGlyZWN0KHN0YWNrLT5yZW1hcE9w ZXJhbmQoYXJndW1lbnRUb09wZXJhbmQoYXJndW1lbnQpKSk7CisgICAgICAgICAgICBmb3IgKGlu dCBsb2NhbCA9IDA7IGxvY2FsIDwgc3RhY2stPm1fY29kZUJsb2NrLT5tX251bVZhcnM7ICsrbG9j YWwpIHsKKyAgICAgICAgICAgICAgICBpZiAoIXN0YWNrLT5tX2NvZGVCbG9jay0+aXNDYXB0dXJl ZChsb2NhbCkpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAg IGZsdXNoRGlyZWN0KHN0YWNrLT5yZW1hcE9wZXJhbmQobG9jYWwpKTsKKyAgICAgICAgICAgIH0K KyAgICAgICAgfQorICAgIH0KKwogICAgIHZvaWQgZmx1c2hBcmd1bWVudHNBbmRDYXB0dXJlZFZh cmlhYmxlcygpCiAgICAgewogICAgICAgICBpbnQgbnVtQXJndW1lbnRzOwpAQCAtMzAxMSwxMiAr MzAyOSwxMiBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVuc2lnbmVkIGxpbWl0 KQogICAgICAgICAgICAgTEFTVF9PUENPREUob3BfZW5kKTsKIAogICAgICAgICBjYXNlIG9wX3Ro cm93OgotICAgICAgICAgICAgZmx1c2hBcmd1bWVudHNBbmRDYXB0dXJlZFZhcmlhYmxlcygpOwor ICAgICAgICAgICAgZmx1c2hBbGxBcmd1bWVudHNBbmRDYXB0dXJlZFZhcmlhYmxlc0luSW5saW5l U3RhY2soKTsKICAgICAgICAgICAgIGFkZFRvR3JhcGgoVGhyb3csIGdldChjdXJyZW50SW5zdHJ1 Y3Rpb25bMV0udS5vcGVyYW5kKSk7CiAgICAgICAgICAgICBMQVNUX09QQ09ERShvcF90aHJvdyk7 CiAgICAgICAgICAgICAKICAgICAgICAgY2FzZSBvcF90aHJvd19zdGF0aWNfZXJyb3I6Ci0gICAg ICAgICAgICBmbHVzaEFyZ3VtZW50c0FuZENhcHR1cmVkVmFyaWFibGVzKCk7CisgICAgICAgICAg ICBmbHVzaEFsbEFyZ3VtZW50c0FuZENhcHR1cmVkVmFyaWFibGVzSW5JbmxpbmVTdGFjaygpOwog ICAgICAgICAgICAgYWRkVG9HcmFwaChUaHJvd1JlZmVyZW5jZUVycm9yKTsKICAgICAgICAgICAg IExBU1RfT1BDT0RFKG9wX3Rocm93X3N0YXRpY19lcnJvcik7CiAgICAgICAgICAgICAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBiYmFmNDM0OTljMDY5NWI0ZWVmZjAwNGE3OWU4NWRkNDMxZjRhOGVhLi45NmM0MjE1YjVmNzgx NjFlOTI5MTEwYTc5N2IyNjM3MTZkZjhkYmNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMt MDYtMTggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBHb2luZyB0 byBnb29nbGUuY29tL3RyZW5kcyBjYXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGNvcnJlY3RseSBpbml0aWFs aXNlIHRoZSBhcHByb3ByaWF0ZSBhcmd1bWVudCByZWdpc3RlcnMsCisgICAgICAgIGFuZCBtYWtl IHN1cmUgd2UgcGVyZm9ybSB0aGUgdGVhcm9mZiBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBmYXN0 L2pzL2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2pzL2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYuaHRtbDogQWRkZWQuCisgICAg ICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5qczog QWRkZWQuCisgICAgICAgIChnKToKKyAgICAgICAgKGYpOgorICAgICAgICAoZG9TdHVmZik6CisK IDIwMTMtMDYtMTggIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmViYXNlbGluZSBhZnRlciBzeXN0ZW0gdXBkYXRlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2pzL2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9pbmxpbmUtYXJndW1lbnRzLXRlYXItb2ZmLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi45YWQzMDE3ZGVjYTk4M2ZiYWM3ZTk1ZjFhZTJkOGI1NzVmNzYzN2I4Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9pbmxpbmUtYXJndW1lbnRzLXRlYXIt b2ZmLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitFbnN1cmUgdGhhdCB3ZSBjb3JyZWN0 bHkgdGVhcm9mZiB0aGUgYXJndW1lbnRzIG9iamVjdHMgd2hlbiB0aHJvd2luZyBmcm9tIGlubGlu ZWQgZnVuY3Rpb24KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNT IiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZmlmdGll dGhBcmd1bWVudHNbMF0gaXMgNTAKK1BBU1MgZmlmdGlldGhBcmd1bWVudHMubGVuZ3RoIGlzIDEK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvanMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmU1MmUyYTI4YzA3MmU0ZTRiNDkzNzU4Mjk4OTQyZDhhNTEyMGVkMjcKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL2lubGluZS1hcmd1bWVudHMtdGVhci1v ZmYuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYv L0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSJz Y3JpcHQtdGVzdHMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5qcyI+PC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9pbmxp bmUtYXJndW1lbnRzLXRlYXItb2ZmLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVz dHMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43YWNmNmU3NmFmMzcy NzNjZGIwNjBlYWI3YjA4YzIyZDcyNjBmMmRiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5qcwpAQCAt MCwwICsxLDE1IEBACitkZXNjcmlwdGlvbigiRW5zdXJlIHRoYXQgd2UgY29ycmVjdGx5IHRlYXJv ZmYgdGhlIGFyZ3VtZW50cyBvYmplY3RzIHdoZW4gdGhyb3dpbmcgZnJvbSBpbmxpbmVkIGZ1bmN0 aW9uIik7CisKK3ZhciBmaWZ0aWV0aEFyZ3VtZW50cyA9IG51bGw7CisKK2Z1bmN0aW9uIGcoYSkg eyBpZiAoYSA9PT0gNTApIGZpZnRpZXRoQXJndW1lbnRzID0gYXJndW1lbnRzOyBmKCk7IH0KK2Z1 bmN0aW9uIGYoKSB7IGRvU3R1ZmYoKTsgIH0KK2Z1bmN0aW9uIGRvU3R1ZmYoKSB7IHRocm93IHt9 OyB9CisKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxMDA7IGkrKykgeyB0cnkgeyAgZyhpKSB9IGNh dGNoIChlKSB7IH0gfQorCitzaG91bGRCZSgiZmlmdGlldGhBcmd1bWVudHNbMF0iLCAiNTAiKTsK K3Nob3VsZEJlKCJmaWZ0aWV0aEFyZ3VtZW50cy5sZW5ndGgiLCAiMSIpOworCisK 204958 2013-06-18 17:31:49 -0700 2013-06-18 17:33:53 -0700 Patch bug-117602-20130618173133.patch text/plain 6854 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2ZkODU1MzA4NzYwNDM3MDY2NjUyOGY2YmZhZWNmMWM2ZGM3Njg5Li5kMTg0YWQ1ODAzYjUzZDZj ZGJlMTQ0Y2E3NWRkYjllMjk2MzYzYmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0wNi0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEdvaW5nIHRvIGdvb2dsZS5jb20vdHJlbmRzIGNhdXNlcyBhIGNyYXNoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2MDIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGhhbmRsaW5n IG9wX3Rocm93LCBldGMgd2UgbmVlZCB0byBmbHVzaCB0aGUgdmFyaWFibGVzIGFuZCBhcmd1bWVu dHMKKyAgICAgICAgZm9yIHRoZSBlbnRpcmUgaW5saW5lIHN0YWNrLCBub3QganVzdCB0aGUgdG9w IGZyYW1lLgorCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAg KEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6Zmx1c2hBbGxBcmd1bWVudHNBbmRDYXB0dXJlZFZh cmlhYmxlc0luSW5saW5lU3RhY2spOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2Vy OjpwYXJzZUJsb2NrKToKKwogMjAxMy0wNi0xOCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFJlcGxhY2UgdG9vbHMzMiBmb2xkZXIgd2l0aCB0b29scyBhbmQg dXBkYXRlIFdlYktpdCBXaW5kb3dzIHNvbHV0aW9uIGFjY29yZGluZ2x5LgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAppbmRleCAwZDQ2YzgxNjJj NWU4MzIzZWM3MGYxMzA2ODc2MjQzODYyMTk4YWY3Li5mYmE4OGU3NTk0OWRjOWU3NWRiNWI4ZDA3 NWQzM2M4ODA5MGU1ZGI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0J5dGVDb2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5 dGVDb2RlUGFyc2VyLmNwcApAQCAtMTU0LDYgKzE1NCw4IEBAIHB1YmxpYzoKICAgICBib29sIHBh cnNlKCk7CiAgICAgCiBwcml2YXRlOgorICAgIHN0cnVjdCBJbmxpbmVTdGFja0VudHJ5OworCiAg ICAgLy8gSnVzdCBwYXJzZSBmcm9tIG1fY3VycmVudEluZGV4IHRvIHRoZSBlbmQgb2YgdGhlIGN1 cnJlbnQgQ29kZUJsb2NrLgogICAgIHZvaWQgcGFyc2VDb2RlQmxvY2soKTsKIApAQCAtNDQ2LDIz ICs0NDgsMzUgQEAgcHJpdmF0ZToKICAgICAgICAgaWYgKGFyZ3VtZW50UG9zaXRpb24pCiAgICAg ICAgICAgICBhcmd1bWVudFBvc2l0aW9uLT5hZGRWYXJpYWJsZSh2YXJpYWJsZSk7CiAgICAgfQot ICAgIAotICAgIHZvaWQgZmx1c2hBcmd1bWVudHNBbmRDYXB0dXJlZFZhcmlhYmxlcygpCisKKyAg ICB2b2lkIGZsdXNoQWxsQXJndW1lbnRzQW5kQ2FwdHVyZWRWYXJpYWJsZXNJbklubGluZVN0YWNr KCkKKyAgICB7CisgICAgICAgIGZvciAoSW5saW5lU3RhY2tFbnRyeSogaW5saW5lU3RhY2tFbnRy eSA9IG1faW5saW5lU3RhY2tUb3A7IGlubGluZVN0YWNrRW50cnk7IGlubGluZVN0YWNrRW50cnkg PSBpbmxpbmVTdGFja0VudHJ5LT5tX2NhbGxlcikKKyAgICAgICAgICAgIGZsdXNoSW5saW5lU3Rh Y2tFbnRyeShpbmxpbmVTdGFja0VudHJ5KTsKKyAgICB9CisKKyAgICB2b2lkIGZsdXNoSW5saW5l U3RhY2tFbnRyeShJbmxpbmVTdGFja0VudHJ5KiBpbmxpbmVTdGFja0VudHJ5KQogICAgIHsKICAg ICAgICAgaW50IG51bUFyZ3VtZW50czsKLSAgICAgICAgaWYgKGlubGluZUNhbGxGcmFtZSgpKQot ICAgICAgICAgICAgbnVtQXJndW1lbnRzID0gaW5saW5lQ2FsbEZyYW1lKCktPmFyZ3VtZW50cy5z aXplKCk7CisgICAgICAgIGlmIChJbmxpbmVDYWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSA9IGlu bGluZVN0YWNrRW50cnktPm1faW5saW5lQ2FsbEZyYW1lKQorICAgICAgICAgICAgbnVtQXJndW1l bnRzID0gaW5saW5lQ2FsbEZyYW1lLT5hcmd1bWVudHMuc2l6ZSgpOwogICAgICAgICBlbHNlCi0g ICAgICAgICAgICBudW1Bcmd1bWVudHMgPSBtX2lubGluZVN0YWNrVG9wLT5tX2NvZGVCbG9jay0+ bnVtUGFyYW1ldGVycygpOworICAgICAgICAgICAgbnVtQXJndW1lbnRzID0gaW5saW5lU3RhY2tF bnRyeS0+bV9jb2RlQmxvY2stPm51bVBhcmFtZXRlcnMoKTsKICAgICAgICAgZm9yICh1bnNpZ25l ZCBhcmd1bWVudCA9IG51bUFyZ3VtZW50czsgYXJndW1lbnQtLSA+IDE7KQotICAgICAgICAgICAg Zmx1c2goYXJndW1lbnRUb09wZXJhbmQoYXJndW1lbnQpKTsKLSAgICAgICAgZm9yIChpbnQgbG9j YWwgPSAwOyBsb2NhbCA8IG1faW5saW5lU3RhY2tUb3AtPm1fY29kZUJsb2NrLT5tX251bVZhcnM7 ICsrbG9jYWwpIHsKLSAgICAgICAgICAgIGlmICghbV9pbmxpbmVTdGFja1RvcC0+bV9jb2RlQmxv Y2stPmlzQ2FwdHVyZWQobG9jYWwpKQorICAgICAgICAgICAgZmx1c2hEaXJlY3QoaW5saW5lU3Rh Y2tFbnRyeS0+cmVtYXBPcGVyYW5kKGFyZ3VtZW50VG9PcGVyYW5kKGFyZ3VtZW50KSkpOworICAg ICAgICBmb3IgKGludCBsb2NhbCA9IDA7IGxvY2FsIDwgaW5saW5lU3RhY2tFbnRyeS0+bV9jb2Rl QmxvY2stPm1fbnVtVmFyczsgKytsb2NhbCkgeworICAgICAgICAgICAgaWYgKCFpbmxpbmVTdGFj a0VudHJ5LT5tX2NvZGVCbG9jay0+aXNDYXB0dXJlZChsb2NhbCkpCiAgICAgICAgICAgICAgICAg Y29udGludWU7Ci0gICAgICAgICAgICBmbHVzaChsb2NhbCk7CisgICAgICAgICAgICBmbHVzaERp cmVjdChpbmxpbmVTdGFja0VudHJ5LT5yZW1hcE9wZXJhbmQobG9jYWwpKTsKICAgICAgICAgfQog ICAgIH0KIAorCisgICAgdm9pZCBmbHVzaEFyZ3VtZW50c0FuZENhcHR1cmVkVmFyaWFibGVzKCkK KyAgICB7CisgICAgICAgIGZsdXNoSW5saW5lU3RhY2tFbnRyeShtX2lubGluZVN0YWNrVG9wKTsK KyAgICB9CisKICAgICAvLyBHZXQgYW4gb3BlcmFuZCwgYW5kIHBlcmZvcm0gYSBUb0ludDMyL1Rv TnVtYmVyIGNvbnZlcnNpb24gb24gaXQuCiAgICAgTm9kZSogZ2V0VG9JbnQzMihpbnQgb3BlcmFu ZCkKICAgICB7CkBAIC0zMDExLDEyICszMDI1LDEyIEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBh cnNlQmxvY2sodW5zaWduZWQgbGltaXQpCiAgICAgICAgICAgICBMQVNUX09QQ09ERShvcF9lbmQp OwogCiAgICAgICAgIGNhc2Ugb3BfdGhyb3c6Ci0gICAgICAgICAgICBmbHVzaEFyZ3VtZW50c0Fu ZENhcHR1cmVkVmFyaWFibGVzKCk7CisgICAgICAgICAgICBmbHVzaEFsbEFyZ3VtZW50c0FuZENh cHR1cmVkVmFyaWFibGVzSW5JbmxpbmVTdGFjaygpOwogICAgICAgICAgICAgYWRkVG9HcmFwaChU aHJvdywgZ2V0KGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9wZXJhbmQpKTsKICAgICAgICAgICAg IExBU1RfT1BDT0RFKG9wX3Rocm93KTsKICAgICAgICAgICAgIAogICAgICAgICBjYXNlIG9wX3Ro cm93X3N0YXRpY19lcnJvcjoKLSAgICAgICAgICAgIGZsdXNoQXJndW1lbnRzQW5kQ2FwdHVyZWRW YXJpYWJsZXMoKTsKKyAgICAgICAgICAgIGZsdXNoQWxsQXJndW1lbnRzQW5kQ2FwdHVyZWRWYXJp YWJsZXNJbklubGluZVN0YWNrKCk7CiAgICAgICAgICAgICBhZGRUb0dyYXBoKFRocm93UmVmZXJl bmNlRXJyb3IpOwogICAgICAgICAgICAgTEFTVF9PUENPREUob3BfdGhyb3dfc3RhdGljX2Vycm9y KTsKICAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJiYWY0MzQ5OWMwNjk1YjRlZWZmMDA0YTc5ZTg1ZGQ0 MzFmNGE4ZWEuLjk2YzQyMTViNWY3ODE2MWU5MjkxMTBhNzk3YjI2MzcxNmRmOGRiY2QgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMCBAQAorMjAxMy0wNi0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgorCisgICAgICAgIEdvaW5nIHRvIGdvb2dsZS5jb20vdHJlbmRzIGNhdXNlcyBhIGNyYXNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc2MDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1 cmUgd2UgY29ycmVjdGx5IGluaXRpYWxpc2UgdGhlIGFwcHJvcHJpYXRlIGFyZ3VtZW50IHJlZ2lz dGVycywKKyAgICAgICAgYW5kIG1ha2Ugc3VyZSB3ZSBwZXJmb3JtIHRoZSB0ZWFyb2ZmIGNvcnJl Y3RseS4KKworICAgICAgICAqIGZhc3QvanMvaW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvaW5saW5lLWFyZ3VtZW50cy10ZWFy LW9mZi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9pbmxpbmUt YXJndW1lbnRzLXRlYXItb2ZmLmpzOiBBZGRlZC4KKyAgICAgICAgKGcpOgorICAgICAgICAoZik6 CisgICAgICAgIChkb1N0dWZmKToKKwogMjAxMy0wNi0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJw b3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWJhc2VsaW5lIGFmdGVyIHN5c3RlbSB1cGRh dGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvaW5saW5lLWFyZ3VtZW50cy10ZWFy LW9mZi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL2lubGluZS1hcmd1bWVudHMt dGVhci1vZmYtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjlhZDMwMTdkZWNhOTgzZmJhYzdlOTVm MWFlMmQ4YjU3NWY3NjM3YjgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pz L2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAK K0Vuc3VyZSB0aGF0IHdlIGNvcnJlY3RseSB0ZWFyb2ZmIHRoZSBhcmd1bWVudHMgb2JqZWN0cyB3 aGVuIHRocm93aW5nIGZyb20gaW5saW5lZCBmdW5jdGlvbgorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBmaWZ0aWV0aEFyZ3VtZW50c1swXSBpcyA1MAorUEFTUyBmaWZ0aWV0 aEFyZ3VtZW50cy5sZW5ndGggaXMgMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvaW5saW5l LWFyZ3VtZW50cy10ZWFyLW9mZi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9pbmxpbmUtYXJn dW1lbnRzLXRlYXItb2ZmLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTUyZTJhMjhjMDcyZTRlNGI0OTM3NTgy OTg5NDJkOGE1MTIwZWQyNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvanMv aW5saW5lLWFyZ3VtZW50cy10ZWFyLW9mZi5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQ RSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9pbmxpbmUtYXJndW1lbnRzLXRlYXIt b2ZmLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvanMvc2NyaXB0LXRlc3RzL2lubGluZS1hcmd1bWVudHMtdGVhci1vZmYuanMgYi9MYXlvdXRU ZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9pbmxpbmUtYXJndW1lbnRzLXRlYXItb2ZmLmpzCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjdhY2Y2ZTc2YWYzNzI3M2NkYjA2MGVhYjdiMDhjMjJkNzI2MGYyZGIKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9pbmxpbmUtYXJn dW1lbnRzLXRlYXItb2ZmLmpzCkBAIC0wLDAgKzEsMTUgQEAKK2Rlc2NyaXB0aW9uKCJFbnN1cmUg dGhhdCB3ZSBjb3JyZWN0bHkgdGVhcm9mZiB0aGUgYXJndW1lbnRzIG9iamVjdHMgd2hlbiB0aHJv d2luZyBmcm9tIGlubGluZWQgZnVuY3Rpb24iKTsKKwordmFyIGZpZnRpZXRoQXJndW1lbnRzID0g bnVsbDsKKworZnVuY3Rpb24gZyhhKSB7IGlmIChhID09PSA1MCkgZmlmdGlldGhBcmd1bWVudHMg PSBhcmd1bWVudHM7IGYoKTsgfQorZnVuY3Rpb24gZigpIHsgZG9TdHVmZigpOyAgfQorZnVuY3Rp b24gZG9TdHVmZigpIHsgdGhyb3cge307IH0KKworCitmb3IgKHZhciBpID0gMDsgaSA8IDEwMDsg aSsrKSB7IHRyeSB7ICBnKGkpIH0gY2F0Y2ggKGUpIHsgfSB9CisKK3Nob3VsZEJlKCJmaWZ0aWV0 aEFyZ3VtZW50c1swXSIsICI1MCIpOworc2hvdWxkQmUoImZpZnRpZXRoQXJndW1lbnRzLmxlbmd0 aCIsICIxIik7CisKKwo=