117600 2013-06-13 10:05:15 -0700 Web Inspector: New Rule button doesn't reveal the newly added rule if not visible upon creation 2015-06-18 10:59:33 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts webkit-unassigned commit-queue graouts hi joepeck timothy webkit-bug-importer oldest_to_newest 900155 0 graouts 2013-06-13 10:05:15 -0700 If you have the Styles sidebar scrolled such that the New Rule button is at the top of the bar, adding a new rule may not scroll to reveal the newly added rule further up in the sidebar. 900156 1 webkit-bug-importer 2013-06-13 10:05:44 -0700 <rdar://problem/14143547> 966640 2 timothy 2014-01-10 15:37:19 -0800 Moving to the right component. 1099615 3 hi 2015-06-04 14:15:00 -0700 Is this still an issue? Every time I add a new rule I always see the newly added rule appear right below the "New Rule" button. Could you possibly elaborate more as to what the specific issue is? Thanks. 1101734 4 254832 hi 2015-06-12 15:58:49 -0700 Created attachment 254832 Patch 1101807 5 254832 timothy 2015-06-13 00:56:12 -0700 Comment on attachment 254832 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254832&action=review > Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:305 > + if (this._previousFocusedSection && this._visible) { What if the previous focused section is no longer in the sidebar after a refresh? Can that happen? 1101986 6 254832 hi 2015-06-15 11:44:43 -0700 Comment on attachment 254832 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254832&action=review >> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:305 >> + if (this._previousFocusedSection && this._visible) { > > What if the previous focused section is no longer in the sidebar after a refresh? Can that happen? From what I can see, no it is not. nodeStylesRefreshed is called whenever the node changes and refresh is called before nodeStylesRefreshed. previousFocusedSection is set (unless there was no previously focused section) by refresh and then used (if set) immediately after in nodeStylesRefreshed. Once used, it is set back to null so it can't be reused until another refresh. 1102966 7 254832 commit-queue 2015-06-18 10:59:29 -0700 Comment on attachment 254832 Patch Clearing flags on attachment: 254832 Committed r185709: <http://trac.webkit.org/changeset/185709> 1102967 8 commit-queue 2015-06-18 10:59:33 -0700 All reviewed patches have been landed. Closing bug. 254832 2015-06-12 15:58:49 -0700 2015-06-18 10:59:29 -0700 Patch bug-117600-20150612155818.patch text/plain 4019 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMzMGVmMzk2YjA5OTU3ZjhlZDk2MDUxODVjMjgw NzdhZDgwZWM5YmYuLjg1OTQ5MTc3MWU0M2EwY2IyYTEwNjE2YjE0M2QyMTViOTUxOTI2YmQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXcgUnVsZSBidXR0b24gZG9lc24ndCByZXZlYWwgdGhlIG5ld2x5IGFkZGVkIHJ1bGUgaWYgbm90 IHZpc2libGUgdXBvbiBjcmVhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE3NjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1J1bGVzU3R5bGVEZXRhaWxzUGFu ZWwuanM6IE1hZGUgcHJldmlvdXNGb2N1c2VkU2VjdGlvbiBpbnRvIGEgbWVtYmVyIHZhcmlhYmxl IG9mIHRoZSBSdWxlc1N0eWxlRGV0YWlsc1BhbmVsLiAgVGhpcyB3YXksIHdoZW4gdGhlIG5vZGVT dHlsZXMgaXMgcmVmcmVzaGVkICh3aGVuIGEgbmV3IHJ1bGUgaXMgYWRkZWQpLCB0aGUgcHJldmlv dXNGb2N1c2VkU2VjdGlvbiB3aWxsIGJlIHNjcm9sbGVkIGludG8gdmlldy4KKyAgICAgICAgKFdl Ykluc3BlY3Rvci5SdWxlc1N0eWxlRGV0YWlsc1BhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5SdWxlc1N0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5yZWZyZXNoLmFwcGVuZFN0eWxlU2Vj dGlvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUnVsZXNTdHlsZURldGFpbHNQYW5lbC5wcm90 b3R5cGUubm9kZVN0eWxlc1JlZnJlc2hlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUnVsZXNT dHlsZURldGFpbHNQYW5lbC5wcm90b3R5cGUucmVmcmVzaCk6IERlbGV0ZWQuCisKIDIwMTUtMDYt MTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBDU1MgUmVnaW9ucyBub3QgZGlzcGxheWluZyBET00gVHJlZXMgaW4gaW5zcGVj dG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9SdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUnVsZXNTdHlsZURldGFpbHNQYW5lbC5qcwppbmRleCA3ZDFiYzdjMWFk ZTZkNTIyYTA4NjBmYzkyMDljMTlmN2M1MzE2NDEzLi5mMzgyMzY2MGEwYjk4NjNiZWIwYzUyNWZh MmY2YzhkMmRhYWQ4MjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9SdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1J1bGVzU3R5bGVEZXRhaWxzUGFuZWwuanMK QEAgLTMwLDYgKzMwLDcgQEAgV2ViSW5zcGVjdG9yLlJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgPSBj bGFzcyBSdWxlc1N0eWxlRGV0YWlsc1BhbmVsIGV4dGVuZHMgV2ViSW4KICAgICAgICAgc3VwZXIo InJ1bGVzIiwgInJ1bGVzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSdWxlcyIpKTsKIAogICAg ICAgICB0aGlzLl9zZWN0aW9ucyA9IFtdOworICAgICAgICB0aGlzLl9wcmV2aW91c0ZvY3VzZWRT ZWN0aW9uID0gbnVsbDsKICAgICAgICAgdGhpcy5fcHJvcGVydHlUb1NlbGVjdEFuZEhpZ2hsaWdo dCA9IG51bGw7CiAgICAgfQogCkBAIC00Nyw3ICs0OCw2IEBAIFdlYkluc3BlY3Rvci5SdWxlc1N0 eWxlRGV0YWlsc1BhbmVsID0gY2xhc3MgUnVsZXNTdHlsZURldGFpbHNQYW5lbCBleHRlbmRzIFdl YkluCiAKICAgICAgICAgdmFyIHByZXZpb3VzTWVkaWFMaXN0ID0gW107CiAgICAgICAgIHZhciBw cmV2aW91c1NlY3Rpb24gPSBudWxsOwotICAgICAgICB2YXIgcHJldmlvdXNGb2N1c2VkU2VjdGlv biA9IG51bGw7CiAKICAgICAgICAgZnVuY3Rpb24gbWVkaWFMaXN0c0VxdWFsKGEsIGIpCiAgICAg ICAgIHsKQEAgLTExNiw4ICsxMTYsOCBAQCBXZWJJbnNwZWN0b3IuUnVsZXNTdHlsZURldGFpbHNQ YW5lbCA9IGNsYXNzIFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5kcyBXZWJJbgogICAgICAg ICBmdW5jdGlvbiBhcHBlbmRTdHlsZVNlY3Rpb24oc3R5bGUpCiAgICAgICAgIHsKICAgICAgICAg ICAgIHZhciBzZWN0aW9uID0gc3R5bGUuX19ydWxlc1NlY3Rpb247Ci0gICAgICAgICAgICBpZiAo c2VjdGlvbiAmJiBzZWN0aW9uLmZvY3VzZWQgJiYgIXByZXZpb3VzRm9jdXNlZFNlY3Rpb24pCi0g ICAgICAgICAgICAgICAgcHJldmlvdXNGb2N1c2VkU2VjdGlvbiA9IHNlY3Rpb247CisgICAgICAg ICAgICBpZiAoc2VjdGlvbiAmJiBzZWN0aW9uLmZvY3VzZWQgJiYgIXRoaXMuX3ByZXZpb3VzRm9j dXNlZFNlY3Rpb24pCisgICAgICAgICAgICAgICAgdGhpcy5fcHJldmlvdXNGb2N1c2VkU2VjdGlv biA9IHNlY3Rpb247CiAKICAgICAgICAgICAgIGlmICghc2VjdGlvbikgewogICAgICAgICAgICAg ICAgIHNlY3Rpb24gPSBuZXcgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9u KHRoaXMsIHN0eWxlKTsKQEAgLTEyNiw3ICsxMjYsNyBAQCBXZWJJbnNwZWN0b3IuUnVsZXNTdHls ZURldGFpbHNQYW5lbCA9IGNsYXNzIFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5kcyBXZWJJ bgogICAgICAgICAgICAgICAgIHNlY3Rpb24ucmVmcmVzaCgpOwogCiAgICAgICAgICAgICBpZiAo dGhpcy5fZm9jdXNOZXh0TmV3SW5zcGVjdG9yUnVsZSAmJiBzdHlsZS5vd25lclJ1bGUgJiYgc3R5 bGUub3duZXJSdWxlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5DU1NSdWxlLlR5cGUuSW5zcGVjdG9y KSB7Ci0gICAgICAgICAgICAgICAgcHJldmlvdXNGb2N1c2VkU2VjdGlvbiA9IHNlY3Rpb247Cisg ICAgICAgICAgICAgICAgdGhpcy5fcHJldmlvdXNGb2N1c2VkU2VjdGlvbiA9IHNlY3Rpb247CiAg ICAgICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2ZvY3VzTmV4dE5ld0luc3BlY3RvclJ1bGU7CiAg ICAgICAgICAgICB9CiAKQEAgLTIzNyw5ICsyMzcsNiBAQCBXZWJJbnNwZWN0b3IuUnVsZXNTdHls ZURldGFpbHNQYW5lbCA9IGNsYXNzIFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5kcyBXZWJJ bgogCiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fc2VjdGlvbnMubGVuZ3RoOyAr K2kpCiAgICAgICAgICAgICB0aGlzLl9zZWN0aW9uc1tpXS51cGRhdGVMYXlvdXQoKTsKLQotICAg ICAgICBpZiAocHJldmlvdXNGb2N1c2VkU2VjdGlvbikKLSAgICAgICAgICAgIHByZXZpb3VzRm9j dXNlZFNlY3Rpb24uZm9jdXMoKTsKICAgICB9CiAKICAgICBzY3JvbGxUb1NlY3Rpb25BbmRIaWdo bGlnaHRQcm9wZXJ0eShwcm9wZXJ0eSkKQEAgLTMwNCw2ICszMDEsMTEgQEAgV2ViSW5zcGVjdG9y LlJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgPSBjbGFzcyBSdWxlc1N0eWxlRGV0YWlsc1BhbmVsIGV4 dGVuZHMgV2ViSW4KICAgICAgICAgICAgIHRoaXMuc2Nyb2xsVG9TZWN0aW9uQW5kSGlnaGxpZ2h0 UHJvcGVydHkodGhpcy5fcHJvcGVydHlUb1NlbGVjdEFuZEhpZ2hsaWdodCk7CiAgICAgICAgICAg ICB0aGlzLl9wcm9wZXJ0eVRvU2VsZWN0QW5kSGlnaGxpZ2h0ID0gbnVsbDsKICAgICAgICAgfQor CisgICAgICAgIGlmICh0aGlzLl9wcmV2aW91c0ZvY3VzZWRTZWN0aW9uICYmIHRoaXMuX3Zpc2li bGUpIHsKKyAgICAgICAgICAgIHRoaXMuX3ByZXZpb3VzRm9jdXNlZFNlY3Rpb24uZm9jdXMoKTsK KyAgICAgICAgICAgIHRoaXMuX3ByZXZpb3VzRm9jdXNlZFNlY3Rpb24gPSBudWxsOworICAgICAg ICB9CiAgICAgfQogCiAgICAgLy8gUHJpdmF0ZQo=