117593 2013-06-13 08:00:33 -0700 Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings 2013-06-13 09:13:16 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue darin ggaren laszlo.gombos oldest_to_newest 900033 0 cdumez 2013-06-13 08:00:33 -0700 In JSDOMBindings.cpp, the following pattern is used several times: if (value.isInt32()) return value.toInt32(exec); This would be more efficiently written as: if (value.isInt32()) return value.asInt32(); The issue is that JSValue::toInt32() also calls value.isInt32() internally as well and returns value.asInt32() if it is. We should therefore call asInt32() directly since we already know the value is an int32. 900039 1 204587 cdumez 2013-06-13 08:15:30 -0700 Created attachment 204587 Patch 900043 2 204587 ggaren 2013-06-13 08:26:47 -0700 Comment on attachment 204587 Patch r=me 900118 3 commit-queue 2013-06-13 09:11:46 -0700 The commit-queue encountered the following flaky tests while processing attachment 204587: platform/mac/fonts/han-disunification.html bug 114207 (author: ap@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/repaint/table-cell-collapsed-border-scroll.html bug 117529 (author: robert@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) compositing/reflections/load-video-in-reflection.html bug 117427 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch. 900120 4 204587 commit-queue 2013-06-13 09:13:05 -0700 Comment on attachment 204587 Patch Clearing flags on attachment: 204587 Committed r151550: <http://trac.webkit.org/changeset/151550> 900121 5 commit-queue 2013-06-13 09:13:16 -0700 All reviewed patches have been landed. Closing bug. 204587 2013-06-13 08:15:30 -0700 2013-06-13 09:13:04 -0700 Patch 117593_asInt32.patch text/plain 2412 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYWZhOTYyLi5jM2ZmNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDYtMTMgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIEF2b2lkIGR1cGxpY2F0ZSBpc0ludDMyKCkgLyBpc1VJbnQzMigpIGNo ZWNrcyBpbiBKU0RPTUJpbmRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTc1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBdm9pZCBkdXBsaWNhdGUgaXNJbnQzMigpIC8gaXNVSW50MzIoKSBjaGVj a3MgaW4gSlNET01CaW5kaW5ncyBieQorICAgICAgICBjYWxsaW5nIGFzSW50MzIoKSAvIGFzVUlu dDMyKCkgaW5zdGVhZCBvZiB0b0ludDMyKCkgLyB0b1VJbnQzMigpCisgICAgICAgIHdoZW4gd2Ug YWxyZWFkeSBrbm93IHRoZSB2YWx1ZSBpcyBhIGludDMyIC8gdWludDMyLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogYmluZGluZ3MvanMv SlNET01CaW5kaW5nLmNwcDoKKwogMjAxMy0wNi0xMyAgTWljaGFlbCBCcsO8bmluZyAgPG1pY2hh ZWwuYnJ1bmluZ0BkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XVtNYWNdIERpc2FibGUgUVRLaXQg dmlkZW8gb24gT1MgWC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NQmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcu Y3BwCmluZGV4IDY3MjY3ZDAuLjhkZjI5ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNET01CaW5kaW5nLmNwcApAQCAtMzA5LDcgKzMwOSw3IEBAIHN0YXRpYyBkb3VibGUgZW5m b3JjZVJhbmdlKEV4ZWNTdGF0ZSogZXhlYywgZG91YmxlIHgsIGRvdWJsZSBtaW5pbXVtLCBkb3Vi bGUgbWF4CiBpbnQzMl90IHRvSW50MzJFbmZvcmNlUmFuZ2UoRXhlY1N0YXRlKiBleGVjLCBKU1Zh bHVlIHZhbHVlKQogewogICAgIGlmICh2YWx1ZS5pc0ludDMyKCkpCi0gICAgICAgIHJldHVybiB2 YWx1ZS50b0ludDMyKGV4ZWMpOworICAgICAgICByZXR1cm4gdmFsdWUuYXNJbnQzMigpOwogCiAg ICAgZG91YmxlIHggPSB2YWx1ZS50b051bWJlcihleGVjKTsKICAgICBpZiAoZXhlYy0+aGFkRXhj ZXB0aW9uKCkpCkBAIC0zMjEsNyArMzIxLDcgQEAgaW50MzJfdCB0b0ludDMyRW5mb3JjZVJhbmdl KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkKIHVpbnQzMl90IHRvVUludDMyRW5mb3Jj ZVJhbmdlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkKIHsKICAgICBpZiAodmFsdWUu aXNVSW50MzIoKSkKLSAgICAgICAgcmV0dXJuIHZhbHVlLnRvVUludDMyKGV4ZWMpOworICAgICAg ICByZXR1cm4gdmFsdWUuYXNVSW50MzIoKTsKIAogICAgIGRvdWJsZSB4ID0gdmFsdWUudG9OdW1i ZXIoZXhlYyk7CiAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQpAQCAtMzMzLDcgKzMzMyw3 IEBAIHVpbnQzMl90IHRvVUludDMyRW5mb3JjZVJhbmdlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1 ZSB2YWx1ZSkKIGludDY0X3QgdG9JbnQ2NChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUs IEludGVnZXJDb252ZXJzaW9uQ29uZmlndXJhdGlvbiBjb25maWd1cmF0aW9uKQogewogICAgIGlm ICh2YWx1ZS5pc0ludDMyKCkpCi0gICAgICAgIHJldHVybiB2YWx1ZS50b0ludDMyKGV4ZWMpOwor ICAgICAgICByZXR1cm4gdmFsdWUuYXNJbnQzMigpOwogCiAgICAgZG91YmxlIHggPSB2YWx1ZS50 b051bWJlcihleGVjKTsKICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCkBAIC0zNTIsNyAr MzUyLDcgQEAgaW50NjRfdCB0b0ludDY0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwg SW50ZWdlckNvbnZlcnNpb25Db25maWd1cmF0aW9uIGMKIHVpbnQ2NF90IHRvVUludDY0KEV4ZWNT dGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgSW50ZWdlckNvbnZlcnNpb25Db25maWd1cmF0aW9u IGNvbmZpZ3VyYXRpb24pCiB7CiAgICAgaWYgKHZhbHVlLmlzVUludDMyKCkpCi0gICAgICAgIHJl dHVybiB2YWx1ZS50b1VJbnQzMihleGVjKTsKKyAgICAgICAgcmV0dXJuIHZhbHVlLmFzVUludDMy KCk7CiAKICAgICBkb3VibGUgeCA9IHZhbHVlLnRvTnVtYmVyKGV4ZWMpOwogICAgIGlmIChleGVj LT5oYWRFeGNlcHRpb24oKSkK